GNU bug report logs - #26239
[PATCH] packages: Use "@" as version separator.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26239 in the body.
You can then email your comments to 26239 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: guix-patches <at> gnu.org
Subject: [PATCH] packages: Use "@" as version separator.
Date: Fri, 24 Mar 2017 17:33:44 +0100

* guix/packages.scm (package-full-name): Use "@" instead of "-" to separate
PACKAGE-NAME and PACKAGE-VERSION.
---

Guix,

This is so trivial that I'm mainly posting it to find out *which* obvious
thing I've completely missed. 

Meanwhile, it won't get lost (again) before core-updates reopens for
business.

Kind regards,

T G-R

guix/packages.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/packages.scm b/guix/packages.scm
index 4bc4b01..34bbc5e 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -382,8 +382,8 @@ object."
 
 
 (define (package-full-name package)
-  "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
-  (string-append (package-name package) "-" (package-version package)))
+  "Return the full name of PACKAGE--i.e., `NAME <at> VERSION'."
+  (string-append (package-name package) "@" (package-version package)))
 
 (define (%standard-patch-inputs)
   (let* ((canonical (module-ref (resolve-interface '(gnu packages base))
-- 
2.9.3

Message #8 received at 26239 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 26239 <at> debbugs.gnu.org
Subject: Re: bug#26239: [PATCH] packages: Use "@" as version separator.
Date: Sat, 25 Mar 2017 19:42:52 -0400

[Message part 1 (text/plain, inline)]

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> * guix/packages.scm (package-full-name): Use "@" instead of "-" to separate
> PACKAGE-NAME and PACKAGE-VERSION.
> ---
>
> Guix,
>
> This is so trivial that I'm mainly posting it to find out *which* obvious
> thing I've completely missed. 
>
> Meanwhile, it won't get lost (again) before core-updates reopens for
> business.
>
> Kind regards,
>
> T G-R
>
> guix/packages.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index 4bc4b01..34bbc5e 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -382,8 +382,8 @@ object."
>  
>  
>  (define (package-full-name package)
> -  "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
> -  (string-append (package-name package) "-" (package-version package)))
> +  "Return the full name of PACKAGE--i.e., `NAME <at> VERSION'."
> +  (string-append (package-name package) "@" (package-version package)))
>  
>  (define (%standard-patch-inputs)
>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))

I think Guix internals could handle the change. As far as I can tell,
Bash and Guile have no problem with handling unquoted at signs in their
logic. I don't see hard-coded expectations of a hyphen rather than an at
sign in Guix's code either. Someone may want to double-check my
claims though.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 26239 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: kei <at> openmailbox.org
Cc: 26239 <at> debbugs.gnu.org
Subject: Re: bug#26239: [PATCH] packages: Use "@" as version separator.
Date: Sun, 26 Mar 2017 17:46:05 +0200

[Message part 1 (text/plain, inline)]

Kei,

On 26/03/17 00:42, Kei Kebreau wrote:
> I think Guix internals could handle the change. [...] I don't see
> hard-coded expectations of a hyphen rather than an at sign in Guix's
> code either.

Ah, good. That was my main worry. I tried to go over each
package-full-name user in the guix repository, but I'm still a very
little Schemer.

Kind regards,

T G-R

PS: if anyone would object to this change, Alex has a very nice
alternative ready to go in bug 26264, complete with unit test.
The only thing I can say for this one's that it's simpler :-)

[signature.asc (application/pgp-signature, attachment)]

Message #18 received at 26239-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 26239-done <at> debbugs.gnu.org
Subject: Re: bug#26239: Acknowledgement ([PATCH] packages: Use "@" as version
 separator.)
Date: Tue, 28 Mar 2017 17:23:05 +0200

[Message part 1 (text/plain, inline)]

‘package-full-name’ is also used to construct store path names, to this
change alone isn't enough.

Closing this bug. Discussion continued at #26264.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.