Received: (at 26275) by debbugs.gnu.org; 2 Jun 2017 16:33:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 02 12:33:47 2017 Received: from localhost ([127.0.0.1]:51821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1dGpWE-0000ma-VN for submit <at> debbugs.gnu.org; Fri, 02 Jun 2017 12:33:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1dGpWD-0000mN-4U for 26275 <at> debbugs.gnu.org; Fri, 02 Jun 2017 12:33:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <ludo@HIDDEN>) id 1dGpW5-0005TC-F4 for 26275 <at> debbugs.gnu.org; Fri, 02 Jun 2017 12:33:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>) id 1dGpW5-0005T2-Bl; Fri, 02 Jun 2017 12:33:37 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:37690 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <ludo@HIDDEN>) id 1dGpW4-0001Ex-P3; Fri, 02 Jun 2017 12:33:37 -0400 From: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac <arunisaac@HIDDEN> Subject: Re: bug#26275: [PATCH] build: perl-build-system: Add `wrap' phase. References: <3389aacc.ADsAAG-tXNgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABY2Wpd@HIDDEN> <87lgrptop7.fsf@HIDDEN> <3061ffaa.AEUAIU7oXLoAAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2pcQ@HIDDEN> Date: Fri, 02 Jun 2017 18:33:34 +0200 In-Reply-To: <3061ffaa.AEUAIU7oXLoAAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2pcQ@HIDDEN> (Arun Isaac's message of "Tue, 28 Mar 2017 22:32:01 +0530") Message-ID: <87k24u4ae9.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26275 Cc: 26275 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) Hi Arun, Arun Isaac <arunisaac@HIDDEN> skribis: >> I can't study the code right now, but at a glance it looks like this >> will also include native-inputs in PERL5LIB. Can you try to filter them >> out? >> >> Doing that will effectively also solve >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25235 . Patch welcome! :) > > Yes, I'll do this! :-) I'll first send a patch for bug 25235, we'll > close that, and then come back here. What=E2=80=99s the status of this patch? It might still be time for =E2=80=98core-updates=E2=80=99 if it=E2=80=99s ready=E2=80=A6 Ludo=E2=80=99.
guix-patches@HIDDEN:bug#26275; Package guix-patches.
Full text available.
Received: (at 26275) by debbugs.gnu.org; 10 Apr 2017 21:53:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 10 17:53:13 2017
Received: from localhost ([127.0.0.1]:41635 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1cxhFJ-0003th-KF
for submit <at> debbugs.gnu.org; Mon, 10 Apr 2017 17:53:13 -0400
Received: from eggs.gnu.org ([208.118.235.92]:49043)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1cxhFJ-0003tW-0P
for 26275 <at> debbugs.gnu.org; Mon, 10 Apr 2017 17:53:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <ludo@HIDDEN>) id 1cxhF9-00087m-GD
for 26275 <at> debbugs.gnu.org; Mon, 10 Apr 2017 17:53:07 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD
autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46097)
by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>)
id 1cxhF9-00087i-CO; Mon, 10 Apr 2017 17:53:03 -0400
Received: from reverse-83.fdn.fr ([80.67.176.83]:58554 helo=ribbon)
by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
(Exim 4.82) (envelope-from <ludo@HIDDEN>)
id 1cxhF8-0000zT-P1; Mon, 10 Apr 2017 17:53:03 -0400
From: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=)
To: Arun Isaac <arunisaac@HIDDEN>
Subject: Re: bug#26275: [PATCH] build: perl-build-system: Add `wrap' phase.
References: <20170327193850.12655-1-arunisaac@HIDDEN>
<f5525e2f.AEAAIZKx6N0AAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2nQ0@HIDDEN>
Date: Mon, 10 Apr 2017 23:53:00 +0200
In-Reply-To: <f5525e2f.AEAAIZKx6N0AAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2nQ0@HIDDEN>
(Arun Isaac's message of "Tue, 28 Mar 2017 20:03:13 +0530")
Message-ID: <87pogkdj5v.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: 26275
Cc: 26275 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)
Hi,
And sorry for the delay.
Arun Isaac <arunisaac@HIDDEN> skribis:
>> +(define* (wrap #:key inputs outputs #:allow-other-keys)
>> + (define (list-of-files dir)
>> + (map (cut string-append dir "/" <>)
>> + (or (scandir dir (lambda (f)
>> + (let ((s (stat (string-append dir "/" f))))
>> + (eq? 'regular (stat:type s)))))
>> + '())))
>> +
>> + (define bindirs
>> + (append-map (match-lambda
>> + ((_ . dir)
>> + (list (string-append dir "/bin")
>> + (string-append dir "/sbin"))))
>> + outputs))
>> +
>> + (let* ((out (assoc-ref outputs "out"))
>> + (var `("PERL5LIB" prefix
>> + ,(search-path-as-string->list
>> + (or (getenv "PERL5LIB") "")))))
>> + (for-each (lambda (dir)
>> + (let ((files (list-of-files dir)))
>> + (for-each (cut wrap-program <> var)
>> + files)))
>> + bindirs)))
>
> I copied this wrap function from the python build system, and modified
> it a little to suite perl. Is there any reason `list-of-files' and
> `bindirs' are initialized using `define' rather than a `let' binding?
> This is probably a very basic Guile question, but still...
It=E2=80=99s purely cosmetic in this case: it makes them more visible and f=
its
within the 80-column limit. :-)
Technically:
(define (proc x y)
(define a =E2=80=A6)
(define b =E2=80=A6)
body =E2=80=A6)
is equivalent to:
(define (proc x y)
(letrec ((a =E2=80=A6)
(b =E2=80=A6))
body =E2=80=A6))
See <https://gnu.org/software/guile/manual/html_node/Local-Bindings.html>.
HTH!
Ludo=E2=80=99.
guix-patches@HIDDEN:bug#26275; Package guix-patches.
Full text available.Received: (at 26275) by debbugs.gnu.org; 28 Mar 2017 17:02:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 28 13:02:12 2017 Received: from localhost ([127.0.0.1]:49575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1csuVX-0007KO-P6 for submit <at> debbugs.gnu.org; Tue, 28 Mar 2017 13:02:11 -0400 Received: from o120.p9.mailjet.com ([87.253.234.120]:54342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <3061ffaa.AEUAIU7oXLoAAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2pcQ@HIDDEN>) id 1csuVV-0007KG-PG for 26275 <at> debbugs.gnu.org; Tue, 28 Mar 2017 13:02:10 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@HIDDEN; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=vDtNAK6nTsOzOdOZAihb1LV0LNg=; b=clnqkKQYvp1a/TkiZ1QztWb8i6aF/di54a9f0u0IEAqKaZOkxz+VtDytR f2JjqR9D1mJPdiGLQCf21/GhsKViOy4HvJwIr9CzdmDJkH62yJqOjqKA/3Yl 1zcRVn+C28onSKSnpSS+ccE28Ih0kmwAk2SgYPqCyhilpj2+EPlaPI= Message-Id: <3061ffaa.AEUAIU7oXLoAAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2pcQ@HIDDEN> MIME-Version: 1.0 From: Arun Isaac <arunisaac@HIDDEN> To: 26275 <at> debbugs.gnu.org Subject: Re: bug#26275: [PATCH] build: perl-build-system: Add `wrap' phase. Date: Tue, 28 Mar 2017 22:32:01 +0530 In-reply-to: <87lgrptop7.fsf@HIDDEN> References: <3389aacc.ADsAAG-tXNgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABY2Wpd@HIDDEN> <87lgrptop7.fsf@HIDDEN> X-CSA-Complaints: whitelist-complaints@HIDDEN X-MJ-Mid: AEUAIU7oXLoAAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2pcQ5TGWxxuIQimZbk8xdJiIeAAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26275 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.8 (--) > I can't study the code right now, but at a glance it looks like this > will also include native-inputs in PERL5LIB. Can you try to filter them > out? > > Doing that will effectively also solve > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25235 . Patch welcome! :) Yes, I'll do this! :-) I'll first send a patch for bug 25235, we'll close that, and then come back here. =
guix-patches@HIDDEN:bug#26275; Package guix-patches.
Full text available.
Received: (at 26275) by debbugs.gnu.org; 28 Mar 2017 15:18:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 28 11:18:15 2017
Received: from localhost ([127.0.0.1]:49502 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1csssx-0004ke-M4
for submit <at> debbugs.gnu.org; Tue, 28 Mar 2017 11:18:15 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:55436)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mbakke@HIDDEN>) id 1csssw-0004kX-7H
for 26275 <at> debbugs.gnu.org; Tue, 28 Mar 2017 11:18:14 -0400
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
by mailout.nyi.internal (Postfix) with ESMTP id 28DD92089C;
Tue, 28 Mar 2017 11:18:14 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
by compute5.internal (MEProxy); Tue, 28 Mar 2017 11:18:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h=
content-type:date:from:in-reply-to:message-id:mime-version
:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc
:x-sasl-enc; s=fm1; bh=kyy4atqqrLbCFDrsHC6Z6+fVKhQsjrHKjTOG75QcG
Ac=; b=onMyySHqGQNTjHbbdyJZnhR/b3b5NChEPX3q2lq1gL2/RqxNXAL6TsJJY
W/jGKJsVNMKK/1T9o0+70VMRs4KZSKNmAm8iqzUdXYkaMuxNwiL/y4Ckl6YEjLrx
aGuspvVNaCBgheykjsnwKs8aOUERNUom4lre7tnSBor4kBAJbrmj6Sv6XzjyAX36
s2q85LdV9LPKbFMUIcoG/Zh9AngCltXERxHpzEg+S1VRHyU4rTf2QP9rkY8+8Xqo
vbSVCTxVODNPBwKA2pU6jHXrfUGYfmgz/LNRPUaDH9BwEI5+msco+6ZwK2qNbefB
hcdSuYOeSeJReJl0fH7/4s0qTPS4A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=kyy4atqqrLbCFDrsHC
6Z6+fVKhQsjrHKjTOG75QcGAc=; b=qySYpZfec25RQaX1VGYb6hP16JX5tcH80n
cHnV+Byoeh3J9tuz2vY+BOIt7KxigrEzL9Xgglu+eaCMo5Y9Sbp8orWejJ5VTUoe
WYb1Cm+HsbDW+qCSf+lKQW16f4ksDVGCyf7SdDP7gY6S0Rg7kdPqwvefkD+UHoUd
KNRnPeNacZo/nJ5ewfX/UQohJWsNNtsKGC4GeG/LBMG5RdwjXf0xpEXMTH0klnt2
TQT3HYw18OyNd5cHqNnk9wHkG6zcW9N4HL8VzT4J1JYQ7YkesoXH0elCYOs74Olb
oPGmCNWHDQlk5c6647/ZUbvJLSdkLTqLj7Hdh0R34jxEXSvETLtw==
X-ME-Sender: <xms:tn7aWEThhWvLTgYQNjCaVGn355uCmFln9CySYIQOrvYfJyRzJAK0Zg>
X-Sasl-enc: hq5ExcR79fCqnUsJvfNBzXseZ0og2hO/H5myBS9Df1Mg 1490714293
Received: from localhost (unknown [188.113.81.93])
by mail.messagingengine.com (Postfix) with ESMTPA id B1C70246CA;
Tue, 28 Mar 2017 11:18:13 -0400 (EDT)
From: Marius Bakke <mbakke@HIDDEN>
To: Arun Isaac <arunisaac@HIDDEN>, 26275 <at> debbugs.gnu.org
Subject: Re: bug#26275: [PATCH] build: perl-build-system: Add `wrap' phase.
In-Reply-To: <3389aacc.ADsAAG-tXNgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABY2Wpd@HIDDEN>
References: <3389aacc.ADsAAG-tXNgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABY2Wpd@HIDDEN>
User-Agent: Notmuch/0.24 (https://notmuchmail.org) Emacs/25.1.1
(x86_64-unknown-linux-gnu)
Date: Tue, 28 Mar 2017 17:18:12 +0200
Message-ID: <87lgrptop7.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 26275
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Hello!
I can't study the code right now, but at a glance it looks like this
will also include native-inputs in PERL5LIB. Can you try to filter them
out?
Doing that will effectively also solve
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25235 . Patch welcome! :)
Arun Isaac <arunisaac@HIDDEN> writes:
> * guix/build/perl-build-system.scm (wrap): New procedure.
> (%standard-phases): Add it.
> ---
> guix/build/perl-build-system.scm | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/guix/build/perl-build-system.scm b/guix/build/perl-build-sys=
tem.scm
> index 8f480eae1..32ef86b65 100644
> --- a/guix/build/perl-build-system.scm
> +++ b/guix/build/perl-build-system.scm
> @@ -19,7 +19,10 @@
> (define-module (guix build perl-build-system)
> #:use-module ((guix build gnu-build-system) #:prefix gnu:)
> #:use-module (guix build utils)
> + #:use-module (ice-9 ftw)
> #:use-module (ice-9 match)
> + #:use-module (srfi srfi-1)
> + #:use-module (srfi srfi-26)
> #:export (%standard-phases
> perl-build))
>=20=20
> @@ -68,6 +71,31 @@
> (define-w/gnu-fallback* (install)
> (zero? (system* "./Build" "install")))
>=20=20
> +(define* (wrap #:key inputs outputs #:allow-other-keys)
> + (define (list-of-files dir)
> + (map (cut string-append dir "/" <>)
> + (or (scandir dir (lambda (f)
> + (let ((s (stat (string-append dir "/" f))))
> + (eq? 'regular (stat:type s)))))
> + '())))
> +
> + (define bindirs
> + (append-map (match-lambda
> + ((_ . dir)
> + (list (string-append dir "/bin")
> + (string-append dir "/sbin"))))
> + outputs))
> +
> + (let* ((out (assoc-ref outputs "out"))
> + (var `("PERL5LIB" prefix
> + ,(search-path-as-string->list
> + (or (getenv "PERL5LIB") "")))))
> + (for-each (lambda (dir)
> + (let ((files (list-of-files dir)))
> + (for-each (cut wrap-program <> var)
> + files)))
> + bindirs)))
> +
> (define %standard-phases
> ;; Everything is as with the GNU Build System except for the `configur=
e',
> ;; `build', `check', and `install' phases.
> @@ -75,6 +103,7 @@
> (replace 'install install)
> (replace 'check check)
> (replace 'build build)
> + (add-after 'install 'wrap wrap)
> (replace 'configure configure)))
>=20=20
> (define* (perl-build #:key inputs (phases %standard-phases)
> --=20
> 2.11.0
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAljafrQACgkQoqBt8qM6
VPoaxwgAovh4FZ4VyPEGx+eV0vEC5IDSwUmGCdOZ5ditnNk94x238bueOpGMfHcm
crtWL9SkFsHE/r9WO6bjyYqB+zkSLiBrRGG0e4hMJFCIgtpGG+iip91q2OjhapYj
sQnsDUrENaVeIsOUKN36VB7aE7Zyq6YP5MYdnPdM/XKmA6/rJbNEHjh8x5p8aFwz
7/p3MnrWqfzubJcktJ5j/RpCqpiPNKKPJJuzge5+YmmA9MxEbTKUExtbMWofY7qs
+T6a7KjfqfN6e+WOoFFxYZXM5/KEGH5ItLYIQLEby+rdUwzsc/9emYuJ/BbKQ1yk
ibWh5VTuJD0wVEWRO5Gok0iXNIk0WQ==
=TgsL
-----END PGP SIGNATURE-----
--=-=-=--
guix-patches@HIDDEN:bug#26275; Package guix-patches.
Full text available.
Received: (at 26275) by debbugs.gnu.org; 28 Mar 2017 14:33:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 28 10:33:28 2017
Received: from localhost ([127.0.0.1]:49426 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1cssBc-0008VE-9z
for submit <at> debbugs.gnu.org; Tue, 28 Mar 2017 10:33:28 -0400
Received: from o169.p9.mailjet.com ([87.253.234.169]:36329)
by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from
<f5525e2f.AEAAIZKx6N0AAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2nQ0@HIDDEN>)
id 1cssBa-0008V6-2a
for 26275 <at> debbugs.gnu.org; Tue, 28 Mar 2017 10:33:26 -0400
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt;
d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@HIDDEN; s=mailjet;
h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to:
references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding;
bh=wz4/8f47EIBkQOPI4oAzN7gFARI=;
b=YURG7wBFlG3s3OKCWRuQ1sfJwkpKJnEFrGKDrZFLAb3Vp/LJh65doYECV
6KXKHHqLcuv1fcbHEgcvOp60HaS24lulV/AW8HLYZAsHUkFbkOulBLaCJJ7C
qrMRxrgAcM/9jE8tt8Tbih/QMoAO2PigjUbsRR/tOiyQe+/2T38M6c=
Message-Id: <f5525e2f.AEAAIZKx6N0AAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2nQ0@HIDDEN>
MIME-Version: 1.0
From: Arun Isaac <arunisaac@HIDDEN>
To: 26275 <at> debbugs.gnu.org
Subject: Re: [PATCH] build: perl-build-system: Add `wrap' phase.
Date: Tue, 28 Mar 2017 20:03:13 +0530
In-reply-to: <20170327193850.12655-1-arunisaac@HIDDEN>
References: <20170327193850.12655-1-arunisaac@HIDDEN>
X-CSA-Complaints: whitelist-complaints@HIDDEN
X-MJ-Mid: AEAAIZKx6N0AAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2nQ0yMgRiLcHQM-Obt8QnQMaswAFgUc
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.8 (--)
X-Debbugs-Envelope-To: 26275
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.8 (--)
> +(define* (wrap #:key inputs outputs #:allow-other-keys)
> + (define (list-of-files dir)
> + (map (cut string-append dir "/" <>)
> + (or (scandir dir (lambda (f)
> + (let ((s (stat (string-append dir "/" f))))
> + (eq? 'regular (stat:type s)))))
> + '())))
> +
> + (define bindirs
> + (append-map (match-lambda
> + ((_ . dir)
> + (list (string-append dir "/bin")
> + (string-append dir "/sbin"))))
> + outputs))
> +
> + (let* ((out (assoc-ref outputs "out"))
> + (var `("PERL5LIB" prefix
> + ,(search-path-as-string->list
> + (or (getenv "PERL5LIB") "")))))
> + (for-each (lambda (dir)
> + (let ((files (list-of-files dir)))
> + (for-each (cut wrap-program <> var)
> + files)))
> + bindirs)))
I copied this wrap function from the python build system, and modified
it a little to suite perl. Is there any reason `list-of-files' and
`bindirs' are initialized using `define' rather than a `let' binding?
This is probably a very basic Guile question, but still...
Thanks,
Arun Isaac.
=
guix-patches@HIDDEN:bug#26275; Package guix-patches.
Full text available.Received: (at 26275) by debbugs.gnu.org; 27 Mar 2017 19:49:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 27 15:49:35 2017 Received: from localhost ([127.0.0.1]:47771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1csadz-0001LD-9h for submit <at> debbugs.gnu.org; Mon, 27 Mar 2017 15:49:35 -0400 Received: from o142.p9.mailjet.com ([87.253.234.142]:38995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <d3615c29.AEUAITWsO4EAAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2WzM@HIDDEN>) id 1csadx-0001L3-Nr for 26275 <at> debbugs.gnu.org; Mon, 27 Mar 2017 15:49:34 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@HIDDEN; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=F1SGywAk0WM+iS8ZbmOE9gdVvhk=; b=n+ghPgAlxHON0NuIA2DNrMSIxwendUe9gKYzwdDVB+09l0yQtgK5FZzEz Fnuc0j0VWXnmSmbbQb+ZCJlWhPo7LtB3QojXK6sOhzAMUGQtK64UIWJXZnrp q7j84D8yaiRP6GYVtDZ70aH+GSPg9arrBn7i4b2c0q0iRTJ7Lg1jnc= Message-Id: <d3615c29.AEUAITWsO4EAAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2WzM@HIDDEN> MIME-Version: 1.0 From: Arun Isaac <arunisaac@HIDDEN> To: 26275 <at> debbugs.gnu.org Subject: Re: [PATCH] build: perl-build-system: Add `wrap' phase. Date: Tue, 28 Mar 2017 01:19:20 +0530 In-reply-to: <20170327193850.12655-1-arunisaac@HIDDEN> References: <20170327193850.12655-1-arunisaac@HIDDEN> X-CSA-Complaints: whitelist-complaints@HIDDEN X-MJ-Mid: AEUAITWsO4EAAAAAAAAAAAOwQVoAAAACwQwAAAAAAAW9WABY2WzMHHJwJPZCT--_Y7tcLnekFAAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26275 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) As discussed earlier at bug 26203 (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26203), I have added a `wrap' phase to the perl-build-system. Please consider this a first iteration and provide feedback. =
guix-patches@HIDDEN:bug#26275; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 27 Mar 2017 19:39:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 27 15:39:26 2017
Received: from localhost ([127.0.0.1]:47762 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1csaUA-00015Z-0v
for submit <at> debbugs.gnu.org; Mon, 27 Mar 2017 15:39:26 -0400
Received: from eggs.gnu.org ([208.118.235.92]:37340)
by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from
<3389aacc.ADsAAG-tXNgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABY2Wpd@HIDDEN>)
id 1csaU7-00015M-UO
for submit <at> debbugs.gnu.org; Mon, 27 Mar 2017 15:39:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from
<3389aacc.ADsAAG-tXNgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABY2Wpd@HIDDEN>)
id 1csaU1-0003Tp-Qi
for submit <at> debbugs.gnu.org; Mon, 27 Mar 2017 15:39:18 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID
autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:59762)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from
<3389aacc.ADsAAG-tXNgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABY2Wpd@HIDDEN>)
id 1csaU1-0003Te-Nk
for submit <at> debbugs.gnu.org; Mon, 27 Mar 2017 15:39:17 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56530)
by lists.gnu.org with esmtp (Exim 4.71) (envelope-from
<3389aacc.ADsAAG-tXNgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABY2Wpd@HIDDEN>)
id 1csaU0-0005RF-JJ
for guix-patches@HIDDEN; Mon, 27 Mar 2017 15:39:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from
<3389aacc.ADsAAG-tXNgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABY2Wpd@HIDDEN>)
id 1csaTy-0003T5-0C
for guix-patches@HIDDEN; Mon, 27 Mar 2017 15:39:16 -0400
Received: from o119.p8.mailjet.com ([87.253.233.119]:43311)
by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from
<3389aacc.ADsAAG-tXNgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABY2Wpd@HIDDEN>)
id 1csaTx-0003SW-Mu
for guix-patches@HIDDEN; Mon, 27 Mar 2017 15:39:13 -0400
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt;
d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@HIDDEN; s=mailjet;
h=message-id:from:to:subject:date:list-unsubscribe:cc:x-csa-complaints:
x-mj-mid:mime-version:content-transfer-encoding;
bh=Ov/7CISevKM4uVtdvZ7dYXBi8bw=;
b=XBlMkFQfOYhO4y9udT1fqfv4kLPiFUo/r5DL7zBZISGcb5qPhO0EvRYNf
bzVyIpqU4fkL49MhmmaIux7eVHbQBMErr7zCO9Oqc4dOZKG0WWwiv7BZ/q+e
1U6a0oZnvh7MJlz2PekqgYxT/wnxnNurhu1DSl/DvSqjIaggLLOK2I=
Message-Id: <3389aacc.ADsAAG-tXNgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABY2Wpd@HIDDEN>
From: Arun Isaac <arunisaac@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] build: perl-build-system: Add `wrap' phase.
Date: Tue, 28 Mar 2017 01:08:50 +0530
X-CSA-Complaints: whitelist-complaints@HIDDEN
X-MJ-Mid: ADsAAG-tXNgAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABY2WpdN2XorILGTJCkMlrkVdFj-AAFgUc
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
[fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
Cc: Arun Isaac <arunisaac@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)
* guix/build/perl-build-system.scm (wrap): New procedure.
(%standard-phases): Add it.
---
guix/build/perl-build-system.scm | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/guix/build/perl-build-system.scm b/guix/build/perl-build-syste=
m.scm
index 8f480eae1..32ef86b65 100644
--- a/guix/build/perl-build-system.scm
+++ b/guix/build/perl-build-system.scm
@@ -19,7 +19,10 @@
(define-module (guix build perl-build-system)
#:use-module ((guix build gnu-build-system) #:prefix gnu:)
#:use-module (guix build utils)
+ #:use-module (ice-9 ftw)
#:use-module (ice-9 match)
+ #:use-module (srfi srfi-1)
+ #:use-module (srfi srfi-26)
#:export (%standard-phases
perl-build))
=20
@@ -68,6 +71,31 @@
(define-w/gnu-fallback* (install)
(zero? (system* "./Build" "install")))
=20
+(define* (wrap #:key inputs outputs #:allow-other-keys)
+ (define (list-of-files dir)
+ (map (cut string-append dir "/" <>)
+ (or (scandir dir (lambda (f)
+ (let ((s (stat (string-append dir "/" f))))
+ (eq? 'regular (stat:type s)))))
+ '())))
+
+ (define bindirs
+ (append-map (match-lambda
+ ((_ . dir)
+ (list (string-append dir "/bin")
+ (string-append dir "/sbin"))))
+ outputs))
+
+ (let* ((out (assoc-ref outputs "out"))
+ (var `("PERL5LIB" prefix
+ ,(search-path-as-string->list
+ (or (getenv "PERL5LIB") "")))))
+ (for-each (lambda (dir)
+ (let ((files (list-of-files dir)))
+ (for-each (cut wrap-program <> var)
+ files)))
+ bindirs)))
+
(define %standard-phases
;; Everything is as with the GNU Build System except for the `configure'=
,
;; `build', `check', and `install' phases.
@@ -75,6 +103,7 @@
(replace 'install install)
(replace 'check check)
(replace 'build build)
+ (add-after 'install 'wrap wrap)
(replace 'configure configure)))
=20
(define* (perl-build #:key inputs (phases %standard-phases)
--=20
2.11.0
=
Arun Isaac <arunisaac@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#26275; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.