GNU logs - #26395, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#26395: 25.1; ses.el git master, inhibit-quit on some cell evaluations
Resent-From: Kevin Ryde <user42_kevin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 08 Apr 2017 02:10:01 +0000
Resent-Message-ID: <handler.26395.B.149161738919833 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 26395 <at> debbugs.gnu.org
From: Kevin Ryde <user42_kevin@HIDDEN>
Date: Sat, 08 Apr 2017 12:07:32 +1000
Message-ID: <87k26v1wkb.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

In debian packaged emacs 25.1 but git head ses.el, it seems cell
evaluations sometimes run with inhibit-quit.  For example, initial entry

    emacs -Q /tmp/foo.ses
    Ret                           # enter formula
    inhibit-quit Ret              # the formula
    =>
    displays t

I hoped no inhibit-quit while running formulas (and thought there wasn't
previously), as protection against slow or accidentally infinite forms.

I noticed this in my stock charting program where I communicate with a
database sub-process by accept-process-input, and that func doesn't run
under inhibit-quit.  I could with-local-quit and bail out in a sensible
way, but perhaps there's not meant to be inhibit-quit anyway.

In GNU Emacs 25.1.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2017-01-01, modified by Debian built on x86-csail-01

Important settings:
  value of $LANG: en_AU.iso88591
  locale-coding-system: iso-latin-1-unix

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Kevin Ryde <user42_kevin@HIDDEN>
Subject: bug#26395: Acknowledgement (25.1; ses.el git master, inhibit-quit
 on some cell evaluations)
Message-ID: <handler.26395.B.149161738919833.ack <at> debbugs.gnu.org>
References: <87k26v1wkb.fsf@HIDDEN>
X-Gnu-PR-Message: ack 26395
X-Gnu-PR-Package: emacs
Reply-To: 26395 <at> debbugs.gnu.org
Date: Sat, 08 Apr 2017 02:10:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 26395 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
26395: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26395
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#26395: 25.1; ses.el git master, inhibit-quit on some cell evaluations
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 26 Jul 2019 09:58:02 +0000
Resent-Message-ID: <handler.26395.B26395.156413504922133 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Kevin Ryde <user42_kevin@HIDDEN>
Cc: Vincent =?UTF-8?Q?Bela=C3=AFche?= <vincentb1@HIDDEN>, 26395 <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <87k26v1wkb.fsf@HIDDEN>
Date: Fri, 26 Jul 2019 11:57:17 +0200
In-Reply-To: <87k26v1wkb.fsf@HIDDEN> (Kevin Ryde's message of "Sat, 08 Apr
 2017 12:07:32 +1000")
Message-ID: <87k1c5nmo2.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Kevin Ryde <user42_kevin@HIDDEN> writes:

> In debian packaged emacs 25.1 but git head ses.el, it seems cell
> evaluations sometimes run with inhibit-quit.  For example, initial entry
>
>     emacs -Q /tmp/foo.ses
>     Ret                           # enter formula
>     inhibit-quit Ret              # the formula
>     =>
>     displays t
>
> I hoped no inhibit-quit while running formulas (and thought there wasn't
> previously), as protection against slow or accidentally infinite forms.
>
> I noticed this in my stock charting program where I communicate with a
> database sub-process by accept-process-input, and that func doesn't run
> under inhibit-quit.  I could with-local-quit and bail out in a sensible
> way, but perhaps there's not meant to be inhibit-quit anyway.

Yes, ses.el binds inhibit-quit all over the place, presumably out of an
overabundance of caution (not wanting to mess up the display).  But it
shouldn't do that while computing the formulas, you'd think.

I've Cc'd the maintainer; perhaps he can weigh in here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#26395: 25.1; ses.el git master, inhibit-quit on some cell evaluations
Resent-From: Vincent =?UTF-8?Q?Bela=C3=AFche?= <vincent.belaiche@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 27 Jul 2019 14:21:01 +0000
Resent-Message-ID: <handler.26395.B26395.156423722917083 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Lars Ingebrigtsen <larsi@HIDDEN>, Kevin Ryde <user42_kevin@HIDDEN>
Cc: Vincent =?UTF-8?Q?Bela=C3=AFche?= <vincentb1@HIDDEN>, 26395 <at> debbugs.gnu.org
References: <87k26v1wkb.fsf@HIDDEN> <87k1c5nmo2.fsf@HIDDEN>
From: Vincent =?UTF-8?Q?Bela=C3=AFche?= <vincent.belaiche@HIDDEN>
Message-ID: <ca9720f0-ad7e-980b-ee19-53593be9d104@HIDDEN>
Date: Sat, 27 Jul 2019 16:20:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <87k1c5nmo2.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: fr
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello,

I am not sure what was the exact intention, as this is code which was
written before I became maintainer of SES.

My understanding is that if you quit during modifying the formulas, then
the SES object that under the hood holds all the inputs of the
spreadsheet might get corrupt, and then it would be impossible to
recover from that situation. However, since some processing (updating
the cell values) might be quite lengthy, you want to be able to quit
during that.

Probably there should be some indicator in the mode bar that the
referenes/values/ or display are « dirty », after some quit has occurred
and until the user makes some repair cell reference all + recalculate
all + redisplay all.

Please note that :

- the « repair cell reference » exists ---
   ses-repair-cell-reference-all --- this is one of the additions I did.

- recalculate all exists --- ses-recalculate-all

- but there is not redisplay-all as such, you need to call
   ses-reconstruct-all that will do all three operations, to my
   knonwledge there is no way if you just want to repair the display (for
   instance you have quitted during changing a column width, so the
   cells references and value are not broken, just the display is broken)

FYI, Updating the cell value through the formulaes is made by
post-command-hook, not during the editing of the formula by itself.

Please not that when time allows, my intention was to add some commands
to make some cell permutations (for instance row or column
transposition). I have still not done that, because there are remaining
bugs with the cell renaming, and I wish to solve that before. Also,
quiting/undoing during cell renaming is probably not well supported.

Anyway this discussion is certainly usefull as I have not yet thought
how to handle quiting during such a permutation, and handling undoing of
it --- idealy quitting would be possible, and undoing would undo only
that part that have been done before the quit.

   Vincent.

Le 26/07/2019 à 11:57, Lars Ingebrigtsen a écrit :
 > Kevin Ryde <user42_kevin@HIDDEN> writes:
 >
 >> In debian packaged emacs 25.1 but git head ses.el, it seems cell
 >> evaluations sometimes run with inhibit-quit.  For example, initial entry
 >>
 >>     emacs -Q /tmp/foo.ses
 >>     Ret                           # enter formula
 >>     inhibit-quit Ret              # the formula
 >>     =>
 >>     displays t
 >>
 >> I hoped no inhibit-quit while running formulas (and thought there wasn't
 >> previously), as protection against slow or accidentally infinite forms.
 >>
 >> I noticed this in my stock charting program where I communicate with a
 >> database sub-process by accept-process-input, and that func doesn't run
 >> under inhibit-quit.  I could with-local-quit and bail out in a sensible
 >> way, but perhaps there's not meant to be inhibit-quit anyway.
 >
 > Yes, ses.el binds inhibit-quit all over the place, presumably out of an
 > overabundance of caution (not wanting to mess up the display). But it
 > shouldn't do that while computing the formulas, you'd think.
 >
 > I've Cc'd the maintainer; perhaps he can weigh in here.
 >

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#26395: 25.1; ses.el git master, inhibit-quit on some cell evaluations
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 27 Jul 2019 15:53:02 +0000
Resent-Message-ID: <handler.26395.B26395.15642427463378 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26395
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Vincent =?UTF-8?Q?Bela=C3=AFche?= <vincent.belaiche@HIDDEN>
Cc: Vincent =?UTF-8?Q?Bela=C3=AFche?= <vincentb1@HIDDEN>, Kevin Ryde <user42_kevin@HIDDEN>, 26395 <at> debbugs.gnu.org
Received: via spool by 26395-submit <at> debbugs.gnu.org id=B26395.15642427463378
          (code B ref 26395); Sat, 27 Jul 2019 15:53:02 +0000
Received: (at 26395) by debbugs.gnu.org; 27 Jul 2019 15:52:26 +0000
Received: from localhost ([127.0.0.1]:45229 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hrOzh-0000sP-Sx
	for submit <at> debbugs.gnu.org; Sat, 27 Jul 2019 11:52:26 -0400
Received: from quimby.gnus.org ([80.91.231.51]:40998)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1hrOzf-0000sD-2P
 for 26395 <at> debbugs.gnu.org; Sat, 27 Jul 2019 11:52:23 -0400
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories)
 by quimby.gnus.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)
 (envelope-from <larsi@HIDDEN>)
 id 1hrOza-0002HV-3p; Sat, 27 Jul 2019 17:52:20 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <87k26v1wkb.fsf@HIDDEN> <87k1c5nmo2.fsf@HIDDEN>
 <ca9720f0-ad7e-980b-ee19-53593be9d104@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAD1BMVEV/AQMlAABTAQKeFxpH
 AAFlvZNhAAACK0lEQVQ4jV1T7YHrIAxzIANgzgMAYQBfeQNAjv1nejJpru3xI2kjbEn+oJ+dWRL3
 pnv3zQ6V9ewLEPUq7BpR0zdglqjUmEPTRPQE5jZYKLqmzIddv4HBXGV2IsfiLVFrzriIQSFjzjG5
 AFiXbyAOQdwU3wgB6pc4AxCzsZzc1SBPf4AIL6QOKnzzFwBZmWVK8tCUwK+/wDoRWcyG01cqHmcF
 OVFyjxouVdf1Ucf4OUsit3P0upwvrRH5euVEiveyQ48RM2TVGXvdQqVM5J0B+SKfM6baD84OPt44
 uPKZslUasvz+UoUQ6qduEpsj4hcgAMrZtBNq6z4AgTl4pkPT6jE9jc9A/dBC2xfaiwaTkY+JTOJg
 ucx8NBcIj5XK+hQpnwrt0e8BRXRXKpgPD0lqWYM7URIAw7o6RneHVwvv6qzEl0FhLuTzjq5wfOC7
 GvmchhUkLdl+6eoKjSFL8GmlXFICYfCI6rNYwJ8n5i+v7i4il5BvhL8agLzqgQTlDmVpJne5MIBf
 B8ADgCy5QeK4hNtwI6Le10K0NDFtbA0sxjHty4yyquO/A75jT6ZcpGWU9bbCN4/ZWz4Qk7aajYAy
 7FkHb47uaI9mvhyfwPFwBwjjcwvWXF259+DRqMOjfc8dvMjXPA1BMfwNXEgN3wjG3FLzH6k4VqwV
 5j2pb78jGhfk4CalteWv2bXjJbsfeuO4i4V/W8cYtLWcbwCanQ9y5dAPcg7/cB1yCxnwH+irfa7/
 1zcoAAAAAElFTkSuQmCC
Date: Sat, 27 Jul 2019 17:52:17 +0200
In-Reply-To: <ca9720f0-ad7e-980b-ee19-53593be9d104@HIDDEN> ("Vincent
 \=\?utf-8\?Q\?Bela\=C3\=AFche\=22's\?\= message of "Sat, 27 Jul 2019 16:20:16
 +0200")
Message-ID: <m3k1c379vy.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 
 Content preview:  Vincent =?UTF-8?Q?Bela=C3=AFche?= <vincent.belaiche@HIDDEN> writes: > Anyway
    this discussion is certainly usefull as I have not yet thought > how to handle
    quiting during such a permutation, and handling undoing of > it --- idealy
    quitting would be possible, and undoi [...] 
 
 Content analysis details:   (-2.9 points, 5.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
                             [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Vincent Bela=C3=AFche <vincent.belaiche@HIDDEN> writes:

> Anyway this discussion is certainly usefull as I have not yet thought
> how to handle quiting during such a permutation, and handling undoing of
> it --- idealy quitting would be possible, and undoing would undo only
> that part that have been done before the quit.

Yes, I think that'd be very nice.

--=20
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#26395: 25.1; ses.el git master, inhibit-quit on some cell evaluations
Resent-From: Kevin Ryde <user42_kevin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 28 Jul 2019 00:40:02 +0000
Resent-Message-ID: <handler.26395.B26395.156427438923962 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26395
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Vincent =?UTF-8?Q?Bela=C3=AFche?= <vincent.belaiche@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 26395 <at> debbugs.gnu.org
Received: via spool by 26395-submit <at> debbugs.gnu.org id=B26395.156427438923962
          (code B ref 26395); Sun, 28 Jul 2019 00:40:02 +0000
Received: (at 26395) by debbugs.gnu.org; 28 Jul 2019 00:39:49 +0000
Received: from localhost ([127.0.0.1]:45614 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hrXE4-0006EQ-SV
	for submit <at> debbugs.gnu.org; Sat, 27 Jul 2019 20:39:49 -0400
Received: from sonic302-22.consmr.mail.ne1.yahoo.com ([66.163.186.148]:42216)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <user42_kevin@HIDDEN>) id 1hrXE1-0006EA-Fa
 for 26395 <at> debbugs.gnu.org; Sat, 27 Jul 2019 20:39:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com.au; s=s2048;
 t=1564274378; bh=BU+RJ01pqwD8wecUJPRbz9nWIqQPxkxZKcW5LoQcaRQ=;
 h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject;
 b=heNZCleohoGD/DxYa+2KeWavQgSm0+BSBhc6rEMgt5vgjCOxS3O76GF1kKvLRz4ico6HvvCi28v/TFhwPSmoCn8XRKs+Gedoe19JNRz/4GVGYsJ+Um/XN1CwFTkbSD9JMLuo+cZcknYrupOD82tnxn1RHdD0l0cq6/cgZ4p93V7Pcxz4FE+TsO+WUd8ByBZeODR320ycAkXVFdJd1UjNUEgmcawynCB43CcxhQqLum/JuSWsEz2T8/yPS1g3TfN6baiXqH5f25DuZVrpWBqb79O4ly5DPspsr9CJ+m4Xz+lh/Qgg98RVQO5VgQ8lDu9chl1ZGQKhgwQzGWdumlioXQ==
X-YMail-OSG: YZ5P3qYVM1msEIIHtKZHwkyCkcD7fns9E_7VMRD2zSQUR5Y.QZ57uE4LOwUG6R_
 HXuMgfwrucZo9Arm5t9RzeTEJdAFUIVYSLiC5xOEfWYTs2AlRhRoLtezstAJCotf6o7IlU1B7x_X
 YHZ26p1GpBL1f9TBkRbpiwveICipMPrkSvBisAPi90zFrApdsvUptFgVAkfawKvDIXyrNwSe0rJ3
 yNBrbBYQAIVwEbuHb20SgZmTrgAJ814.A1pBOhKHs18LkUY8lQP3VTwoImVAN5kuD2.Zxfofi94j
 vLMWmAFWCmrX4vSXVq8NxFOjJerchICKYQsrtyYbF1bAuEXuUjEJv8MmEMacXZhjbLKxOmRUFXmq
 .TBOjMuVKao9QHMokumjNiacbkEUW.e2AIckAmAyLgKyCtXqPLN25YNc.8AaIosLydOuUGDGR9NC
 GSpbMu2o5sgomrv0ja987XkqcfOVLgLXBk50d_vQVyBEAjD1ksrSaFwigkNY6JQdCqIEH80ayaPJ
 dd8r33ve3FaqnzFBwtTb6hWlzkPmGzMJaKTNtHNgDU7mQ3bToyJnPe9bQ7oaHx9vJ9CPzJg99K1E
 B7eu0X7xpJkNnvpkqj_JqhsP0Si9.ivTx7YArAoKrfnpWHOY1_YBvytKOeIGEQGdpojjz0D45MZI
 fQhltxkxH4sFC2ERUIs_rGFOiUeaORHZLIoJN7hcXaE48EsGmi0oP0rur9A6uGy0LXycg3_f7HD2
 J7b2vl8q1h.1OWWtZYQn5GaLZYqup2oLvJXIOUkvKEYAkMtDW_ugF4DLU9PSNerrBgqHJ3sa.pfL
 NhxiSWm46.o4OQMy1scplCVwWW9R4jyPNMg5VXBxjozgOXkw_lXs9XcTQjST9UGHDsuHCGck3ZS_
 FWQu6ausUTZtWNa4plDQcnCLSZ3tupWs9LAlupOVxq5L0V2ige7onp9N2FW0zpr_KFtxO7Ddyi0c
 QGkBQgB23sWMdh1eWPfhy8bzqwSwx2FTW8Ql138IlKk8Mn_QA73_28Id4byV41QGPoloJv7g.s.1
 0fTUWtUHSwyXKLCNXGjYfNIxyqDU6K.nQON4QF7gr9.ooBRwYng5o3SYQMABvTX7PAxnStRW01NJ
 tNhqAGkkcfX1EFmIDgkWdmAl6vyI8Rb5qWU.L.eH2rKIsH3pyNtwcpmyceABQrPnuCe1w0uYeQV.
 gNNK2.jrN.SYlhplmsqevAb1BVlxDFFfC.y57qKTgxYM5xg3m1IiXKi83kYeP.MpQHOrhklVABn_
 ahIY-
Received: from sonic.gate.mail.ne1.yahoo.com by
 sonic302.consmr.mail.ne1.yahoo.com with HTTP; Sun, 28 Jul 2019 00:39:38 +0000
Received: by smtp411.mail.ne1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA
 ID 772d3ad89413643733de1889fa9f35a8; 
 Sun, 28 Jul 2019 00:39:38 +0000 (UTC)
From: Kevin Ryde <user42_kevin@HIDDEN>
References: <87k26v1wkb.fsf@HIDDEN> <87k1c5nmo2.fsf@HIDDEN>
 <ca9720f0-ad7e-980b-ee19-53593be9d104@HIDDEN>
Date: Sun, 28 Jul 2019 10:37:12 +1000
In-Reply-To: <ca9720f0-ad7e-980b-ee19-53593be9d104@HIDDEN> ("Vincent
 \=\?iso-8859-1\?Q\?Bela\=EFche\=22's\?\= message of "Sat, 27 Jul 2019 16:20:16
 +0200")
Message-ID: <87imrn0zbb.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Vincent Bela=EFche <vincent.belaiche@HIDDEN> writes:
>
> However, since some processing (updating
> the cell values) might be quite lengthy, you want to be able to quit
> during that.

This is a while ago for me, but I arrived at it only from the formula
eval part.

No doubt storing data and formatted etc should be atomic.  I hoped only
that perhaps those could otherwise be in a consistent state when a
particular formula is evalled, so quit out of something wild is ok.
It would leave some or all recalculates still needed of course.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#26395: 25.1; ses.el git master, inhibit-quit on some cell evaluations
Resent-From: Richard Stallman <rms@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 28 Jul 2019 03:01:02 +0000
Resent-Message-ID: <handler.26395.B26395.15642828364125 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26395
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Vincent =?UTF-8?Q?Bela=C3=83=C2=AFche?= <vincent.belaiche@HIDDEN>
Cc: vincentb1@HIDDEN, user42_kevin@HIDDEN, larsi@HIDDEN, 26395 <at> debbugs.gnu.org
Reply-To: rms@HIDDEN
Received: via spool by 26395-submit <at> debbugs.gnu.org id=B26395.15642828364125
          (code B ref 26395); Sun, 28 Jul 2019 03:01:02 +0000
Received: (at 26395) by debbugs.gnu.org; 28 Jul 2019 03:00:36 +0000
Received: from localhost ([127.0.0.1]:45634 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hrZQK-00014S-IB
	for submit <at> debbugs.gnu.org; Sat, 27 Jul 2019 23:00:36 -0400
Received: from eggs.gnu.org ([209.51.188.92]:47096)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rms@HIDDEN>) id 1hrZQI-00014F-67
 for 26395 <at> debbugs.gnu.org; Sat, 27 Jul 2019 23:00:34 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:50958)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <rms@HIDDEN>)
 id 1hrZQC-00089w-MU; Sat, 27 Jul 2019 23:00:28 -0400
Received: from rms by fencepost.gnu.org with local (Exim 4.82)
 (envelope-from <rms@HIDDEN>)
 id 1hrZQB-0002SF-6u; Sat, 27 Jul 2019 23:00:27 -0400
Content-Type: text/plain; charset=Utf-8
From: Richard Stallman <rms@HIDDEN>
In-Reply-To: <ca9720f0-ad7e-980b-ee19-53593be9d104@HIDDEN> (message from
 Vincent =?UTF-8?Q?Bela=C3=83=C2=AFche?= on Sat, 27 Jul 2019 16:20:16 +0200)
References: <87k26v1wkb.fsf@HIDDEN> <87k1c5nmo2.fsf@HIDDEN>
 <ca9720f0-ad7e-980b-ee19-53593be9d104@HIDDEN>
Message-Id: <E1hrZQB-0002SF-6u@HIDDEN>
Date: Sat, 27 Jul 2019 23:00:27 -0400
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > I am not sure what was the exact intention, as this is code which was
  > written before I became maintainer of SES.

If you think it is worth the trouble, you could try to contact
previous developers and ask them.

-- 
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#26395: 25.1; ses.el git master, inhibit-quit on some cell evaluations
Resent-From: Vincent =?UTF-8?Q?Bela=C3=AFche?= <vincent.belaiche@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 28 Jul 2019 15:12:01 +0000
Resent-Message-ID: <handler.26395.B26395.156432669027824 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26395
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Kevin Ryde <user42_kevin@HIDDEN>
Cc: Lars Ingebrigtsen <larsi@HIDDEN>, 26395 <at> debbugs.gnu.org
Received: via spool by 26395-submit <at> debbugs.gnu.org id=B26395.156432669027824
          (code B ref 26395); Sun, 28 Jul 2019 15:12:01 +0000
Received: (at 26395) by debbugs.gnu.org; 28 Jul 2019 15:11:30 +0000
Received: from localhost ([127.0.0.1]:46990 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hrkpe-0007Eh-9a
	for submit <at> debbugs.gnu.org; Sun, 28 Jul 2019 11:11:30 -0400
Received: from mail-wr1-f49.google.com ([209.85.221.49]:41687)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vincent.belaiche@HIDDEN>) id 1hrkpc-0007EO-2S
 for 26395 <at> debbugs.gnu.org; Sun, 28 Jul 2019 11:11:28 -0400
Received: by mail-wr1-f49.google.com with SMTP id c2so55910832wrm.8
 for <26395 <at> debbugs.gnu.org>; Sun, 28 Jul 2019 08:11:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-transfer-encoding:content-language;
 bh=WUYdonLxgMacARFytOt2g94SGt17XFoSTOuCifI2gws=;
 b=u4TG943j9zD/bDaiH7zeEV13lueTYj1JQPurE7n0P6FMotXyARz3lpuvm1DXMTPgFx
 u+INaAiJsVrtPF81GvbPa6854Pjk9HiPNgzyC/lf/LJ/Ujw7FXw8OJPknaCfIXcKeqs2
 g/E31EBIPEXdt4FP8NV2VUY0+/6YsZvbMUr2Aa/nvSM5+Ju1nWYVKEFTe7TNktBz3XMo
 VP6GL/9GCRR44TBOyByNgeW19HOdkUl8pw3UfOL11lhkdiqi7IMDirBlNrMP6/vn+gjK
 05Cww+iAjoS/sR0rTBfDIU+x17JwORWj5s/NlkiT2uYir6P3ChNsj/9AT+Y+4QNkQ3eT
 Td1A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-transfer-encoding
 :content-language;
 bh=WUYdonLxgMacARFytOt2g94SGt17XFoSTOuCifI2gws=;
 b=FJImSmcnqog8N7fUag7Lw3ksOxOPium3ZqqW2MIJzhoCLy5lB0RagE/9/BF3HZyaHu
 S/WGD+NqmiDYnSZfyqUkw4yjPUNXlzcyirDCzvFxufnfc9Td+n4SBsfT2vjGVXD/1uqS
 2Bd3Ri9QHX69UjCOML3FjEl7FpgpsflwnVEHBS8V0mIXLIK40b8HT6701kcKoHsqcw0m
 4zTJZ3SfSS41fzM6KbRz54SzP5fYNAROie8uAc8/OhREmOyvNMC/KuohRfhbEAp6wiiN
 YYe49znE0/u5sTs9RULMapJKCFQQcftpER41kuvXcCPX3zYnWiMx577wXWqI+qIe51Yo
 chZQ==
X-Gm-Message-State: APjAAAWNvbpYvjbcS7z4o+DAdrPOW0nLFL/WVt8AqwxQqUq1xyWSbhUx
 YRqXNhEMXAT1IilnKeE9r0vekJrq
X-Google-Smtp-Source: APXvYqyku732PluH2UQwsuhWxvWNPM0lO4U1imDNDGI3ZGOpJjn27WW0eVtXwWVTz7vLIsKpKiw1Fg==
X-Received: by 2002:adf:de08:: with SMTP id b8mr89343584wrm.282.1564326682193; 
 Sun, 28 Jul 2019 08:11:22 -0700 (PDT)
Received: from [192.168.1.19] (arennes-656-1-376-211.w90-32.abo.wanadoo.fr.
 [90.32.124.211]) by smtp.googlemail.com with ESMTPSA id
 g131sm42011073wmf.37.2019.07.28.08.11.20
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 28 Jul 2019 08:11:21 -0700 (PDT)
References: <87k26v1wkb.fsf@HIDDEN> <87k1c5nmo2.fsf@HIDDEN>
 <ca9720f0-ad7e-980b-ee19-53593be9d104@HIDDEN> <87imrn0zbb.fsf@HIDDEN>
From: Vincent =?UTF-8?Q?Bela=C3=AFche?= <vincent.belaiche@HIDDEN>
Message-ID: <b99c3628-1f20-17c3-8194-a42285393ce8@HIDDEN>
Date: Sun, 28 Jul 2019 17:11:20 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <87imrn0zbb.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: fr
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,


Le 28/07/2019 à 02:37, Kevin Ryde a écrit : > Vincent Belaïche
<vincent.belaiche@HIDDEN> writes:
 >>
 >> However, since some processing (updating the cell values) might be
 >> quite lengthy, you want to be able to quit during that.
 >
 > This is a while ago for me, but I arrived at it only from the formula
 > eval part.
 >
 > No doubt storing data and formatted etc should be atomic.  I hoped
 > only that perhaps those could otherwise be in a consistent state when
 > a particular formula is evalled, so quit out of something wild is ok.
 > It would leave some or all recalculates still needed of course.

SES has two zones in the buffer.

- print area is what you see data area is where the document object is
- stored

The document object is a vector of cell objects + a few parameters
(column count/width, cell width, local printers), each cell object is
also implemented as a vector.

IMHO what really needs to be atomic --- otherwise recovery is
jeopardized :

1) keep correct the number of lines in the print area --- if you don't
    have that, locating the data area is jeopardized

2) keep correct the cell widths in the print area, and cell intangible
    property --- otherwise the print-area point to cell id is broken

3) any update of the data area.

Just reading the code I found one place where this was not observed, and
I just made a correction --- see
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c1b180153f57777b64e27c45633d8a05e02dda5a

There are surely a number of other ones which I still need to spot and
fix.

FYI cell calculation + update of the print area on the one hand is
deferred with the list ses--deferred-recalc, and update of the data area
is also deferred with the list ses--deferred-write, so inherently there
is a risk when you quit to drop the deferred operations and make the
cell values inconsistent with the result that calculations would
otherwise have, or to break the reference lists, or to make the printed
cell values inconsistent with the actual cell values in the document
object, or to make the data area inconsistent with the document object.

In the latter case (document object inconsistent with data area),
reconstructing all will overwrite document object by what is read from
data area, loosing your latest edits. Similarly saving the document will
not update to consistency the data area, so if you save + close + reopen
the file, that won't solve it.

What really is needed is the « Dirty » indicator for the user to get
warned, and not go on editing a document while there are such
inconsistency. This is especially true for inconsistency between
document object and data area.

I need to fix that, when I am done with remaining bugs in cell renaming.

   Vincent.

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.