GNU bug report logs - #26575
[PATCH] gnu: pcre: Fix Check for Hurd systems.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: rennes <rennes@HIDDEN>; Keywords: patch; merged with #26582; dated Thu, 20 Apr 2017 05:13:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Merged 26575 26582. Request was from ludo@HIDDEN (Ludovic Courtès) to control <at> debbugs.gnu.org. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 20 Apr 2017 14:08:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 20 10:08:20 2017
Received: from localhost ([127.0.0.1]:59092 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1d1Cku-0005dv-Lr
	for submit <at> debbugs.gnu.org; Thu, 20 Apr 2017 10:08:20 -0400
Received: from eggs.gnu.org ([208.118.235.92]:55192)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <manolis837@HIDDEN>) id 1d1Cks-0005df-Fi
 for submit <at> debbugs.gnu.org; Thu, 20 Apr 2017 10:08:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <manolis837@HIDDEN>) id 1d1Ckm-0008Fy-Bw
 for submit <at> debbugs.gnu.org; Thu, 20 Apr 2017 10:08:13 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_20,
 FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:35375)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <manolis837@HIDDEN>)
 id 1d1Ckm-0008Fr-8o
 for submit <at> debbugs.gnu.org; Thu, 20 Apr 2017 10:08:12 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46151)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <manolis837@HIDDEN>) id 1d1Ckl-0004lv-3l
 for guix-patches@HIDDEN; Thu, 20 Apr 2017 10:08:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <manolis837@HIDDEN>) id 1d1Ckf-0008Bu-7l
 for guix-patches@HIDDEN; Thu, 20 Apr 2017 10:08:11 -0400
Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:35761)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <manolis837@HIDDEN>)
 id 1d1Ckf-0008BJ-0I
 for guix-patches@HIDDEN; Thu, 20 Apr 2017 10:08:05 -0400
Received: by mail-wr0-x241.google.com with SMTP id l44so7699456wrc.2
 for <guix-patches@HIDDEN>; Thu, 20 Apr 2017 07:08:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:references:cc:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=oXPDExiZphZSMDGjf/eN2Es77Mn+S3oioaTEOlo88Fo=;
 b=eq08NOFcUnjhUrWxHEj/9Bs2RbT0fEZ5YyfiN8zEym5IHd916fgRMB6uf1T0H2Ylwe
 A9JZbkX3TSIK/J306USnWF4qr3XC3CskBanBocLpx1dn0W0MqEy2n6ujn8aVKU3SnnfK
 Pg96tNHct5JRyjXLYEIhLwA/I+2J0JSBOIRgH7tzNcw9NK8XJgueRV+Q7GbQTc2bmP4E
 +s9jgBTicSMdHef5mU/+sbj3SJRMwOhUIFceX0lFGCo7QGNZ76iYDWySDWJtbBwUniz/
 bYQhd4tI13su2tfriVNsZPKJg2ZvghPmrKobZKbrl/jDFmZ69eu81k8yohP5F5xUjImu
 Zn6Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:references:cc:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=oXPDExiZphZSMDGjf/eN2Es77Mn+S3oioaTEOlo88Fo=;
 b=qHtSsCdLq5nDGrKeXkCaRtWWan7VhG9698rJrLT0LNi5ui4HmT3nB2KACdpt7eoqQX
 yMaJIjeqfz755w4AUEg9CewggmUAUZdnTkkpIcmAlfGQnNKwtNUkpx1aZgEo946JKupt
 lT+J4DVJh3stXldpOdyEaWicG4l7O/rFswbNJMndkoNS8HSJ9xOWt8ibcfmAD+w/TtDL
 6+btXV0bwuU4M0CiIgUFihZ9rZDKnuFREKbE7HSSDwEOfGn9o2kMPiW7Kb03MmC2l4rX
 aVEyhys4AFbvV98QrGhH0t3Mk4dWAedVqs5S7Nf4+m6QCyRJu+zD1cjOVVClwcgqxRvv
 1hrg==
X-Gm-Message-State: AN3rC/5vclNtZG1AeQ81ys2xv1qBKUjV3DT0Xvnwqs0pZxRoqgWkvn7U
 8T1xGeleLPZuCg==
X-Received: by 10.223.179.24 with SMTP id j24mr8335002wrd.172.1492697283865;
 Thu, 20 Apr 2017 07:08:03 -0700 (PDT)
Received: from [192.168.2.110] (ppp-2-86-209-94.home.otenet.gr. [2.86.209.94])
 by smtp.gmail.com with ESMTPSA id
 y190sm23736915wmy.15.2017.04.20.07.08.02
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 20 Apr 2017 07:08:03 -0700 (PDT)
Subject: Re: [PATCH] gnu: pcre: Fix Check for Hurd systems.
To: rennes <rennes@HIDDEN>
References: <5KS7z5mphS+XEqq1mDxH00@zOZmN4tlatuvZLJiZIxdE>
From: Manolis Ragkousis <manolis837@HIDDEN>
Message-ID: <e22f9c74-66f0-5340-a9c7-e88590f3bc96@HIDDEN>
Date: Thu, 20 Apr 2017 17:08:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.0
MIME-Version: 1.0
In-Reply-To: <5KS7z5mphS+XEqq1mDxH00@zOZmN4tlatuvZLJiZIxdE>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
 recognized.
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -3.8 (---)
X-Debbugs-Envelope-To: submit
Cc: guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.8 (---)

Hello Rene

On 04/20/2017 08:12 AM, rennes wrote:
> Hello,
> This patch fix the Check phase on GNU/Hurd.
> Built in Linux and Hurd.
> 
> Additional, I have a doubt regarding the outputs of the package, after
> build shows:
> /gnu/store/9bx00n7mpxiyp9nyjz5qas53kc3wid5i-pcre-8.40-bin
> /gnu/store/qb2mbv1wj3b18ix88blfidyy0yzrzggz-pcre-8.40-doc
> /gnu/store/v8ma5z2d1m78f64c9m3dp6s3359w02h0-pcre-8.40
> 
> The outputs have different hash, is this correct?

You have 3 outputs because of this
(outputs '("out"           ;library & headers
           "bin"           ;depends on Readline (adds 20MiB to the closure)
           "doc"))         ;1.8 MiB of HTML

It seems correct to me.

Also this

>   ,@(if (hurd-triplet? ((or %current-system
>                             %current-target-system)))

should be this

>   ,@(if (hurd-triplet? (or (%current-system)
>                            (%current-target-system)))

Btw trying to build it with `./pre-inst-env guix build
--target=i586-pc-gnu pcre' fails with

** Cannot --enable-pcregrep-libz because zlib.h was not found

Maybe the inputs should become native-inputs?

Thank you!
Manolis




Information forwarded to guix-patches@HIDDEN:
bug#26575; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 20 Apr 2017 05:12:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 20 01:12:35 2017
Received: from localhost ([127.0.0.1]:57814 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1d14OQ-0003QP-N2
	for submit <at> debbugs.gnu.org; Thu, 20 Apr 2017 01:12:34 -0400
Received: from eggs.gnu.org ([208.118.235.92]:35982)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rennes@HIDDEN>) id 1d14OP-0003QC-IW
 for submit <at> debbugs.gnu.org; Thu, 20 Apr 2017 01:12:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <rennes@HIDDEN>) id 1d14OJ-0002cx-8l
 for submit <at> debbugs.gnu.org; Thu, 20 Apr 2017 01:12:28 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,T_DKIM_INVALID
 autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:37767)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <rennes@HIDDEN>)
 id 1d14OJ-0002ct-5a
 for submit <at> debbugs.gnu.org; Thu, 20 Apr 2017 01:12:27 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55183)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <rennes@HIDDEN>) id 1d14OH-0006NQ-UT
 for guix-patches@HIDDEN; Thu, 20 Apr 2017 01:12:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <rennes@HIDDEN>) id 1d14OE-0002cK-Or
 for guix-patches@HIDDEN; Thu, 20 Apr 2017 01:12:25 -0400
Received: from lb1.openmailbox.org ([5.79.108.160]:52422
 helo=mail.openmailbox.org)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <rennes@HIDDEN>)
 id 1d14OE-0002c6-B1
 for guix-patches@HIDDEN; Thu, 20 Apr 2017 01:12:22 -0400
Received: by mail.openmailbox.org (Postfix, from userid 20002)
 id 00E9E510108; Thu, 20 Apr 2017 07:12:19 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org;
 s=openmailbox; t=1492665140;
 bh=dJgXN9NHsobY6jG0AYWzJ9k+YqKK2c2ge/hfGHjV/Eo=;
 h=Date:From:Subject:To:Cc:From;
 b=bpm/nLdDyjYqhjmrE9WcX9hap8lwK9ODTDwxMlR2/ox77CYfYD2B0XlfctADBhgbp
 gQlWjrDlCS1nN2Wj5WpxwhpJ0hj2LUrEwPwhq3NpPE4T+++F6DC3/Sw1wJ4T+RvSvp
 nwvDf/iXxXad+1ByOZB2sPqiB7o3P4gd1P0kxtWE=
Date: Thu, 20 Apr 2017 00:12:13 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=openmailbox.org;
 s=openmailbox; t=1492665138;
 bh=dJgXN9NHsobY6jG0AYWzJ9k+YqKK2c2ge/hfGHjV/Eo=;
 h=Date:From:Subject:To:Cc:From;
 b=QdUpnOa+lpkMsE5ieBQdVqOB3tY7UrVdT8G59gy3d6DtQT4BdUbRv35jbsdVDzhyh
 64dd71DcGNYVvGwsUc2UgtrIUXGX+EmaY9iNimLPY59YEALlQNbM4pu4ccPQBqxwjv
 X3j59IGE6TF25yb/KrZuVmO9zFuB6ywarGTPGsE0=
From: rennes <rennes@HIDDEN>
Subject: [PATCH] gnu: pcre: Fix Check for Hurd systems.
To: guix-patches@HIDDEN
X-Mailer: Balsa 2.5.3
Message-Id: <5KS7z5mphS+XEqq1mDxH00@zOZmN4tlatuvZLJiZIxdE>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-yCOYXEPId47MFgzZPpL2"
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
Cc: manolis837@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)

--=-yCOYXEPId47MFgzZPpL2
Content-Type: text/plain; charset=us-ascii; DelSp=Yes; Format=Flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,
This patch fix the Check phase on GNU/Hurd.
Built in Linux and Hurd.

Additional, I have a doubt regarding the outputs of the package, after =20
build shows:
/gnu/store/9bx00n7mpxiyp9nyjz5qas53kc3wid5i-pcre-8.40-bin
/gnu/store/qb2mbv1wj3b18ix88blfidyy0yzrzggz-pcre-8.40-doc
/gnu/store/v8ma5z2d1m78f64c9m3dp6s3359w02h0-pcre-8.40

The outputs have different hash, is this correct?=

--=-yCOYXEPId47MFgzZPpL2
Content-Type: text/x-patch; charset=UTF-8;
	name=0001-gnu-pcre-Fix-Check-for-Hurd-systems.patch
Content-Disposition: attachment;
	filename=0001-gnu-pcre-Fix-Check-for-Hurd-systems.patch
Content-Transfer-Encoding: quoted-printable

=46rom 051df2ff88138039bfe007f724d983ff9172e264 Mon Sep 17 00:00:00 2001
From: rennes <rennes@HIDDEN>
Date: Thu, 20 Apr 2017 00:05:35 -0500
Subject: [PATCH] gnu: pcre: Fix Check for Hurd systems.

* gnu/packages/pcre.scm (pcre)[arguments]: Add "--disable-stack-for-recursi=
on".
---
 gnu/packages/pcre.scm | 41 ++++++++++++++++++++++++++++++++---------
 1 file changed, 32 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/pcre.scm b/gnu/packages/pcre.scm
index 1946f5229..c92267a90 100644
--- a/gnu/packages/pcre.scm
+++ b/gnu/packages/pcre.scm
@@ -5,6 +5,7 @@
 ;;; Copyright =C2=A9 2016 Leo Famulari <leo@HIDDEN>
 ;;; Copyright =C2=A9 2017 Marius Bakke <mbakke@HIDDEN>
 ;;; Copyright =C2=A9 2017 Ludovic Court=C3=A8s <ludo@HIDDEN>
+;;; Copyright =C2=A9 2017 Rene Saavedra <rennes@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -24,6 +25,7 @@
 (define-module (gnu packages pcre)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages hurd)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages)
   #:use-module (guix packages)
@@ -54,15 +56,36 @@
              ("readline" ,readline)
              ("zlib" ,zlib)))
    (arguments
-    '(#:disallowed-references ("doc")
-      #:configure-flags '("--enable-utf"
-                          "--enable-pcregrep-libz"
-                          "--enable-pcregrep-libbz2"
-                          "--enable-pcretest-libreadline"
-                          "--enable-unicode-properties"
-                          "--enable-pcre16"
-                          "--enable-pcre32"
-                          "--enable-jit")))
+    `(#:disallowed-references ("doc")
+      #:phases
+      (modify-phases %standard-phases
+        (replace 'configure
+                 (lambda* (#:key inputs outputs #:allow-other-keys)
+                   (let* ((out (assoc-ref outputs "out"))
+                          (bin (assoc-ref outputs "bin"))
+                          (doc (assoc-ref outputs "doc")))
+                     (setenv "CONFIG_SHELL" (which "bash"))
+                     (zero?
+                      (system* "./configure"
+                               (string-append "--prefix=3D" out)
+                               (string-append "--bindir=3D" bin)
+                               (string-append "--docdir=3D" doc)
+                               "--enable-utf"
+                               "--enable-pcregrep-libz"
+                               "--enable-pcregrep-libbz2"
+                               "--enable-pcretest-libreadline"
+                               "--enable-unicode-properties"
+                               "--enable-pcre16"
+                               "--enable-pcre32"
+                               "--enable-jit"
+                               ;; On GNU/Hurd systems FAIL 'RunTest' with =
'segmentation
+                               ;; fault' in Check phase, to pass the test =
we can disable
+                               ;; "--enable-jit" or set "--disable-stack-f=
or-recursion"
+                               ;; argument.
+                               ,@(if (hurd-triplet? ((or %current-system
+                                                         %current-target-s=
ystem)))
+                                     '("--disable-stack-for-recursion")
+                                     '())))))))))
    (synopsis "Perl Compatible Regular Expressions")
    (description
     "The PCRE library is a set of functions that implement regular express=
ion
--=20
2.12.0

=

--=-yCOYXEPId47MFgzZPpL2--




Acknowledgement sent to rennes <rennes@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#26575; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 21 Apr 2017 09:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.