GNU bug report logs - #26575
[PATCH] gnu: pcre: Fix Check for Hurd systems.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26575 in the body.
You can then email your comments to 26575 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: rennes <rennes <at> openmailbox.org>
To: guix-patches <at> gnu.org
Cc: manolis837 <at> gmail.com
Subject: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Date: Thu, 20 Apr 2017 00:12:13 -0500

[Message part 1 (text/plain, inline)]

Hello,
This patch fix the Check phase on GNU/Hurd.
Built in Linux and Hurd.

Additional, I have a doubt regarding the outputs of the package, after  
build shows:
/gnu/store/9bx00n7mpxiyp9nyjz5qas53kc3wid5i-pcre-8.40-bin
/gnu/store/qb2mbv1wj3b18ix88blfidyy0yzrzggz-pcre-8.40-doc
/gnu/store/v8ma5z2d1m78f64c9m3dp6s3359w02h0-pcre-8.40

The outputs have different hash, is this correct?

[0001-gnu-pcre-Fix-Check-for-Hurd-systems.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Manolis Ragkousis <manolis837 <at> gmail.com>
To: rennes <rennes <at> openmailbox.org>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Date: Thu, 20 Apr 2017 17:08:01 +0300

Hello Rene

On 04/20/2017 08:12 AM, rennes wrote:
> Hello,
> This patch fix the Check phase on GNU/Hurd.
> Built in Linux and Hurd.
> 
> Additional, I have a doubt regarding the outputs of the package, after
> build shows:
> /gnu/store/9bx00n7mpxiyp9nyjz5qas53kc3wid5i-pcre-8.40-bin
> /gnu/store/qb2mbv1wj3b18ix88blfidyy0yzrzggz-pcre-8.40-doc
> /gnu/store/v8ma5z2d1m78f64c9m3dp6s3359w02h0-pcre-8.40
> 
> The outputs have different hash, is this correct?

You have 3 outputs because of this
(outputs '("out"           ;library & headers
           "bin"           ;depends on Readline (adds 20MiB to the closure)
           "doc"))         ;1.8 MiB of HTML

It seems correct to me.

Also this

>   ,@(if (hurd-triplet? ((or %current-system
>                             %current-target-system)))

should be this

>   ,@(if (hurd-triplet? (or (%current-system)
>                            (%current-target-system)))

Btw trying to build it with `./pre-inst-env guix build
--target=i586-pc-gnu pcre' fails with

** Cannot --enable-pcregrep-libz because zlib.h was not found

Maybe the inputs should become native-inputs?

Thank you!
Manolis

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.