GNU bug report logs - #26613
Add pootle

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26613 in the body.
You can then email your comments to 26613 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: Add pootle
Date: Sat, 22 Apr 2017 23:13:14 +0200

[Message part 1 (text/plain, inline)]

Hi,

here are patches that add pootle, a translation server written in
django. Some patches modify packages that have several dependents, so
it should probably go to core-updates first.

[0001-gnu-python-pytest-runner-Update-to-2.11.1.patch (text/x-patch, attachment)]

[0002-gnu-Add-python-pytest-warnings.patch (text/x-patch, attachment)]

[0003-gnu-Add-python-pytest-catchlog.patch (text/x-patch, attachment)]

[0004-gnu-Add-python-utils.patch (text/x-patch, attachment)]

[0005-gnu-Add-python-webassets.patch (text/x-patch, attachment)]

[0006-gnu-Add-python-sphinx-me.patch (text/x-patch, attachment)]

[0007-gnu-python-rq-Update-to-0.7.1.patch (text/x-patch, attachment)]

[0008-gnu-Add-python-cssmin.patch (text/x-patch, attachment)]

[0009-gnu-Add-python-diff-match-patch.patch (text/x-patch, attachment)]

[0010-gnu-Add-python-dirsync.patch (text/x-patch, attachment)]

[0011-gnu-Add-python-nosexcover.patch (text/x-patch, attachment)]

[0012-gnu-Add-python-elasticsearch.patch (text/x-patch, attachment)]

[0013-gnu-python-dateutil-Update-to-2.6.0.patch (text/x-patch, attachment)]

[0014-gnu-Add-python-levenshtein.patch (text/x-patch, attachment)]

[0015-gnu-Add-python-scandir.patch (text/x-patch, attachment)]

[0016-gnu-Add-python2-stemming.patch (text/x-patch, attachment)]

[0017-gnu-Add-python-factory-boy.patch (text/x-patch, attachment)]

[0018-gnu-Add-python-translate-toolkit.patch (text/x-patch, attachment)]

[0019-gnu-Add-python-mysqlclient.patch (text/x-patch, attachment)]

[0020-gnu-Add-python-django-assets.patch (text/x-patch, attachment)]

[0021-gnu-Add-python-django-jsonfield.patch (text/x-patch, attachment)]

[0022-gnu-Add-python-django-bulk-update.patch (text/x-patch, attachment)]

[0023-gnu-Add-python-django-contact-form.patch (text/x-patch, attachment)]

[0024-gnu-Add-python-django-contrib-comments.patch (text/x-patch, attachment)]

[0025-gnu-Add-python-django-overextends.patch (text/x-patch, attachment)]

[0026-gnu-Add-python-django-redis.patch (text/x-patch, attachment)]

[0027-gnu-Add-python-django-rq.patch (text/x-patch, attachment)]

[0028-gnu-Add-python-django-sortedm2m.patch (text/x-patch, attachment)]

[0029-gnu-Add-python-django-appconf.patch (text/x-patch, attachment)]

[0030-gnu-Add-python-django-statici18n.patch (text/x-patch, attachment)]

[0031-gnu-python-pytest-django-Update-to-3.1.2.patch (text/x-patch, attachment)]

[0032-gnu-python-pytest-cov-Update-to-2.4.0.patch (text/x-patch, attachment)]

[0033-gnu-Fix-python2-django-allauth.patch (text/x-patch, attachment)]

[0034-gnu-Add-pootle.patch (text/x-patch, attachment)]

Message #8 received at 26613 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 26613 <at> debbugs.gnu.org
Subject: Re: bug#26613: Add pootle
Date: Sat, 22 Apr 2017 20:33:21 -0400

[Message part 1 (text/plain, inline)]

On Sat, Apr 22, 2017 at 11:13:14PM +0200, Julien Lepiller wrote:

Thanks for all these patches!

> here are patches that add pootle, a translation server written in
> django. Some patches modify packages that have several dependents, so
> it should probably go to core-updates first.

We don't want to update foo and break foo's dependents on the master
branch, but unless foo has > 1200 dependents, we can avoid waiting for
core-updates. See:

https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html

For this patch series, the bigger changes are updates to pytest-runner
and dateutil, right? That's less than 200 dependent packages. At that
scale, all the packages could be built as a test on a developer's
machine, or you could just check a few dependent packages and push it to
master with fingers crossed ;)

Patch-specific comments below. Whatever I don't comment on LGTM.

> Subject: [PATCH 01/34] gnu: python-pytest-runner: Update to 2.11.1.
> 
> * gnu/packages/python.scm (python-pytest-runner)
> (python2-pytest-runner): Update to 2.11.1.

I'd check a handful of dependent packages and cross my fingers :)

> Subject: [PATCH 02/34] gnu: Add python-pytest-warnings.
> 
> * gnu/packages/python.scm (python-pytest-warnings, python2-pytest-warnings):
> New variables.

> +    (description
> +     "Pytest plugin to list Python warnings in pytest report.")

I know it can be hard to write detailed descriptions for these little
modules, but please at least write a complete English sentence. For
example, "Python-pytest-warnings is a pytest plugin to list Python
warnings in the pytest report".

> Subject: [PATCH 03/34] gnu: Add python-pytest-catchlog.
> 
> * gnu/packages/python.scm (python-pytest-catchlog, python2-pytest-catchlog):
> New variables.

> +    (home-page "https://github.com/fschulze/pytest-warnings")

Wrong home-page?

> Subject: [PATCH 04/34] gnu: Add python-utils.
> 
> * gnu/packages/python.scm (python-utils, python2-utils): New variables.

> +    (version "2.0.1")

We should use the latest release (2.1.0) or leave a code comment
explaining why we are using an older version. I won't mention this again
if it's an issue for the rest of the new packages.

> Subject: [PATCH 05/34] gnu: Add python-webassets.
> 
> * gnu/packages/python.scm (python-webassets, python2-webassets): New variables.

> +    (home-page "http://github.com/miracle2k/webassets")

Please use the HTTPS URL.

> Subject: [PATCH 07/34] gnu: python-rq: Update to 0.7.1.
> 
> * gnu/packages/python.scm (python-rq, python2-rq): Update to 0.7.1.

We can add this to the commit message:

[source]: Use pypi-uri.

> Subject: [PATCH 11/34] gnu: Add python-nosexcover.
> 
> * gnu/packages/python.scm (python-nosexcover, python2-nosexcover): New variables.

> +    (description "Companion to the built-in nose.plugins.cover.  This plugin
> +will write out an XML coverage report to a file named coverage.xml.

"Nose-xcover is a companion to the built-in @code{nose.plugins.cover}.

> +
> +It will honor all the options you pass to the Nose coverage plugin, especially
> +???cover-package.")

Is '???cover-package' intended?

> Subject: [PATCH 17/34] gnu: Add python-factory-boy.
> 
> * gnu/packages/python.scm (python-factory-boy, python2-factory-boy): New variables.

> +    (arguments
> +     `(#:tests? #f))

Why?

> Subject: [PATCH 18/34] gnu: Add python-translate-toolkit.
> 
> * gnu/packages/python.scm (python-translate-toolkit, python2-translate-toolkit):
> New variables.

> +    (arguments
> +     ;; TODO: tests don't run properly
> +     `(#:tests? #f))

Does it indicate a real problem? If not, can you include a bit about how
it fails in the comment?

> Subject: [PATCH 20/34] gnu: Add python-django-assets.
> 
> * gnu/packages/django.scm (python-django-assets, python2-django-assets):
> New variables.

> +              (snippet
> +               ;; https://github.com/miracle2k/django-assets/issues/87
> +               `(begin
> +                  (substitute* "tests/__init__.py"
> +                    (("settings.configure.*")
> +                     (string-append
> +                       "settings.configure(\n"
> +                       "INSTALLED_APPS=['django_assets', "
> +                       "'django.contrib.staticfiles'],\n"
> +                       "TEMPLATES=[{'BACKEND': "
> +                       "'django.template.backends.django.DjangoTemplates'}],\n"
> +                       ")\n")))
> +                 ;; These tests fail
> +                 (substitute* "tests/test_django.py"
> +                   (("TestLoader") "NoTestLoader"))))))

I think we should do this in a build phase so that the result of `guix
build --source` is not affected. Origin snippets should be used for
removing non-free components and fixing serious security bugs.

> +    (home-page "http://github.com/miracle2k/django-assets")

HTTPS URL, please :)

> Subject: [PATCH 21/34] gnu: Add python-django-jsonfield.
> 
> * gnu/packages/django.scm (python-django-jsonfield, python2-django-jsonfield):
> New variables.

> +            (snippet
> +              '(substitute* "jsonfield/tests.py"
> +                 (("django.forms.util") "django.forms.utils")))))

I'd do this in a build phase, too.

> Subject: [PATCH 22/34] gnu: Add python-django-bulk-update.
> 
> * gnu/packages/django.scm (python-django-bulk-update, python2-django-bulk-update):
> New variables.

> +    (arguments
> +     ;; tests seem to be broken
> +     `(#:tests? #f))

I assume the installed package seems to be working ;)

> Subject: [PATCH 23/34] gnu: Add python-django-contact-form.
> 
> * gnu/packages/django.scm (python-django-contact-form, python2-django-contact-form):
> New variables.

> +    (arguments
> +     `(#:tests? #f))

Why?

> Subject: [PATCH 25/34] gnu: Add python-django-overextends.
> 
> * gnu/packages/django.scm (python-django-overextends, python2-django-overextends):
> New variables.

> +    (arguments
> +     `(#:tests? #f))

? :)

> Subject: [PATCH 26/34] gnu: Add python-django-redis.
> 
> * gnu/packages/django.scm (python-django-redis, python2-django-redis):
> New variables.

> +    (arguments
> +     `(#:tests? #f))

? :)

> Subject: [PATCH 27/34] gnu: Add python-django-rq.
> 
> * gnu/packages/django.scm (python-django-rq, python2-django-rq): New variables.

> +    (arguments
> +     `(#:tests? #f))

? :)

> Subject: [PATCH 28/34] gnu: Add python-django-sortedm2m.
> 
> * gnu/packages/django.scm (python-django-sortedm2m, python2-django-sortedm2m):
> New variables.

> +    (arguments
> +     `(#:tests? #f))

? :)

> Subject: [PATCH 33/34] gnu: Fix python2-django-allauth.
> 
> because python-openid is not the same package as python2-openid,
> package-with-python2 doesn't work in packages that depend on it.

I think this will need the python2-variant system, which was introduced
to handle Python packages whose python-2 variants can't be automatically
created by package-with-python2.

See:
https://bugs.gnu.org/22437

> Subject: [PATCH 34/34] gnu: Add pootle.
> 
> * gnu/packages/django.scm (pootle): New variable.

> +    (version "2.8.0rc5")

Usually we don't package beta versions or release candidates, but
sometimes it's the right thing to do. What's the story here?

> +        (modules '((guix build utils)))
> +        (snippet
> +         '(begin
> +            (mkdir-p "pytest_pootle/data/po/.tmp")
> +            (substitute* "Pootle.egg-info/requires.txt"
> +              (("1.7.3") "1.8.0")
> +              (("2.0.0") "2.1.0"))
> +            (substitute* "requirements/tests.txt"
> +              (("==3.0.6") ">=3.0.6"))
> +            (substitute* "requirements/base.txt"
> +              (("1.7.3") "1.8.0")
> +              (("2.0.0") "2.1.0"))))))

Let's do this in a build phase.

> +    (arguments
> +     `(#:python ,python-2

If it only supports python-2, can you mention that in a code comment?

> +       #:tests? #f))

Why skip the tests?

> +    (description "Community localization server.")

How about copying the text from <https://github.com/translate/pootle>
for the description?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 26613 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 26613 <at> debbugs.gnu.org
Subject: Re: bug#26613: Add pootle
Date: Sun, 23 Apr 2017 17:25:59 +0200

[Message part 1 (text/plain, inline)]

Le Sat, 22 Apr 2017 20:33:21 -0400,
Leo Famulari <leo <at> famulari.name> a écrit :

> On Sat, Apr 22, 2017 at 11:13:14PM +0200, Julien Lepiller wrote:
> 
> Thanks for all these patches!
> 
> > here are patches that add pootle, a translation server written in
> > django. Some patches modify packages that have several dependents,
> > so it should probably go to core-updates first.  
> 
> We don't want to update foo and break foo's dependents on the master
> branch, but unless foo has > 1200 dependents, we can avoid waiting for
> core-updates. See:
> 
> https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html
> 
> For this patch series, the bigger changes are updates to pytest-runner
> and dateutil, right? That's less than 200 dependent packages. At that
> scale, all the packages could be built as a test on a developer's
> machine, or you could just check a few dependent packages and push it
> to master with fingers crossed ;)
> 
> Patch-specific comments below. Whatever I don't comment on LGTM.
> 
> > Subject: [PATCH 01/34] gnu: python-pytest-runner: Update to 2.11.1.
> > 
> > * gnu/packages/python.scm (python-pytest-runner)
> > (python2-pytest-runner): Update to 2.11.1.  
> 
> I'd check a handful of dependent packages and cross my fingers :)
I've rebuilt everything, and nothing new fails.

> 
> [lots of suggestions]
OK, I applied all your suggestions, thanks :).

I attached the updated patches. I could find how to run some of the
testsuite, and commented when they failed before even running the tests
or when there was no testsuite to begin with. I had to add a few more
packages for the testsuites to run in some packages.

> 
> > Subject: [PATCH 34/34] gnu: Add pootle.
> > 
> > * gnu/packages/django.scm (pootle): New variable.  
> 
> > +    (version "2.8.0rc5")  
> 
> Usually we don't package beta versions or release candidates, but
> sometimes it's the right thing to do. What's the story here?
I use pootle on another system and found that the latest version has
some bugs that make it difficult to use (though not breaking it
completely). I'm a happy user of the release candidate. I could package
version 2.7.6 too, but I wouldn't use it ;).

> 
> [other suggestions]
>

All done too, thanks :)

[0001-gnu-python-pytest-runner-Update-to-2.11.1.patch (text/x-patch, attachment)]

[0002-gnu-Add-python-pytest-warnings.patch (text/x-patch, attachment)]

[0003-gnu-Add-python-pytest-catchlog.patch (text/x-patch, attachment)]

[0004-gnu-Add-python-utils.patch (text/x-patch, attachment)]

[0005-gnu-Add-python-webassets.patch (text/x-patch, attachment)]

[0006-gnu-Add-python-sphinx-me.patch (text/x-patch, attachment)]

[0007-gnu-python-rq-Update-to-0.7.1.patch (text/x-patch, attachment)]

[0008-gnu-Add-python-cssmin.patch (text/x-patch, attachment)]

[0009-gnu-Add-python-diff-match-patch.patch (text/x-patch, attachment)]

[0010-gnu-Add-python-dirsync.patch (text/x-patch, attachment)]

[0011-gnu-Add-python-nosexcover.patch (text/x-patch, attachment)]

[0012-gnu-Add-python-elasticsearch.patch (text/x-patch, attachment)]

[0013-gnu-python-dateutil-Update-to-2.6.0.patch (text/x-patch, attachment)]

[0014-gnu-Add-python-levenshtein.patch (text/x-patch, attachment)]

[0015-gnu-Add-python-scandir.patch (text/x-patch, attachment)]

[0016-gnu-Add-python2-stemming.patch (text/x-patch, attachment)]

[0017-gnu-Add-python-factory-boy.patch (text/x-patch, attachment)]

[0018-gnu-Add-python-translate-toolkit.patch (text/x-patch, attachment)]

[0019-gnu-Add-python-mysqlclient.patch (text/x-patch, attachment)]

[0020-gnu-Add-python-django-assets.patch (text/x-patch, attachment)]

[0021-gnu-Add-python-django-jsonfield.patch (text/x-patch, attachment)]

[0022-gnu-Add-python-dj-database-url.patch (text/x-patch, attachment)]

[0023-gnu-Add-python-django-bulk-update.patch (text/x-patch, attachment)]

[0024-gnu-Add-python-django-contact-form.patch (text/x-patch, attachment)]

[0025-gnu-Add-python-django-contrib-comments.patch (text/x-patch, attachment)]

[0026-gnu-Add-python-django-overextends.patch (text/x-patch, attachment)]

[0027-gnu-Add-python-hiredis.patch (text/x-patch, attachment)]

[0028-gnu-Add-python-fakeredis.patch (text/x-patch, attachment)]

[0029-gnu-Add-python-django-redis.patch (text/x-patch, attachment)]

[0030-gnu-Add-python-django-rq.patch (text/x-patch, attachment)]

[0031-gnu-Add-python-django-sortedm2m.patch (text/x-patch, attachment)]

[0032-gnu-Add-python-django-appconf.patch (text/x-patch, attachment)]

[0033-gnu-Add-python-django-statici18n.patch (text/x-patch, attachment)]

[0034-gnu-python-pytest-django-Update-to-3.1.2.patch (text/x-patch, attachment)]

[0035-gnu-python-pytest-cov-Update-to-2.4.0.patch (text/x-patch, attachment)]

[0036-gnu-Fix-python2-django-allauth.patch (text/x-patch, attachment)]

[0037-gnu-Add-pootle.patch (text/x-patch, attachment)]

Message #14 received at 26613 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 26613 <at> debbugs.gnu.org
Subject: Re: bug#26613: Add pootle
Date: Mon, 08 May 2017 22:13:55 +0200

Julien Lepiller <julien <at> lepiller.eu> skribis:

>> 
>> [other suggestions]
>>
>
> All done too, thanks :)

37 patches, woow.  :-)

As a rule of thumb, if you addressed all of Leo’s comments and
everything passes ‘guix lint’ and ‘guix build’, you can go ahead and
push!

Thank you.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.