X-Loop: help-debbugs@HIDDEN
Subject: bug#26750: 25.2; js-mode missing keywords
Resent-From: Yuen Ho Wong <wyuenho@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 02 May 2017 19:47:01 +0000
Resent-Message-ID: <handler.26750.B.14937543743585 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 26750
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: 26750 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.14937543743585
(code B ref -1); Tue, 02 May 2017 19:47:01 +0000
Received: (at submit) by debbugs.gnu.org; 2 May 2017 19:46:14 +0000
Received: from localhost ([127.0.0.1]:51552 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1d5dkT-0000vl-KE
for submit <at> debbugs.gnu.org; Tue, 02 May 2017 15:46:13 -0400
Received: from eggs.gnu.org ([208.118.235.92]:40824)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <wyuenho@HIDDEN>) id 1d5dPc-0000P6-Ag
for submit <at> debbugs.gnu.org; Tue, 02 May 2017 15:24:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <wyuenho@HIDDEN>) id 1d5dPW-0002fr-0n
for submit <at> debbugs.gnu.org; Tue, 02 May 2017 15:24:35 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM,
T_DKIM_INVALID autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:34497)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <wyuenho@HIDDEN>) id 1d5dPV-0002ff-TI
for submit <at> debbugs.gnu.org; Tue, 02 May 2017 15:24:33 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60023)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from <wyuenho@HIDDEN>) id 1d5dPU-00033S-CX
for bug-gnu-emacs@HIDDEN; Tue, 02 May 2017 15:24:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <wyuenho@HIDDEN>) id 1d5dPT-0002dM-0V
for bug-gnu-emacs@HIDDEN; Tue, 02 May 2017 15:24:32 -0400
Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:38900)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
(Exim 4.71) (envelope-from <wyuenho@HIDDEN>) id 1d5dPS-0002ce-PM
for bug-gnu-emacs@HIDDEN; Tue, 02 May 2017 15:24:30 -0400
Received: by mail-wm0-x230.google.com with SMTP id r190so32510314wme.1
for <bug-gnu-emacs@HIDDEN>; Tue, 02 May 2017 12:24:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:subject:date:message-id:mime-version;
bh=dvmVOIYTdFgToX2zm2os4+3r1ojIwiZaetFKaXanGL0=;
b=Vvnf4fo0QJnFZdpyu1nkDgZmIeAnFxGRIdNDrFyHAVDuMgdTh5A86KWFnUZ1rnDgKp
HqN+oyzBAueDVOIQ+pevRHjPWdVHmnKiiJYX2TFGpc6gUrnOzRsDZhFsy83b4atTMkIN
qlI38o411TVMObqWVXfb9+2xX1tebortv1z3kg0qYaiddSRXTdeGQ5MWLmP0WOgfPLs0
IexJB3jsvyR59eiuE8PDM/qmaLLPSDVeGHGXkxkvrIQWPPTWoZ7nLrBW05l6P99219QF
PBt9UFH7Ko1/l7flmG0I1geHPn+epPWLKvtqIW7+AWix4S7PVyWzmy+UPv/FNNyVjfkc
mAgQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:subject:date:message-id:mime-version;
bh=dvmVOIYTdFgToX2zm2os4+3r1ojIwiZaetFKaXanGL0=;
b=X7uBQAms6JqHhIHi85eLR5qe088hBD9/N199LgcZt2m63RueMF+yHmxz0l51PZ0JqM
zIQbuK3O7xQlE1mJBMJmZqnjlA5baJObcLiJqFGVXlMKFmOBBgT61ufRXSqnP/fWqBA8
2lAjgnqUlUtgx4sEDKQTvFHYvrYXkVx/n3O239XC6roJCnmhTVLOZlpcRS/pze4tkt96
dSak7Nnnb+Ql2MxhGFheqekPmAO2q89A3/wVtnmj3XK5qyJO2Lh3+N+wU56wyvvtPRoV
TsmfksJMHO4Iiz+hQMkprGvOP6h174MMWkzsDSE6Ke8Do3iqQOwUhwUm8r+56+GZ//t+
QUaQ==
X-Gm-Message-State: AN3rC/4udgSXXSciFrUbHVtNqG67iYAqwacb4YMKrfXCxvYvtK8qRcW5
2HCvrjMHbqts3mc8ax0=
X-Received: by 10.28.20.84 with SMTP id 81mr3604503wmu.51.1493753069210;
Tue, 02 May 2017 12:24:29 -0700 (PDT)
Received: from ceremony-paternal-broken.local
([2a06:98c0:1000:8200:8086:4681:d37e:20f9])
by smtp.gmail.com with ESMTPSA id y6sm22989254wrc.51.2017.05.02.12.24.28
for <bug-gnu-emacs@HIDDEN>
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Tue, 02 May 2017 12:24:28 -0700 (PDT)
From: Yuen Ho Wong <wyuenho@HIDDEN>
X-Google-Original-From: Yuen Ho Wong <jwong@HIDDEN>
Date: Tue, 02 May 2017 20:23:44 +0100
Message-ID: <m2mvavkqpr.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
recognized.
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Mailman-Approved-At: Tue, 02 May 2017 15:46:11 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)
When in js-mode, some latest Javascript keywords are not
highlighted. After looking at js.el, js--keyword-re seems to be missing
the following:
"as", "await, "async", and "of".
"await" is treated as a "future reserved word" in ES6 and promoted to a
keyword in the latest ES8 spec draft.
"async" is treated as a keyword in the AsyncFunctionExpression rule in
ES8 draft.
"of" is treated as a keyword in the for-of iteration production rule in
ES6.
"as" is treated as a keyword in import * as statements in ES6.
References:
ES6: https://www.ecma-international.org/ecma-262/6.0/
ES8: https://tc39.github.io/ecma262/
In GNU Emacs 25.2.1 (x86_64-apple-darwin16.4.0)
of 2017-04-24 built on sierra.internal.macports.net
Configured using:
'configure --prefix=/opt/local --without-ns --without-x --without-dbus
--without-gconf --without-libotf --without-m17n-flt --without-gpm
--without-gnutls --with-xml2 --with-modules --infodir
/opt/local/share/info/emacs 'CFLAGS=-pipe -Os -arch x86_64'
CPPFLAGS=-I/opt/local/include 'LDFLAGS=-L/opt/local/lib
-Wl,-headerpad_max_install_names -Wl,-no_pie -arch x86_64''
Configured features:
NOTIFY ACL LIBXML2 ZLIB MODULES
Important settings:
value of $LC_ALL: en_US.UTF-8
value of $LANG: en_US.UTF-8
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
electric-indent-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Making completion list...
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message dired format-spec rfc822 mml
mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
regexp-opt rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode
easymenu cl-loaddefs pcase cl-lib mail-prsvr mail-utils term/xterm xterm
time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type tabulated-list newcomment elisp-mode lisp-mode prog-mode
register page menu-bar rfn-eshadow timer select mouse jit-lock font-lock
syntax facemenu font-core frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
kqueue multi-tty make-network-process emacs)
Memory information:
((conses 16 84806 4043)
(symbols 48 18787 0)
(miscs 40 41 113)
(strings 32 14158 5341)
(string-bytes 1 408779)
(vectors 16 9651)
(vector-slots 8 378732 18240)
(floats 8 149 126)
(intervals 56 197 0)
(buffers 976 19))
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Yuen Ho Wong <wyuenho@HIDDEN> Subject: bug#26750: Acknowledgement (25.2; js-mode missing keywords) Message-ID: <handler.26750.B.14937543743585.ack <at> debbugs.gnu.org> References: <m2mvavkqpr.fsf@HIDDEN> X-Gnu-PR-Message: ack 26750 X-Gnu-PR-Package: emacs Reply-To: 26750 <at> debbugs.gnu.org Date: Tue, 02 May 2017 19:47:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 26750 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 26750: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26750 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: bug#26750: [PATCH] add missing keywords to js-mode
References: <m2mvavkqpr.fsf@HIDDEN>
In-Reply-To: <m2mvavkqpr.fsf@HIDDEN>
Resent-From: Ruslan Bekenev <furyinbox@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 12 May 2017 15:39:01 +0000
Resent-Message-ID: <handler.26750.B26750.149460351916544 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26750
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: 26750 <at> debbugs.gnu.org
Received: via spool by 26750-submit <at> debbugs.gnu.org id=B26750.149460351916544
(code B ref 26750); Fri, 12 May 2017 15:39:01 +0000
Received: (at 26750) by debbugs.gnu.org; 12 May 2017 15:38:39 +0000
Received: from localhost ([127.0.0.1]:41154 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1d9CeN-0004Im-EE
for submit <at> debbugs.gnu.org; Fri, 12 May 2017 11:38:39 -0400
Received: from mail-wr0-f182.google.com ([209.85.128.182]:35453)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <furyinbox@HIDDEN>) id 1d98Uy-0004Wy-Rg
for 26750 <at> debbugs.gnu.org; Fri, 12 May 2017 07:12:41 -0400
Received: by mail-wr0-f182.google.com with SMTP id z52so42159837wrc.2
for <26750 <at> debbugs.gnu.org>; Fri, 12 May 2017 04:12:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=date:from:to:message-id:subject:mime-version;
bh=syKQU/ogAlsBVCm3gs5Igh6zaZW0fadDFRnl8UHOS10=;
b=XXDyF9ahDBaw8pw5aCUGe9zt98hW/JJgVt96ErO95M3PeN1qrI32nUGE343MrdnEsw
OOf/2BqBR4fWjJWIQ5BEuzsoI3Yq1yqmMkCKY+VZutsAwMfCuYwivLjcTMdl2kPCDi59
oPtbjU+gLwLoOaGpS4LOnC1DtHMrf5gAy4DoaqAXlq1Hlsd379LWdcmmblMbcE9WoUOQ
XJHPxkT0+y0rLXbIINi6zOdcTDDCtVvEgRyMcFJj74MwkUTojxgIiZiZuhCGzR341J3a
86YRdxHqxITqzcToW2Kh3aXP5xlhnU1+vHyMiFVg0zEEHYH/Y0krrY5Dp7+EVrgHtn7G
cj5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:message-id:subject:mime-version;
bh=syKQU/ogAlsBVCm3gs5Igh6zaZW0fadDFRnl8UHOS10=;
b=l+P75ESxob0BCR3dh7wUfdyypGV2030jBnAzFo09MC9lSbVS1ck92pIdTmjGFRmagv
8ZWkUWNjlrrNJuanfe389MK9UpaAfpep+oT+yPpmaG5v1lI+k5quYpoKX4VE2h9LnT9Q
dy/uw8LCzk4xVrrrHgTSkIY29NlubyI/rFfC/NvonyYD8PZBudd7y7/BRTxvv1PE5ns2
hd0VBE8Bj3+yJx8u6UkWApLBkLDL928ZoxZfCuKFvG0A3spyoCmNOL6lDTopLnQ9JYkP
ubZjrDiJesmqOq4prpTJWtnbtz2hNZpmh6rpB1YDj/GNsUoDWql5/QMqxEBCGUCQq7QF
y2rw==
X-Gm-Message-State: AODbwcCBV4ndEuTU4mOYirx+yY42X5HnD6BSIg7N0JA4vIFxbpZjQFFz
8xPmD4ZCYbTCiARk
X-Received: by 10.46.13.1 with SMTP id 1mr957884ljn.134.1494587554819;
Fri, 12 May 2017 04:12:34 -0700 (PDT)
Received: from Ruslans-MacBook-Air.local.mail
(broadband-skytelecom-185-52-28-15.clients.kubtel.ru. [185.52.28.15])
by smtp.gmail.com with ESMTPSA id f26sm520979lji.23.2017.05.12.04.12.33
for <26750 <at> debbugs.gnu.org>
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Fri, 12 May 2017 04:12:34 -0700 (PDT)
Date: Fri, 12 May 2017 14:12:32 +0300
From: Ruslan Bekenev <furyinbox@HIDDEN>
Message-ID: <etPan.591598a0.25ce87fd.8ce6@HIDDEN>
X-Mailer: Airmail (424)
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="591598a0_2841737b_8ce6"
X-Spam-Score: -2.3 (--)
X-Mailman-Approved-At: Fri, 12 May 2017 11:38:36 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
--591598a0_2841737b_8ce6
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Hi. It is my first contribution.=C2=A0
I hope everything is correct with this PATCH and submission itself.=C2=A0=
In this patch added two missed keywords to =60js--keyword-re=60 which are=
=60as=60 and =60of=60.=C2=A0
=60async=60 and =60await=60 are already there.=C2=A0
---
=C2=A0lisp/progmodes/js.el =7C 4 ++--
=C2=A01 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el
index bae9e52bf0..02e63986d6 100644
--- a/lisp/progmodes/js.el
+++ b/lisp/progmodes/js.el
=40=40 -278,11 +278,11 =40=40 Match group 1 is the name of the macro.=22)=
=C2=A0(defconst js--keyword-re
=C2=A0 =C2=A0(js--regexp-opt-symbol
- =C2=A0 '(=22abstract=22 =22async=22 =22await=22 =22break=22 =22case=22 =
=22catch=22 =22class=22 =22const=22
+ =C2=A0 '(=22abstract=22 =22as=22 =22async=22 =22await=22 =22break=22 =22=
case=22 =22catch=22 =22class=22 =22const=22
=C2=A0 =C2=A0 =C2=A0 =22continue=22 =22debugger=22 =22default=22 =22delet=
e=22 =22do=22 =22else=22
=C2=A0 =C2=A0 =C2=A0 =22enum=22 =22export=22 =22extends=22 =22final=22 =22=
finally=22 =22for=22
=C2=A0 =C2=A0 =C2=A0 =22function=22 =22goto=22 =22if=22 =22implements=22 =
=22import=22 =22in=22
- =C2=A0 =C2=A0 =22instanceof=22 =22interface=22 =22native=22 =22new=22 =22=
package=22
+ =C2=A0 =C2=A0 =22instanceof=22 =22interface=22 =22native=22 =22new=22 =22=
package=22 =22of=22
=C2=A0 =C2=A0 =C2=A0 =22private=22 =22protected=22 =22public=22 =22return=
=22 =22static=22
=C2=A0 =C2=A0 =C2=A0 =22super=22 =22switch=22 =22synchronized=22 =22throw=
=22
=C2=A0 =C2=A0 =C2=A0 =22throws=22 =22transient=22 =22try=22 =22typeof=22 =
=22var=22 =22void=22 =22let=22
--
--=C2=A0
Ruslan Bekenev
--591598a0_2841737b_8ce6
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
<html><head><style>body=7Bfont-family:Helvetica,Arial;font-size:13px=7D</=
style></head><body style=3D=22word-wrap: break-word; -webkit-nbsp-mode: s=
pace; -webkit-line-break: after-white-space;=22><div id=3D=22bloop=5Fcust=
omfont=22 style=3D=22font-family:Helvetica,Arial;font-size:13px; color: r=
gba(0,0,0,1.0); margin: 0px; line-height: auto;=22>Hi. It is my first con=
tribution. </div><div id=3D=22bloop=5Fcustomfont=22 style=3D=22font-=
family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0p=
x; line-height: auto;=22>I hope everything is correct with this PATCH and=
submission itself. </div><div id=3D=22bloop=5Fcustomfont=22 style=3D=
=22font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); ma=
rgin: 0px; line-height: auto;=22>In this patch added two missed keywords =
to =60js--keyword-re=60 which are =60as=60 and =60of=60. </div><div =
id=3D=22bloop=5Fcustomfont=22 style=3D=22font-family:Helvetica,Arial;font=
-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;=22>=60=
async=60 and =60await=60 are already there. </div><div id=3D=22bloop=
=5Fcustomfont=22 style=3D=22font-family:Helvetica,Arial;font-size:13px; c=
olor: rgba(0,0,0,1.0); margin: 0px; line-height: auto;=22><br></div><div =
id=3D=22bloop=5Fcustomfont=22 style=3D=22font-family:Helvetica,Arial;font=
-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;=22><d=
iv id=3D=22bloop=5Fcustomfont=22 style=3D=22margin: 0px;=22>---</div><div=
id=3D=22bloop=5Fcustomfont=22 style=3D=22margin: 0px;=22> lisp/prog=
modes/js.el =7C 4 ++--</div><div id=3D=22bloop=5Fcustomfont=22 style=3D=22=
margin: 0px;=22> 1 file changed, 2 insertions(+), 2 deletions(-)</di=
v><div id=3D=22bloop=5Fcustomfont=22 style=3D=22margin: 0px;=22><br></div=
><div id=3D=22bloop=5Fcustomfont=22 style=3D=22margin: 0px;=22>diff --git=
a/lisp/progmodes/js.el b/lisp/progmodes/js.el</div><div id=3D=22bloop=5F=
customfont=22 style=3D=22margin: 0px;=22>index bae9e52bf0..02e63986d6 100=
644</div><div id=3D=22bloop=5Fcustomfont=22 style=3D=22margin: 0px;=22>--=
- a/lisp/progmodes/js.el</div><div id=3D=22bloop=5Fcustomfont=22 style=3D=
=22margin: 0px;=22>+++ b/lisp/progmodes/js.el</div><div id=3D=22bloop=5Fc=
ustomfont=22 style=3D=22margin: 0px;=22>=40=40 -278,11 +278,11 =40=40 Mat=
ch group 1 is the name of the macro.=22)</div><div id=3D=22bloop=5Fcustom=
font=22 style=3D=22margin: 0px;=22><br></div><div id=3D=22bloop=5Fcustomf=
ont=22 style=3D=22margin: 0px;=22> (defconst js--keyword-re</div><di=
v id=3D=22bloop=5Fcustomfont=22 style=3D=22margin: 0px;=22> (=
js--regexp-opt-symbol</div><div id=3D=22bloop=5Fcustomfont=22 style=3D=22=
margin: 0px;=22>- '(=22abstract=22 =22async=22 =22await=22 =22brea=
k=22 =22case=22 =22catch=22 =22class=22 =22const=22</div><div id=3D=22blo=
op=5Fcustomfont=22 style=3D=22margin: 0px;=22>+ '(=22abstract=22 =22=
as=22 =22async=22 =22await=22 =22break=22 =22case=22 =22catch=22 =22class=
=22 =22const=22</div><div id=3D=22bloop=5Fcustomfont=22 style=3D=22margin=
: 0px;=22> =22continue=22 =22debugger=22 =22default=22=
=22delete=22 =22do=22 =22else=22</div><div id=3D=22bloop=5Fcustomfont=22=
style=3D=22margin: 0px;=22> =22enum=22 =22export=22 =
=22extends=22 =22final=22 =22finally=22 =22for=22</div><div id=3D=22bloop=
=5Fcustomfont=22 style=3D=22margin: 0px;=22> =22funct=
ion=22 =22goto=22 =22if=22 =22implements=22 =22import=22 =22in=22</div><d=
iv id=3D=22bloop=5Fcustomfont=22 style=3D=22margin: 0px;=22>- &nbs=
p; =22instanceof=22 =22interface=22 =22native=22 =22new=22 =22package=22<=
/div><div id=3D=22bloop=5Fcustomfont=22 style=3D=22margin: 0px;=22>+ &nbs=
p; =22instanceof=22 =22interface=22 =22native=22 =22new=22 =22pack=
age=22 =22of=22</div><div id=3D=22bloop=5Fcustomfont=22 style=3D=22margin=
: 0px;=22> =22private=22 =22protected=22 =22public=22=
=22return=22 =22static=22</div><div id=3D=22bloop=5Fcustomfont=22 style=3D=
=22margin: 0px;=22> =22super=22 =22switch=22 =22synch=
ronized=22 =22throw=22</div><div id=3D=22bloop=5Fcustomfont=22 style=3D=22=
margin: 0px;=22> =22throws=22 =22transient=22 =22try=22=
=22typeof=22 =22var=22 =22void=22 =22let=22</div><div id=3D=22bloop=5Fcu=
stomfont=22 style=3D=22margin: 0px;=22>--</div></div><br><div class=3D=22=
bloop=5Fsign=22 id=3D=22bloop=5Fsign=5F1494586521550140928=22><div style=3D=
=22font-family:helvetica,arial;font-size:13px=22>-- <br>Ruslan Beken=
ev<br><br></div></div></body></html>
--591598a0_2841737b_8ce6--
X-Loop: help-debbugs@HIDDEN
Subject: bug#26750: [PATCH] add missing keywords to js-mode
Resent-From: Noam Postavsky <npostavs@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 28 Apr 2018 21:09:01 +0000
Resent-Message-ID: <handler.26750.B26750.152494970730439 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26750
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Ruslan Bekenev <furyinbox@HIDDEN>
Cc: Jimmy Yuen Ho Wong <wyuenho@HIDDEN>, 26750 <at> debbugs.gnu.org
Received: via spool by 26750-submit <at> debbugs.gnu.org id=B26750.152494970730439
(code B ref 26750); Sat, 28 Apr 2018 21:09:01 +0000
Received: (at 26750) by debbugs.gnu.org; 28 Apr 2018 21:08:27 +0000
Received: from localhost ([127.0.0.1]:42289 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1fCX51-0007uo-IG
for submit <at> debbugs.gnu.org; Sat, 28 Apr 2018 17:08:27 -0400
Received: from mail-it0-f49.google.com ([209.85.214.49]:50244)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <npostavs@HIDDEN>)
id 1fCX50-0007uX-JW; Sat, 28 Apr 2018 17:08:26 -0400
Received: by mail-it0-f49.google.com with SMTP id p3-v6so5959049itc.0;
Sat, 28 Apr 2018 14:08:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:references:date:in-reply-to:message-id
:user-agent:mime-version:content-transfer-encoding;
bh=1f9I6d4pcJfzZ85xoXeUkVOp8nSba7YU0kdmPX5ir8w=;
b=GAXsfhNBacKWQStqCRWPbv9GQGL9t4IpMENUaZkEWZW5b/Aq4ZMpN+AWMXc5+hS1yP
A3rMsLGNm4HV4+ANkghHGeyJpgy+wwwB8T8Pqk8GneAY23BU8DzdRLY3f9HlCIsnhdkH
f/7poMPUysSoRr4ajYkMC3IgNCkym9MobWmsp3RQM6mkDuq2sp/7LfTR5j3GNWaguqQL
2DJF16pz2Ojm2a3ww/G6sSG5O3u9dutZ33R2EOHikMq6xI4y2GsUdB4nNvwrBhLjVtbb
sf69jwdlDkJknlRsIn4nN43kuAgJMesAupX0gHnSDw9GCNnhriSk/6JQsSVyHkoRg6/T
FYCQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
:message-id:user-agent:mime-version:content-transfer-encoding;
bh=1f9I6d4pcJfzZ85xoXeUkVOp8nSba7YU0kdmPX5ir8w=;
b=ucUTo7jb7vWik3SKbXUcju/5T/uPoalqpLVYf48WVIhOLuqkxDx7Z1k6n++NvU8Ulu
4X81v9JxfhaWC74hx/RF56kOx5HQnCGZPp3Rky3qCVhq0H8Su4IVSQrR7CLrBBTsSquI
VFQUDhifv36+xmYTzpfRi63dvHoSwpx65/W15BGRYPP1LXGhcuXd64nnN0LV8f8A9fTu
MHXGG+LYto5VLlWIA7DVySyTWEZvs56XnfLetihilKp4l1FmAUWxZ48diCe1WbkNeh0w
vs6Ndqa2UQjHUnX1TI4VOqE5znrvl18BtKToNDqQKWQONlmYo9iM5lt6KVvSvynAeA5A
1XIw==
X-Gm-Message-State: ALQs6tBPq8B12GapDLD6w5lyxUZ5CYT6xmNFSzgwatl7EInERHkkjhZT
8RDnFlG3Ua6/H8J45ggvkIccTA==
X-Google-Smtp-Source: AB8JxZofM/xR63U03vK5z9DXR6OZlqo7KIthd31Bg0wDeYwwFnbPHL1rL545n4uaSegGY3XOL9glNw==
X-Received: by 2002:a24:1995:: with SMTP id b143-v6mr59628itb.84.1524949700851;
Sat, 28 Apr 2018 14:08:20 -0700 (PDT)
Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34])
by smtp.googlemail.com with ESMTPSA id
q67-v6sm1986522ita.11.2018.04.28.14.08.19
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Sat, 28 Apr 2018 14:08:20 -0700 (PDT)
From: Noam Postavsky <npostavs@HIDDEN>
References: <m2mvavkqpr.fsf@HIDDEN>
<etPan.591598a0.25ce87fd.8ce6@HIDDEN>
Date: Sat, 28 Apr 2018 17:08:09 -0400
In-Reply-To: <etPan.591598a0.25ce87fd.8ce6@HIDDEN> (Ruslan Bekenev's
message of "Fri, 12 May 2017 14:12:32 +0300")
Message-ID: <87zi1nox8m.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
forcemerge 26750 31306
quit
Ruslan Bekenev <furyinbox@HIDDEN> writes:
> Hi. It is my first contribution.=C2=A0
> I hope everything is correct with this PATCH and submission itself.=C2=A0
> In this patch added two missed keywords to `js--keyword-re` which are `as=
` and `of`.=C2=A0
> `async` and `await` are already there.=C2=A0
Hi, sorry your patch was overlooked for so long. Unfortunately, I think
just adding keywords to js--keyword-re will not quite do the right
thing, based on https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31306#5:
Specially, "as" and "from" should only be highlighted in an import
statement. "of" should only be highlighted in a for statement. Any other
occurrances of "as", "from" and "of" should not be highlighted as they
are legal identifiers outside of import and for statements respectively.
Received: (at control) by debbugs.gnu.org; 28 Apr 2018 21:08:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 28 17:08:27 2018
Received: from localhost ([127.0.0.1]:42287 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1fCX51-0007um-Bk
for submit <at> debbugs.gnu.org; Sat, 28 Apr 2018 17:08:27 -0400
Received: from mail-it0-f49.google.com ([209.85.214.49]:50244)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <npostavs@HIDDEN>)
id 1fCX50-0007uX-JW; Sat, 28 Apr 2018 17:08:26 -0400
Received: by mail-it0-f49.google.com with SMTP id p3-v6so5959049itc.0;
Sat, 28 Apr 2018 14:08:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:references:date:in-reply-to:message-id
:user-agent:mime-version:content-transfer-encoding;
bh=1f9I6d4pcJfzZ85xoXeUkVOp8nSba7YU0kdmPX5ir8w=;
b=GAXsfhNBacKWQStqCRWPbv9GQGL9t4IpMENUaZkEWZW5b/Aq4ZMpN+AWMXc5+hS1yP
A3rMsLGNm4HV4+ANkghHGeyJpgy+wwwB8T8Pqk8GneAY23BU8DzdRLY3f9HlCIsnhdkH
f/7poMPUysSoRr4ajYkMC3IgNCkym9MobWmsp3RQM6mkDuq2sp/7LfTR5j3GNWaguqQL
2DJF16pz2Ojm2a3ww/G6sSG5O3u9dutZ33R2EOHikMq6xI4y2GsUdB4nNvwrBhLjVtbb
sf69jwdlDkJknlRsIn4nN43kuAgJMesAupX0gHnSDw9GCNnhriSk/6JQsSVyHkoRg6/T
FYCQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
:message-id:user-agent:mime-version:content-transfer-encoding;
bh=1f9I6d4pcJfzZ85xoXeUkVOp8nSba7YU0kdmPX5ir8w=;
b=ucUTo7jb7vWik3SKbXUcju/5T/uPoalqpLVYf48WVIhOLuqkxDx7Z1k6n++NvU8Ulu
4X81v9JxfhaWC74hx/RF56kOx5HQnCGZPp3Rky3qCVhq0H8Su4IVSQrR7CLrBBTsSquI
VFQUDhifv36+xmYTzpfRi63dvHoSwpx65/W15BGRYPP1LXGhcuXd64nnN0LV8f8A9fTu
MHXGG+LYto5VLlWIA7DVySyTWEZvs56XnfLetihilKp4l1FmAUWxZ48diCe1WbkNeh0w
vs6Ndqa2UQjHUnX1TI4VOqE5znrvl18BtKToNDqQKWQONlmYo9iM5lt6KVvSvynAeA5A
1XIw==
X-Gm-Message-State: ALQs6tBPq8B12GapDLD6w5lyxUZ5CYT6xmNFSzgwatl7EInERHkkjhZT
8RDnFlG3Ua6/H8J45ggvkIccTA==
X-Google-Smtp-Source: AB8JxZofM/xR63U03vK5z9DXR6OZlqo7KIthd31Bg0wDeYwwFnbPHL1rL545n4uaSegGY3XOL9glNw==
X-Received: by 2002:a24:1995:: with SMTP id b143-v6mr59628itb.84.1524949700851;
Sat, 28 Apr 2018 14:08:20 -0700 (PDT)
Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34])
by smtp.googlemail.com with ESMTPSA id
q67-v6sm1986522ita.11.2018.04.28.14.08.19
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Sat, 28 Apr 2018 14:08:20 -0700 (PDT)
From: Noam Postavsky <npostavs@HIDDEN>
To: Ruslan Bekenev <furyinbox@HIDDEN>
Subject: Re: bug#26750: [PATCH] add missing keywords to js-mode
References: <m2mvavkqpr.fsf@HIDDEN>
<etPan.591598a0.25ce87fd.8ce6@HIDDEN>
Date: Sat, 28 Apr 2018 17:08:09 -0400
In-Reply-To: <etPan.591598a0.25ce87fd.8ce6@HIDDEN> (Ruslan Bekenev's
message of "Fri, 12 May 2017 14:12:32 +0300")
Message-ID: <87zi1nox8m.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
Cc: Jimmy Yuen Ho Wong <wyuenho@HIDDEN>, 26750 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
forcemerge 26750 31306
quit
Ruslan Bekenev <furyinbox@HIDDEN> writes:
> Hi. It is my first contribution.=C2=A0
> I hope everything is correct with this PATCH and submission itself.=C2=A0
> In this patch added two missed keywords to `js--keyword-re` which are `as=
` and `of`.=C2=A0
> `async` and `await` are already there.=C2=A0
Hi, sorry your patch was overlooked for so long. Unfortunately, I think
just adding keywords to js--keyword-re will not quite do the right
thing, based on https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31306#5:
Specially, "as" and "from" should only be highlighted in an import
statement. "of" should only be highlighted in a for statement. Any other
occurrances of "as", "from" and "of" should not be highlighted as they
are legal identifiers outside of import and for statements respectively.
X-Loop: help-debbugs@HIDDEN
Subject: bug#26750: [PATCH] add missing keywords to js-mode
Resent-From: Jimmy Yuen Ho Wong <wyuenho@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 28 Apr 2018 21:48:02 +0000
Resent-Message-ID: <handler.26750.B26750.152495202516932 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26750
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: Noam Postavsky <npostavs@HIDDEN>, Ruslan Bekenev <furyinbox@HIDDEN>
Cc: 26750 <at> debbugs.gnu.org
Received: via spool by 26750-submit <at> debbugs.gnu.org id=B26750.152495202516932
(code B ref 26750); Sat, 28 Apr 2018 21:48:02 +0000
Received: (at 26750) by debbugs.gnu.org; 28 Apr 2018 21:47:05 +0000
Received: from localhost ([127.0.0.1]:42351 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1fCXgO-0004P1-Nj
for submit <at> debbugs.gnu.org; Sat, 28 Apr 2018 17:47:04 -0400
Received: from mail-wr0-f181.google.com ([209.85.128.181]:34690)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <wyuenho@HIDDEN>) id 1fCXgM-0004OR-GV
for 26750 <at> debbugs.gnu.org; Sat, 28 Apr 2018 17:47:03 -0400
Received: by mail-wr0-f181.google.com with SMTP id p18-v6so4785011wrm.1
for <26750 <at> debbugs.gnu.org>; Sat, 28 Apr 2018 14:47:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date
:user-agent:mime-version:in-reply-to:content-transfer-encoding
:content-language;
bh=t1soDS5bORAmHelD4eNjHDiFNtn1dVVJDBPKILd5f9A=;
b=dSuE7jra4kMovhV5HAFWhnUtV7/nnEy2UHtX9KwvV5h8+cwLoDSCecITSgY7f8yZnn
RoYowjjFbfbxWq4gil+eau5xP+i7KINfvjLs0egx1iFItkhhBE9gaxzJ0nKeNf5eh8IT
z+JKw5gyDJNxoWB2ZyngufDE2VdTt91MH7NSoIJftk+fIG9aKwcFXEK/dO8/R9TZ6e5W
bPQWoF8H1xNTTLdjtfBHAPmj6x/KVyU/1gTUtWGcS0uXHPsbSCPYcnPK3hb3T29rnxc3
Z0wgTkn1B85mLL7aT3cX5SIR+QfL17wadHl4Mraf69SxBlarOYJF+BScGJzQYjg5cZRY
HKww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt
:message-id:date:user-agent:mime-version:in-reply-to
:content-transfer-encoding:content-language;
bh=t1soDS5bORAmHelD4eNjHDiFNtn1dVVJDBPKILd5f9A=;
b=WDKGOsQjOmqpYJekka4YZQvemL12kAyuzS6v61Xion9w4rXjU64GI/oSuDEnAtRqFq
+wFXDL30CrsU3dukJmBM3ZAcsUZUI5GAW/MPN39n15OrfpnT+HZ4bLq0ww1A07hnIAEb
GDc8+4Et9YP4yU1ScPG+4d+mL+pbnv++qzGA6rq+ZjSVNOXjjWGPspbVkLI/8K7rn/E8
8gFJBSydjWeJjC9TT9rGXmUa/gt0jyRep8T7TU9I9USmQczcwPGs6w1Hs2LNAQGY5NRI
57dz9GU14wal2l1cvTrp3jVu8tjE7tqajTwwnJ4GNSKSZ5Vh4hbiNntcMSAfFU4n06NA
f0zg==
X-Gm-Message-State: ALQs6tAm2TMP38Tr+oijwU8AQfuEikAiNSMruIIucj2D2FExPy4YrpIe
LKuhdeBneigMQzsTen5QIwak5PXD
X-Google-Smtp-Source: AB8JxZrQOO+x9V/WaMEmOdJVc+JF/c3CDjRAiGZbK189p9f2PMxC4WvOIzy0vcjW55dZCeLss09/HQ==
X-Received: by 2002:adf:86b2:: with SMTP id
47-v6mr5094985wrx.256.1524952016684;
Sat, 28 Apr 2018 14:46:56 -0700 (PDT)
Received: from MobileCat.local ([88.98.208.53])
by smtp.gmail.com with ESMTPSA id q34-v6sm6466396wrb.27.2018.04.28.14.46.55
(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Sat, 28 Apr 2018 14:46:55 -0700 (PDT)
References: <m2mvavkqpr.fsf@HIDDEN>
<etPan.591598a0.25ce87fd.8ce6@HIDDEN> <87zi1nox8m.fsf@HIDDEN>
From: Jimmy Yuen Ho Wong <wyuenho@HIDDEN>
Openpgp: preference=signencrypt
Autocrypt: addr=wyuenho@HIDDEN; prefer-encrypt=mutual; keydata=
xsFNBFrSFY8BEADPCwJ+z3krWkYRMNlw3UkxtYlj3v5fuPzjxvpzegH7x0breoiF782EY1j6
Xr3U3yV6WKBRVNgCkF6xibSl1BXFYQMw+k/27OGr/v+7NB+HOORAKxMvYeepR9nMpQuIB5+4
BT2Jyk2bmnpS27eXscDFlS4KmUPztg1odVGlMwe0ltrNgmEb5AZ7OSGw9doq4KfwBLJ0K+YQ
Se0LltI8DP/TTNgl/srmWxWER4DhNB7c5+Eu8k+OLSED1bborTZPOBN6xYVupv8KolQNMg3c
EvQ11jvVCa5vDV1o/2IR2UT18fp2XjFQbJSHd6dKuXnBNlkyqhtgJzDBk6YtBhRlh+/2DcKA
VCaxIFNjWAl1SmTb79rPYIVRHCN7WCj2wV+rjBb3DAQ4TAWjOiEBkBQIdWIA2Cv7nOsni4cT
/s9yb7ZU0KUGdoFs5vVCk0z9fDKvzZKifPerT5zPzeEq6k7CvU2Gfkk7CMWUcmi/2gjKspXv
POL2c5Wl+lTwrOYs4ZEwy1QHXq7DIdod0wjWBc8LmiezW8kdYJMNjBq6+4nRdQHgjh92oYjF
Xn0NZy77wlpzq3AMRMCRe2KPfEFfe2JolsTpDG0JLQZ3YO2zEqGJS9l0lpJh8wRvnQgK8ZIb
XkG4fnj84wnm3pQ2P8qmpeLcVeeBIZ+N6zLiw1PMCKbcYshYCQARAQABzSVKaW1teSBXb25n
IDxqaW1teS53b25nQGhvbWV0YXN0eS5jb20+wsGUBBMBCAA+FiEEuxndnIwL3x6VsafhJzCH
EBHFrC8FAlrSFY8CGyMFCQlmAYAFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQJzCHEBHF
rC+unQ//Uy0JxmWA5UzwnIBXxIgFoOcmYTi9mcy3IsDBsAjV2QcVgWRvssiZHk/PUX/P9pU3
I4qEv6eiwB77XrDm+H2XSSjE+d1GAs3HD/WPRCM75tkVEO5RjXiABRRkUQ7umqW3jhsh5GCp
zd217IycDxDZRZmllL0fmAn/V1NdpzxbEloleJYeJNfFtvJSSGWobct4DriXxMBCAro2amGY
bX6mJqfYLB22UpNT8RONqNb4SztQrZp1+j4KEsndIWusdcXX34t+bumUv0SdbtGA4Ck+ld1I
lIPMJuD9rdhiFx+JpYjPreaA7oZ6dkgAJfJQ95K19PTm8lxFmR1mUahmD6JmLbOcQ1r5WtZ0
CbqCGqNLMTOPp0vXEpdP7bRpl6rjzsfyNVs6TVF6yVf8RvWkn88zqV6LLnops7NTEvVU2dD6
AEDN7H1EOWgsXwzr5ePCxw2AVdLpnUERMvvWWnHO5uCzsH8ODa8GGOpDGinUwZSQRTDFrrJV
nhIvEATM9cHGbKzSXSiU7iFxuC58yIeC+jHKKMUjYMouv+iLmKYbcPtfqZF8mkD4h4nIg9HR
Cb7iyNeP2BSvG3Mw/I9/mdpq6u7XfdJAmYEtQUAVLDu9NeKh7/xSQmWIDsvxpAPxTrrymF62
eULOrKKS/Af3e5OMceC6YRtSPe2umgcey9/2RmJQ4ZnOwU0EWtIVjwEQAMC63B3i5sAAQEaV
w4Zntm2BFvOoBfrUkmgBAByBlmCJTrGMBbPfkt70vpulyziei1EylPHmF4Ak2QaMraTdh3sf
j9hc+VJibT0vMM8YGMvB2l44dJoX7DGYezlcRGUES0lwBufM9PzD+ZWBqWsh510BTB/Q1i/m
tKrClhwKkIsINgmi9RYzy+l2VT6YX3BQiLit0HhVqzABxO3z7W9cr0Pv3YSXytO/aQh1Xw5q
kM0hXKkjuFlmnS3VJNI6UYiSkNkBeQkfEw+TvwtcLmv3vIeF0B40w+XFmIGiLOe/mQV4TALr
9JtxTAhZiFMW2MkEpZ6BomaTt1FHRiT2S5oX+uLZBcz3Cw/qZAztNSuUqZEOuvG9mQnAYia/
QDxMLvt1HyxPI9ShDuoxoqtS3H95f+AO2wZ6Ix9CgXis6ff1SPjzwhzkVVLkU5jYRTjp36oI
onJ1g7ccEDM+Fito06oPDEww47ceaqihg3Zqc5HiY96SbQPb411RhrIak37gZlX2g2RIUc9x
Jq7LuFnRBqUG+1XwY7+LGEnTu6k8mCuQ281ofk87t9SO5RCp8+MrhImOc7xAkslEK1qJ8o26
ncL4IuAkI9FL4/cAhMFBu153BaUWaYQhFaKa+AG8l1Puon39rE+1YTbUerWB+5iclt4noIyV
pnZD8qCN92iptg63eteBABEBAAHCwXwEGAEIACYWIQS7Gd2cjAvfHpWxp+EnMIcQEcWsLwUC
WtIVjwIbDAUJCWYBgAAKCRAnMIcQEcWsL3+AD/4i5dBMnj5V2SkrkTn/Gho1/tz/zXzx0lxe
+y+NWQZ8dbBUmFhWU1xK+kU49oOpozx6iu1EzPYke/YKYBcR7g858HxC5BlrUVxZxdIX+anm
vD3eU1nkOYM6U5TMqHtc//KK+ZoXkN7uLsYkkRPQjQ9hrTFX5RpkHI+6ilKJ+9uUBDUWPQGd
y5YimlI6BJn1TzAGixfEytYNRIe6InB2ce/ptFQHc83TrcML2Y1gL0E2SieHw6vv07WfrNK2
/tV4N/lA97IT/xZLZ9bRkzoTSJz6QOrdyGdhqXDkw2ghYNKM3+3YU5SBfoqoaBYvzoAdw5KE
B8qUHrHe3qmjee8xgZ4wH8acOnxNCo9cZVNUH1otGOwPREYbSYGkd93kFlUkyHbtFtCx1Cl4
ODqZ0sAEmP6dR5Zc2kNTKWX+1ZsCFHO8Z7NLgmshg2BcB+fqDefHJ9JU47BEWSZW3rRYkr42
KivMs8eFO8YoYwnOIrg4mf5hWgfPo8Rh9FicpN6PiVv8B1ojOsQ4OTDb+58iEjCe/LbRAIBC
LnIcIbx2kSS+d2DCNk5+e9SKhi3SoZVRtvFzXQO7dJhkeGevkWGxrBT5OpvPtxfwFPOUbG8y
9gBiJ7VntqfR4FtXQ+OQF5yz05EAEsxevsDLw8np5W6ZBA79mHkOADOGi0TRP9QrOJnFFirV ig==
Message-ID: <9822cef6-7fb4-1b25-e056-a237fa706430@HIDDEN>
Date: Sat, 28 Apr 2018 22:46:55 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0)
Gecko/20100101 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <87zi1nox8m.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-GB
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Technically, "async", "await" and "yield" can also be identifiers.
"async" should only be highlighted if it's followed by a function, arrow
function or a method. "await" should only be highlighted if it's inside
an async function, async arrow function or an async method. "yield"
should only be highlighted inside a generator function/arrow function
and method. But for all intends and purposes, you can put "await" and
"yield" into the list of keywords or you'll have to write a full blown
parser and AST in order to traverse back and forth. That's how Chrome
devtools does it anyway. Only "async", "as", "of" and "from" need
special handling.
On 28/04/2018 22:08, Noam Postavsky wrote:
> forcemerge 26750 31306
> quit
>
> Ruslan Bekenev <furyinbox@HIDDEN> writes:
>
>> Hi. It is my first contribution.=C2=A0
>> I hope everything is correct with this PATCH and submission itself.=C2=
=A0
>> In this patch added two missed keywords to `js--keyword-re` which are =
`as` and `of`.=C2=A0
>> `async` and `await` are already there.=C2=A0
> Hi, sorry your patch was overlooked for so long. Unfortunately, I thin=
k
> just adding keywords to js--keyword-re will not quite do the right
> thing, based on https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D31306#5=
:
>
> Specially, "as" and "from" should only be highlighted in an import
> statement. "of" should only be highlighted in a for statement. Any =
other
> occurrances of "as", "from" and "of" should not be highlighted as t=
hey
> are legal identifiers outside of import and for statements respecti=
vely.
>
>
Received: (at control) by debbugs.gnu.org; 6 Aug 2019 15:45:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Aug 06 11:45:17 2019 Received: from localhost ([127.0.0.1]:37663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1hv1eH-0004AH-Dr for submit <at> debbugs.gnu.org; Tue, 06 Aug 2019 11:45:17 -0400 Received: from mail-pg1-f177.google.com ([209.85.215.177]:37962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <akgaikwad001@HIDDEN>) id 1hv1eD-00049w-MB for control <at> debbugs.gnu.org; Tue, 06 Aug 2019 11:45:15 -0400 Received: by mail-pg1-f177.google.com with SMTP id z14so4571853pga.5 for <control <at> debbugs.gnu.org>; Tue, 06 Aug 2019 08:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=zPbp/lHo8WTTure2ZYbZyxTpzIoRBDuGtn+3r19XyUI=; b=NsC4ockKm5S6f6S8VuJiDTTZbmTo17EQez9PAghW6SeJs9lhx4mhNTPyaUrNL2tVZ2 OSYKc3DjB9cqCdG/AFew0q5ErkeNzmgW35HsrJFeMfCvPLZuR4nSw45SAf8cq0ydCRsf tNw/CrtqHbcBG/lECds0VYIKTHoaZ8Akl7msFLilaKQCyMohocmAwahgkeLxRY5PDLwl OojJLtvE6RbdLczU8iTijEMXEfU8wuCDQQrVjpaqY8X4Zy2WekjRb1tj/jdwR+9w8Sj9 4zOt8YLZlXwJaM6ylFuryeWVWYsU89zOASVTPsI3xefchw2rPzKlcRyGn6EepG9VGRLT eqGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=zPbp/lHo8WTTure2ZYbZyxTpzIoRBDuGtn+3r19XyUI=; b=HtBTmM/P+2lj5NqlLZmbk1yN6ES7hrJASMjA7MMLRDwCpNzqT1VXtKdkhz3xp5mHDo UjP9K2Ku1sEmM5cw3218mbtP1ND27C0BmQ8i64P6tl0n6zEePlh1zjg/PKMsU2VwaOPI RbcL+o+jcEklGyn2DSd3jP+elv0liVlNeWYOZyLWtIO7FSwGCw/iEToWwsuSnyC7p9jW 2YxykPZBtBaSTv8HvZ0XT6MkBEvNc0eHUFfTh1bzeIPazmM1KoP/JlADT9/Qtoma3BIZ P7jdHKiwOVrzN19fDp5phe9RB2MsPiDGTiwdWVgc5SJaFTE9JLhaBIngDPXGV1WiLZJx TQwg== X-Gm-Message-State: APjAAAU/75YOCMRvPLhoc5k9KY/8wxHVJ8iGSWDbkSe2lXGaQVujhaqo rpWxlWBAOINT6X43AB5yrvrOfVnz X-Google-Smtp-Source: APXvYqwUKa9c9UXXge6kEt2U586YfsdbypmjwS2FD5U0BEMspdUV+Y2g6BwIsT2HFEpXkiNHC+CH2w== X-Received: by 2002:aa7:9191:: with SMTP id x17mr4336178pfa.23.1565106307177; Tue, 06 Aug 2019 08:45:07 -0700 (PDT) Received: from localhost.localdomain ([2409:4042:2805:27b9:2c1e:99b4:28f1:c2a2]) by smtp.gmail.com with ESMTPSA id 11sm29772517pgo.43.2019.08.06.08.45.03 for <control <at> debbugs.gnu.org> (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 06 Aug 2019 08:45:06 -0700 (PDT) To: control <at> debbugs.gnu.org From: Akshay Gaikwad <akgaikwad001@HIDDEN> Subject: control message for bug #31306 Message-ID: <7d6a18e8-b6b9-0365-20de-09fd5910ea13@HIDDEN> Date: Tue, 6 Aug 2019 21:14:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) tag 31306 confirmed quit
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.