GNU bug report logs - #26776
[PATCH] gnu: Add Parcimonie.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26776 in the body.
You can then email your comments to 26776 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Petter <petter <at> mykolab.ch>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add Parcimonie.
Date: Thu, 4 May 2017 13:51:28 +0200

[Message part 1 (text/plain, inline)]

Hi Guix,

So I'm looking to improve my key management skills and was reading this article,
https://riseup.net/en/security/message-security/openpgp/best-practices
I had not heard of Parcimonie before, but I immediately liked the idea of it.
And since Parcimonie wasn't packaged for Guix I of course figured I should
package it real quick. After all, a program that just refreshes your keyring
every now and then shouldn't be too complex and need a lot of dependencies,
maybe a few, right?

Well, it needed a lot. And the dependencies needed a lot of dependencies. And
also some of the dependencies dependencies required many dependencies. Great! I
naively jumped into this, and at any one point had no idea if I was packaging
the last module or not (I'm sure you're familiar with this). Think I got the
last one in the end though. But it's taken waaay more time than I anticipated.
Also with 56 packages it becomes difficult to make sure each of them is on
standard, so I assume some are below standard.

It would be particularly interesting if someone with some Parcimonie experience
could try it, and report if there's any missing features etc.. I haven't used
it before and have just started it a few times to see that it can at least
start.

Back to the article for me :)

Best,
Petter

[0001-gnu-Add-Parcimonie.patch (text/x-patch, attachment)]

Message #8 received at 26776 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Petter <petter <at> mykolab.ch>
Cc: 26776 <at> debbugs.gnu.org
Subject: Re: bug#26776: [PATCH] gnu: Add Parcimonie.
Date: Thu, 11 May 2017 23:31:10 +0200

Hi Petter,

Petter <petter <at> mykolab.ch> skribis:

> From fdf2b751d19a1c9397535cb5054557b1fd711d23 Mon Sep 17 00:00:00 2001
> From: Petter <petter <at> mykolab.ch>
> Date: Sun, 30 Apr 2017 11:40:06 +0200
> Subject: [PATCH] gnu: Add Parcimonie.
>
> * gnu/packages/gnupg.scm: New variables.
> * gnu/packages/perl.scm: Same.
> * gnu/packages/web.scm: Same.
> * gnu/packages/xml.scm: Same.

Overall this looks good to me, and a useful addition!  There are a few
“cosmetic” things that I think should be addressed:

[...]

> +    (synopsis "Lorem Ipsum")
> +    (description "Lorem Ipsum")

Could you fix this?  :-)

> +(define-public perl-archive-extract
> +(package
> +  (name "perl-archive-extract")
> +  (version "0.80")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +             "mirror://cpan/authors/id/B/BI/BINGOS/Archive-Extract-"
> +             version
> +             ".tar.gz"))
> +      (sha256
> +        (base32
> +          "1x15j1q6w6z8hqyqgap0lz4qbq2174wfhksy1fdd653ccbaw5jr5"))))
> +  (build-system perl-build-system)
> +  (home-page
> +    "http://search.cpan.org/dist/Archive-Extract")
> +  (synopsis "Generic archive extracting mechanism")
> +  (description "It allows you to extract any archive file of the type .tar, .tar.gz, .gz, .Z, tar.bz2, .tbz, .bz2, .zip, .xz,, .txz, .tar.xz or .lzma without having to worry how it does so, or use different interfaces for each type by using either perl modules, or commandline tools on your system.")
> +  (license (package-license perl))))

Please run:

  ./etc/indent-code.el gnu/packages/perl.scm perl-archive-extract
  ./pre-inst-env guix lint perl-archive-extract

Likewise for the other packages here.

Last thing: we usually submit one package per patch.  Do you think you
could split the patch?  If not, if there are no objections (Ricardo?),
we could consider making an exception…

Thanks in advance!

Ludo’.

Message #13 received at 26776-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Petter <petter <at> mykolab.ch>, 26776-done <at> debbugs.gnu.org
Subject: Re: bug#26776: [PATCH] gnu: Add Parcimonie.
Date: Wed, 25 Oct 2017 10:53:46 +0200

Hi Petter,

I have split the patch into separate commits, fixed some incorrect
licenses and descriptions, enabled tests where possible, changed
“inputs” to “propagated-inputs” where appropriate, and updated some of
the packages.

I skipped some non-essential packages such as perl-app-nopaste and its
dependencies, because it was not needed after all, and it reduced the
overall amount of work.

The result is the parcimonie package added with commit 15b084425 in
master.

Thanks for the contribution!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #16 received at 26776-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Petter <petter <at> mykolab.ch>, 26776-done <at> debbugs.gnu.org
Subject: Re: bug#26776: [PATCH] gnu: Add Parcimonie.
Date: Thu, 26 Oct 2017 15:17:38 -0700

Heya,

Ricardo Wurmus <rekado <at> elephly.net> skribis:

> I have split the patch into separate commits, fixed some incorrect
> licenses and descriptions, enabled tests where possible, changed
> “inputs” to “propagated-inputs” where appropriate, and updated some of
> the packages.
>
> I skipped some non-essential packages such as perl-app-nopaste and its
> dependencies, because it was not needed after all, and it reduced the
> overall amount of work.
>
> The result is the parcimonie package added with commit 15b084425 in
> master.

A big thanks to you too, Ricardo, for this thankless work!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.