GNU bug report logs - #26818
Certbot with Python 3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26818 in the body.
You can then email your comments to 26818 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: Certbot with Python 3
Date: Sun, 7 May 2017 14:46:10 -0400

[Message part 1 (text/plain, inline)]

The latest release of Certbot and the acme library can use Python 3 [0].

These patches create a new python-mock <at> 2 variable, and then upgrade
certbot and python-acme to use Python 3 by default. I did some light
testing by renewing some certificates.

[0]
https://github.com/certbot/certbot/pull/4568/commits/48b47274e7e6b11b7748b72a8e87add3f218e8b7

[0001-gnu-Add-python-mock-2.patch (text/plain, attachment)]

[0002-gnu-certbot-Build-with-Python-3.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 26818 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>, 26818 <at> debbugs.gnu.org
Subject: Re: bug#26818: Certbot with Python 3
Date: Mon, 08 May 2017 10:05:29 +0200

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> * gnu/packages/python.scm (python-mock-2): New variable.

[...]

> +;;; Some packages (notably, certbot and python-acme) rely on this newer version
> +;;; of python-mock. However, a large number of packages fail to build with
> +;;; mock <at> 2, so we add a new variable for now. Also, there may be a dependency
> +;;; cycle between mock and six, so we avoid creating python2-mock <at> 2 for now.
  ^^^^
Only two semicolons. The patches LGTM otherwise.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 26818 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26818 <at> debbugs.gnu.org
Subject: Re: bug#26818: Certbot with Python 3
Date: Mon, 8 May 2017 14:00:06 -0400

[Message part 1 (text/plain, inline)]

On Mon, May 08, 2017 at 10:05:29AM +0200, Marius Bakke wrote:
> Leo Famulari <leo <at> famulari.name> writes:
> 
> > * gnu/packages/python.scm (python-mock-2): New variable.
> 
> [...]
> 
> > +;;; Some packages (notably, certbot and python-acme) rely on this newer version
> > +;;; of python-mock. However, a large number of packages fail to build with
> > +;;; mock <at> 2, so we add a new variable for now. Also, there may be a dependency
> > +;;; cycle between mock and six, so we avoid creating python2-mock <at> 2 for now.
>   ^^^^
> Only two semicolons. The patches LGTM otherwise.

The convention is to use 3 when the comment starts at the beginning of
the line:

https://www.gnu.org/software/guile/manual/html_node/Comments.html

Thank you for reviewing my patches!

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 26818 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 26818 <at> debbugs.gnu.org
Subject: Re: bug#26818: Certbot with Python 3
Date: Sun, 18 Jun 2017 13:10:38 +0200

Hi Leo,

> The latest release of Certbot and the acme library can use Python 3 [0].
>
> These patches create a new python-mock <at> 2 variable, and then upgrade
> certbot and python-acme to use Python 3 by default. I did some light
> testing by renewing some certificates.
>
[…]
> Subject: [PATCH 1/2] gnu: Add python-mock-2.
> Subject: [PATCH 2/2] gnu: certbot: Build with Python 3.
[…]

Is there something holding up merging these patches?  I haven’t seen
them in master nor in core-updates.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #19 received at 26818-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 26818-done <at> debbugs.gnu.org
Subject: Re: bug#26818: Certbot with Python 3
Date: Mon, 19 Jun 2017 13:08:00 -0400

[Message part 1 (text/plain, inline)]

On Sun, Jun 18, 2017 at 01:10:38PM +0200, Ricardo Wurmus wrote:
> 
> Hi Leo,
> 
> > The latest release of Certbot and the acme library can use Python 3 [0].
> >
> > These patches create a new python-mock <at> 2 variable, and then upgrade
> > certbot and python-acme to use Python 3 by default. I did some light
> > testing by renewing some certificates.
> >
> […]
> > Subject: [PATCH 1/2] gnu: Add python-mock-2.
> > Subject: [PATCH 2/2] gnu: certbot: Build with Python 3.
> […]
> 
> Is there something holding up merging these patches?  I haven’t seen
> them in master nor in core-updates.

I'd hoped to hear about some other people testing this Python-3 certbot,
but since it's working for me, I pushed as
fed1898d4e7855de03a276eb4d370ca1d32a789e.

Thanks for the reminder!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.