GNU bug report logs - #26850
perl-mode: apostrophes trigger color change in wrong situation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26850 in the body.
You can then email your comments to 26850 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: perl-mode: apostrophes trigger color change in wrong situation
Date: Tue, 09 May 2017 06:50:40 +0800

Apostrophes trigger color change in wrong situation:

sub interesting {
    $_ = shift;
    return
         />Today is .+'s birthday\.</
      || / like[ds]? your post in </
      || /like[ds] your new subscription\. </
      || / likes? that you're interested in </
      || /> likes? your comment: /
      || /&amp;birthdays=.*birthdays?\.<\/a>/;
}

Message #14 received at 26850 <at> debbugs.gnu.org (full text, mbox):

From: haj <at> posteo.de (Harald Jörg)
To: 26850 <at> debbugs.gnu.org
Subject: perl-mode and cperl-mode: Recognize regex after "return"
Date: Mon, 16 Nov 2020 23:13:16 +0100

[Message part 1 (text/plain, inline)]

merge 26850 26745
thanks

I don't know whether I have the authority to merge bugs, but they
clearly are the same issue, so I'll just give it a try.

The apostrophe, as mentioned in the subject of Bug#26850, is irrelevant:
The actual problem in both reports is the failure to recognize a regular
expression after the keyword "return".  The apostrophe just changes the
interpretation of the text which follows.

There are several workarounds: You could, for example, explicitly write
the regexes as $_ =~ /.../; ... but of course, why would you do that,
since $_ is superfluous.  Alternatively, you could just omit the
"return", which is also superfluous in the examples provided.

Nevertheless, the patch fixes the issue, which happens in both perl-mode
and cperl-mode.  I guess that in neither mode the list of keywords which
precede a regex is actually complete, but "return" is a use case
relevant enough to be fixed.
--
Cheers,
haj

[0001-cperl-mode-perl-mode-Recognize-a-regular-expression-.patch (text/x-diff, attachment)]

Message #19 received at 26850 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: haj <at> posteo.de (Harald Jörg)
Cc: 26850 <at> debbugs.gnu.org
Subject: Re: bug#26850: perl-mode and cperl-mode: Recognize regex after
 "return"
Date: Tue, 17 Nov 2020 00:24:42 +0100

haj <at> posteo.de (Harald Jörg) writes:

> I don't know whether I have the authority to merge bugs, but they
> clearly are the same issue, so I'll just give it a try.

Oh, sure, I think everybody can.  Hm...  but it doesn't seem to have
gone through in this case?  When the statuses of the bugs involved
aren't the same, you have to use "forcemerge" to make it actually
happened; I did that now.

> There are several workarounds: You could, for example, explicitly write
> the regexes as $_ =~ /.../; ... but of course, why would you do that,
> since $_ is superfluous.  Alternatively, you could just omit the
> "return", which is also superfluous in the examples provided.
>
> Nevertheless, the patch fixes the issue, which happens in both perl-mode
> and cperl-mode.  I guess that in neither mode the list of keywords which
> precede a regex is actually complete, but "return" is a use case
> relevant enough to be fixed.

Thanks for the patch; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.