GNU bug report logs - #26863
guile-squee

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26863 in the body.
You can then email your comments to 26863 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: guile-squee
Date: Wed, 10 May 2017 08:35:06 +0200

[Message part 1 (text/plain, inline)]

I hope this is ok

[Message part 2 (text/html, inline)]

[0002-gnu-Add-guile-squee.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Re: guile-squee
Date: Wed, 10 May 2017 08:59:57 +0200

[Message part 1 (text/plain, inline)]

2017-05-10 8:35 GMT+02:00 Catonano <catonano <at> gmail.com>:

>
> I hope this is ok
>

it's not so ok

Squee contains a link to a C library. It then uses guile i to call C things.

I edited such link manually in order for squee to work on GuixSD

A general solution should be using some configuration machinery.

Ugh

[Message part 2 (text/html, inline)]

Message #11 received at 26863 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Catonano <catonano <at> gmail.com>
Cc: 26863 <at> debbugs.gnu.org
Subject: Re: bug#26863: guile-squee
Date: Sun, 18 Jun 2017 13:28:00 +0200

Hi,

[…]

> +      (arguments
> +       `(#:modules ((guix build utils)
> +                    (ice-9 popen)
> +                    (ice-9 rdelim)
> +                    (srfi srfi-1)
> +                    (guix build gnu-build-system))
> +         #:tests? #f                    ; there is no test target
> +         #:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure)
> +           (delete 'build)
> +           (replace 'install
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (let* ((cwd        (getcwd))
> +                      (scm-files  (find-files "." "\\.scm$"))
> +                      (effective  (read-line
> +                                   (open-pipe* OPEN_READ
> +                                               "guile" "-c"
> +                                               "(display (effective-version))")))
> +                      (module-dir (string-append (assoc-ref outputs "out")
> +                                                 "/share/guile/site/"
> +                                                 effective)))
> +
> +                 ;; Make installation directories.
> +                 (mkdir-p module-dir)
> +
> +                 (setenv "GUILE_AUTO_COMPILE" "0")
> +
> +                 ;; Compile .scm files and install.
> +                 (every (lambda (file)
> +                          (let ((go-file (string-append module-dir "/"
> +                                                        (basename file ".scm") ".go")))
> +                            ;; Install source module.
> +                            (install-file file module-dir)
> +                            ;; Compile and install module.
> +                            (zero? (system* "guild" "compile" "-L" cwd
> +                                            "-o" go-file file))))
> +                        scm-files)))))))

[…]

This looks like it really should be implemented in the Makefile of the project.

> +      (home-page "https://notabug.org/cwebber/guile-squee")

Luckily, upstream is no stranger!  Maybe it would be best to submit a
patch to add a Makefile first, so that we don’t need to do so much work
to package it.

> +      (synopsis "Postgresql bindings for Guile")
> +      (description "Squee is a library for connecting to the excellent
> +PostgreSQL database using Guile.  It uses Guile's \"foreign function
> +interface\" support, which means you don't need to compile
> +anything... it all happens through the magic of dynamic linking!")
> +      (license license:gpl3))))

According to the readme file this is not correct:

   The project is released under the GNU Lesser Public License, version 3
   or later (as published by the FSF), just like Guile itself.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #14 received at 26863 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 26863 <at> debbugs.gnu.org
Subject: Re: bug#26863: guile-squee
Date: Sun, 18 Jun 2017 13:56:52 +0200

[Message part 1 (text/plain, inline)]

2017-06-18 13:28 GMT+02:00 Ricardo Wurmus <rekado <at> elephly.net>:

>
> This looks like it really should be implemented in the Makefile of the
> project.
>
> > +      (home-page "https://notabug.org/cwebber/guile-squee")
>
> Luckily, upstream is no stranger!  Maybe it would be best to submit a
> patch to add a Makefile first, so that we don’t need to do so much work
> to package it.
>

Right, we had a brief chat about this with cwebber. I will probably do
that, some day.
Not only a Makefile but the whole config.am paraphernalia


> > +      (license license:gpl3))))
>
> According to the readme file this is not correct:
>
>    The project is released under the GNU Lesser Public License, version 3
>    or later (as published by the FSF), just like Guile itself.
>

Oh right ! It slipped. I will keep this present in the next one I'll send

For now, I'd say that this issue can be closed.

It won't be soon.

Thanks for reviewing !

[Message part 2 (text/html, inline)]

Message #19 received at 26863-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Catonano <catonano <at> gmail.com>
Cc: 26863-done <at> debbugs.gnu.org
Subject: Re: bug#26863: guile-squee
Date: Sun, 18 Jun 2017 16:17:19 +0200

Catonano <catonano <at> gmail.com> writes:

> For now, I'd say that this issue can be closed.
>
> It won't be soon.

Okay, I’m closing this for now.  Thank you!

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.