GNU logs - #26909, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#26909: 25.1; A face for margins
Resent-From: Yuri Khan <yuri.v.khan@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 13 May 2017 14:08:02 +0000
Resent-Message-ID: <handler.26909.B.149468445929513 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 26909 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Yuri Khan <yuri.v.khan@HIDDEN>
Date: Sat, 13 May 2017 21:07:03 +0700
Message-ID: <CAP_d_8Xi05oZqWa-QNo-x5P5Dn=GJvUWNkPiGET+23rY0tPZtA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

$ emacs -Q

Observed behavior: *scratch* buffer with two lines of text and an empty line.


M-x linum-mode RET

(Note: Linum is only used as a demonstration example. Other modes that
enable margins are affected similarly.)

Observed behavior: A margin appears on the left of the fringe. The
margin is white, the fringe is light gray. Line numbers 1, 2, and 3
are displayed in the margin.

Desired behavior: I would like to make the margin background the same
color as the fringe, and different from the default background.


M-: (set-face-attribute 'linum nil :inherit '(shadow fringe default)) RET

Observed behavior: Line numbers 1, 2, and 3 are displayed over light
gray background. Empty space below line number 3 is displayed in
default background color.


<up> <up> DEL

Observed behavior: Lines formerly numbered 1 and 2 are joined into a
long line. It is wrapped over so there is a gap between line numbers 1
and 2. The gap is displayed in default background color.


The last two actions demonstrate that customizing the faces of
whatever is displayed in the margin is not sufficient. A mechanism is
needed that will allow customization of the margin where nothing is
displayed. A new face would serve nicely.



In GNU Emacs 25.1.1 (x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
 of 2016-12-13, modified by Debian built on lgw01-55
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description:    Ubuntu 16.04.2 LTS

Configured using:
 'configure --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.1/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.1/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --with-x=yes --with-x-toolkit=gtk3
 --with-toolkit-scroll-bars 'CFLAGS=-g -O2 -fstack-protector-strong
 -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time
 -D_FORTIFY_SOURCE=2' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro''

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LC_MONETARY: en_RU.UTF-8
  value of $LC_NUMERIC: en_RU.UTF-8
  value of $LC_TIME: en_RU.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  linum-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Back to top level
Type C-x 1 to delete the help window.
mouse-2, RET: describe this symbol

nil [2 times]
C-c C-g is undefined
Quit [2 times]
Type C-x 1 to delete the help window, C-M-v to scroll help.
C-x <down> is undefined
Mark saved where search started [2 times]
scroll-down-command: Beginning of buffer

Load-path shadows:
None found.

Features:
(shadow sort mail-extr misearch multi-isearch emacsbug message dired
format-spec rfc822 mml mml-sec password-cache epg epg-config gnus-util
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils cl-extra thingatpt help-fns help-mode easymenu cl-loaddefs
pcase cl-lib debug linum time-date mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
dbusbind inotify dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 91665 11380)
 (symbols 48 19957 0)
 (miscs 40 93 221)
 (strings 32 15138 4640)
 (string-bytes 1 432034)
 (vectors 16 12162)
 (vector-slots 8 438633 9404)
 (floats 8 169 186)
 (intervals 56 736 16)
 (buffers 976 20)
 (heap 1024 47507 1126))

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Yuri Khan <yuri.v.khan@HIDDEN>
Subject: bug#26909: Acknowledgement (25.1; A face for margins)
Message-ID: <handler.26909.B.149468445929513.ack <at> debbugs.gnu.org>
References: <CAP_d_8Xi05oZqWa-QNo-x5P5Dn=GJvUWNkPiGET+23rY0tPZtA@HIDDEN>
X-Gnu-PR-Message: ack 26909
X-Gnu-PR-Package: emacs
Reply-To: 26909 <at> debbugs.gnu.org
Date: Sat, 13 May 2017 14:08:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 26909 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
26909: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26909
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#26909: 25.1; A face for margins
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 13 May 2017 14:28:01 +0000
Resent-Message-ID: <handler.26909.B26909.149468565031302 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Yuri Khan <yuri.v.khan@HIDDEN>
Cc: 26909 <at> debbugs.gnu.org
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Date: Sat, 13 May 2017 17:27:00 +0300
Message-Id: <83lgq096iz.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <CAP_d_8Xi05oZqWa-QNo-x5P5Dn=GJvUWNkPiGET+23rY0tPZtA@HIDDEN>
 (message from Yuri Khan on Sat, 13 May 2017 21:07:03 +0700)
References: <CAP_d_8Xi05oZqWa-QNo-x5P5Dn=GJvUWNkPiGET+23rY0tPZtA@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Yuri Khan <yuri.v.khan@HIDDEN>
> Date: Sat, 13 May 2017 21:07:03 +0700
> 
> The last two actions demonstrate that customizing the faces of
> whatever is displayed in the margin is not sufficient. A mechanism is
> needed that will allow customization of the margin where nothing is
> displayed. A new face would serve nicely.

A face can only affect places where something is displayed using that
face.  Display margins only display text if the buffer specifies text
properties or overlays which display in the margins.  But what you
would like to do calls for having a face that would affect screen
space where _nothing_ is displayed, and such screen space in Emacs is
always displayed using the frame's background color, not by using some
face.

You could specify a light gray background color for the frame, and
another color for the default face, but I think this would cause
unpleasant effects elsewhere on display, e.g. in the text area beyond
EOB.

IOW, I don't think introducing a new face would help here.  Some
additional mechanism would be necessary.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#26909: 25.1; A face for margins
Resent-From: Yuri Khan <yuri.v.khan@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 13 May 2017 15:00:02 +0000
Resent-Message-ID: <handler.26909.B26909.14946875971672 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 26909 <at> debbugs.gnu.org
MIME-Version: 1.0
In-Reply-To: <83lgq096iz.fsf@HIDDEN>
References: <CAP_d_8Xi05oZqWa-QNo-x5P5Dn=GJvUWNkPiGET+23rY0tPZtA@HIDDEN>
 <83lgq096iz.fsf@HIDDEN>
From: Yuri Khan <yuri.v.khan@HIDDEN>
Date: Sat, 13 May 2017 21:59:29 +0700
Message-ID: <CAP_d_8Uk5nBHw78v5H5+TaK-d8h7QhnQkzyF+ygM9p84EJuj5Q@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Sat, May 13, 2017 at 9:27 PM, Eli Zaretskii <eliz@HIDDEN> wrote:

> A face can only affect places where something is displayed using that
> face.  Display margins only display text if the buffer specifies text
> properties or overlays which display in the margins.  But what you
> would like to do calls for having a face that would affect screen
> space where _nothing_ is displayed, and such screen space in Emacs is
> always displayed using the frame's background color, not by using some
> face.
>
> You could specify a light gray background color for the frame, and
> another color for the default face, but I think this would cause
> unpleasant effects elsewhere on display, e.g. in the text area beyond
> EOB.

That might in fact work for me. However, I do not seem to be able to do tha=
t.

(linum-mode) ^X^E
(set-frame-parameter nil 'background-color "gray95") ^X^E

* The backgrounds of both the margin and the buffer turn light gray.

(set-face-background 'default "white") ^X^E

* The backgrounds of both the buffer and the margin turn back to white.

Indeed, (elisp) Font and Color Parameters says:

| =E2=80=98background-color=E2=80=99
|      The color to use for the background of characters.  It is
|      equivalent to the =E2=80=98:background=E2=80=99 attribute of the =E2=
=80=98default=E2=80=99 face.

So the =E2=80=98default=E2=80=99 face is already special in that its :backg=
round is
used to draw the frame background. The proposed new face could be also
special that way.

(If by =E2=80=9Cbackground color for the frame=E2=80=9D you meant something=
 other than
the =E2=80=98background-color=E2=80=99 frame parameter, please point me to =
it.)

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#26909: 25.1; A face for margins
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 13 May 2017 16:41:02 +0000
Resent-Message-ID: <handler.26909.B26909.149469364817720 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26909
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Yuri Khan <yuri.v.khan@HIDDEN>
Cc: 26909 <at> debbugs.gnu.org
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 26909-submit <at> debbugs.gnu.org id=B26909.149469364817720
          (code B ref 26909); Sat, 13 May 2017 16:41:02 +0000
Received: (at 26909) by debbugs.gnu.org; 13 May 2017 16:40:48 +0000
Received: from localhost ([127.0.0.1]:43182 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1d9a64-0004bk-7n
	for submit <at> debbugs.gnu.org; Sat, 13 May 2017 12:40:48 -0400
Received: from eggs.gnu.org ([208.118.235.92]:57327)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1d9a62-0004bP-6U
 for 26909 <at> debbugs.gnu.org; Sat, 13 May 2017 12:40:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eliz@HIDDEN>) id 1d9a5t-0003yV-VB
 for 26909 <at> debbugs.gnu.org; Sat, 13 May 2017 12:40:41 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50322)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1d9a5t-0003yK-Rg; Sat, 13 May 2017 12:40:37 -0400
Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1037
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1d9a5t-00026Y-4V; Sat, 13 May 2017 12:40:37 -0400
Date: Sat, 13 May 2017 19:40:18 +0300
Message-Id: <83inl490ct.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <CAP_d_8Uk5nBHw78v5H5+TaK-d8h7QhnQkzyF+ygM9p84EJuj5Q@HIDDEN>
 (message from Yuri Khan on Sat, 13 May 2017 21:59:29 +0700)
References: <CAP_d_8Xi05oZqWa-QNo-x5P5Dn=GJvUWNkPiGET+23rY0tPZtA@HIDDEN>
 <83lgq096iz.fsf@HIDDEN>
 <CAP_d_8Uk5nBHw78v5H5+TaK-d8h7QhnQkzyF+ygM9p84EJuj5Q@HIDDEN>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

> From: Yuri Khan <yuri.v.khan@HIDDEN>
> Date: Sat, 13 May 2017 21:59:29 +0700
> Cc: 26909 <at> debbugs.gnu.org
> 
> > You could specify a light gray background color for the frame, and
> > another color for the default face, but I think this would cause
> > unpleasant effects elsewhere on display, e.g. in the text area beyond
> > EOB.
> 
> That might in fact work for me. However, I do not seem to be able to do that.
> 
> (linum-mode) ^X^E
> (set-frame-parameter nil 'background-color "gray95") ^X^E
> 
> * The backgrounds of both the margin and the buffer turn light gray.
> 
> (set-face-background 'default "white") ^X^E
> 
> * The backgrounds of both the buffer and the margin turn back to white.

Maybe I've misremembered, sorry.

Did you try remapping the default face, and if so, did that fail to
work as well?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#26909: 25.1; A face for margins
Resent-From: Yuri Khan <yuri.v.khan@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 13 May 2017 17:21:02 +0000
Resent-Message-ID: <handler.26909.B26909.149469601021247 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26909
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 26909 <at> debbugs.gnu.org
Received: via spool by 26909-submit <at> debbugs.gnu.org id=B26909.149469601021247
          (code B ref 26909); Sat, 13 May 2017 17:21:02 +0000
Received: (at 26909) by debbugs.gnu.org; 13 May 2017 17:20:10 +0000
Received: from localhost ([127.0.0.1]:43210 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1d9aiA-0005Wd-7K
	for submit <at> debbugs.gnu.org; Sat, 13 May 2017 13:20:10 -0400
Received: from mail-wr0-f179.google.com ([209.85.128.179]:34990)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <yurivkhan@HIDDEN>) id 1d9ai6-0005W3-TW
 for 26909 <at> debbugs.gnu.org; Sat, 13 May 2017 13:20:07 -0400
Received: by mail-wr0-f179.google.com with SMTP id z52so57937075wrc.2
 for <26909 <at> debbugs.gnu.org>; Sat, 13 May 2017 10:20:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc:content-transfer-encoding;
 bh=b7yoDNJy3Sdu4r2G7CAHnEhTIdd++CExWhRFGLGDxzY=;
 b=slRY71yTTnt6sH5BYy5NnKKU6SSJt5OHasLM+Y+CXk7LKRTk+uhpOAQ+Uivk4ySwkf
 ySNLunBapEg9LASwYUiTGedKzLT7HJjJ59QMsyEeWdKE0n3dq5PBBP2aAIZhWUq/y//g
 xu7jd24PzPRwIq1eWxzdPhI7s5rbUVSTLtSlmXhkzRu1/Vbq3C6i+t4lkaCf1o3IWeya
 5Ow06L6SeFrbD5NaypitFagDVVW+7zaRtLfQRnrHcEIOt2r3E7IV9cE8lblPZakvA5Vb
 1DbMB9oP0B7ajvRfCphTQCAdGGVrWjuco9f8JHO6qSM44YSzFGhe6dPj7mQkmcfYCo9F
 qcTA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
 :date:message-id:subject:to:cc:content-transfer-encoding;
 bh=b7yoDNJy3Sdu4r2G7CAHnEhTIdd++CExWhRFGLGDxzY=;
 b=iZhNBECQXZ06j1doDz2QV7O2s8sOVwd3X61UeY0si95wonEEASxEbHabg4mNMowFk8
 2r9rzCk8crrXG4aVesXXtDMxdkNNzd3VEDbr1blXZHLf9ogViFx+gBZu5/4qOkzN0WfC
 3RI9C+8w0FN+vv+CPkIIlrZeGd8U4M6Xp/6f72DJWDCvAfqTDWCxagH2F+UI5Z1IFwnc
 WOZnzViahZF1RKHOiNBcAQTxt3sUtnEjY7MPwos2SQNYE742zWUVToz+KNPCME5MJ2P6
 qXUrpw7FgGXxtVxnAR9oN4i96AI1yBu4p55GCR0kYD4DwanOKNWYAWlo5QG+JL3y9eIo
 c7HA==
X-Gm-Message-State: AODbwcAObg4nwbZGqveH3bf3nONUPnKgB9gcu4PlWkur5YgFncaH7fei
 57gdCT6VaiG5/uZsSCbCBw6kUPsx0w==
X-Received: by 10.223.160.139 with SMTP id m11mr5948768wrm.99.1494696000864;
 Sat, 13 May 2017 10:20:00 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.223.163.196 with HTTP; Sat, 13 May 2017 10:19:40 -0700 (PDT)
In-Reply-To: <83inl490ct.fsf@HIDDEN>
References: <CAP_d_8Xi05oZqWa-QNo-x5P5Dn=GJvUWNkPiGET+23rY0tPZtA@HIDDEN>
 <83lgq096iz.fsf@HIDDEN>
 <CAP_d_8Uk5nBHw78v5H5+TaK-d8h7QhnQkzyF+ygM9p84EJuj5Q@HIDDEN>
 <83inl490ct.fsf@HIDDEN>
From: Yuri Khan <yuri.v.khan@HIDDEN>
Date: Sun, 14 May 2017 00:19:40 +0700
X-Google-Sender-Auth: dOQLIyv_22KCmHsyO-2Fqzop0k0
Message-ID: <CAP_d_8UOt1VQFhgbG6FeYqU2841NtN3yEpYBp9_qOpS1+_kGTQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

On Sat, May 13, 2017 at 11:40 PM, Eli Zaretskii <eliz@HIDDEN> wrote:
>> > You could specify a light gray background color for the frame, and
>> > another color for the default face, but I think this would cause
>> > unpleasant effects elsewhere on display, e.g. in the text area beyond
>> > EOB.
>>
>> (linum-mode) ^X^E
>> (set-frame-parameter nil 'background-color "gray95") ^X^E
>> (set-face-background 'default "white") ^X^E
>>
>> * The backgrounds of both the buffer and the margin turn back to white.
>
> Maybe I've misremembered, sorry.
>
> Did you try remapping the default face, and if so, did that fail to
> work as well?

You mean, like this?

(linum-mode)
(set-frame-parameter nil 'background-color "gray95")
(face-remap-add-relative 'default :background "white")

Same as above: remapping the default face=E2=80=99s background affects the =
margin, too.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#26909: 25.1; A face for margins
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 13 May 2017 17:43:01 +0000
Resent-Message-ID: <handler.26909.B26909.149469735123215 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26909
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Yuri Khan <yuri.v.khan@HIDDEN>
Cc: 26909 <at> debbugs.gnu.org
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 26909-submit <at> debbugs.gnu.org id=B26909.149469735123215
          (code B ref 26909); Sat, 13 May 2017 17:43:01 +0000
Received: (at 26909) by debbugs.gnu.org; 13 May 2017 17:42:31 +0000
Received: from localhost ([127.0.0.1]:43221 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1d9b3n-00062M-Dw
	for submit <at> debbugs.gnu.org; Sat, 13 May 2017 13:42:31 -0400
Received: from eggs.gnu.org ([208.118.235.92]:38032)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1d9b3m-00062B-6N
 for 26909 <at> debbugs.gnu.org; Sat, 13 May 2017 13:42:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eliz@HIDDEN>) id 1d9b3e-0002jh-2S
 for 26909 <at> debbugs.gnu.org; Sat, 13 May 2017 13:42:25 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50845)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1d9b3d-0002jd-Ul; Sat, 13 May 2017 13:42:21 -0400
Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1226
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1d9b3d-0007BS-6I; Sat, 13 May 2017 13:42:21 -0400
Date: Sat, 13 May 2017 20:42:02 +0300
Message-Id: <83bmqw8xhx.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <CAP_d_8UOt1VQFhgbG6FeYqU2841NtN3yEpYBp9_qOpS1+_kGTQ@HIDDEN>
 (message from Yuri Khan on Sun, 14 May 2017 00:19:40 +0700)
References: <CAP_d_8Xi05oZqWa-QNo-x5P5Dn=GJvUWNkPiGET+23rY0tPZtA@HIDDEN>
 <83lgq096iz.fsf@HIDDEN>
 <CAP_d_8Uk5nBHw78v5H5+TaK-d8h7QhnQkzyF+ygM9p84EJuj5Q@HIDDEN>
 <83inl490ct.fsf@HIDDEN>
 <CAP_d_8UOt1VQFhgbG6FeYqU2841NtN3yEpYBp9_qOpS1+_kGTQ@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

> From: Yuri Khan <yuri.v.khan@HIDDEN>
> Date: Sun, 14 May 2017 00:19:40 +0700
> Cc: 26909 <at> debbugs.gnu.org
> 
> > Maybe I've misremembered, sorry.
> >
> > Did you try remapping the default face, and if so, did that fail to
> > work as well?
> 
> You mean, like this?
> 
> (linum-mode)
> (set-frame-parameter nil 'background-color "gray95")
> (face-remap-add-relative 'default :background "white")
> 
> Same as above: remapping the default face’s background affects the margin, too.

Sorry for my confusion.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#26909: 25.1; A face for margins
Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel <cpitclaudel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 11 May 2020 21:02:02 +0000
Resent-Message-ID: <handler.26909.B26909.158923089312327 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26909
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>, Yuri Khan <yuri.v.khan@HIDDEN>
Cc: 26909 <at> debbugs.gnu.org
Received: via spool by 26909-submit <at> debbugs.gnu.org id=B26909.158923089312327
          (code B ref 26909); Mon, 11 May 2020 21:02:02 +0000
Received: (at 26909) by debbugs.gnu.org; 11 May 2020 21:01:33 +0000
Received: from localhost ([127.0.0.1]:53464 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jYFYK-0003Ck-VA
	for submit <at> debbugs.gnu.org; Mon, 11 May 2020 17:01:33 -0400
Received: from mail-qt1-f177.google.com ([209.85.160.177]:40229)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <cpitclaudel@HIDDEN>) id 1jYFYJ-0003CV-JR
 for 26909 <at> debbugs.gnu.org; Mon, 11 May 2020 17:01:32 -0400
Received: by mail-qt1-f177.google.com with SMTP id c24so2860786qtw.7
 for <26909 <at> debbugs.gnu.org>; Mon, 11 May 2020 14:01:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language;
 bh=C/3CBi9DqnfzgYko5/FFUbf/2uovoYGDMbnSfKdgDKE=;
 b=F9AvwWwaijZuXd6Ze1xYDRezhmGaFMxeOHaWi1iEFeMkI+h6adja6WRGt+Y4vb9Jqv
 UGrkRZvLYBZ2aenjoDsf+LLRQCA4ibMlK2oK3LAd2zApPRWz8iMN3VD9f/jrpgiPqbqr
 ykY0K0mdhU9g6qMhDKi+TkxpE1X3qnCO37JC5QsHeDkc1ebrNzr/7fOm2gRf4sLhM/ER
 PzTQ8RlgbQMZ3Bzj1Rkc4FK7AcVOkaXx9qkjMPaXFVHaYI45y40bdI0e6QVZ9Hur3IB0
 6CF5TqMaxuSObu3qsIpGBYiADN83Q7KyMbWLGxa0jPCZwkSsZJOXkPJcFXjDHDNYcbng
 v54A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-language;
 bh=C/3CBi9DqnfzgYko5/FFUbf/2uovoYGDMbnSfKdgDKE=;
 b=it8Onqc1nzMW2CYbAdNsluv/l0bI2YTNwAgEMzA6L28XseWwfsZy4wQQ7s0AMZx1Sm
 FBipfjFgDqlm5Dt4x/TAprUF86PttUBCRQXkqgK+H+tt7WmwUFujisRic2OBAZLzW+P0
 Ox97Dr9YCq1XHlx90yj6Hh3kX7rC7gwDZ28U3wEEGW/0mDmOrYyU0YOnqFP0cJhegPF8
 ZwDJKU+HDzBt4gbtUM5QeYXP2fFAqLhjsfKse+xYHwbRm69dLONrixczgFty4/KtUJGI
 aPx6aAymX8hGVn01OyKnJQCrXvKm/Y9j0Zfn3lOoJwwjF+IGlrTIJdY8x7ld/bLkSie/
 JxAw==
X-Gm-Message-State: AGi0PubMmQA8imFjmkobyocBTm8JvkMeSXcB8o8f3/+vHTdKct1la9l4
 RH22CIY7coEE4vXGCzj3iZTEvk50OvI=
X-Google-Smtp-Source: APiQypIGdauCBH3OGZzLRRrH+KxPorYt3MOIYhsYE87pbjgsdtVOh5+al5EYy4HJIZfl0mkz89UyDA==
X-Received: by 2002:ac8:534b:: with SMTP id d11mr10890807qto.287.1589230885732; 
 Mon, 11 May 2020 14:01:25 -0700 (PDT)
Received: from ?IPv6:2601:184:4180:66e7:4d17:b25e:8d9:2188?
 ([2601:184:4180:66e7:4d17:b25e:8d9:2188])
 by smtp.googlemail.com with ESMTPSA id q17sm9324552qkq.111.2020.05.11.14.01.24
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 11 May 2020 14:01:24 -0700 (PDT)
References: <CAP_d_8Xi05oZqWa-QNo-x5P5Dn=GJvUWNkPiGET+23rY0tPZtA@HIDDEN>
 <83lgq096iz.fsf@HIDDEN>
From: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel <cpitclaudel@HIDDEN>
Message-ID: <f33cb5cf-1779-991b-4b1d-6852cfdd1dc5@HIDDEN>
Date: Mon, 11 May 2020 17:01:23 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <83lgq096iz.fsf@HIDDEN>
Content-Type: multipart/mixed; boundary="------------728EDCB6E572DF804AC06739"
Content-Language: en-GB
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is a multi-part message in MIME format.
--------------728EDCB6E572DF804AC06739
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

Hi Eli and Yuri,

On 13/05/2017 10.27, Eli Zaretskii wrote:>> From: Yuri Khan <yuri.v.khan@HIDDEN>
>> Date: Sat, 13 May 2017 21:07:03 +0700
>>
>> The last two actions demonstrate that customizing the faces of
>> whatever is displayed in the margin is not sufficient. A mechanism is
>> needed that will allow customization of the margin where nothing is
>> displayed. A new face would serve nicely.
> 
> A face can only affect places where something is displayed using that
> face.  Display margins only display text if the buffer specifies text
> properties or overlays which display in the margins.  But what you
> would like to do calls for having a face that would affect screen
> space where _nothing_ is displayed, and such screen space in Emacs is
> always displayed using the frame's background color, not by using some
> face.
> 
> IOW, I don't think introducing a new face would help here.  Some
> additional mechanism would be necessary.

A margin face would be great to have.  
How reasonable would it be to fill the margins with a stretched space?  Would it be too costly?
Currently we almost do that in extend_face_to_end_of_line, but short-circuits earlier in that function mean that this part is only applicable when there is e.g. a region.


  if (WINDOW_LEFT_MARGIN_WIDTH (it->w) > 0
      && it->glyph_row->used[LEFT_MARGIN_AREA] == 0)
    {
      it->glyph_row->glyphs[LEFT_MARGIN_AREA][0] = space_glyph;
      it->glyph_row->glyphs[LEFT_MARGIN_AREA][0].face_id =
        default_face->id;
      it->glyph_row->used[LEFT_MARGIN_AREA] = 1;
    }
  if (WINDOW_RIGHT_MARGIN_WIDTH (it->w) > 0
      && it->glyph_row->used[RIGHT_MARGIN_AREA] == 0)
    {
      it->glyph_row->glyphs[RIGHT_MARGIN_AREA][0] = space_glyph;
      it->glyph_row->glyphs[RIGHT_MARGIN_AREA][0].face_id =
        default_face->id;
      it->glyph_row->used[RIGHT_MARGIN_AREA] = 1;
    }

The (silly) attached patch confirms that removing the short-circuits makes it possible to set a face in the margins, but besides the performance aspect it only applies to lines that have contents.

Is this a reasonable way to go? If not, what might be better way?

Clément.

--------------728EDCB6E572DF804AC06739
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Add-a-margin-face-remove-short-circuits-in-extend_fa.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename*0="0001-Add-a-margin-face-remove-short-circuits-in-extend_fa.pa";
 filename*1="tch"

From a8a13cec225b00117557e5c84999a877843099da Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20Pit-Claudel?= <clement.pitclaudel@HIDDEN>
Date: Mon, 11 May 2020 16:52:51 -0400
Subject: [PATCH] Add a margin face, remove short-circuits in
 extend_face_to_end_of_line

---
 src/dispextern.h |  1 +
 src/xdisp.c      | 10 ++++++----
 src/xfaces.c     |  3 +++
 3 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/src/dispextern.h b/src/dispextern.h
index 0b1f3d14ae..2650d49e02 100644
--- a/src/dispextern.h
+++ b/src/dispextern.h
@@ -1814,6 +1814,7 @@ #define FACE_UNIBYTE_P(FACE) ((FACE)->charset < 0)
   MODE_LINE_INACTIVE_FACE_ID,
   TOOL_BAR_FACE_ID,
   FRINGE_FACE_ID,
+  MARGIN_FACE_ID,
   HEADER_LINE_FACE_ID,
   SCROLL_BAR_FACE_ID,
   BORDER_FACE_ID,
diff --git a/src/xdisp.c b/src/xdisp.c
index 140d134572..5a7bf58828 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -21759,7 +21759,8 @@ extend_face_to_end_of_line (struct it *it)
       /* If the window has display margins, we will need to extend
 	 their face even if the text area is filled.  */
       && !(WINDOW_LEFT_MARGIN_WIDTH (it->w) > 0
-	   || WINDOW_RIGHT_MARGIN_WIDTH (it->w) > 0))
+	   || WINDOW_RIGHT_MARGIN_WIDTH (it->w) > 0)
+      && false)
     return;
 
   const int extend_face_id = (it->face_id == DEFAULT_FACE_ID
@@ -21785,7 +21786,8 @@ extend_face_to_end_of_line (struct it *it)
       && !face->stipple
 #endif
       && !it->glyph_row->reversed_p
-      && !Vdisplay_fill_column_indicator)
+      && !Vdisplay_fill_column_indicator
+      && false)
     return;
 
   /* Set the glyph row flag indicating that the face of the last glyph
@@ -21834,7 +21836,7 @@ extend_face_to_end_of_line (struct it *it)
 	    {
 	      it->glyph_row->glyphs[LEFT_MARGIN_AREA][0] = space_glyph;
 	      it->glyph_row->glyphs[LEFT_MARGIN_AREA][0].face_id =
-		default_face->id;
+		lookup_named_face (it->w, f, Qmargin, false);
 	      it->glyph_row->used[LEFT_MARGIN_AREA] = 1;
 	    }
 	  if (WINDOW_RIGHT_MARGIN_WIDTH (it->w) > 0
@@ -21842,7 +21844,7 @@ extend_face_to_end_of_line (struct it *it)
 	    {
 	      it->glyph_row->glyphs[RIGHT_MARGIN_AREA][0] = space_glyph;
 	      it->glyph_row->glyphs[RIGHT_MARGIN_AREA][0].face_id =
-		default_face->id;
+		lookup_named_face (it->w, f, Qmargin, false);
 	      it->glyph_row->used[RIGHT_MARGIN_AREA] = 1;
 	    }
 
diff --git a/src/xfaces.c b/src/xfaces.c
index bab142ade0..f604c43928 100644
--- a/src/xfaces.c
+++ b/src/xfaces.c
@@ -4768,6 +4768,7 @@ lookup_basic_face (struct window *w, struct frame *f, int face_id)
     case TAB_BAR_FACE_ID:		name = Qtab_bar;		break;
     case TOOL_BAR_FACE_ID:		name = Qtool_bar;		break;
     case FRINGE_FACE_ID:		name = Qfringe;			break;
+    case MARGIN_FACE_ID:		name = Qmargin;			break;
     case SCROLL_BAR_FACE_ID:		name = Qscroll_bar;		break;
     case BORDER_FACE_ID:		name = Qborder;			break;
     case CURSOR_FACE_ID:		name = Qcursor;			break;
@@ -5463,6 +5464,7 @@ realize_basic_faces (struct frame *f)
       realize_named_face (f, Qmode_line_inactive, MODE_LINE_INACTIVE_FACE_ID);
       realize_named_face (f, Qtool_bar, TOOL_BAR_FACE_ID);
       realize_named_face (f, Qfringe, FRINGE_FACE_ID);
+      realize_named_face (f, Qmargin, MARGIN_FACE_ID);
       realize_named_face (f, Qheader_line, HEADER_LINE_FACE_ID);
       realize_named_face (f, Qscroll_bar, SCROLL_BAR_FACE_ID);
       realize_named_face (f, Qborder, BORDER_FACE_ID);
@@ -6808,6 +6810,7 @@ syms_of_xfaces (void)
   DEFSYM (Qtool_bar, "tool-bar");
   DEFSYM (Qtab_bar, "tab-bar");
   DEFSYM (Qfringe, "fringe");
+  DEFSYM (Qmargin, "margin");
   DEFSYM (Qtab_line, "tab-line");
   DEFSYM (Qheader_line, "header-line");
   DEFSYM (Qscroll_bar, "scroll-bar");
-- 
2.17.1


--------------728EDCB6E572DF804AC06739--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#26909: 25.1; A face for margins
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 12 May 2020 16:53:01 +0000
Resent-Message-ID: <handler.26909.B26909.158930237928427 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26909
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel <cpitclaudel@HIDDEN>
Cc: 26909 <at> debbugs.gnu.org, yuri.v.khan@HIDDEN
Received: via spool by 26909-submit <at> debbugs.gnu.org id=B26909.158930237928427
          (code B ref 26909); Tue, 12 May 2020 16:53:01 +0000
Received: (at 26909) by debbugs.gnu.org; 12 May 2020 16:52:59 +0000
Received: from localhost ([127.0.0.1]:56404 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jYY9L-0007OR-Cg
	for submit <at> debbugs.gnu.org; Tue, 12 May 2020 12:52:59 -0400
Received: from eggs.gnu.org ([209.51.188.92]:49646)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1jYY9J-0007OB-CR
 for 26909 <at> debbugs.gnu.org; Tue, 12 May 2020 12:52:57 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45138)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@HIDDEN>)
 id 1jYY9D-0001ic-Ma; Tue, 12 May 2020 12:52:51 -0400
Received: from [176.228.60.248] (port=2909 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1jYY9D-00052w-31; Tue, 12 May 2020 12:52:51 -0400
Date: Tue, 12 May 2020 19:52:29 +0300
Message-Id: <83ftc5859u.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <f33cb5cf-1779-991b-4b1d-6852cfdd1dc5@HIDDEN> (message from
 =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel on Mon, 11 May 2020 17:01:23 -0400)
References: <CAP_d_8Xi05oZqWa-QNo-x5P5Dn=GJvUWNkPiGET+23rY0tPZtA@HIDDEN>
 <83lgq096iz.fsf@HIDDEN> <f33cb5cf-1779-991b-4b1d-6852cfdd1dc5@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 26909 <at> debbugs.gnu.org
> From: Clément Pit-Claudel <cpitclaudel@HIDDEN>
> Date: Mon, 11 May 2020 17:01:23 -0400
> 
> A margin face would be great to have.  
> How reasonable would it be to fill the margins with a stretched space?  Would it be too costly?

It would slow down redisplay, especially if the window is large, but
maybe the slow-down will not be so awful.

> The (silly) attached patch confirms that removing the short-circuits makes it possible to set a face in the margins, but besides the performance aspect it only applies to lines that have contents.
> 
> Is this a reasonable way to go?

Something like that, yes.  But you will need to make sure
extend_face_to_end_of_line is called also for empty lines.  And of
course the "silly" changes need to be made less silly.  And you need
to compute the pixel-width of the stretch glyph, since the code you
cited only places a single SPC character there, which is not what you
want if the margin is wider than one column.

> --- a/src/xfaces.c
> +++ b/src/xfaces.c
> @@ -4768,6 +4768,7 @@ lookup_basic_face (struct window *w, struct frame *f, int face_id)
>      case TAB_BAR_FACE_ID:		name = Qtab_bar;		break;
>      case TOOL_BAR_FACE_ID:		name = Qtool_bar;		break;
>      case FRINGE_FACE_ID:		name = Qfringe;			break;
> +    case MARGIN_FACE_ID:		name = Qmargin;			break;

If this is going to be an additional basic face, then why do you call
lookup_named_face  and not lookup_basic_face?

Also, this face should have a defface definition in faces.el.  (And
NEWS, and update for the manuals...)

Thanks.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#26909: 25.1; A face for margins
Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel <cpitclaudel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 12 May 2020 17:07:02 +0000
Resent-Message-ID: <handler.26909.B26909.158930317029846 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26909
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 26909 <at> debbugs.gnu.org, yuri.v.khan@HIDDEN
Received: via spool by 26909-submit <at> debbugs.gnu.org id=B26909.158930317029846
          (code B ref 26909); Tue, 12 May 2020 17:07:02 +0000
Received: (at 26909) by debbugs.gnu.org; 12 May 2020 17:06:10 +0000
Received: from localhost ([127.0.0.1]:56417 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1jYYM6-0007lJ-Ga
	for submit <at> debbugs.gnu.org; Tue, 12 May 2020 13:06:10 -0400
Received: from mail-qk1-f172.google.com ([209.85.222.172]:35401)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <cpitclaudel@HIDDEN>) id 1jYYM3-0007kl-6a
 for 26909 <at> debbugs.gnu.org; Tue, 12 May 2020 13:06:08 -0400
Received: by mail-qk1-f172.google.com with SMTP id f13so13781820qkh.2
 for <26909 <at> debbugs.gnu.org>; Tue, 12 May 2020 10:06:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=pd2CJUDlKoB9Np2LW6Yh77Dv84WtHsnmkoHB0FbrB54=;
 b=ewleW5liEs48iB1jQzN5NsNV6U2/aJXViTYFg0qyOEHp6Dzh87jGD1weFln8jDvBlk
 qViZUhQ1yaXNj34VkzwA6nceRCdvIXYbCGxRtBIbxugTlwXOLUkFcglqb+nlQLFsKs1w
 1Pbx4Zn51yr5vuwla/iFRtXGKildYErzHyJpkunaYCnvUecZTXAQ4wFE0+Cwkcl5YDPz
 O+D6fhnnGS38XcynPyleBtmVI/zKwv9Q+9F97Si63S/s03OcShtKMrghl7dYNkT090QJ
 QUlrKSL5GRm34+xJRk3gvEMtUE2psUMTx1C87Q1MfimJ844lNjaVqyQJ0TNbQv1EHUrn
 uRjg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=pd2CJUDlKoB9Np2LW6Yh77Dv84WtHsnmkoHB0FbrB54=;
 b=YDvPxzU2IEHDS6+5NklL0EvtCZIrW8uEYhP2EGprVRQGliCf90p4XzdldL6p6PKhGK
 oH/7fPxWU8iL1hdir0Cv4Jry1YRbKhaIVY1Xz6tXEp9wAuQA493HtQ4yfMGQhBEuuGcn
 ziT5y/cDOxObLU++gp71OXoEAvPHEMPCkDDYBANfjZ32ySYRTgIhuK8yyeFACc3PmguD
 2xk/PYN/ZAXOg6dxVGvmLte9opOcfqLS4YSSjeOsXmoXKAyDuHGohGVwDYgT+Ho2UTgd
 Fjg60/ZiTCX70jT0LLaTFE4JAdeS2BqPTPXYZMa3XOHMCXV5S2/rLOi2bgWMtHfSGw4g
 ZLKQ==
X-Gm-Message-State: AGi0PubMDxCbMZ7r72CXyVEsTeUdykvJCbaAoYIwVvwHfdS1e6sqtS5V
 wxdWpc04l/qLQGKxu1zLbRtOeUigp3M=
X-Google-Smtp-Source: APiQypL2Y69dZT0181Onzh/aD3+1For6thwUImV58/5RkxWVG9x3SIto+ftdcHKGvAqdG1LY1y167w==
X-Received: by 2002:ae9:ed95:: with SMTP id
 c143mr17502066qkg.394.1589303161341; 
 Tue, 12 May 2020 10:06:01 -0700 (PDT)
Received: from ?IPv6:2601:184:4180:66e7:4d17:b25e:8d9:2188?
 ([2601:184:4180:66e7:4d17:b25e:8d9:2188])
 by smtp.googlemail.com with ESMTPSA id w43sm4271287qtw.68.2020.05.12.10.06.00
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 12 May 2020 10:06:00 -0700 (PDT)
References: <CAP_d_8Xi05oZqWa-QNo-x5P5Dn=GJvUWNkPiGET+23rY0tPZtA@HIDDEN>
 <83lgq096iz.fsf@HIDDEN> <f33cb5cf-1779-991b-4b1d-6852cfdd1dc5@HIDDEN>
 <83ftc5859u.fsf@HIDDEN>
From: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel <cpitclaudel@HIDDEN>
Message-ID: <c8ebffec-c174-b0fa-1b13-07dbe5f83c91@HIDDEN>
Date: Tue, 12 May 2020 13:06:00 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <83ftc5859u.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 12/05/2020 12.52, Eli Zaretskii wrote:
>> Cc: 26909 <at> debbugs.gnu.org
>> From: Clément Pit-Claudel <cpitclaudel@HIDDEN>
>> Date: Mon, 11 May 2020 17:01:23 -0400
>>
>> A margin face would be great to have.  
>> How reasonable would it be to fill the margins with a stretched space?  Would it be too costly?
> 
> It would slow down redisplay, especially if the window is large, but
> maybe the slow-down will not be so awful.

Got it.

> Something like that, yes.  But you will need to make sure
> extend_face_to_end_of_line is called also for empty lines.  And of
> course the "silly" changes need to be made less silly. 

Where the less silly strategy would be to only run the extend_face code when the margins face isn't customized, right?

> And you need
> to compute the pixel-width of the stretch glyph, since the code you
> cited only places a single SPC character there, which is not what you
> want if the margin is wider than one column.

Hmm, I think the code already does that? At least it seems to work with the patch I sent.

>> --- a/src/xfaces.c
>> +++ b/src/xfaces.c
>> @@ -4768,6 +4768,7 @@ lookup_basic_face (struct window *w, struct frame *f, int face_id)
>>      case TAB_BAR_FACE_ID:		name = Qtab_bar;		break;
>>      case TOOL_BAR_FACE_ID:		name = Qtool_bar;		break;
>>      case FRINGE_FACE_ID:		name = Qfringe;			break;
>> +    case MARGIN_FACE_ID:		name = Qmargin;			break;
> 
> If this is going to be an additional basic face, then why do you call
> lookup_named_face  and not lookup_basic_face?

It's because I have no idea what a basic face is, so I just cribbed from places that use the fringe face.  It does things like the following, and I have no idea what those mean:

      face_id = NILP (face) ? lookup_named_face (w, f, Qfringe, false)
	: lookup_derived_face (w, f, face, FRINGE_FACE_ID, 0);
      if (face_id < 0)
	face_id = FRINGE_FACE_ID;

Last modified: Tue, 12 May 2020 17:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.