GNU logs - #26958, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#26958: Can we make wavy underlines scale like straight ones?
Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 May 2017 03:49:02 +0000
Resent-Message-ID: <handler.26958.B.149499289411652 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 26958 <at> debbugs.gnu.org
From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>
Message-ID: <2751b56b-c419-8ad9-c588-11186a86fb9e@HIDDEN>
Date: Tue, 16 May 2017 23:47:48 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="t92oTSxqWn1Kkw1q5visDIquDuj0hIoXX"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--t92oTSxqWn1Kkw1q5visDIquDuj0hIoXX
Content-Type: multipart/mixed; boundary="7dHgNWqk04NpNNNWuJhVv7RlOF08mGu8P";
 protected-headers="v1"
From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= <clement.pitclaudel@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Message-ID: <2751b56b-c419-8ad9-c588-11186a86fb9e@HIDDEN>
Subject: Can we make wavy underlines scale like straight ones?

--7dHgNWqk04NpNNNWuJhVv7RlOF08mGu8P
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi bug-gnu-emacs,

Straight underlines get thicker when font size increases, but wavy underl=
ines do not.  The problem is particularly visible on hi-resolution displa=
ys, where wavy underlines look really tiny. This problem can be observed =
on all displays by running the following and pressing C-x C-=3D a few tim=
es:

(font-lock-mode -1)
(insert (propertize "AAAAA" 'face '(:underline (:style line)))
        "\n" (propertize "AAAAA" 'face '(:underline (:style wave))))

I've seen the problem mentioned a few times online (https://emacs.stackex=
change.com/questions/24713/change-size-of-wavy-underlines-for-hidpi-displ=
ays, https://www.reddit.com/r/emacs/comments/51wm7d/emacs_on_hidpi_displa=
ys/).

For xterm.c, the relevant function seems to be x_draw_underwave.

Thanks!
Cl=C3=A9ment.


--7dHgNWqk04NpNNNWuJhVv7RlOF08mGu8P--

--t92oTSxqWn1Kkw1q5visDIquDuj0hIoXX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJZG8fpAAoJEPqg+cTm90wjba4P/0cdmefVXb4/HRrulJQDtRWV
OCMlTmJsR7xe39EH20CQ0BKM92hWNIckqfdI7y7Lg08k0fHdRZWUMqGDJeNUERfK
rxa8+9VLCYhsmPX1TSucpoWpcUnxe9dCQZpC25kP1BTz2ouROzhLQGqsX7p7+rl3
UsUeTPGg2tD4ahOaTiaGKTEDbmw8PBuFs6PFMEKCYte6a6bxT4toPdnkN9WEVtlQ
/aBw8W3GT1Y6V84TZC7hQP/tXknzoqq9tGZH3BEeMMlh1l3EpA2tdlJrIpmtxai/
my3zibJtUQ5rXmjiG0dbjtQNTESJ/HBpEW2aKaILBQ+0YF7/QawO/jn1FthSW5+N
aziAsdjVEfcfWsp+wQrLPJTzS9YidSmBW2mpiekyLO6rW4EiUeCVxzfNhOo3z4Td
lEALHptObdPY8ZaN0AEuFD5dgBgKM8+K2phCJmi5Kgt51kSwzzUpRxcZR0Gb7ZIJ
I1dY5X5z1zXOTi1cAzfii2gUXS/h0fjWMf4WWM/pBfYOFUlPAa5GNkVsLBZhCyNi
A9jdLi+ps9/AAppaWfcvCSNBNlIU+hjLOvAJLxYFOzFriHdF+fBT4+ZfTaABTQ+k
z3aWvh28dwKVGYknXyGwHkAHreSwsjMhEFuIq8Xc43LCZgHQST9bELz/+BHsOF9f
AFbFznB3Y1gkFtnVNqwx
=OgGw
-----END PGP SIGNATURE-----

--t92oTSxqWn1Kkw1q5visDIquDuj0hIoXX--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>
Subject: bug#26958: Acknowledgement (Can we make wavy underlines scale
 like straight ones?)
Message-ID: <handler.26958.B.149499289411652.ack <at> debbugs.gnu.org>
References: <2751b56b-c419-8ad9-c588-11186a86fb9e@HIDDEN>
X-Gnu-PR-Message: ack 26958
X-Gnu-PR-Package: emacs
Reply-To: 26958 <at> debbugs.gnu.org
Date: Wed, 17 May 2017 03:49:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 26958 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
26958: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26958
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#26958: Can we make wavy underlines scale like straight ones?
Resent-From: Drew Adams <drew.adams@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 May 2017 04:15:02 +0000
Resent-Message-ID: <handler.26958.B26958.149499447514036 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>, 26958 <at> debbugs.gnu.org
MIME-Version: 1.0
Message-ID: <0f5ba7d0-ab89-448c-969f-cdfc6bd0ef50@default>
Date: Tue, 16 May 2017 21:14:24 -0700 (PDT)
From: Drew Adams <drew.adams@HIDDEN>
References: <2751b56b-c419-8ad9-c588-11186a86fb9e@HIDDEN>
In-Reply-To: <2751b56b-c419-8ad9-c588-11186a86fb9e@HIDDEN>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Straight underlines get thicker when font size increases, but wavy
> underlines do not.  The problem is particularly visible on hi-resolution
> displays, where wavy underlines look really tiny. This problem can be
> observed on all displays by running the following and pressing C-x C-=3D =
a few
> times:
>=20
> (font-lock-mode -1)
> (insert (propertize "AAAAA" 'face '(:underline (:style line)))
>         "\n" (propertize "AAAAA" 'face '(:underline (:style wave))))

FWIW, on Windows I see neither straight nor wavy underline thicken.
They both continue to have the same line width (thickness) when
text-scaled.

Should they not stay the same?  Should they thicken?  Why?

I'm not on a "highdpi", I imagine.  But why should that make
difference as to whether an underline should change thickness
as the text is scaled?

What about :overline?  It has no :wavy property, but should
it too thicken when the text is scaled up?

And :box?  :box has a :line-width property.  Is that relevant
here?  What should the behavior be for :box?  What should it
be for attributes such as :underline or :overline or
:strike-through, which don't have a :line-width property?

It doesn't seem as if the right design is obvious.

Note that the first URL you cite does not ask necessarily for
the wavy underline to scale.  It explicitly asks about
customizing to specify the line width.

Maybe that's what the enhancement request should be: provide
:line-width for :underline, like we do for :box.  And perhaps
for :overline and :strike-through?

The first question is whether such line widths should respond
to scaling.  Dunno.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#26958: Can we make wavy underlines scale like straight ones?
Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 May 2017 04:38:02 +0000
Resent-Message-ID: <handler.26958.B26958.149499582916163 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Drew Adams <drew.adams@HIDDEN>, 26958 <at> debbugs.gnu.org
References: <2751b56b-c419-8ad9-c588-11186a86fb9e@HIDDEN>
 <0f5ba7d0-ab89-448c-969f-cdfc6bd0ef50@default>
From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>
Message-ID: <a043deca-ed80-2338-bc69-c58b3a6327f2@HIDDEN>
Date: Wed, 17 May 2017 00:36:47 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <0f5ba7d0-ab89-448c-969f-cdfc6bd0ef50@default>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="ArQ0nrLCtB9uc27J9R3mQA4l5TGu1Vrw5"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--ArQ0nrLCtB9uc27J9R3mQA4l5TGu1Vrw5
Content-Type: multipart/mixed; boundary="cFVetV8bgJ27awjR508i9GOVR3geOskLQ";
 protected-headers="v1"
From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= <clement.pitclaudel@HIDDEN>
To: Drew Adams <drew.adams@HIDDEN>, 26958 <at> debbugs.gnu.org
Message-ID: <a043deca-ed80-2338-bc69-c58b3a6327f2@HIDDEN>
Subject: Re: bug#26958: Can we make wavy underlines scale like straight ones?
References: <2751b56b-c419-8ad9-c588-11186a86fb9e@HIDDEN>
 <0f5ba7d0-ab89-448c-969f-cdfc6bd0ef50@default>
In-Reply-To: <0f5ba7d0-ab89-448c-969f-cdfc6bd0ef50@default>

--cFVetV8bgJ27awjR508i9GOVR3geOskLQ
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 2017-05-17 00:14, Drew Adams wrote:
>> Straight underlines get thicker when font size increases, but wavy
>> underlines do not.  The problem is particularly visible on hi-resoluti=
on
>> displays, where wavy underlines look really tiny. This problem can be
>> observed on all displays by running the following and pressing C-x C-=3D=
 a few
>> times:
>>
>> (font-lock-mode -1)
>> (insert (propertize "AAAAA" 'face '(:underline (:style line)))
>>         "\n" (propertize "AAAAA" 'face '(:underline (:style wave))))
>=20
> FWIW, on Windows I see neither straight nor wavy underline thicken.
> They both continue to have the same line width (thickness) when
> text-scaled.
>=20
> Should they not stay the same?  Should they thicken?  Why?

Thanks for the reply! They do scale in GNU/Linux; the code in xftfont say=
s:

      font->underline_position =3D -ft_face->underline_position * size / =
upEM;
      font->underline_thickness =3D ft_face->underline_thickness * size /=
 upEM;

The corresponding code in w32font says:

      font->underline_thickness =3D metrics->otmsUnderscoreSize;
      font->underline_position =3D -metrics->otmsUnderscorePosition;

which might be missing the scaling?

> I'm not on a "highdpi", I imagine.  But why should that make
> difference as to whether an underline should change thickness
> as the text is scaled?

That's the behavior I see on every other program that (I checked and that=
) supports underlines on my machine: Thunderbird (which also scales wavy =
underlines used to indicate spelling errors), Firefox, Chromium, and Libr=
e Office Writer (which used to not scale spell-checking underlines, thoug=
h this is partly fixed =E2=80=94 see bug 90793).

> What about :overline?  It has no :wavy property, but should
> it too thicken when the text is scaled up?
>=20
> And :box?  :box has a :line-width property.  Is that relevant
> here?  What should the behavior be for :box?  What should it
> be for attributes such as :underline or :overline or
> :strike-through, which don't have a :line-width property?
>=20
> It doesn't seem as if the right design is obvious.

Judging by what web browsers do, they should all scale.

> Note that the first URL you cite does not ask necessarily for
> the wavy underline to scale.  It explicitly asks about
> customizing to specify the line width.
>=20
> Maybe that's what the enhancement request should be: provide
> :line-width for :underline, like we do for :box.  And perhaps
> for :overline and :strike-through?

I made a separate request for (a limited version of) this.

> The first question is whether such line widths should respond
> to scaling.  Dunno.

I expect they should, based on looking at web browsers (and plenty of oth=
er programs =E2=80=94 including Emacs ^^ =C2=AD=E2=80=94 in the case of u=
nderlines).  But it's not only a thickness issue: it's also a positioning=
 issue (the relative space between the text and the underline should be c=
onstant).

Cl=C3=A9ment.


--cFVetV8bgJ27awjR508i9GOVR3geOskLQ--

--ArQ0nrLCtB9uc27J9R3mQA4l5TGu1Vrw5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJZG9NfAAoJEPqg+cTm90wjD/QP/0NJeJR+8xKGTyzgYkZWBi1J
ZRk2BWmovF2+FZiZteKPLw/7qvpCroZsDmxJFxlUllAaoEPXnc249906X7qzHyPM
wOuOswyYwegYxCYHAQtU6t1CtqXseNNj/Mp25QfvqpFWdbqyoXGR4LF8g1ErIw1F
7V3881E+nHjRPQ/Z5CV3C9pbIEbgQSou1YSOWoP+oKNP4hR+w2wfXo1UYdYJYsCG
goiD+adaeJsAre+goBr2y8IoG0Dw/GzZhzQwQ5CJvENwdoZ9pn6e8n0tDIOJNGHz
73LTi6/9cKuxwSVDjKAiaOLKyqkwQxjPTraCF+VKr33phSD2eLkztBEiMXxvRZeQ
miq6+rcCiAbeLbZWQvkrx2v5ClQTRvaIUUT/2SZFUBfZeboEmVFYLhYNHqbxgraT
oa3b35LcqdmzNKI1skN2/6s+VDYpSPbx5rUThunAQUVl4b7hakCVvJDk1ezBriit
gDoEFm/tlxJ6q3+HaGNBNpUcYI9UqxdH3Y7dG1cJF5A8cvHVfErD2H2IlepepNEO
58a5e68NPn8m5Ke1G9HxjH62t98QIUrchEdcvle01Cq3ZcHRC3LoEt7+4gu3p6fs
5H8QMUA0DsQTqHGKgnlBss1aBDe565suqOmxPRxg6xPeP2+iYYxjtwwmEzvoWNeI
5uc3++2RuS/uqjD5MFN2
=O2uR
-----END PGP SIGNATURE-----

--ArQ0nrLCtB9uc27J9R3mQA4l5TGu1Vrw5--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#26958: Can we make wavy underlines scale like straight ones?
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 May 2017 15:24:02 +0000
Resent-Message-ID: <handler.26958.B26958.149503461631132 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26958
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>
Cc: 26958 <at> debbugs.gnu.org
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 26958-submit <at> debbugs.gnu.org id=B26958.149503461631132
          (code B ref 26958); Wed, 17 May 2017 15:24:02 +0000
Received: (at 26958) by debbugs.gnu.org; 17 May 2017 15:23:36 +0000
Received: from localhost ([127.0.0.1]:51062 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1dB0nX-000863-Ub
	for submit <at> debbugs.gnu.org; Wed, 17 May 2017 11:23:36 -0400
Received: from eggs.gnu.org ([208.118.235.92]:42175)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1dB0nW-00085r-Jt
 for 26958 <at> debbugs.gnu.org; Wed, 17 May 2017 11:23:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eliz@HIDDEN>) id 1dB0nO-0008WN-0i
 for 26958 <at> debbugs.gnu.org; Wed, 17 May 2017 11:23:29 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60545)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1dB0nN-0008WI-Te; Wed, 17 May 2017 11:23:25 -0400
Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3840
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1dB0nN-0001dn-7q; Wed, 17 May 2017 11:23:25 -0400
Date: Wed, 17 May 2017 18:23:16 +0300
Message-Id: <83inkz5wyj.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <2751b56b-c419-8ad9-c588-11186a86fb9e@HIDDEN> (message from
 =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel on Tue, 16 May 2017 23:47:48 -0400)
References: <2751b56b-c419-8ad9-c588-11186a86fb9e@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

> From: Clément Pit--Claudel <clement.pitclaudel@HIDDEN>
> Date: Tue, 16 May 2017 23:47:48 -0400
> 
> Straight underlines get thicker when font size increases

That's not really accurate, see my other messages.

> but wavy underlines do not.  The problem is particularly visible on hi-resolution displays, where wavy underlines look really tiny. This problem can be observed on all displays by running the following and pressing C-x C-= a few times:
> 
> (font-lock-mode -1)
> (insert (propertize "AAAAA" 'face '(:underline (:style line)))
>         "\n" (propertize "AAAAA" 'face '(:underline (:style wave))))
> 
> I've seen the problem mentioned a few times online (https://emacs.stackexchange.com/questions/24713/change-size-of-wavy-underlines-for-hidpi-displays, https://www.reddit.com/r/emacs/comments/51wm7d/emacs_on_hidpi_displays/).
> 
> For xterm.c, the relevant function seems to be x_draw_underwave.

How about sending a patch?

But I suggest to read about the related complications first, because I
think this issue is not as simple as it sounds.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#26958: Can we make wavy underlines scale like straight ones?
Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 May 2017 19:40:02 +0000
Resent-Message-ID: <handler.26958.B26958.149504994821852 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26958
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 26958 <at> debbugs.gnu.org
Received: via spool by 26958-submit <at> debbugs.gnu.org id=B26958.149504994821852
          (code B ref 26958); Wed, 17 May 2017 19:40:02 +0000
Received: (at 26958) by debbugs.gnu.org; 17 May 2017 19:39:08 +0000
Received: from localhost ([127.0.0.1]:51329 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1dB4mq-0005gO-0B
	for submit <at> debbugs.gnu.org; Wed, 17 May 2017 15:39:08 -0400
Received: from mout.kundenserver.de ([217.72.192.74]:52722)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <clement.pitclaudel@HIDDEN>) id 1dB4mo-0005fu-76
 for 26958 <at> debbugs.gnu.org; Wed, 17 May 2017 15:39:07 -0400
Received: from [18.189.18.195] ([18.189.18.195]) by mrelayeu.kundenserver.de
 (mreue103 [212.227.15.184]) with ESMTPSA (Nemesis) id
 0MPrBi-1d7F1l0oU6-0054li; Wed, 17 May 2017 21:38:59 +0200
References: <2751b56b-c419-8ad9-c588-11186a86fb9e@HIDDEN>
 <83inkz5wyj.fsf@HIDDEN>
From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>
Message-ID: <91ab653c-1677-0eef-b038-f79c58378c1c@HIDDEN>
Date: Wed, 17 May 2017 15:38:32 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <83inkz5wyj.fsf@HIDDEN>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="qAhUSeCqfrPd9lA32aXJjpOuchDXc4v0l"
X-Provags-ID: V03:K0:UhPiqVY0FGzkeBiqCG//NwbdkRvj01F+N62CtJ2ZgSFjmPJUt27
 ey0b4W14uSf2vUEsMpAA1g0+DITpktCSEEROXP+9Dy2VB2iQtgoCYxI99pE2YPaal6KDs8k
 3bLXLr+CqEfSirzR2FCKtcEL21lVEmk32nTgt89tta/XR8DmG5Y9cgsBc5KqxUj9EqjFaiM
 YGtpaeAwx2MNh6Wolgw5w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:EeSLqEVGiKU=:TlK3OgbM38ge1IxPwjhFLS
 v7O5h1HP3VJvjcxkQYl0admV9gxxUfYYKwRFhkpGyIY2EQXnxW+ZaB92M33ojmAxGI2pq7ZhJ
 s7+P0dWbq2lZoQDHsAZu8BRE2UVoyagL69gKSXZuTJrXynjwN/AKJZD53DCTYwW9EBGmmXQjq
 vUh2xYF7Tpl5RFGZNiDWJev6gFEvI75Uis3ca8H5tGJ7carazf6Nor6vPzqOUF7z6+R3igpwu
 tETB2e2VdtjHEBSB4G0mJ2G325B0/n+0MnENKij/yodiWx1lDTMydNGR9aLNY/YW519ScdfsG
 S408ZKDqyqvnRcUhIf2AvblZfcNg5ppe1Z3NVFtSrTYvWyJsBgfSGuAHKvubihzcf4pLcmQp1
 F/l/No+IotE+YbL34JRPn5nbZyeJG1xrgt0hoyWWLGVzyqZgzejlic2jAXephZFf+vnm/iT4R
 0V6axSW0HAjSvr5eGRc7Hap45L6z/SqKUA2SRyeLwCNAHOWwfI/CVCXZwiCFiwUgCLdOZS9sE
 fCUG1P7S00/Lb3WOazk0SIO9YDgGO2Bn9ZEGlM9gQtPWwuG2IDnpyfQzU5TDJ8Hj6jqce9CW+
 ob23RXrwNb0KGpapJcYLdGyT06Qj6h5jWP1Eqf2VyK4lPhhsyyA22MC3zvOlU5bYaYQiHOIuv
 rDbA3V9uoXLeP+nvlnxUl5glGpfXZVnvoALXyDywmGPYNh9p9HYCuYGZ+P4dsJvxAeqM=
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.3 (-)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--qAhUSeCqfrPd9lA32aXJjpOuchDXc4v0l
Content-Type: multipart/mixed; boundary="tXSIQOOLa5u6jMkcReMsnwwVQ5TCsH4Bv";
 protected-headers="v1"
From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= <clement.pitclaudel@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 26958 <at> debbugs.gnu.org
Message-ID: <91ab653c-1677-0eef-b038-f79c58378c1c@HIDDEN>
Subject: Re: bug#26958: Can we make wavy underlines scale like straight ones?
References: <2751b56b-c419-8ad9-c588-11186a86fb9e@HIDDEN>
 <83inkz5wyj.fsf@HIDDEN>
In-Reply-To: <83inkz5wyj.fsf@HIDDEN>

--tXSIQOOLa5u6jMkcReMsnwwVQ5TCsH4Bv
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: quoted-printable

On 2017-05-17 11:23, Eli Zaretskii wrote:
>> For xterm.c, the relevant function seems to be x_draw_underwave.
> How about sending a patch?

I had a quick look. The current code uses a loop and draws line segments =
between each of the underline points.
This strategy doesn't look as pretty when using a thicker line.  Would it=
 be OK to use XDrawLines instead?

Cl=C3=A9ment.


--tXSIQOOLa5u6jMkcReMsnwwVQ5TCsH4Bv--

--qAhUSeCqfrPd9lA32aXJjpOuchDXc4v0l
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJZHKa4AAoJEPqg+cTm90wjX3YQAJFMCVAUHzMCv5QcwJNuZwZn
a2llQ/y9i/6RrY8voSkEWOJr8VcTA27u9JLMoqsxbE6SVlG86v8AUAcyMRfQZG3Y
3DHlFRFWOKBIWeXr5ICt7CsNmSs2zTgVkcb2GnKK/qGYc03VM+MLSoxD4hDdwHh6
D9zgpNJtuAfYMROA9T131qbUh/f9gMFxs0up54vTCLy1S+xEVDQmzyF81pLIpzhV
Kgjv0wWPJKwGDscdKDLNUM1SnDAS7MLCWH6yacb2Q/salczDi7hN8Adcq+frLeJB
30/YcWzpqs7goukG957xibZBKO1VayY7RIgm6gYmc3f6VdIgwrewX1X71JEN8eii
Ni6ADqfkfCclR3RNkZENRfAQ9iiztCdbryXCzAduFwP8zLl7/igdRm9B+Qh68oc+
P0BAafNQeoVHNWpCIQpld4nGRmtUzdrkwDNbH4aCV4hho3kuI6x3saFnzlplDVSI
dRfvMxqpG2eZfauAuVRQHMpwU1Yagq26IsJXqrvXqMU+l6Wmoe88u+uc8DaYm8zP
EEYrc349Uk96WJ3UXOgFhhus0cC/fhxplxmfqnSzKZk2BUOQjUCFZ8t5dMaH8QNH
VUEYmNmOZvy1louk3v//tZoel7TJN/CIP9LlAUooIQah0Zfc75nhi4YHPI3iU47H
1M3SM5XYYXNUivWFuvqa
=CPs/
-----END PGP SIGNATURE-----

--qAhUSeCqfrPd9lA32aXJjpOuchDXc4v0l--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#26958: Can we make wavy underlines scale like straight ones?
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 19 May 2017 07:19:02 +0000
Resent-Message-ID: <handler.26958.B26958.149517832624599 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 26958
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel <clement.pitclaudel@HIDDEN>
Cc: 26958 <at> debbugs.gnu.org
Reply-To: Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 26958-submit <at> debbugs.gnu.org id=B26958.149517832624599
          (code B ref 26958); Fri, 19 May 2017 07:19:02 +0000
Received: (at 26958) by debbugs.gnu.org; 19 May 2017 07:18:46 +0000
Received: from localhost ([127.0.0.1]:54300 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1dBcBS-0006Og-0a
	for submit <at> debbugs.gnu.org; Fri, 19 May 2017 03:18:46 -0400
Received: from eggs.gnu.org ([208.118.235.92]:53603)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1dBcBQ-0006OU-FO
 for 26958 <at> debbugs.gnu.org; Fri, 19 May 2017 03:18:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eliz@HIDDEN>) id 1dBcBI-0007ac-9m
 for 26958 <at> debbugs.gnu.org; Fri, 19 May 2017 03:18:39 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39344)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@HIDDEN>)
 id 1dBcBI-0007aY-6O; Fri, 19 May 2017 03:18:36 -0400
Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3267
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@HIDDEN>)
 id 1dBcBH-000120-Do; Fri, 19 May 2017 03:18:35 -0400
Date: Fri, 19 May 2017 10:18:30 +0300
Message-Id: <8360gx48mx.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-reply-to: <91ab653c-1677-0eef-b038-f79c58378c1c@HIDDEN> (message from
 =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel on Wed, 17 May 2017 15:38:32 -0400)
References: <2751b56b-c419-8ad9-c588-11186a86fb9e@HIDDEN>
 <83inkz5wyj.fsf@HIDDEN> <91ab653c-1677-0eef-b038-f79c58378c1c@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

> Cc: 26958 <at> debbugs.gnu.org
> From: Clément Pit--Claudel <clement.pitclaudel@HIDDEN>
> Date: Wed, 17 May 2017 15:38:32 -0400
> 
> On 2017-05-17 11:23, Eli Zaretskii wrote:
> >> For xterm.c, the relevant function seems to be x_draw_underwave.
> > How about sending a patch?
> 
> I had a quick look. The current code uses a loop and draws line segments between each of the underline points.
> This strategy doesn't look as pretty when using a thicker line.  Would it be OK to use XDrawLines instead?

I don't think I understand your proposal, and I'm not an expert on X
graphics anyway.  How about presenting a patch that works for you?

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.