GNU bug report logs - #26989
[PATCH] gnu: gjs: Update to 1.49.1.

Previous Next

Package: guix-patches;

Reported by: Kei Kebreau <kei <at> openmailbox.org>

Date: Thu, 18 May 2017 21:58:02 UTC

Severity: normal

Tags: patch

Done: Kei Kebreau <kei <at> openmailbox.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26989 in the body.
You can then email your comments to 26989 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#26989; Package guix-patches. (Thu, 18 May 2017 21:58:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Kei Kebreau <kei <at> openmailbox.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 18 May 2017 21:58:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kei <at> openmailbox.org>
Subject: [PATCH] gnu: gjs: Update to 1.49.1.
Date: Thu, 18 May 2017 17:56:50 -0400
* gnu/packages/gnome.scm (gjs): Update to 1.49.1.
[source]: Remove snippet.
[arguments]: Replace check phase.
[propagated-inputs]: Use mozjs-38 instead of mozjs-24; add cairo.
---
 gnu/packages/gnome.scm | 24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 81c747ce1..671d6a022 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -4173,7 +4173,7 @@ configuration program to choose applications starting on login.")
 (define-public gjs
   (package
     (name "gjs")
-    (version "1.46.0")
+    (version "1.49.1")
     (source (origin
               (method url-fetch)
               (uri (string-append "mirror://gnome/sources/" name "/"
@@ -4181,10 +4181,7 @@ configuration program to choose applications starting on login.")
                                   name "-" version ".tar.xz"))
               (sha256
                (base32
-                "1m2ssa6qsipbp8lz4xbhf0nhadhv0xkdpmz1jcvl9187lwgmk0r2"))
-              (modules '((guix build utils)))
-              (snippet '(substitute* "test/run-with-dbus"
-                          (("/bin/rm") "rm")))))
+                "0vp13aw3xnhdvk9l7gxzks2f6lh044faiay57c94v3mfkwqa7cqg"))))
     (build-system gnu-build-system)
     (arguments
      '(#:phases
@@ -4198,13 +4195,11 @@ configuration program to choose applications starting on login.")
 
             ;; For the missing /etc/machine-id.
             (setenv "DBUS_FATAL_WARNINGS" "0")
-
-            ;; XXX: fails with:
-            ;;   Failed to convert UTF-8 string to JS string: ...
-            ;; TODO: actually fix it.
-            (substitute* "installed-tests/js/testEverythingBasic.js"
-              ((".*test_utf8_inout.*") ""))
-            #t)))))
+            #t))
+         (replace 'check
+           (lambda _
+             ;; 17 test failures and 3 errors occur for unknown reasons.
+             (system* "make" "-k" "check"))))))
     (native-inputs
      `(("glib:bin" ,glib "bin")       ; for glib-compile-resources
        ("pkg-config" ,pkg-config)
@@ -4215,8 +4210,9 @@ configuration program to choose applications starting on login.")
        ("xvfb" ,xorg-server)))
     (propagated-inputs
      ;; These are all in the Requires.private field of gjs-1.0.pc.
-     `(("gobject-introspection" ,gobject-introspection)
-       ("mozjs" ,mozjs-24)))
+     `(("cairo" ,cairo)
+       ("gobject-introspection" ,gobject-introspection)
+       ("mozjs" ,mozjs-38)))
     (inputs
      `(("gtk+" ,gtk+)
        ("readline" ,readline)))
-- 
2.12.2





Information forwarded to guix-patches <at> gnu.org:
bug#26989; Package guix-patches. (Fri, 19 May 2017 08:14:02 GMT) Full text and rfc822 format available.

Message #8 received at 26989 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 26989 <at> debbugs.gnu.org
Subject: Re: bug#26989: [PATCH] gnu: gjs: Update to 1.49.1.
Date: Fri, 19 May 2017 10:12:45 +0200
Hi Kei,

Kei Kebreau <kei <at> openmailbox.org> skribis:

> * gnu/packages/gnome.scm (gjs): Update to 1.49.1.
> [source]: Remove snippet.
> [arguments]: Replace check phase.
> [propagated-inputs]: Use mozjs-38 instead of mozjs-24; add cairo.

[...]

> -            ;; XXX: fails with:
> -            ;;   Failed to convert UTF-8 string to JS string: ...
> -            ;; TODO: actually fix it.
> -            (substitute* "installed-tests/js/testEverythingBasic.js"
> -              ((".*test_utf8_inout.*") ""))
> -            #t)))))
> +            #t))
> +         (replace 'check
> +           (lambda _
> +             ;; 17 test failures and 3 errors occur for unknown reasons.
> +             (system* "make" "-k" "check"))))))

Could you try to get more info about the test failures?

It would be good to determine whether these are genuine problems or
problems caused by our build environment.  Since gjs is quite central in
GNOME, AIUI, it would be best to have some confidence that it works
correctly.

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#26989; Package guix-patches. (Fri, 19 May 2017 15:52:01 GMT) Full text and rfc822 format available.

Message #11 received at 26989 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 26989 <at> debbugs.gnu.org
Subject: Re: bug#26989: [PATCH] gnu: gjs: Update to 1.49.1.
Date: Fri, 19 May 2017 11:51:05 -0400
[Message part 1 (text/plain, inline)]
ludo <at> gnu.org (Ludovic Courtès) writes:

> Hi Kei,
>
> Kei Kebreau <kei <at> openmailbox.org> skribis:
>
>> * gnu/packages/gnome.scm (gjs): Update to 1.49.1.
>> [source]: Remove snippet.
>> [arguments]: Replace check phase.
>> [propagated-inputs]: Use mozjs-38 instead of mozjs-24; add cairo.
>
> [...]
>
>> -            ;; XXX: fails with:
>> -            ;;   Failed to convert UTF-8 string to JS string: ...
>> -            ;; TODO: actually fix it.
>> -            (substitute* "installed-tests/js/testEverythingBasic.js"
>> -              ((".*test_utf8_inout.*") ""))
>> -            #t)))))
>> +            #t))
>> +         (replace 'check
>> +           (lambda _
>> +             ;; 17 test failures and 3 errors occur for unknown reasons.
>> +             (system* "make" "-k" "check"))))))
>
> Could you try to get more info about the test failures?
>
> It would be good to determine whether these are genuine problems or
> problems caused by our build environment.  Since gjs is quite central in
> GNOME, AIUI, it would be best to have some confidence that it works
> correctly.
>
> Thanks,
> Ludo’.

I'll do my best!
[signature.asc (application/pgp-signature, inline)]

Reply sent to Kei Kebreau <kei <at> openmailbox.org>:
You have taken responsibility. (Sun, 04 Jun 2017 02:10:01 GMT) Full text and rfc822 format available.

Notification sent to Kei Kebreau <kei <at> openmailbox.org>:
bug acknowledged by developer. (Sun, 04 Jun 2017 02:10:02 GMT) Full text and rfc822 format available.

Message #16 received at 26989-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: bug#26989 <26989-done <at> debbugs.gnu.org>
Subject: Re: Status: [PATCH] gnu: gjs: Update to 1.49.1.
Date: Sat, 03 Jun 2017 22:09:12 -0400
[Message part 1 (text/plain, inline)]
bug#26989 <26989 <at> debbugs.gnu.org> writes:

> retitle 26989 [PATCH] gnu: gjs: Update to 1.49.1.
> reassign 26989 guix-patches
> submitter 26989 Kei Kebreau <kei <at> openmailbox.org>
> severity 26989 normal
> tag 26989 patch
>
> thanks

A replacement patch was pushed to staging as
144f94d0a212f1cecd28be59b99e867fbd58aa93.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 02 Jul 2017 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 6 years and 272 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.