GNU bug report logs - #27002
[PATCH] gnu: Add lollypop.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27002 in the body.
You can then email your comments to 27002 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: rennes <rennes <at> openmailbox.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add lollypop.
Date: Fri, 19 May 2017 23:18:05 -0500

[Message part 1 (text/plain, inline)]

Hello,
Lollypop is a modern and intuitive music player.
Lint and tested.

[0001-gnu-Add-lollypop.patch (text/x-patch, attachment)]

Message #8 received at 27002 <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: rennes <rennes <at> openmailbox.org>
Cc: 27002 <at> debbugs.gnu.org
Subject: Re: bug#27002: [PATCH] gnu: Add lollypop.
Date: Fri, 16 Jun 2017 14:08:37 +0200

rennes <rennes <at> openmailbox.org> writes:

> Hello,
> Lollypop is a modern and intuitive music player.
> Lint and tested.

Hi,

looks good to me, though the recent update of the gmime package (commit
a512ca81e) breaks the totem-pl-parser package, so lollypop doesn't build
on current guix master.

I tested it on the commit before the gmime update (f54efbdc4), and was
able to build it, but the program would not run.  Something about a
gstreamer issue, though I have the gst-plugins-xyz packages in my
profile.

(lollypop:16613): GStreamer-CRITICAL **: gst_bin_add: assertion 'GST_IS_ELEMENT (element)' failed

(lollypop:16613): GStreamer-CRITICAL **: gst_element_get_static_pad: assertion 'GST_IS_ELEMENT (element)' failed

(lollypop:16613): GStreamer-CRITICAL **: gst_object_unref: assertion 'object != NULL' failed
Replay Gain not available,

Is there anything I should do to make this work, or are there extra
variables that should be set when wrapping the executable?

I also noticed that the executable gets wrapped twice: bin/lollypop
wraps bin/.lollypop-real, which wraps bin/..lollypop-real-real :-) Can
this be avoided, or is it a side-effect of using the python build system
and wrapping the result?

Thomas

Message #11 received at 27002 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Thomas Danckaert <post <at> thomasdanckaert.be>
Cc: rennes <rennes <at> openmailbox.org>, 27002 <at> debbugs.gnu.org
Subject: Re: [bug#27002] [PATCH] gnu: Add lollypop.
Date: Fri, 16 Jun 2017 14:59:39 +0200

Thomas Danckaert <post <at> thomasdanckaert.be> skribis:

> I also noticed that the executable gets wrapped twice: bin/lollypop
> wraps bin/.lollypop-real, which wraps bin/..lollypop-real-real :-) Can
> this be avoided, or is it a side-effect of using the python build system
> and wrapping the result?

The ‘wrap-program’ procedure in (guix build utils) arranges things so as
to never create double wrappers, so it would be interesting to see how
this happened!

Ludo’.

Message #14 received at 27002 <at> debbugs.gnu.org (full text, mbox):

From: rennes <rennes <at> openmailbox.org>
To: Thomas Danckaert <post <at> thomasdanckaert.be>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 27002 <at> debbugs.gnu.org
Subject: Re: [bug#27002] [PATCH] gnu: Add lollypop.
Date: Sat, 17 Jun 2017 22:21:28 -0500

Hello,
thank you for your comments.

I had not noticed that in my profile I have installed  
'gst-plugins-base'. I try to add 'gst-plugins-base' to Inputs but it  
does not work, I will continue to test.

On the other hand, under the 'bin' directory I only see one binary for  
lollipop:

jin <at> home ~$ l  
/gnu/store/0psmp896kkijsszczmvbs0b9h7wfprdb-lollypop-0.9.240/bin/
total 12
-r-xr-xr-x 2 root root 2743 Dec 31  1969 lollypop
-r-xr-xr-x 2 root root 1523 Dec 31  1969 lollypop-cli
-r-xr-xr-x 2 root root 1529 Dec 31  1969 rhythmbox2lollypop


On 06/16/2017 07:59:39 AM, Ludovic Courtès wrote:
> Thomas Danckaert <post <at> thomasdanckaert.be> skribis:
> 
> > I also noticed that the executable gets wrapped twice: bin/lollypop
> > wraps bin/.lollypop-real, which wraps bin/..lollypop-real-real :-)  
> Can
> > this be avoided, or is it a side-effect of using the python build  
> system
> > and wrapping the result?
> 
> The ‘wrap-program’ procedure in (guix build utils) arranges things so  
> as
> to never create double wrappers, so it would be interesting to see how
> this happened!

Message #17 received at 27002 <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: rennes <at> openmailbox.org
Cc: ludo <at> gnu.org, 27002 <at> debbugs.gnu.org
Subject: Re: [bug#27002] [PATCH] gnu: Add lollypop.
Date: Mon, 19 Jun 2017 10:52:01 +0200 (CEST)

From: rennes <rennes <at> openmailbox.org>
Subject: Re: [bug#27002] [PATCH] gnu: Add lollypop.
Date: Sat, 17 Jun 2017 22:21:28 -0500

> I had not noticed that in my profile I have installed
> 'gst-plugins-base'. I try to add 'gst-plugins-base' to Inputs but it
> does not work, I will continue to test.

I also have gst-plugins-base in my profile.  I don't know why it 
doesn't work :)  I assume lollypop works for you?

> On the other hand, under the 'bin' directory I only see one binary 
> for
> lollipop:

Try "ll -a" to show the “hidden” files.

thanks,

Thomas

Message #20 received at 27002 <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: ludo <at> gnu.org
Cc: rennes <at> openmailbox.org, 27002 <at> debbugs.gnu.org
Subject: Re: [bug#27002] [PATCH] gnu: Add lollypop.
Date: Mon, 19 Jun 2017 15:28:14 +0200 (CEST)

From: ludo <at> gnu.org (Ludovic Courtès)
Subject: Re: [bug#27002] [PATCH] gnu: Add lollypop.
Date: Fri, 16 Jun 2017 14:59:39 +0200

> The ‘wrap-program’ procedure in (guix build utils) arranges things 
> so as
> to never create double wrappers, so it would be interesting to see 
> how
> this happened!

I think it happens as follows: the lollypop package uses three 
wrapping phases:

 - the GI_TYPELIB_PATH wrapping defined in the package description

 - 'wrap' from the python build system

 - 'glib-or-gtk-wrap'

It looks like wrapping methods from different build systems do not 
compose well: both the glib and python wrapping code contain a loop 
over all executables, so they wrap the executables “.xyz-real” from 
previous wrappings, too.  (the wrap-program procedure only checks if 
“.xyz-real” exists, when wrapping “xyz”, but it does not check if 
“xyz” itself is already a wrapper.  One solution (but probably for 
core-updates) might be to exclude wrapper files from the list of 
executables in the python and glib build systems?

Thomas

Message #23 received at 27002 <at> debbugs.gnu.org (full text, mbox):

From: rennes <rennes <at> openmailbox.org>
To: Thomas Danckaert <post <at> thomasdanckaert.be>
Cc: ludo <at> gnu.org, 27002 <at> debbugs.gnu.org
Subject: Re: [bug#27002] [PATCH] gnu: Add lollypop.
Date: Sat, 24 Jun 2017 13:06:53 -0500

[Message part 1 (text/plain, inline)]

Hello,
> 
> I also have gst-plugins-base in my profile.  I don't know why it  
> doesn't work :)  I assume lollypop works for you?
> 
I have added libraries to 'propagated-inputs', in 'inputs' does not  
work.
Now I don't have libraries in my profile. Can you test?

[0001-gnu-Add-lollypop.patch (text/x-patch, attachment)]

Message #26 received at 27002 <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: rennes <at> openmailbox.org
Cc: 27002 <at> debbugs.gnu.org
Subject: Re: [bug#27002] [PATCH] gnu: Add lollypop.
Date: Mon, 26 Jun 2017 10:39:39 +0200 (CEST)

From: rennes <rennes <at> openmailbox.org>
Subject: Re: [bug#27002] [PATCH] gnu: Add lollypop.
Date: Sat, 24 Jun 2017 13:06:53 -0500

>>I also have gst-plugins-base in my profile.  I don't know why it
>>doesn't work :) I assume lollypop works for you?
>>
> I have added libraries to 'propagated-inputs', in 'inputs' does not
> work.
> Now I don't have libraries in my profile. Can you test?

I don't think that was the problem, because I have all the 
gst-plugins-xyz libraries installed, too.  The patch didn't change 
the result.  Perhaps someone else can check and possibly apply this 
patch (perhaps the patch is fine and it's a problem on my system :-/ )

Thomas

For future reference, I'll copy the output I get when I try to run 
'lollypop'.  It looks like something goes wrong with the (py-)gobject 
for gstreamer:

/gnu/store/6jwmm9f665xmkkhhj1x5b904kzn00y82-python-pygobject-3.24.1/lib/python3.5/site-packages/gi/module.py:178: 
Warning: g_array_append_vals: assertion 'array' failed
  g_type = info.get_g_type()
/gnu/store/6jwmm9f665xmkkhhj1x5b904kzn00y82-python-pygobject-3.24.1/lib/python3.5/site-packages/gi/module.py:178: 
Warning: g_hash_table_lookup: assertion 'hash_table != NULL' failed
  g_type = info.get_g_type()
/gnu/store/6jwmm9f665xmkkhhj1x5b904kzn00y82-python-pygobject-3.24.1/lib/python3.5/site-packages/gi/module.py:178: 
Warning: g_hash_table_insert_internal: assertion 'hash_table != NULL' 
failed
  g_type = info.get_g_type()
You need to add a music uri to org.gnome.Lollypop in dconf
/gnu/store/9xik31h3z5vi0kbcg8av5c2h9wqckjs5-python-gst-1.12.0/lib/python3.5/site-packages/gi/overrides/Gst.py:217: 
Warning: g_object_set: assertion 'G_IS_OBJECT (object)' failed
  return Gst.ElementFactory.make(factory_name, instance_name)

(lollypop:29867): GStreamer-CRITICAL **: gst_bin_add: assertion 
'GST_IS_ELEMENT (element)' failed

(lollypop:29867): GStreamer-CRITICAL **: gst_element_get_static_pad: 
assertion 'GST_IS_ELEMENT (element)' failed

(lollypop:29867): GStreamer-CRITICAL **: gst_object_unref: assertion 
'object != NULL' failed
Replay Gain not available,
please check your gstreamer installation...

(lollypop:29867): GStreamer-CRITICAL **: gst_bin_add: assertion 
'GST_IS_ELEMENT (element)' failed

(lollypop:29867): GStreamer-CRITICAL **: gst_element_get_static_pad: 
assertion 'GST_IS_ELEMENT (element)' failed

(lollypop:29867): GStreamer-CRITICAL **: gst_object_unref: assertion 
'object != NULL' failed
Replay Gain not available,
please check your gstreamer installation...
Traceback (most recent call last):
  File 
"/gnu/store/3g6x62m095k19imzygh4jf50hn0h31fp-lollypop-0.9.240/lib/python3.5/site-packages/lollypop/application.py", 
line 210, in do_startup
    self.init()
  File 
"/gnu/store/3g6x62m095k19imzygh4jf50hn0h31fp-lollypop-0.9.240/lib/python3.5/site-packages/lollypop/application.py", 
line 169, in init
    self.player = Player()
  File 
"/gnu/store/3g6x62m095k19imzygh4jf50hn0h31fp-lollypop-0.9.240/lib/python3.5/site-packages/lollypop/player.py", 
line 40, in __init__
    BinPlayer.__init__(self)
  File 
"/gnu/store/3g6x62m095k19imzygh4jf50hn0h31fp-lollypop-0.9.240/lib/python3.5/site-packages/lollypop/player_bin.py", 
line 46, in __init__
    self._playbin.connect("notify::volume", self.__on_volume_changed)
AttributeError: 'NoneType' object has no attribute 'connect'

Message #31 received at 27002-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Thomas Danckaert <post <at> thomasdanckaert.be>
Cc: rennes <at> openmailbox.org, 27002-done <at> debbugs.gnu.org
Subject: Re: [bug#27002] [PATCH] gnu: Add lollypop.
Date: Tue, 11 Jul 2017 11:11:03 +0200

Hi,

Thomas Danckaert <post <at> thomasdanckaert.be> skribis:

> I don't think that was the problem, because I have all the
> gst-plugins-xyz libraries installed, too.  The patch didn't change the
> result.  Perhaps someone else can check and possibly apply this patch
> (perhaps the patch is fine and it's a problem on my system :-/ )

I went ahead and applied this patch since it had been sitting here for a
while already.  I moved it to gnome.scm, which seems more appropriate
than mpd.scm (it’s not an MPD client AIUI).

Apparently it requires a full GNOME desktop to run so I couldn’t test
it.  If you notice something’s wrong, we can always fix it.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.