GNU bug report logs - #27024
25.2: gud.el: wrong menu :visible for pdb

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27024 in the body.
You can then email your comments to 27024 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Charles A. Roelli" <charles <at> aurox.ch>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.2: gud.el: wrong menu :visible for pdb
Date: Mon, 22 May 2017 20:33:26 +0200

The "stop" entry in `gud-menu-map' (line 158):

    ([stop]	menu-item "Stop" gud-stop-subjob
		  :visible (or (not (memq gud-minor-mode '(gdbmi pdb)))
			       (gdb-show-stop-p)))

has a :visible entry that calls `gdb-show-stop-p' if `gud-minor-mode' is 
either
`gdbmi' or `pdb'.  This function is only related to gdb and isn't loaded 
by running
just pdb, so it can cause an error during redisplay (but interestingly,
it doesn't seem to happen all the time while running pdb -- or maybe the 
error is
caught somehow).

Does anyone understand why this check for pdb is here?  It seems to be a 
mistake,
but it has been there for more than 7 years...

Otherwise, could someone please remove the check for pdb?  Thanks.

Message #10 received at 27024-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Charles A. Roelli" <charles <at> aurox.ch>
Cc: 27024-done <at> debbugs.gnu.org
Subject: Re: bug#27024: 25.2: gud.el: wrong menu :visible for pdb
Date: Sat, 27 May 2017 15:17:00 +0300

> From: "Charles A. Roelli" <charles <at> aurox.ch>
> Date: Mon, 22 May 2017 20:33:26 +0200
> 
> The "stop" entry in `gud-menu-map' (line 158):
> 
>      ([stop]	menu-item "Stop" gud-stop-subjob
> 		  :visible (or (not (memq gud-minor-mode '(gdbmi pdb)))
> 			       (gdb-show-stop-p)))
> 
> has a :visible entry that calls `gdb-show-stop-p' if `gud-minor-mode' is 
> either
> `gdbmi' or `pdb'.  This function is only related to gdb and isn't loaded 
> by running
> just pdb, so it can cause an error during redisplay (but interestingly,
> it doesn't seem to happen all the time while running pdb -- or maybe the 
> error is
> caught somehow).
> 
> Does anyone understand why this check for pdb is here?  It seems to be a 
> mistake,
> but it has been there for more than 7 years...
> 
> Otherwise, could someone please remove the check for pdb?  Thanks.

Thanks, I've modified the test to not call gdb-show-stop-p in pdb
mode.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.