GNU bug report logs - #27043
[PATCH] gnu: Add python-asn1crypto.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27043 in the body.
You can then email your comments to 27043 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add python-asn1crypto.
Date: Tue, 23 May 2017 15:42:27 -0400

* gnu/packages/crypto.scm (python-asn1crypto, python2-asn1crypto): New variables.
---
 gnu/packages/crypto.scm | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index 856308afe..86cd777ef 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -51,7 +51,8 @@
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix build-system cmake)
-  #:use-module (guix build-system gnu))
+  #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python))
 
 (define-public libsodium
   (package
@@ -414,3 +415,27 @@ utility as a demonstration of the @code{scrypt} key derivation function.
 @code{Scrypt} is designed to be far more resistant against hardware brute-force
 attacks than alternative functions such as @code{PBKDF2} or @code{bcrypt}.")
     (license license:bsd-2)))
+
+(define-public python-asn1crypto
+  (package
+    (name "python-asn1crypto")
+    (version "0.22.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "asn1crypto" version))
+        (sha256
+         (base32
+          "06pd1bglyisjnjkgc5dc24b498q9r8fmvwkfn0janr9i1mjdvfnb"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:tests? #f)) ; Tests are not distributed via PyPi.
+    (home-page "https://github.com/wbond/asn1crypto")
+    (synopsis "ASN.1 parser and serializer in Python")
+    (description "Fast ASN.1 parser and serializer with definitions for private
+keys, public keys, certificates, CRL, OCSP, CMS, PKCS#3, PKCS#7, PKCS#8,
+PKCS#12, PKCS#5, X.509 and TSP.")
+    (license license:expat)))
+
+(define-public python2-asn1crypto
+  (package-with-python2 python-asn1crypto))
-- 
2.13.0

Message #8 received at 27043 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 27043 <at> debbugs.gnu.org
Subject: Re: bug#27043: [PATCH] gnu: Add python-asn1crypto.
Date: Wed, 24 May 2017 13:24:41 +0530

Thanks for the patch! :-)

Leo Famulari writes:

> * gnu/packages/crypto.scm (python-asn1crypto, python2-asn1crypto): New variables.

I think we should put this package in gnu/packages/python.scm. Packages
like python-cryptography are in python.scm.

> +(define-public python-asn1crypto
> +  (package
> +    (name "python-asn1crypto")
> +    (version "0.22.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "asn1crypto" version))

Release tarballs are availabe on the project's github page. Why not use
those?

> +    (arguments
> +     '(#:tests? #f)) ; Tests are not distributed via PyPi.

The github release tarballs have tests. Could you package them?

> +    (home-page "https://github.com/wbond/asn1crypto")
> +    (synopsis "ASN.1 parser and serializer in Python")
> +    (description "Fast ASN.1 parser and serializer with definitions for private
> +keys, public keys, certificates, CRL, OCSP, CMS, PKCS#3, PKCS#7, PKCS#8,
> +PKCS#12, PKCS#5, X.509 and TSP.")

The description should be in full sentences.

Message #11 received at 27043 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>, Leo Famulari <leo <at> famulari.name>
Cc: 27043 <at> debbugs.gnu.org
Subject: Re: bug#27043: [PATCH] gnu: Add python-asn1crypto.
Date: Wed, 24 May 2017 18:13:58 +0200

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> Leo Famulari writes:
>
>> * gnu/packages/crypto.scm (python-asn1crypto, python2-asn1crypto): New variables.
>
> I think we should put this package in gnu/packages/python.scm. Packages
> like python-cryptography are in python.scm.

I think crypto.scm is fine. "python.scm" is already rather bloated, so
it's good to add new libraries in topic-specific modules.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 27043-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 27043-done <at> debbugs.gnu.org
Subject: Re: bug#27043: [PATCH] gnu: Add python-asn1crypto.
Date: Thu, 25 May 2017 15:44:29 -0400

[Message part 1 (text/plain, inline)]

On Wed, May 24, 2017 at 01:24:41PM +0530, Arun Isaac wrote:
> Leo Famulari writes:
> > * gnu/packages/crypto.scm (python-asn1crypto, python2-asn1crypto): New variables.
> 
> I think we should put this package in gnu/packages/python.scm. Packages
> like python-cryptography are in python.scm.

There are performance issues with Guile 2.2, and the huge (gnu packages
python) module is really a pathological case [0]. So, if a new package
makes sense in other modules, I'll be adding them in those other
modules, at least until the compiler performance is improved.

https://lists.gnu.org/archive/html/guile-devel/2017-05/msg00033.html

> > +        (uri (pypi-uri "asn1crypto" version))
> 
> Release tarballs are availabe on the project's github page. Why not use
> those?
> 
> > +    (arguments
> > +     '(#:tests? #f)) ; Tests are not distributed via PyPi.
> 
> The github release tarballs have tests. Could you package them?

Aha! Good catch.

> 
> > +    (description "Fast ASN.1 parser and serializer with definitions for private
> > +keys, public keys, certificates, CRL, OCSP, CMS, PKCS#3, PKCS#7, PKCS#8,
> > +PKCS#12, PKCS#5, X.509 and TSP.")
> 
> The description should be in full sentences.

Indeed, fixed!

Thanks for the review!

Pushed as 10e65d5e5adde4e17bae47f0b59b36df264ded39

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.