GNU logs - #27130, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#27130: c-mode indentation mistreats structs in function arguments
Resent-From: Sam Pagenkopf <ssaammp@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 29 May 2017 16:01:02 +0000
Resent-Message-ID: <handler.27130.B.149607361013756 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 27130 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Sam Pagenkopf <ssaammp@HIDDEN>
Date: Mon, 29 May 2017 08:33:35 -0500
Message-ID: <CAKiGDcO6hedSbWEP=VLq5U-7PunPewX_2JD_qm_Hs6W4NJH6+A@HIDDEN>
Content-Type: multipart/alternative; boundary="001a113c2366eede520550a9bbc5"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--001a113c2366eede520550a9bbc5
Content-Type: text/plain; charset="UTF-8"

In emacs 25.2.1.

Relevant code:

    draw_add(&battle.draw, (Drawn){
            .kind = DRAW_RECT,
                .size = {40,24},
                .pos.border = {
                .align = {ALIGN_LEFT, ALIGN_TOP},
                .dist = 3
            }
        }
        );

My guess is that it's reading (Drawn){...} as a statement, and the , as
the (,) C operator.

--001a113c2366eede520550a9bbc5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: base64

PGRpdiBkaXI9Imx0ciI+SW4gZW1hY3MgMjUuMi4xLjxicj48ZGl2Pjxicj5SZWxldmFudCBjb2Rl
Ojxicj48ZGl2Pjxicj7CoMKgwqAgZHJhd19hZGQoJmFtcDtiYXR0bGUuZHJhdywgKERyYXduKXs8
YnI+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAua2luZCA9IERSQVdfUkVDVCw8YnI+wqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgIC5zaXplID0gezQwLDI0fSw8YnI+wqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgIC5wb3MuYm9yZGVyID0gezxicj7CoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgLmFsaWduID0ge0FMSUdOX0xFRlQsIEFMSUdOX1RPUH0sPGJyPsKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoCAuZGlzdCA9IDM8YnI+wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9
PGJyPsKgwqDCoMKgwqDCoMKgIH08YnI+wqDCoMKgwqDCoMKgwqAgKTs8YnI+PGJyPk15IGd1ZXNz
IGlzIHRoYXQgaXQmIzM5O3MgcmVhZGluZyAoRHJhd24pey4uLn0gYXMgYSBzdGF0ZW1lbnQsIGFu
ZCB0aGUgLCBhczxicj50aGUgKCwpIEMgb3BlcmF0b3IuPC9kaXY+PC9kaXY+PC9kaXY+DQo=
--001a113c2366eede520550a9bbc5--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Sam Pagenkopf <ssaammp@HIDDEN>
Subject: bug#27130: Acknowledgement (c-mode indentation mistreats structs
 in function arguments)
Message-ID: <handler.27130.B.149607361013756.ack <at> debbugs.gnu.org>
References: <CAKiGDcO6hedSbWEP=VLq5U-7PunPewX_2JD_qm_Hs6W4NJH6+A@HIDDEN>
X-Gnu-PR-Message: ack 27130
X-Gnu-PR-Package: emacs
Reply-To: 27130 <at> debbugs.gnu.org
Date: Mon, 29 May 2017 16:01:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 27130 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
27130: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D27130
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN:

Subject: bug#27130: c-mode indentation mistreats structs in function arguments
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN
Resent-Date: Mon, 30 Nov 2020 11:13:02 +0000
Resent-Message-ID: <handler.27130.B27130.16067347282269 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Sam Pagenkopf <ssaammp@HIDDEN>
Cc: 27130 <at> debbugs.gnu.org, Alan Mackenzie <acm@HIDDEN>
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <CAKiGDcO6hedSbWEP=VLq5U-7PunPewX_2JD_qm_Hs6W4NJH6+A@HIDDEN>
Date: Mon, 30 Nov 2020 12:11:56 +0100
In-Reply-To: <CAKiGDcO6hedSbWEP=VLq5U-7PunPewX_2JD_qm_Hs6W4NJH6+A@HIDDEN>
 (Sam Pagenkopf's message of "Mon, 29 May 2017 08:33:35 -0500")
Message-ID: <87zh2zaykj.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Sam Pagenkopf <ssaammp@HIDDEN> writes:

> In emacs 25.2.1.
>
> Relevant code:
>
>     draw_add(&battle.draw, (Drawn){
>             .kind = DRAW_RECT,
>                 .size = {40,24},
>                 .pos.border = {
>                 .align = {ALIGN_LEFT, ALIGN_TOP},
>                 .dist = 3
>             }
>         }
>         );
>
> My guess is that it's reading (Drawn){...} as a statement, and the , as
> the (,) C operator.

I'm not sure how this should be indented (as I didn't even know that
that was valid C).  But that does look wrong, in any case.  (I've
confirmed that it indents it the same way in Emacs 28.)

Alan?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 30 Nov 2020 11:12:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 30 06:12:12 2020
Received: from localhost ([127.0.0.1]:53721 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kjh6K-0000an-9j
	for submit <at> debbugs.gnu.org; Mon, 30 Nov 2020 06:12:12 -0500
Received: from quimby.gnus.org ([95.216.78.240]:34842)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1kjh6I-0000aM-Q8
 for control <at> debbugs.gnu.org; Mon, 30 Nov 2020 06:12:11 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc:
 MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=Olh8SfGQYdvTJ1L4ulTsmEV8CX0tG9mQ2n5I853Uo1w=; b=ZpqgwET5QG0qohjepimSuJhwm+
 6OMjxt/jn6EziUiz9bDp3zCISeOUYeRkuk4dwB+OlQqLorfICMSbs9KF0XNFIaIxtkxgyZxIt9nAB
 9oVE94tMpwsxHJ20eLmsUJEY7em3D4S5HunBSnr2ma2H034CHYGC52hP8PmoVKpxO3q4=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>) id 1kjh6B-00086t-3P
 for control <at> debbugs.gnu.org; Mon, 30 Nov 2020 12:12:05 +0100
Date: Mon, 30 Nov 2020 12:12:02 +0100
Message-Id: <87y2ijaykd.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: control message for bug #27130
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  tags 27130 + confirmed quit 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 27130 + confirmed
quit

Message sent to bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#27130: c-mode indentation mistreats structs in function arguments
Resent-From: Alan Mackenzie <acm@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN, bug-cc-mode@HIDDEN
Resent-Date: Mon, 30 Nov 2020 17:05:02 +0000
Resent-Message-ID: <handler.27130.B27130.160675589911392 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 27130
X-GNU-PR-Package: emacs,cc-mode
X-GNU-PR-Keywords: confirmed
To: Lars Ingebrigtsen <larsi@HIDDEN>
Cc: Sam Pagenkopf <ssaammp@HIDDEN>, 27130 <at> debbugs.gnu.org, acm@HIDDEN
Received: via spool by 27130-submit <at> debbugs.gnu.org id=B27130.160675589911392
          (code B ref 27130); Mon, 30 Nov 2020 17:05:02 +0000
Received: (at 27130) by debbugs.gnu.org; 30 Nov 2020 17:04:59 +0000
Received: from localhost ([127.0.0.1]:56500 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1kjmbU-0002xQ-7Y
	for submit <at> debbugs.gnu.org; Mon, 30 Nov 2020 12:04:59 -0500
Received: from colin.muc.de ([193.149.48.1]:59162 helo=mail.muc.de)
 by debbugs.gnu.org with smtp (Exim 4.84_2)
 (envelope-from <acm@HIDDEN>) id 1kjmbS-0002xB-Eh
 for 27130 <at> debbugs.gnu.org; Mon, 30 Nov 2020 12:04:43 -0500
Received: (qmail 88650 invoked by uid 3782); 30 Nov 2020 17:04:35 -0000
Received: from acm.muc.de (p4fe15abb.dip0.t-ipconnect.de [79.225.90.187]) by
 localhost.muc.de (tmda-ofmipd) with ESMTP;
 Mon, 30 Nov 2020 18:04:34 +0100
Received: (qmail 10024 invoked by uid 1000); 30 Nov 2020 17:04:34 -0000
Date: Mon, 30 Nov 2020 17:04:34 +0000
Message-ID: <X8UmIl+Yp8A/R17n@ACM>
References: <CAKiGDcO6hedSbWEP=VLq5U-7PunPewX_2JD_qm_Hs6W4NJH6+A@HIDDEN>
 <87zh2zaykj.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87zh2zaykj.fsf@HIDDEN>
X-Delivery-Agent: TMDA/1.1.12 (Macallan)
From: Alan Mackenzie <acm@HIDDEN>
X-Primary-Address: acm@HIDDEN
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello, Lars.

On Mon, Nov 30, 2020 at 12:11:56 +0100, Lars Ingebrigtsen wrote:
> Sam Pagenkopf <ssaammp@HIDDEN> writes:

> > In emacs 25.2.1.

> > Relevant code:

> >     draw_add(&battle.draw, (Drawn){
> >             .kind = DRAW_RECT,
> >                 .size = {40,24},
> >                 .pos.border = {
> >                 .align = {ALIGN_LEFT, ALIGN_TOP},
> >                 .dist = 3
> >             }
> >         }
> >         );

> > My guess is that it's reading (Drawn){...} as a statement, and the , as
> > the (,) C operator.

> I'm not sure how this should be indented (as I didn't even know that
> that was valid C).  But that does look wrong, in any case.  (I've
> confirmed that it indents it the same way in Emacs 28.)

> Alan?

That's strange.  In my Emacs 28 copy, I get this indentation:

    int main ()
    {
        draw_add(&battle.draw, (Drawn){
                .kind = DRAW_RECT,
                .size = {40,24},
                .pos.border = {
                    .align = {ALIGN_LEFT, ALIGN_TOP},
                    .dist = 3
                }
            }
            );
    }

, which apart from the closing parenthesis being indented too far, looks
basically OK.  Possibly, one might want the .kind line indented one space
further (it is indented 2 * c-basic-offset from the draw_add on the
previous line).  C-c C-s on that line gives the following analysis:

    ((arglist-cont-nonempty 19 27) (brace-list-intro 19))

.  C-c C-s on the following line should give

    ((brace-list-entry 63))

, where 63 is the position of the . in .kind.  This is correct.  In fact,
something in this area was corrected in the last three or four years, 

The closing paren is lined up by c-align-arglist-close-under-paren, which
contains a bit of DWIMery which misfires here, causing the ) to be
indented c-basic-offset from the first character on the line opening the
construct (here the draw_add line).  This DWIMery has also recently
misfired on a C++ file, so I think I'll have to modernise
c-align-arglist-close-under-paren to be more discerning.

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).

Last modified: Mon, 30 Nov 2020 17:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.