GNU logs - #27188, boring messages

Message sent to bug-automake@HIDDEN:

Subject: bug#27188: lex/yacc with subdir-objects and --disable-dependency-tracking broken
Resent-From: Nick Brown <brownn@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Thu, 01 Jun 2017 15:13:02 +0000
Resent-Message-ID: <handler.27188.B.149632998126240 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 27188 <at> debbugs.gnu.org
From: Nick Brown <brownn@HIDDEN>
Thread-Topic: lex/yacc with subdir-objects and --disable-dependency-tracking
 broken
Thread-Index: AQHS2uLj82g1YbizfU6br51UzT/d0g==
Date: Thu, 1 Jun 2017 14:25:15 +0000
Message-ID: <1496327115.8761.26.camel@HIDDEN>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [172.27.212.149]
Content-Type: multipart/mixed; boundary="_002_1496327115876126camelbrocadecom_"
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, ,
 definitions=2017-06-01_03:, , signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0
 priorityscore=1501 malwarescore=0
 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015
 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706010260
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

--_002_1496327115876126camelbrocadecom_
Content-Type: text/plain; charset="utf-8"
Content-ID: <B1A14FD355D6264EBAE79E5D3FEEEE62@HIDDEN>
Content-Transfer-Encoding: base64

QnkgZGVmYXVsdCBEZWJpYW4gZGggcGFzc2VzIC0tZGlzYWJsZS1kZXBlbmRhY3ktdHJhY2tpbmcg
d2hlbiBidWlsZGluZy4NCklmIHRoZSBwYWNrYWdlIHJ1bGVzIGFsc28gYWRkcyAtLWJ1aWxkZGly
ZWN0b3J5IHRvIHVzZSBvdXQgb2Ygc291cmNlIGJ1aWxkcw0KKGVnLiAiZGggJEAgLS1idWlsZGRp
cmVjdG9yeT1idWlsZCAtLXBhcmFsbGVsIC0td2l0aCBhdXRvcmVjb25mIiksIGFuZCB0aGUNCnBh
Y2thZ2UgaGFwcGVucyB0byBiZSB1c2luZyBzdWJkaXItb2JqZWN0cyBhdXRvbWFrZSBvcHRpb24g
YW5kIGdlbmVyYXRlZCBzb3VyY2UNCmZpbGVzIGZyb20gbGV4L3lhY2MgdGhlbiB0aGUgYnVpbGQg
d2lsbCBmYWlsLg0KDQpFZy4NCg0KbWtkaXIgYnVpbGQNCi4uL2NvbmZpZ3VyZSAtLWRpc2FibGUt
ZGVwZW5kZW5jeS10cmFja2luZyAtLWRpc2FibGUtc2lsZW50LXJ1bGVzDQptYWtlDQoNCi9iaW4v
YmFzaCAuLi95bHdyYXAgLi4vc3JjL3NjYW5uZXIubGwgbGV4Lnl5LmMgc3JjL3NjYW5uZXIuY2Mg
LS0gZmxleA0KLi4veWx3cmFwOiBsaW5lIDIwNjogLi4vc3JjL3NjYW5uZXIuY2M6IE5vIHN1Y2gg
ZmlsZSBvciBkaXJlY3RvcnkNCk1ha2VmaWxlOjQyMjogcmVjaXBlIGZvciB0YXJnZXQgJ3NyYy9z
Y2FubmVyLmNjJyBmYWlsZWQNCm1ha2U6ICoqKiBbc3JjL3NjYW5uZXIuY2NdIEVycm9yIDENCg0K
QSBzaW1wbGUgcGF0Y2ggdG8gbGV4LmFtIGFuZCB5YWNjLmFtIGZpeGVzIHRoaXMuDQo=

--_002_1496327115876126camelbrocadecom_
Content-Type: text/x-patch;
	name="0001-yacc-and-lex-built-objects-without-dependancy-tracking.patch"
Content-Description: 0001-yacc-and-lex-built-objects-without-dependancy-tracking.patch
Content-Disposition: attachment;
	filename="0001-yacc-and-lex-built-objects-without-dependancy-tracking.patch";
	size=1257; creation-date="Thu, 01 Jun 2017 14:25:15 GMT";
	modification-date="Thu, 01 Jun 2017 14:25:15 GMT"
Content-ID: <96901421A8F99841BD93BBFD4E2CA7B3@HIDDEN>
Content-Transfer-Encoding: base64

PkZyb20gYmQ2OTcxMjI0ZjMwNGM4ZjU5NTFhZmNhNjIwZjMzYzI1MjQ4YjQ0NiBNb24gU2VwIDE3
IDAwOjAwOjAwIDIwMDEKRnJvbTogTmljaG9sYXMgQnJvd24gPGJyb3dubkBicm9jYWRlLmNvbT4K
RGF0ZTogRnJpLCA0IERlYyAyMDE1IDEwOjQ5OjE4ICswMDAwClN1YmplY3Q6IFtQQVRDSF0geWFj
YyBhbmQgbGV4IGJ1aWx0IG9iamVjdHMgd2l0aG91dCBkZXBlbmRhbmN5IHRyYWNraW5nCgotLS0K
IGxpYi9hbS9sZXguYW0gIHwgMSArCiBsaWIvYW0veWFjYy5hbSB8IDEgKwogMiBmaWxlcyBjaGFu
Z2VkLCAyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saWIvYW0vbGV4LmFtIGIvbGliL2Ft
L2xleC5hbQppbmRleCBkN2RkYzc3Li42MzU3NTA3IDEwMDY0NAotLS0gYS9saWIvYW0vbGV4LmFt
CisrKyBiL2xpYi9hbS9sZXguYW0KQEAgLTIzLDYgKzIzLDcgQEAgZW5kaWYgJT9NQUlOVEFJTkVS
LU1PREUlCiAKID9HRU5FUklDPyVFWFQlJURFUklWRUQtRVhUJToKID8hR0VORVJJQz8lT0JKJTog
JVNPVVJDRSUKKz9TVUJESVJPQko/CSVTSUxFTlQldGVzdCAtZCAkKGRpciAkQCkgfHwgJChNS0RJ
Ul9QKSAkKGRpciAkQCkKID9HRU5FUklDPwklVkVSQk9TRSUkKGFtX19za2lwbGV4KSAkKFNIRUxM
KSAkKFlMV1JBUCkgJVNPVVJDRSUgJChMRVhfT1VUUFVUX1JPT1QpLmMgJU9CSiUgLS0gJUNPTVBJ
TEUlCiA/IUdFTkVSSUM/CSVWRVJCT1NFJSBcCiA/IUdFTkVSSUM/P0RJU1RfU09VUkNFPwkkKGFt
X19za2lwbGV4KSBcCmRpZmYgLS1naXQgYS9saWIvYW0veWFjYy5hbSBiL2xpYi9hbS95YWNjLmFt
CmluZGV4IDJiM2Y5MmEuLjJjMzMwMjMgMTAwNjQ0Ci0tLSBhL2xpYi9hbS95YWNjLmFtCisrKyBi
L2xpYi9hbS95YWNjLmFtCkBAIC00Myw2ICs0Myw3IEBAIGVuZGlmICU/RklSU1QlCiAKID9HRU5F
UklDPyVFWFQlJURFUklWRUQtRVhUJToKID8hR0VORVJJQz8lT0JKJTogJVNPVVJDRSUKKz9TVUJE
SVJPQko/CSVTSUxFTlQldGVzdCAtZCAkKGRpciAkQCkgfHwgJChNS0RJUl9QKSAkKGRpciAkQCkK
ID9HRU5FUklDPwklVkVSQk9TRSUkKGFtX19za2lweWFjYykgJChTSEVMTCkgJChZTFdSQVApICVT
T1VSQ0UlIHkudGFiLmMgJU9CSiUgeS50YWIuaCBgZWNobyAlT0JKJSB8ICQoYW1fX3lhY2NfYzJo
KWAgeS5vdXRwdXQgJUJBU0UlLm91dHB1dCAtLSAlQ09NUElMRSUKID8hR0VORVJJQz8JJVZFUkJP
U0UlIFwKID8hR0VORVJJQz8/RElTVF9TT1VSQ0U/CSQoYW1fX3NraXB5YWNjKSBcCi0tIAoyLjEu
NAoK

--_002_1496327115876126camelbrocadecom_--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Nick Brown <brownn@HIDDEN>
Subject: bug#27188: Acknowledgement (lex/yacc with subdir-objects and
 --disable-dependency-tracking broken)
Message-ID: <handler.27188.B.149632998126240.ack <at> debbugs.gnu.org>
References: <1496327115.8761.26.camel@HIDDEN>
X-Gnu-PR-Message: ack 27188
X-Gnu-PR-Package: automake
Reply-To: 27188 <at> debbugs.gnu.org
Date: Thu, 01 Jun 2017 15:13:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-automake@HIDDEN

If you wish to submit further information on this problem, please
send it to 27188 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
27188: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D27188
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-automake@HIDDEN:

Subject: bug#27188: lex/yacc with subdir-objects and --disable-dependency-tracking broken
Resent-From: Mathieu Lirzin <mthl@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Sun, 04 Jun 2017 23:16:02 +0000
Resent-Message-ID: <handler.27188.B27188.149661814721964 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Nick Brown <brownn@HIDDEN>
Cc: 27188 <at> debbugs.gnu.org
From: Mathieu Lirzin <mthl@HIDDEN>
References: <1496327115.8761.26.camel@HIDDEN>
Date: Mon, 05 Jun 2017 01:15:30 +0200
In-Reply-To: <1496327115.8761.26.camel@HIDDEN> (Nick Brown's message of
 "Thu, 1 Jun 2017 14:25:15 +0000")
Message-ID: <87vaobwdil.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello,

Nick Brown <brownn@HIDDEN> writes:

> By default Debian dh passes --disable-dependacy-tracking when building.
> If the package rules also adds --builddirectory to use out of source builds
> (eg. "dh $@ --builddirectory=build --parallel --with autoreconf"), and the
> package happens to be using subdir-objects automake option and generated source
> files from lex/yacc then the build will fail.
>
> Eg.
>
> mkdir build
> ../configure --disable-dependency-tracking --disable-silent-rules
> make
>
> /bin/bash ../ylwrap ../src/scanner.ll lex.yy.c src/scanner.cc -- flex
> ../ylwrap: line 206: ../src/scanner.cc: No such file or directory
> Makefile:422: recipe for target 'src/scanner.cc' failed
> make: *** [src/scanner.cc] Error 1

This seems like a known bug since 2011, that would be nice to fix.
There is already an "expected fail" test case for the issue you have
described.  The commit 40c34328d1e5d3ab6885f046ce27517332413c13 which
has intentionaly make the test fail has the following ChangeLog:

+2011-10-20  Stefano Lattarini  <stefano.lattarini@HIDDEN>
+
+	deps: partially revert commit `v1.11-512-geeee551'
+	This change partly reverts commit "Create subdirs for generated
+	sources even when not dep tracking", of 2011-04-02.
+	That commit had caused the bugs #8485 and #8526.  Since we are
+	nearing the bug-fixing automake release 1.11.2, the safest policy
+	at the moment is to just revert the problematic hunks: an older,
+	known bug is better than a regression.
+	* automake.in (handle_single_transform): Don't add a dirstamp
+	dependency, even when $object is derived and lands in a subdir.
+	* tests/Makefile.am (XFAIL_TESTS): Add lex-subobj-nodep.test,
+	remove yacc-dist-nobuild-subdir.test.

This seems to imply that this has not been fixed because of time
constraints before a release.  Can you investigate more to see if your
patch doesn't reintroduce problems from bugs #8485 and #8526?

>
> A simple patch to lex.am and yacc.am fixes this.
>
>>From bd6971224f304c8f5951afca620f33c25248b446 Mon Sep 17 00:00:00 2001
> From: Nicholas Brown <brownn@HIDDEN>
> Date: Fri, 4 Dec 2015 10:49:18 +0000
> Subject: [PATCH] yacc and lex built objects without dependancy tracking
>
> ---
>  lib/am/lex.am  | 1 +
>  lib/am/yacc.am | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/lib/am/lex.am b/lib/am/lex.am
> index d7ddc77..6357507 100644
> --- a/lib/am/lex.am
> +++ b/lib/am/lex.am
> @@ -23,6 +23,7 @@ endif %?MAINTAINER-MODE%
>  
>  ?GENERIC?%EXT%%DERIVED-EXT%:
>  ?!GENERIC?%OBJ%: %SOURCE%
> +?SUBDIROBJ?	%SILENT%test -d $(dir $@) || $(MKDIR_P) $(dir $@)

I suspect the '$(dir ..)' syntax is not portable.  Hopefully there
should be a alternative.  Can you look into it? 

>  ?GENERIC?	%VERBOSE%$(am__skiplex) $(SHELL) $(YLWRAP) %SOURCE% $(LEX_OUTPUT_ROOT).c %OBJ% -- %COMPILE%
>  ?!GENERIC?	%VERBOSE% \
>  ?!GENERIC??DIST_SOURCE?	$(am__skiplex) \
> diff --git a/lib/am/yacc.am b/lib/am/yacc.am
> index 2b3f92a..2c33023 100644
> --- a/lib/am/yacc.am
> +++ b/lib/am/yacc.am
> @@ -43,6 +43,7 @@ endif %?FIRST%
>  
>  ?GENERIC?%EXT%%DERIVED-EXT%:
>  ?!GENERIC?%OBJ%: %SOURCE%
> +?SUBDIROBJ?	%SILENT%test -d $(dir $@) || $(MKDIR_P) $(dir $@)
>  ?GENERIC?	%VERBOSE%$(am__skipyacc) $(SHELL) $(YLWRAP) %SOURCE% y.tab.c %OBJ% y.tab.h `echo %OBJ% | $(am__yacc_c2h)` y.output %BASE%.output -- %COMPILE%
>  ?!GENERIC?	%VERBOSE% \
>  ?!GENERIC??DIST_SOURCE?	$(am__skipyacc) \

Thank you for you patch.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

Message sent to bug-automake@HIDDEN:

Subject: bug#27188: lex/yacc with subdir-objects and --disable-dependency-tracking broken
Resent-From: Nick Bowler <nbowler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Mon, 05 Jun 2017 23:18:01 +0000
Resent-Message-ID: <handler.27188.B27188.14967046256882 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Mathieu Lirzin <mthl@HIDDEN>
Cc: Nick Brown <brownn@HIDDEN>, 27188 <at> debbugs.gnu.org
MIME-Version: 1.0
In-Reply-To: <87vaobwdil.fsf@HIDDEN>
References: <1496327115.8761.26.camel@HIDDEN> <87vaobwdil.fsf@HIDDEN>
From: Nick Bowler <nbowler@HIDDEN>
Date: Mon, 5 Jun 2017 19:16:56 -0400
Message-ID: <CADyTPEwzkmh_N3PeLxNmg8X-VAwiTy7_2hcLCq+LUYovVwp_LA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 6/4/17, Mathieu Lirzin <mthl@HIDDEN> wrote:
> Nick Brown <brownn@HIDDEN> writes:
>> diff --git a/lib/am/lex.am b/lib/am/lex.am
>> index d7ddc77..6357507 100644
>> --- a/lib/am/lex.am
>> +++ b/lib/am/lex.am
>> @@ -23,6 +23,7 @@ endif %?MAINTAINER-MODE%
>>
>>  ?GENERIC?%EXT%%DERIVED-EXT%:
>>  ?!GENERIC?%OBJ%: %SOURCE%
>> +?SUBDIROBJ?	%SILENT%test -d $(dir $@) || $(MKDIR_P) $(dir $@)
>
> I suspect the '$(dir ..)' syntax is not portable.  Hopefully there
> should be a alternative.  Can you look into it?

$(dir ...) is most definitely not portable.  One alternative is to use
$(@D), which is specified in POSIX and essentially works in every make
implementation that I know of.

However, there are still portability gotchas.  At least one implementation
(dmake) supports $(@D) in principle but expands it in a not-quite-POSIX-
compliant way.

POSIX says that the expansion of $(@D) (and similar variables) does not
include a trailing slash and expands to .  for the current directory
(i.e., when the target name does not contain a slash).

In dmake, the expansion of $(@D) (and similar variables) for the current
directory is the empty string, otherwise the expansion contains a trailing
slash.

In cases where the difference matters, this can be worked around in the
shell easily enough.  The difference matters if we adapt the above example
because mkdir with an empty string will fail.  Something like this should
be pretty portable (untested):

  test x"$(@D)" = x || $(MKDIR_P) "$(@D)"

Another way, perhaps even more portable, would be to do the splitting
entirely in the shell, e.g., by using expr.

Cheers,
  Nick

Message sent to bug-automake@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#27188: lex/yacc with subdir-objects and --disable-dependency-tracking broken
Resent-From: Mathieu Lirzin <mthl@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Sat, 17 Jun 2017 21:43:02 +0000
Resent-Message-ID: <handler.27188.B27188.149773572731257 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 27188
X-GNU-PR-Package: automake
X-GNU-PR-Keywords: 
To: Nick Bowler <nbowler@HIDDEN>
Cc: Nick Brown <brownn@HIDDEN>, 27188 <at> debbugs.gnu.org
Received: via spool by 27188-submit <at> debbugs.gnu.org id=B27188.149773572731257
          (code B ref 27188); Sat, 17 Jun 2017 21:43:02 +0000
Received: (at 27188) by debbugs.gnu.org; 17 Jun 2017 21:42:07 +0000
Received: from localhost ([127.0.0.1]:53730 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1dMLTn-000881-Ns
	for submit <at> debbugs.gnu.org; Sat, 17 Jun 2017 17:42:07 -0400
Received: from eggs.gnu.org ([208.118.235.92]:48498)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mthl@HIDDEN>) id 1dMLTl-00087X-DH
 for 27188 <at> debbugs.gnu.org; Sat, 17 Jun 2017 17:42:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mthl@HIDDEN>) id 1dMLTf-0006oz-8Q
 for 27188 <at> debbugs.gnu.org; Sat, 17 Jun 2017 17:41:56 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46570)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <mthl@HIDDEN>)
 id 1dMLTb-0006oT-86; Sat, 17 Jun 2017 17:41:51 -0400
Received: from [2a01:e35:2ec2:e580:491c:541:7a4a:37d9] (port=52304
 helo=localhost.localdomain)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <mthl@HIDDEN>)
 id 1dMLTa-000208-Ii; Sat, 17 Jun 2017 17:41:50 -0400
From: Mathieu Lirzin <mthl@HIDDEN>
References: <1496327115.8761.26.camel@HIDDEN> <87vaobwdil.fsf@HIDDEN>
 <CADyTPEwzkmh_N3PeLxNmg8X-VAwiTy7_2hcLCq+LUYovVwp_LA@HIDDEN>
Date: Sat, 17 Jun 2017 23:41:47 +0200
In-Reply-To: <CADyTPEwzkmh_N3PeLxNmg8X-VAwiTy7_2hcLCq+LUYovVwp_LA@HIDDEN>
 (Nick Bowler's message of "Mon, 5 Jun 2017 19:16:56 -0400")
Message-ID: <8760funvfo.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -3.4 (---)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

Hello Nick,

Nick Bowler <nbowler@HIDDEN> writes:

> On 6/4/17, Mathieu Lirzin <mthl@HIDDEN> wrote:
>> Nick Brown <brownn@HIDDEN> writes:
>>> diff --git a/lib/am/lex.am b/lib/am/lex.am
>>> index d7ddc77..6357507 100644
>>> --- a/lib/am/lex.am
>>> +++ b/lib/am/lex.am
>>> @@ -23,6 +23,7 @@ endif %?MAINTAINER-MODE%
>>>
>>>  ?GENERIC?%EXT%%DERIVED-EXT%:
>>>  ?!GENERIC?%OBJ%: %SOURCE%
>>> +?SUBDIROBJ?	%SILENT%test -d $(dir $@) || $(MKDIR_P) $(dir $@)
>>
>> I suspect the '$(dir ..)' syntax is not portable.  Hopefully there
>> should be a alternative.  Can you look into it?
>
> $(dir ...) is most definitely not portable.  One alternative is to use
> $(@D), which is specified in POSIX and essentially works in every make
> implementation that I know of.
>
> However, there are still portability gotchas.  At least one implementation
> (dmake) supports $(@D) in principle but expands it in a not-quite-POSIX-
> compliant way.
>
> POSIX says that the expansion of $(@D) (and similar variables) does not
> include a trailing slash and expands to .  for the current directory
> (i.e., when the target name does not contain a slash).
>
> In dmake, the expansion of $(@D) (and similar variables) for the current
> directory is the empty string, otherwise the expansion contains a trailing
> slash.
>
> In cases where the difference matters, this can be worked around in the
> shell easily enough.  The difference matters if we adapt the above example
> because mkdir with an empty string will fail.  Something like this should
> be pretty portable (untested):
>
>   test x"$(@D)" = x || $(MKDIR_P) "$(@D)"
>
> Another way, perhaps even more portable, would be to do the splitting
> entirely in the shell, e.g., by using expr.

I have searched for similar MKDIR_P constructs in the lib/am files to
know what is the current practice, but I haven't found any.  I think it
might be reasonable to use $(@D) fornow.  In fact Automake is using it
in its own Makefile (see "bin/Automake.inc").

Besides the portability issue, we need to figure out if this bug-fix
doesn't bring some regressions (as suggested by the commit log sample of
my previous email).  I have run the test suite with the changes you have
suggested, and the test suite doesn't complain except for the "XPASS"
concerning the "t/lex-subobj-nodep.sh" test (the one I was refering too
in my previous email).  So this seems to look good, but this isn't
enough to commit it confidently.

I have discovered that this bug is a duplicate of #9859 for which you
have already sent a patch 2 year ago.  :)

Thank you for investigating.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 17 Jun 2017 21:44:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 17 17:44:55 2017
Received: from localhost ([127.0.0.1]:53734 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1dMLWZ-0008C3-Jp
	for submit <at> debbugs.gnu.org; Sat, 17 Jun 2017 17:44:55 -0400
Received: from eggs.gnu.org ([208.118.235.92]:49144)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mthl@HIDDEN>) id 1dMLWY-0008Br-6t
 for control <at> debbugs.gnu.org; Sat, 17 Jun 2017 17:44:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mthl@HIDDEN>) id 1dMLWS-0000HP-K0
 for control <at> debbugs.gnu.org; Sat, 17 Jun 2017 17:44:49 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46619)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <mthl@HIDDEN>)
 id 1dMLWS-0000HJ-GF
 for control <at> debbugs.gnu.org; Sat, 17 Jun 2017 17:44:48 -0400
Received: from [2a01:e35:2ec2:e580:491c:541:7a4a:37d9] (port=52324
 helo=localhost.localdomain)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <mthl@HIDDEN>) id 1dMLWR-00029G-TY
 for control <at> debbugs.gnu.org; Sat, 17 Jun 2017 17:44:48 -0400
Date: Sat, 17 Jun 2017 23:44:46 +0200
Message-Id: <871sqinvap.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Mathieu Lirzin <mthl@HIDDEN>
Subject: control message for bug #27188
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -3.4 (---)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.4 (---)

merge 27188 9859

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 18 Jun 2017 11:27:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 18 07:27:37 2017
Received: from localhost ([127.0.0.1]:54036 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1dMYMj-0005hT-3W
	for submit <at> debbugs.gnu.org; Sun, 18 Jun 2017 07:27:37 -0400
Received: from eggs.gnu.org ([208.118.235.92]:45915)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mthl@HIDDEN>) id 1dMYMh-0005hC-GD
 for control <at> debbugs.gnu.org; Sun, 18 Jun 2017 07:27:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mthl@HIDDEN>) id 1dMYMb-00085W-MD
 for control <at> debbugs.gnu.org; Sun, 18 Jun 2017 07:27:30 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53583)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <mthl@HIDDEN>)
 id 1dMYMb-00085S-Ii
 for control <at> debbugs.gnu.org; Sun, 18 Jun 2017 07:27:29 -0400
Received: from [2a01:e35:2ec2:e580:491c:541:7a4a:37d9] (port=50372
 helo=localhost.localdomain)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <mthl@HIDDEN>) id 1dMYMa-0006EU-W4
 for control <at> debbugs.gnu.org; Sun, 18 Jun 2017 07:27:29 -0400
Date: Sun, 18 Jun 2017 13:27:27 +0200
Message-Id: <87poe1r0ww.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Mathieu Lirzin <mthl@HIDDEN>
Subject: control message for bug #27188
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -3.4 (---)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.4 (---)

tags 27188 confirmed

Message sent to bug-automake@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#27188: 
References: <1496327115.8761.26.camel@HIDDEN>
In-Reply-To: <1496327115.8761.26.camel@HIDDEN>
Resent-From: Nicholas Brown <nickbroon@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-automake@HIDDEN
Resent-Date: Tue, 30 Jul 2019 20:33:01 +0000
Resent-Message-ID: <handler.27188.B27188.15645187239176 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 27188
X-GNU-PR-Package: automake
X-GNU-PR-Keywords: confirmed
To: 27188 <at> debbugs.gnu.org
Received: via spool by 27188-submit <at> debbugs.gnu.org id=B27188.15645187239176
          (code B ref 27188); Tue, 30 Jul 2019 20:33:01 +0000
Received: (at 27188) by debbugs.gnu.org; 30 Jul 2019 20:32:03 +0000
Received: from localhost ([127.0.0.1]:51258 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hsYmx-0002Nv-47
	for submit <at> debbugs.gnu.org; Tue, 30 Jul 2019 16:32:03 -0400
Received: from mail-yw1-f44.google.com ([209.85.161.44]:40256)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <nickbroon@HIDDEN>) id 1hsXLi-00088J-LF
 for 27188 <at> debbugs.gnu.org; Tue, 30 Jul 2019 14:59:50 -0400
Received: by mail-yw1-f44.google.com with SMTP id b143so24131294ywb.7
 for <27188 <at> debbugs.gnu.org>; Tue, 30 Jul 2019 11:59:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:from:date:message-id:subject:to;
 bh=FNjrp8Qz/ExOEYQ/uKZov2v3V5ZPC/0gSDiwOfSn20I=;
 b=DyNPSTzcRlsUjT9Z3+RgQ29aY0DtihQPanugf/zmKFWiwOGagc0UYa1WKYzKmRzmlY
 J+EBH0fXCgfGwkQ8iIETkW1VSKg1M2ZbtG7CwRMovUR2mZ3eRBtIGn1Vy7u5+FQLyHlS
 Du/jY1Q1pPsgwCnYLCMpZFFTFtDanIKDSXDwfTozmIufiG4z4weiUO6N4yWQw7kP5x4f
 3+llJBQ8n+fxFLSrJ7Xhg1AcjjVXILnwj8zG6jbV3jcGAT8g85ljgEP0KRzIJCBMQP/h
 IYaaS07NZlj/TYNXmbrVGDZu98BJavMkeOWpkjrjKNfjXjfgsYbHqBXZ02s2VszLcQF3
 f+NQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=FNjrp8Qz/ExOEYQ/uKZov2v3V5ZPC/0gSDiwOfSn20I=;
 b=r2SiifQUwgnO2WaDkFjoftVD+Q5/B8q09nAvrueX+YGNsA1kXEuM2GyXtvB1OlfK6w
 kIFX1KBp6Bko9TGs9J0gPhTWtjizCpDikA0WOqSo4KlLaW5472S3aRpfISlDOndjTotW
 ybHSn6vYdAFWw+gKAngmQ/vuXh+bKcYy54nYJX8LaNmqIvXfsySRXPJdCJX28MfTJ4DB
 j3CXZzGj3l3e/LyA+zvjWWJJYpBO2c9uJjEEkzgsLM9mOAeaTlaGVxj9evwgH9Aa9ogF
 DVQtXoxirl3aDQ2tXN1cFd020UTvJmwgPr0avATEEMag3tQFgIFLhBlJHazeOwmOgR+c
 E54A==
X-Gm-Message-State: APjAAAWN+k0eez4kHu9yws0TvW2TpwryI2Bk5gGW4aiaSe65OG2p20Lm
 kySl1gZNGpJDkEaf1ts7mGkb5v40INNia19lLcFAUBM=
X-Google-Smtp-Source: APXvYqw8OrrnDr0dAptopLh8+IwmMQOl6KDqlyG84H2USEBiARSUvGBeX83fZ4SLsMqmgFP9ydtE3AkBcdTcHgNr358=
X-Received: by 2002:a81:4ec7:: with SMTP id
 c190mr69103697ywb.160.1564513184756; 
 Tue, 30 Jul 2019 11:59:44 -0700 (PDT)
MIME-Version: 1.0
From: Nicholas Brown <nickbroon@HIDDEN>
Date: Tue, 30 Jul 2019 19:59:18 +0100
Message-ID: <CA++smE+nv4zxnwLN0Sb3hYfY6bPmR5TTjsCO4cE_cv8zvPANEg@HIDDEN>
Content-Type: multipart/alternative; boundary="0000000000009fb88f058eea9cb5"
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: Any traction on fixing this issue? There are patches attached
 to both merged issues. Any traction on fixing this issue? There are patches
 attached to both merged issues. 
 Content analysis details:   (2.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (nickbroon[at]gmail.com)
 0.0 HTML_MESSAGE           BODY: HTML included in message
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [209.85.161.44 listed in list.dnswl.org]
 2.0 BLANK_SUBJECT          Subject is present but empty
X-Mailman-Approved-At: Tue, 30 Jul 2019 16:32:01 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.0 (+)

--0000000000009fb88f058eea9cb5
Content-Type: text/plain; charset="UTF-8"

Any traction on fixing this issue?
There are patches attached to both merged issues.

--0000000000009fb88f058eea9cb5
Content-Type: text/html; charset="UTF-8"

<div dir="ltr">Any traction on fixing this issue?<div>There are patches attached to both merged issues.</div></div>

--0000000000009fb88f058eea9cb5--

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.