GNU bug report logs - #27232
[PATCH] gnu: python-apsw: Build with all extensions.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27232 in the body.
You can then email your comments to 27232 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: guix-patches <at> gnu.org
Cc: Jelle Licht <jlicht <at> fsfe.org>
Subject: [PATCH] gnu: python-apsw: Build with all extensions.
Date: Sun,  4 Jun 2017 14:49:03 +0200

* gnu/packages/python.scm (python-apsw)[phases]: Replace build phase; add flag
  to build all extensions.
---
 gnu/packages/python.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 7617490bd..4ce56d45c 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5725,6 +5725,10 @@ implementation of D-Bus.")
     (arguments
      `(#:phases
        (modify-phases %standard-phases
+         (replace 'build
+           (lambda _
+             (zero?
+              (system* "python" "setup.py" "build" "--enable-all-extensions"))))
          (delete 'check)
          (add-after 'install 'check
            (lambda* (#:key inputs outputs #:allow-other-keys)
-- 
2.13.0

Message #8 received at 27232 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: 27232 <at> debbugs.gnu.org
Subject: Re: bug#27232: [PATCH] gnu: python-apsw: Build with all extensions.
Date: Sun, 4 Jun 2017 18:19:24 +0200

It works.  LGTM.

I get the following message though:

  Not doing LoadExtension test.  You need to compile the extension first
    gcc -fPIC -shared -o ./testextension.sqlext -I. -Isqlite3 src/testextension.c

Message #11 received at 27232 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 27232 <at> debbugs.gnu.org
Subject: Re: bug#27232: [PATCH] gnu: python-apsw: Build with all extensions.
Date: Fri, 07 Jul 2017 16:54:23 +0200

[Message part 1 (text/plain, inline)]

Hi Jelle!

As proposed earlier, I’ve added you as a committer on Savannah.
Hopefully that will allow you to push all the patches that people have
already okayed but not pushed thinking that you’d do it.  :-)

Please make sure the OpenPGP key at
<https://savannah.gnu.org/users/jlicht> is what you’ll use to sign
commits.  Could you reply to this message signed with this key?

Also please read ‘HACKING’.

That’s it!  Happy hacking, and welcome again!  :-)

Ludo’.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 27232 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Jelle Licht <jlicht <at> fsfe.org>, 27232 <at> debbugs.gnu.org
Subject: Re: bug#27232: [PATCH] gnu: python-apsw: Build with all extensions.
Date: Sat, 08 Jul 2017 02:10:46 +0200

[Message part 1 (text/plain, inline)]

Hi Ludo,

Still being a bit unused at integrating gpg into my workflow, but I
should have it all working now.

- Jelle

[Message part 2 (text/plain, inline)]

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 27232 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: 27232 <at> debbugs.gnu.org
Subject: Re: bug#27232: [PATCH] gnu: python-apsw: Build with all extensions.
Date: Sat, 08 Jul 2017 18:16:53 +0200

Hi Jelle,

Jelle Licht <jlicht <at> fsfe.org> skribis:

> Still being a bit unused at integrating gpg into my workflow, but I
> should have it all working now.

This looks good, except that you signed an empty MIME part, not the body
of your message.  :-)

Ludo’.

Message #20 received at 27232 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Jelle Licht <jlicht <at> fsfe.org>, 27232 <at> debbugs.gnu.org
Subject: Re: bug#27232: [PATCH] gnu: python-apsw: Build with all extensions.
Date: Thu, 20 Jul 2017 11:29:02 +0200

Hello,

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> It works.  LGTM.
>
> I get the following message though:
>
>   Not doing LoadExtension test.  You need to compile the extension first
>     gcc -fPIC -shared -o ./testextension.sqlext -I. -Isqlite3 src/testextension.c

Jelle, could you check and possibly commit this patch?

Thanks!

Ludo’.

Message #23 received at 27232 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 27232 <at> debbugs.gnu.org
Subject: Re: bug#27232: [PATCH] gnu: python-apsw: Build with all extensions.
Date: Thu, 27 Jul 2017 15:38:12 +0200

[Message part 1 (text/plain, inline)]

I add this command in a phase after build, and adjusted the attached patch
accordingly.
If there are no further issues, I will commit this at the end of this week.


2017-07-20 11:29 GMT+02:00 Ludovic Courtès <ludo <at> gnu.org>:

> Hello,
>
> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
>
> > It works.  LGTM.
> >
> > I get the following message though:
> >
> >   Not doing LoadExtension test.  You need to compile the extension first
> >     gcc -fPIC -shared -o ./testextension.sqlext -I. -Isqlite3
> src/testextension.c
>
> Jelle, could you check and possibly commit this patch?
>
> Thanks!
>
> Ludo’.
>

[Message part 2 (text/html, inline)]

[0001-gnu-python-apsw-Build-with-all-extensions.patch (text/x-patch, attachment)]

Message #26 received at 27232 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: Jelle Licht <jlicht <at> fsfe.org>, 27232 <at> debbugs.gnu.org
Subject: Re: [bug#27232] [PATCH] gnu: python-apsw: Build with all extensions.
Date: Fri, 08 Sep 2017 17:51:21 +0200

Hello Jelle,

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
>
>> It works.  LGTM.
>>
>> I get the following message though:
>>
>>   Not doing LoadExtension test.  You need to compile the extension first
>>     gcc -fPIC -shared -o ./testextension.sqlext -I. -Isqlite3 src/testextension.c
>
> Jelle, could you check and possibly commit this patch?

Ping!  :-)

Please close it if it’s no longer relevant.

Ludo’.

Message #31 received at 27232-done <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 27232-done <at> debbugs.gnu.org
Subject: Re: [bug#27232] [PATCH] gnu: python-apsw: Build with all extensions.
Date: Mon, 11 Sep 2017 01:16:09 +0200

[Message part 1 (text/plain, inline)]

2017-09-08 17:51 GMT+02:00 Ludovic Courtès <ludo <at> gnu.org>:

> Hello Jelle,
>
> ludo <at> gnu.org (Ludovic Courtès) skribis:
>
> > Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
> >
> >> It works.  LGTM.
> >>
> >> I get the following message though:
> >>
> >>   Not doing LoadExtension test.  You need to compile the extension first
> >>     gcc -fPIC -shared -o ./testextension.sqlext -I. -Isqlite3
> src/testextension.c
> >
> > Jelle, could you check and possibly commit this patch?
>
> Ping!  :-)
>
> Please close it if it’s no longer relevant.
>
> Ludo’.
>
Done!

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.