GNU logs - #27269, boring messages

Message sent to bug-sed@HIDDEN:

Subject: bug#27269: Sed --in-place is messing NTFS file permissions
Resent-From: Maiko Cezar Rodrigues Costa <maiko.cezar@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-sed@HIDDEN
Resent-Date: Wed, 07 Jun 2017 03:22:02 +0000
Resent-Message-ID: <handler.27269.B.14968057201923 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 27269 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Maiko Cezar Rodrigues Costa <maiko.cezar@HIDDEN>
Date: Wed, 07 Jun 2017 02:45:39 +0000
Message-ID: <CAJFYRRkoXk_Jqv=wg-2-NnevazuZZDZhBj5WL8nhPiuAr2LW0g@HIDDEN>
Content-Type: multipart/alternative; boundary="001a114dfc36e30dca055155bba6"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--001a114dfc36e30dca055155bba6
Content-Type: text/plain; charset="UTF-8"

Hi, I've a problem with sed when using the --in-place option in a mounted
NTFS partition;
$ sed --version
sed (GNU sed) 4.4
Copyright (C) 2017 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html
>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Jay Fenlason, Tom Lord, Ken Pizzini,
and Paolo Bonzini.
GNU sed home page: <http://www.gnu.org/software/sed/>.
General help using GNU software: <http://www.gnu.org/gethelp/>.
E-mail bug reports to: <bug-sed@HIDDEN>.


$ echo " test string teste" > x

$ sed --in-place=.bak 's@tes.*string@TESTE@g' x

$ ls -l
-rw-r--r-- 1 maiko users   13 jun  6 23:39  x
-rw-r--r-- 1 maiko users   19 jun  6 23:39  x.bak

$ cat x
 TESTE teste

$ cat x.bak
 test string teste

 So far, so good.

 my /etc/fstab

UUID=1CACB8ABACB88136 /media/FILES ntfs defaults,permissions,noatime 0 0


$ cd /media/FILES

$ echo " test string teste" > x

$ sed --in-place=.bak 's@tes.*string@TESTE@g' x

$ ls -l
---------- 1 maiko users   13 jun  6 23:42  x
-rw-r--r-- 1 maiko users   19 jun  6 23:42  x.bak

$ sudo cat x
 TESTE teste

$ cat x.bak
 test string teste


This guy has a very similar problem too
https://unix.stackexchange.com/questions/244603/why-is-sed-changing-permissions-of-a-file-on-a-cifs-mounted-share

Thanks
-- 

Maiko Cezar R Costa

PGP Public Key
<http://keyserver1.pgp.com/vkd/DownloadKey.event?keyid=0xB69302C5F63F5F84>

--001a114dfc36e30dca055155bba6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi, I&#39;ve a problem with sed when using the --in-place =
option in a mounted NTFS partition;=C2=A0<br><div>$ sed --version</div><div=
>sed (GNU sed) 4.4</div><div>Copyright (C) 2017 Free Software Foundation, I=
nc.</div><div>License GPLv3+: GNU GPL version 3 or later &lt;<a href=3D"htt=
p://gnu.org/licenses/gpl.html">http://gnu.org/licenses/gpl.html</a>&gt;.</d=
iv><div>This is free software: you are free to change and redistribute it.<=
/div><div>There is NO WARRANTY, to the extent permitted by law.</div><div><=
br></div><div>Written by Jay Fenlason, Tom Lord, Ken Pizzini,</div><div>and=
 Paolo Bonzini.</div><div>GNU sed home page: &lt;<a href=3D"http://www.gnu.=
org/software/sed/">http://www.gnu.org/software/sed/</a>&gt;.</div><div>Gene=
ral help using GNU software: &lt;<a href=3D"http://www.gnu.org/gethelp/">ht=
tp://www.gnu.org/gethelp/</a>&gt;.</div><div>E-mail bug reports to: &lt;<a =
href=3D"mailto:bug-sed@HIDDEN">bug-sed@HIDDEN</a>&gt;.</div><div><br></di=
v><br><div><div>$ echo &quot; test string teste&quot; &gt; x =C2=A0 =C2=A0 =
=C2=A0 =C2=A0</div><div><br></div><div>$ sed --in-place=3D.bak &#39;s@tes.*=
string@TESTE@g&#39; x</div><div><br></div><div>$ ls -l</div><div>-rw-r--r--=
 1 maiko users =C2=A0 13 jun =C2=A06 23:39 =C2=A0x</div><div>-rw-r--r-- 1 m=
aiko users =C2=A0 19 jun =C2=A06 23:39 =C2=A0x.bak</div><div><br></div><div=
>$ cat x</div><div>=C2=A0TESTE teste</div><div><br></div><div>$ cat x.bak=
=C2=A0</div><div>=C2=A0test string teste</div><div><br></div><div>=C2=A0So =
far, so good.</div><div><br></div><div>=C2=A0my /etc/fstab</div><div><br></=
div><div>UUID=3D1CACB8ABACB88136 /media/FILES ntfs defaults,permissions,noa=
time 0 0</div><div><br></div><div><br></div><div>$ cd /media/FILES=C2=A0</d=
iv><div><br></div><div>$ echo &quot; test string teste&quot; &gt; x =C2=A0 =
=C2=A0 =C2=A0 =C2=A0</div><div><br></div><div>$ sed --in-place=3D.bak &#39;=
s@tes.*string@TESTE@g&#39; x</div><div><br></div><div>$ ls -l</div><div>---=
------- 1 maiko users =C2=A0 13 jun =C2=A06 23:42 =C2=A0x</div><div>-rw-r--=
r-- 1 maiko users =C2=A0 19 jun =C2=A06 23:42 =C2=A0x.bak</div><div><br></d=
iv><div>$ sudo cat x</div><div>=C2=A0TESTE teste</div><div><br></div><div>$=
 cat x.bak=C2=A0</div><div>=C2=A0test string teste</div><div><br></div><br>=
This guy has a very similar problem too=C2=A0<a href=3D"https://unix.stacke=
xchange.com/questions/244603/why-is-sed-changing-permissions-of-a-file-on-a=
-cifs-mounted-share">https://unix.stackexchange.com/questions/244603/why-is=
-sed-changing-permissions-of-a-file-on-a-cifs-mounted-share</a><br><br>Than=
ks</div></div><div dir=3D"ltr">-- <br></div><div data-smartmail=3D"gmail_si=
gnature"><div dir=3D"ltr"><span><p style=3D"margin:0px 0px 10px;font-family=
:helvetica,arial,sans-serif;font-size:12px;line-height:14px"><span style=3D=
"color:rgb(153,153,153)"><span style=3D"font-weight:bold">Maiko Cezar R Cos=
ta</span>=C2=A0</span></p><p style=3D"margin:0px 0px 10px;font-family:helve=
tica,arial,sans-serif;font-size:12px;line-height:14px"><a href=3D"http://ke=
yserver1.pgp.com/vkd/DownloadKey.event?keyid=3D0xB69302C5F63F5F84" style=3D=
"font-size:11.2px" target=3D"_blank">PGP Public Key</a><span style=3D"color=
:rgb(153,153,153)"><br></span></p></span></div></div>

--001a114dfc36e30dca055155bba6--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Maiko Cezar Rodrigues Costa <maiko.cezar@HIDDEN>
Subject: bug#27269: Acknowledgement (Sed --in-place is messing NTFS file
 permissions)
Message-ID: <handler.27269.B.14968057201923.ack <at> debbugs.gnu.org>
References: <CAJFYRRkoXk_Jqv=wg-2-NnevazuZZDZhBj5WL8nhPiuAr2LW0g@HIDDEN>
X-Gnu-PR-Message: ack 27269
X-Gnu-PR-Package: sed
Reply-To: 27269 <at> debbugs.gnu.org
Date: Wed, 07 Jun 2017 03:22:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-sed@HIDDEN

If you wish to submit further information on this problem, please
send it to 27269 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
27269: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D27269
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-sed@HIDDEN:

Subject: bug#27269: Sed --in-place is messing NTFS file permissions
Resent-From: Assaf Gordon <assafgordon@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-sed@HIDDEN
Resent-Date: Wed, 15 Nov 2017 09:24:02 +0000
Resent-Message-ID: <handler.27269.B27269.151073782421116 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Maiko Cezar Rodrigues Costa <maiko.cezar@HIDDEN>, 27269 <at> debbugs.gnu.org
References: <CAJFYRRkoXk_Jqv=wg-2-NnevazuZZDZhBj5WL8nhPiuAr2LW0g@HIDDEN>
From: Assaf Gordon <assafgordon@HIDDEN>
Message-ID: <9f3ac097-b1b3-338e-c134-278e53f08f9b@HIDDEN>
Date: Wed, 15 Nov 2017 02:23:31 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAJFYRRkoXk_Jqv=wg-2-NnevazuZZDZhBj5WL8nhPiuAr2LW0g@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello,

On 2017-06-06 08:45 PM, Maiko Cezar Rodrigues Costa wrote:
> Hi, I've a problem with sed when using the --in-place option in a mounted
> NTFS partition;

Thank you for the report.

I can reproduce this and I believe it is a regression in sed-4.4 that 
happens when an ntfs partition is mounted with "-o permissions".

To reproduce:

Create dummy NTFS partition and mount it:

   cd /tmp/
   dd if=/dev/zero of=ntfs.partition.bin bs=1M count=20
   mkfs.ntfs --force ./ntfs.partition.bin
   mkdir /tmp/mnt
   sudo mount -t ntfs -o permissions ./ntfs.partition.bin /tmp/mnt/
   cd /tmp/mnt

Create first file:

   $ echo hello > world
   $ ls -l
   total 1
   -rw-rw-r-- 1 gordon gordon 6 Nov 15 02:16 world

Use sed-4.2, permissions retained:

   $ sed-4.2.2 -i.bak-sed4.2 's/e/x/' world
   $ ls -l
   total 1
   -rw-rw-r-- 1 gordon gordon 6 Nov 15 02:16 world
   -rw-rw-r-- 1 gordon gordon 6 Nov 15 02:16 world.bak-sed4.2

Same with sed-4.4, permissions lost:

   $ sed-4.4 -i.bak-sed4.4 's/e/x/' world
   $ ls -l
   total 2
   ---------- 1 gordon gordon 6 Nov 15 02:16 world
   -rw-rw-r-- 1 gordon gordon 6 Nov 15 02:16 world.bak-sed4.2
   -rw-rw-r-- 1 gordon gordon 6 Nov 15 02:16 world.bak-sed4.4



I will investigate further to try and pinpoint the offending code.

regards,
  - assaf

Message sent to bug-sed@HIDDEN:

Subject: bug#27269: Sed --in-place is messing NTFS file permissions
Resent-From: Assaf Gordon <assafgordon@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-sed@HIDDEN
Resent-Date: Wed, 15 Nov 2017 10:44:02 +0000
Resent-Message-ID: <handler.27269.B27269.151074262128142 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Maiko Cezar Rodrigues Costa <maiko.cezar@HIDDEN>, 27269 <at> debbugs.gnu.org
From: Assaf Gordon <assafgordon@HIDDEN>
References: <CAJFYRRkoXk_Jqv=wg-2-NnevazuZZDZhBj5WL8nhPiuAr2LW0g@HIDDEN>
 <9f3ac097-b1b3-338e-c134-278e53f08f9b@HIDDEN>
Message-ID: <aace9ca0-1cbb-923a-4321-95bdf0434ce3@HIDDEN>
Date: Wed, 15 Nov 2017 03:43:30 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <9f3ac097-b1b3-338e-c134-278e53f08f9b@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello,

On 2017-11-15 02:23 AM, Assaf Gordon wrote:
> On 2017-06-06 08:45 PM, Maiko Cezar Rodrigues Costa wrote:
>> Hi, I've a problem with sed when using the --in-place option in a mounted
>> NTFS partition;
> 
> I can reproduce this and I believe it is a regression in sed-4.4 that 
> happens when an ntfs partition is mounted with "-o permissions".

The above statement is incorrect.
It is not a regression in sed-4.4 compared to sed-4.2 but a different 
issue relating to ACL support during compilation ("./configure 
--disable-acl").

If ACL support is included, NTFS permissions DO NOT work.
If ACL support is NOT included, NTFS permissions DO work.

What confused me before is that on Debian/Ubuntu systems
the default sed (/bin/sed) is compiled without ACL
and using it "just worked", while compiling from source code
did include ACL and it never worked.

Current Work around:
1. Use the system's default sed (e.g /bin/sed) which is likely compiled 
without ACL, or
2. Build sed with "./configure --disable-acl".
This of course will lose the ability to copy other ACLs on non-NTFS file 
systems.

----

Technical reason:
1.
If "./configure" finds the header file <sys/acl.h>, ACL support is included.

2.
Another way to test ACL support is by checking if the sed binary
requires the acl shared library:

     $ ldd /bin/sed | grep acl
     $ ldd ~/projects/sed/sed/sed | grep acl
         libacl.so.1 => /lib/x86_64-linux-gnu/libacl.so.1

3.
If ACL support is compiled in sed, using "--in-place"
leads to the following syscalls:

   fchown(4, 1000, 1000)                   = 0
   fgetxattr(3, "system.posix_acl_access", "", 132) = 0
   fstat(3, {st_mode=S_IFREG|0664, st_size=6, ...}) = 0
   fsetxattr(4, "system.posix_acl_access", "\2\0\0\0\37....", 28, 0) = 0
   close(3)                                = 0
   close(4)                                = 0
   rename("world", "world.bak")            = 0
   rename("./sedcrOmKi", "world")          = 0

4.
If ACL support is not compiled in sed, using "--in-place"
leads to the following syscalls:

   fchown(4, 1000, 1000)                   = 0
   fchmod(4, 0100664)                      = 0
   close(3)                                = 0
   close(4)                                = 0
   rename("world", "world.bak")            = 0
   rename("./sednDUqpF", "world")          = 0

One can perhaps infer that fsetxattr/fgetxattr do not work on NTFS
mounts, but also don't fail with ENOTSUP.

----

Code flow:
sed's execute.c calls gnulib's "copy_acl" [1].
copy_acl calls qcopy_acl [2].
qcopy_acl calls set_permissions [3]
set_permissions uses the USE_ACL #define to either call "set_acls"
or call chmod/fchmod directly [4].

[1] https://opengrok.housegordon.com/source/xref/sed/sed/execute.c#677
[2] https://opengrok.housegordon.com/source/xref/gnulib/lib/copy-acl.c#43
[3] https://opengrok.housegordon.com/source/xref/gnulib/lib/qcopy-acl.c#39
[4] 
https://opengrok.housegordon.com/source/xref/gnulib/lib/set-permissions.c#776

----

Is this a bug?
and if so, is it in sed or gnulib or libacl ?
Not sure about this.

Jim and all,
What do you think?

regards,
  - assaf

Message sent to bug-sed@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#27269: Sed --in-place is messing NTFS file permissions
Resent-From: Jim Meyering <jim@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-sed@HIDDEN
Resent-Date: Fri, 17 Nov 2017 06:24:01 +0000
Resent-Message-ID: <handler.27269.B27269.151089978814509 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 27269
X-GNU-PR-Package: sed
X-GNU-PR-Keywords: 
To: Assaf Gordon <assafgordon@HIDDEN>
Cc: 27269 <at> debbugs.gnu.org, Maiko Cezar Rodrigues Costa <maiko.cezar@HIDDEN>
Received: via spool by 27269-submit <at> debbugs.gnu.org id=B27269.151089978814509
          (code B ref 27269); Fri, 17 Nov 2017 06:24:01 +0000
Received: (at 27269) by debbugs.gnu.org; 17 Nov 2017 06:23:08 +0000
Received: from localhost ([127.0.0.1]:44124 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1eFa3Q-0003lw-BX
	for submit <at> debbugs.gnu.org; Fri, 17 Nov 2017 01:23:08 -0500
Received: from mail-qt0-f193.google.com ([209.85.216.193]:34797)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <meyering@HIDDEN>) id 1eFa3O-0003lP-Sd
 for 27269 <at> debbugs.gnu.org; Fri, 17 Nov 2017 01:23:07 -0500
Received: by mail-qt0-f193.google.com with SMTP id 8so3624308qtv.1
 for <27269 <at> debbugs.gnu.org>; Thu, 16 Nov 2017 22:23:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc;
 bh=RpytZiJXP94E5J1Fu9KIwYWJb/eYOwKEJ2158PA+XB0=;
 b=gMD6eB/+lqdBWI7Al1K0FdCyFXljbMmTbZy8TUPSLY9LS3fOXhF0lxYkQrkIV0aws0
 AX7xhwXuq6vkFdDBiCrlvos4gamln8LI93iG5UtKnN+vyHmheKBjobTDZDluyqwInvLu
 bqbGCkhUYQDtEhGO+uZMdr5q3I6jDGtso7bvVfdk8XaunfGt0eW8q/gUD715YRo30rhO
 reRx1FgmCaD6RneVii2vZsy8W7LrC8+6XQVBqaUD2z+mvqozljMly+diLLlu+wNps+lN
 ifTW4SIXN3ZCezYcdz8Ru4FSNzs4pYCMs2IjptqrBl1yhcpX2n/ZGuk8WhE9NYUhXqrf
 hovg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
 :date:message-id:subject:to:cc;
 bh=RpytZiJXP94E5J1Fu9KIwYWJb/eYOwKEJ2158PA+XB0=;
 b=Je4ORyZl1DBHTZHsUJUI+JvLWuTIG7qva5UxlLVjk9gXyo5rdkVLeGWdW54I9h9fLH
 5rXUvDGx5BJRRJR3TV/sA4bBoVjG3ZYV9D/xaoOk//fWF0vDZBi4aYtCCC3/H+BT3n8+
 FnwadljH9vVi6gGhu8yMYTTl7IJ1VlGD3DAX/Datmkj0JGA6VhAKVMzuIP45FauWk3lr
 LlxjOQ/tq1YcQoIrl+1Yxjsb0Enxtqf3v88Bfgw8Lfi6uDhPMPw1Q5ofHpLfe0fwZOC9
 JZ31g7IR3xWwdZU40A0LoCuVfJRBza1Nf2g/jan+7B2friTckYuqe6Bl4ta6JaCDQfPM
 CxNQ==
X-Gm-Message-State: AJaThX77hLGt8JdDkOple9zHOeOIejOEOW9jGQK+f/oGD9/anx+CAs6y
 tt3+0J/mkQqgsubOEBIn8P/PXKkvu347PZ081ao=
X-Google-Smtp-Source: AGs4zMbPD3L5q9Xam96TfwiF/6ZyKVo2SJpv+E1GC1bpiMSMP7fi6L8i/n7Xrfqr4optyH0OJKoL4omrEk7n5DYROm0=
X-Received: by 10.200.40.54 with SMTP id 51mr6793643qtq.339.1510899781255;
 Thu, 16 Nov 2017 22:23:01 -0800 (PST)
MIME-Version: 1.0
Received: by 10.55.9.17 with HTTP; Thu, 16 Nov 2017 22:22:40 -0800 (PST)
In-Reply-To: <aace9ca0-1cbb-923a-4321-95bdf0434ce3@HIDDEN>
References: <CAJFYRRkoXk_Jqv=wg-2-NnevazuZZDZhBj5WL8nhPiuAr2LW0g@HIDDEN>
 <9f3ac097-b1b3-338e-c134-278e53f08f9b@HIDDEN>
 <aace9ca0-1cbb-923a-4321-95bdf0434ce3@HIDDEN>
From: Jim Meyering <jim@HIDDEN>
Date: Thu, 16 Nov 2017 22:22:40 -0800
X-Google-Sender-Auth: XXh56bIYAJsG1oFuAMxRyiELXTA
Message-ID: <CA+8g5KGDPDBQEissjBPSY_rTjoEX3-DN5cW6oCwM8jPGwjFz7w@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)

On Wed, Nov 15, 2017 at 2:43 AM, Assaf Gordon <assafgordon@HIDDEN> wrote:
...
> 3.
> If ACL support is compiled in sed, using "--in-place"
> leads to the following syscalls:
>
>   fchown(4, 1000, 1000)                   = 0
>   fgetxattr(3, "system.posix_acl_access", "", 132) = 0
>   fstat(3, {st_mode=S_IFREG|0664, st_size=6, ...}) = 0
>   fsetxattr(4, "system.posix_acl_access", "\2\0\0\0\37....", 28, 0) = 0
>   close(3)                                = 0
>   close(4)                                = 0
>   rename("world", "world.bak")            = 0
>   rename("./sedcrOmKi", "world")          = 0
>
> 4.
> If ACL support is not compiled in sed, using "--in-place"
> leads to the following syscalls:
>
>   fchown(4, 1000, 1000)                   = 0
>   fchmod(4, 0100664)                      = 0
>   close(3)                                = 0
>   close(4)                                = 0
>   rename("world", "world.bak")            = 0
>   rename("./sednDUqpF", "world")          = 0
>
>
> One can perhaps infer that fsetxattr/fgetxattr do not work on NTFS
> mounts, but also don't fail with ENOTSUP.
...
> Is this a bug?
> and if so, is it in sed or gnulib or libacl ?
> Not sure about this.

Hi Assaf,
Thank you for the thorough analysis.
Following your instructions in https://debbugs.gnu.org/27269#8, I
reproduced the failure on Fedora 26 with Linux 4.13.12.
That looks like either we're somehow telling f[gs]etxattr to do the
wrong thing, or it's a bug that they fail to do what we want, yet they
return 0/success.

Message sent to bug-sed@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#27269: Sed --in-place is messing NTFS file permissions
Resent-From: Assaf Gordon <assafgordon@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-sed@HIDDEN
Resent-Date: Tue, 09 Oct 2018 11:25:01 +0000
Resent-Message-ID: <handler.27269.B27269.153908426932202 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 27269
X-GNU-PR-Package: sed
X-GNU-PR-Keywords: 
To: Jim Meyering <jim@HIDDEN>
Cc: 27269 <at> debbugs.gnu.org, Maiko Cezar Rodrigues Costa <maiko.cezar@HIDDEN>
Received: via spool by 27269-submit <at> debbugs.gnu.org id=B27269.153908426932202
          (code B ref 27269); Tue, 09 Oct 2018 11:25:01 +0000
Received: (at 27269) by debbugs.gnu.org; 9 Oct 2018 11:24:29 +0000
Received: from localhost ([127.0.0.1]:41241 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1g9q7o-0008NF-VW
	for submit <at> debbugs.gnu.org; Tue, 09 Oct 2018 07:24:29 -0400
Received: from mail-it1-f193.google.com ([209.85.166.193]:51107)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <assafgordon@HIDDEN>)
 id 1g9q7n-0008Mw-FF; Tue, 09 Oct 2018 07:24:27 -0400
Received: by mail-it1-f193.google.com with SMTP id j81-v6so2027960ite.0;
 Tue, 09 Oct 2018 04:24:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=shijodR9GCcXarIWIHOoB2h/dn7GjTD0WMmO0D8sMLI=;
 b=Tja7sSLrzKvqfTK1pSjBw5F+kUc+nEmslGa4tcBvQwFxcF3O1z5kSJ+Jfa7zcmVoKn
 Im2jFPH3D1TopP+ZC0giMuVhaS+137t7miQGWqipXgGVXrR4w1NiIGNq2zLPby/vRTZk
 uNiFCa3tliiYoDQxmtwBfyhM5AyA/JWRcCj+zb/kq3q5SH6QHGrYIMrcLctl3MjgVIRV
 v+GKTQLKvTMn8wZg1DdLpanAcAqZMevEPs4Y2QjoVG2S/wjBHovWUvYkzrxT26wAjULA
 sTYf3FzFBDe6OLlEC9w/7q2MEyaLjH9fXgycjhTj+xM91YjISeh8sWvqEHuu/mBczgNK
 jgmw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=shijodR9GCcXarIWIHOoB2h/dn7GjTD0WMmO0D8sMLI=;
 b=WkrLaaJ3kXjD1Z9jFkUJSyhC+NiagBE7nBEPJgq0ldXPEmZPbfYVS3jYx51KF+lDmP
 hsxcoEB5m9qHBZ64BDQ0ZJqZ3vkix9Febhulf79Q2mPHlRjO8ActW+TiD9YXX+lkngZ3
 wMSqPi/abURSwi5j9lXbdkDC5BdF8seoaP8uXgaaAaBi6pH575mPCP1gqkGxdRO2uLan
 KRXOx6U28orlxxYLzWVJadEU7rqjml422BJ60TPiEMcM6n2fvxk2EW2qNqFTLUCISZJY
 s2/uHKvI8DJPYBxUqOO2T6gDL69GNFJyhOnSbPzq4gj4uaj80P5+cQWzp3NDxpTnOAxo
 HovA==
X-Gm-Message-State: ABuFfohkITLKnsgpdqqOrMRSGzpOkkBLLoBceNAMDFeVjVLQCSfArlcW
 RR+8j0JIqDtVdPtROOa5dSeJl5Rd
X-Google-Smtp-Source: ACcGV63zOThs33xsS74hymK2kqrynURGzBMzD79hNWqcpDRJQj5doog6gYWDSg6E1z/5XIssUM973A==
X-Received: by 2002:a24:ce02:: with SMTP id v2-v6mr1237010itg.18.1539084261281; 
 Tue, 09 Oct 2018 04:24:21 -0700 (PDT)
Received: from tomato.housegordon.com (moose.housegordon.com. [184.68.105.38])
 by smtp.googlemail.com with ESMTPSA id
 f8-v6sm6071156ioh.11.2018.10.09.04.24.19
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 09 Oct 2018 04:24:19 -0700 (PDT)
References: <CAJFYRRkoXk_Jqv=wg-2-NnevazuZZDZhBj5WL8nhPiuAr2LW0g@HIDDEN>
 <9f3ac097-b1b3-338e-c134-278e53f08f9b@HIDDEN>
 <aace9ca0-1cbb-923a-4321-95bdf0434ce3@HIDDEN>
 <CA+8g5KGDPDBQEissjBPSY_rTjoEX3-DN5cW6oCwM8jPGwjFz7w@HIDDEN>
From: Assaf Gordon <assafgordon@HIDDEN>
Message-ID: <5132d3dc-f8f2-97eb-664d-8c090dbe3de7@HIDDEN>
Date: Tue, 9 Oct 2018 05:24:18 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CA+8g5KGDPDBQEissjBPSY_rTjoEX3-DN5cW6oCwM8jPGwjFz7w@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 27269 wishlist
stop

Hello,

> On Wed, Nov 15, 2017 at 2:43 AM, Assaf Gordon <assafgordon@HIDDEN> wrote:
>> One can perhaps infer that fsetxattr/fgetxattr do not work on NTFS
>> mounts, but also don't fail with ENOTSUP.
In a follow-up thread in bug-gnulib@ [1], Paul Eggert wrote [2]:

   "This sounds like a bug inside the kernel then, in the ntfs code
   presumably. Perhaps we could work around the bug in Gnulib, but that
   sounds a bit expensive."

[1] https://lists.gnu.org/archive/html/bug-gnulib/2017-11/msg00031.html
[2] https://lists.gnu.org/archive/html/bug-gnulib/2017-11/msg00035.html


I'm therefore marking this as a "wishlist" item (but keeping it open, 
for future improvements).

regards,
  - assaf

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 9 Oct 2018 11:24:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Oct 09 07:24:28 2018
Received: from localhost ([127.0.0.1]:41239 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1g9q7o-0008NC-OH
	for submit <at> debbugs.gnu.org; Tue, 09 Oct 2018 07:24:28 -0400
Received: from mail-it1-f193.google.com ([209.85.166.193]:51107)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <assafgordon@HIDDEN>)
 id 1g9q7n-0008Mw-FF; Tue, 09 Oct 2018 07:24:27 -0400
Received: by mail-it1-f193.google.com with SMTP id j81-v6so2027960ite.0;
 Tue, 09 Oct 2018 04:24:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=shijodR9GCcXarIWIHOoB2h/dn7GjTD0WMmO0D8sMLI=;
 b=Tja7sSLrzKvqfTK1pSjBw5F+kUc+nEmslGa4tcBvQwFxcF3O1z5kSJ+Jfa7zcmVoKn
 Im2jFPH3D1TopP+ZC0giMuVhaS+137t7miQGWqipXgGVXrR4w1NiIGNq2zLPby/vRTZk
 uNiFCa3tliiYoDQxmtwBfyhM5AyA/JWRcCj+zb/kq3q5SH6QHGrYIMrcLctl3MjgVIRV
 v+GKTQLKvTMn8wZg1DdLpanAcAqZMevEPs4Y2QjoVG2S/wjBHovWUvYkzrxT26wAjULA
 sTYf3FzFBDe6OLlEC9w/7q2MEyaLjH9fXgycjhTj+xM91YjISeh8sWvqEHuu/mBczgNK
 jgmw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=shijodR9GCcXarIWIHOoB2h/dn7GjTD0WMmO0D8sMLI=;
 b=WkrLaaJ3kXjD1Z9jFkUJSyhC+NiagBE7nBEPJgq0ldXPEmZPbfYVS3jYx51KF+lDmP
 hsxcoEB5m9qHBZ64BDQ0ZJqZ3vkix9Febhulf79Q2mPHlRjO8ActW+TiD9YXX+lkngZ3
 wMSqPi/abURSwi5j9lXbdkDC5BdF8seoaP8uXgaaAaBi6pH575mPCP1gqkGxdRO2uLan
 KRXOx6U28orlxxYLzWVJadEU7rqjml422BJ60TPiEMcM6n2fvxk2EW2qNqFTLUCISZJY
 s2/uHKvI8DJPYBxUqOO2T6gDL69GNFJyhOnSbPzq4gj4uaj80P5+cQWzp3NDxpTnOAxo
 HovA==
X-Gm-Message-State: ABuFfohkITLKnsgpdqqOrMRSGzpOkkBLLoBceNAMDFeVjVLQCSfArlcW
 RR+8j0JIqDtVdPtROOa5dSeJl5Rd
X-Google-Smtp-Source: ACcGV63zOThs33xsS74hymK2kqrynURGzBMzD79hNWqcpDRJQj5doog6gYWDSg6E1z/5XIssUM973A==
X-Received: by 2002:a24:ce02:: with SMTP id v2-v6mr1237010itg.18.1539084261281; 
 Tue, 09 Oct 2018 04:24:21 -0700 (PDT)
Received: from tomato.housegordon.com (moose.housegordon.com. [184.68.105.38])
 by smtp.googlemail.com with ESMTPSA id
 f8-v6sm6071156ioh.11.2018.10.09.04.24.19
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 09 Oct 2018 04:24:19 -0700 (PDT)
Subject: Re: bug#27269: Sed --in-place is messing NTFS file permissions
To: Jim Meyering <jim@HIDDEN>
References: <CAJFYRRkoXk_Jqv=wg-2-NnevazuZZDZhBj5WL8nhPiuAr2LW0g@HIDDEN>
 <9f3ac097-b1b3-338e-c134-278e53f08f9b@HIDDEN>
 <aace9ca0-1cbb-923a-4321-95bdf0434ce3@HIDDEN>
 <CA+8g5KGDPDBQEissjBPSY_rTjoEX3-DN5cW6oCwM8jPGwjFz7w@HIDDEN>
From: Assaf Gordon <assafgordon@HIDDEN>
Message-ID: <5132d3dc-f8f2-97eb-664d-8c090dbe3de7@HIDDEN>
Date: Tue, 9 Oct 2018 05:24:18 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CA+8g5KGDPDBQEissjBPSY_rTjoEX3-DN5cW6oCwM8jPGwjFz7w@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: control
Cc: 27269 <at> debbugs.gnu.org, Maiko Cezar Rodrigues Costa <maiko.cezar@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 27269 wishlist
stop

Hello,

> On Wed, Nov 15, 2017 at 2:43 AM, Assaf Gordon <assafgordon@HIDDEN> wrote:
>> One can perhaps infer that fsetxattr/fgetxattr do not work on NTFS
>> mounts, but also don't fail with ENOTSUP.
In a follow-up thread in bug-gnulib@ [1], Paul Eggert wrote [2]:

   "This sounds like a bug inside the kernel then, in the ntfs code
   presumably. Perhaps we could work around the bug in Gnulib, but that
   sounds a bit expensive."

[1] https://lists.gnu.org/archive/html/bug-gnulib/2017-11/msg00031.html
[2] https://lists.gnu.org/archive/html/bug-gnulib/2017-11/msg00035.html


I'm therefore marking this as a "wishlist" item (but keeping it open, 
for future improvements).

regards,
  - assaf

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.