GNU bug report logs - #27353
25.2; rmail corrupts encoded message if you edit headers

Previous Next

Package: emacs;

Reported by: Ken Olum <kdo <at> cosmos.phy.tufts.edu>

Date: Tue, 13 Jun 2017 23:47:02 UTC

Severity: normal

Found in version 25.2

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27353 in the body.
You can then email your comments to 27353 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#27353; Package emacs. (Tue, 13 Jun 2017 23:47:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ken Olum <kdo <at> cosmos.phy.tufts.edu>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 13 Jun 2017 23:47:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ken Olum <kdo <at> cosmos.phy.tufts.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.2; rmail corrupts encoded message if you edit headers
Date: Tue, 13 Jun 2017 19:45:54 -0400
If you use rmail edit to change any header in an message with nontrivial
transfer encoding, parts of the header will get encoded, not just the
body.  The problem is that the reencoding system in rmail-cease-edit
uses (point), but the previous call to rmail-edit-update-headers changes
(point), unless no headers are modified.

Even if you don't yourself modify any headers, bug#26918 can cause there
to be a new content-type header, triggering this problem.

I'll send a patch to fix this bug and #26918.

                                        Ken

In GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw scroll bars)
 of 2017-06-08 built on cosmos
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description:	Ubuntu 14.04.5 LTS

Configured features:
XPM JPEG TIFF GIF PNG SOUND NOTIFY LIBXML2 FREETYPE XFT ZLIB
TOOLKIT_SCROLL_BARS LUCID X11

Important settings:
  value of $LC_ALL: C
  value of $LANG: en_US.UTF-8
  locale-coding-system: nil

Major mode: Lisp Interaction

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent messages:
Loading /home/kdo/emacs-init.el (source)...done
Loading /home/kdo/emacs-init-mail.el (source)...done
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug sendmail advice rmailmm message dired
format-spec rfc822 mml mml-sec password-cache epg epg-config gnus-util
mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader mail-parse
rfc2231 rmail rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode
mail-prsvr mail-utils shell pcomplete diff-mode easy-mmode thingatpt
browse-url math derived inf-lisp easymenu comint ansi-color ring
warnings cl-macs cl gv cl-loaddefs pcase cl-lib time-date mule-util
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote inotify dynamic-setting
font-render-setting x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 105422 9891)
 (symbols 48 21581 3)
 (miscs 40 64 121)
 (strings 32 20808 4178)
 (string-bytes 1 588741)
 (vectors 16 14339)
 (vector-slots 8 453622 3906)
 (floats 8 173 8)
 (intervals 56 203 135)
 (buffers 976 18)
 (heap 1024 41469 1008))




Added indication that bug 27353 blocks24655 Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 14 Jun 2017 16:30:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#27353; Package emacs. (Mon, 19 Jun 2017 18:41:02 GMT) Full text and rfc822 format available.

Message #10 received at 27353 <at> debbugs.gnu.org (full text, mbox):

From: Ken Olum <kdo <at> cosmos.phy.tufts.edu>
To: 26918 <at> debbugs.gnu.org, 27353 <at> debbugs.gnu.org
Subject: rmail-cease-edit patches for bugs 26918 and 27353
Date: Mon, 19 Jun 2017 14:40:24 -0400
[Message part 1 (text/plain, inline)]
Here is a patch to fix rmail editing problems associated with the
content-type header and reapplying the transfer-encoding to edited
messages.

                                        Ken

* lisp/mail/rmailedit.el (rmail-cease-edit): 
If no content-type in edited headers, look for one in original
headers and add it to edited headers (Bug #26918).
Marker to track start of new body, so that content-transfer-encoding
gets applied only to body (Bug #27353).
Ensure blank line at end of message after encoding, not before.

[rmailedit.patch (text/x-diff, attachment)]

Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Fri, 08 Sep 2017 09:12:03 GMT) Full text and rfc822 format available.

Notification sent to Ken Olum <kdo <at> cosmos.phy.tufts.edu>:
bug acknowledged by developer. (Fri, 08 Sep 2017 09:12:03 GMT) Full text and rfc822 format available.

Message #15 received at 27353-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Olum <kdo <at> cosmos.phy.tufts.edu>
Cc: 26918-done <at> debbugs.gnu.org, 27353-done <at> debbugs.gnu.org
Subject: Re: rmail-cease-edit patches for bugs 26918 and 27353
Date: Fri, 08 Sep 2017 12:11:22 +0300
> From: Ken Olum <kdo <at> cosmos.phy.tufts.edu>
> Date: Mon, 19 Jun 2017 14:40:24 -0400
> 
> Here is a patch to fix rmail editing problems associated with the
> content-type header and reapplying the transfer-encoding to edited
> messages.

Thanks, pushed to master.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 06 Oct 2017 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 6 years and 175 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.