GNU bug report logs - #27377
[PATCH] gnu: Add f-seq.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27377 in the body.
You can then email your comments to 27377 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
To: <guix-patches <at> gnu.org>
Cc: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
Subject: [PATCH] gnu: Add f-seq.
Date: Thu, 15 Jun 2017 17:26:24 +0200

* gnu/packages/bioinformatics.scm (f-seq): New variable.
---
 gnu/packages/bioinformatics.scm | 50 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index c1c0faf24..4c81f0741 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -9655,3 +9655,53 @@ browser.")
     (license (license:non-copyleft
               "http://genome.ucsc.edu/license/"
               "The contents of this package are free for all uses."))))
+
+(define-public f-seq
+  (let ((commit "6ccded34cff38cf432deed8503648b4a66953f9b")
+        (revision "1"))
+    (package
+      (name "f-seq")
+      (version (string-append "1.1-" revision "." commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/aboyle/F-seq.git")
+                      (commit commit)))
+                (file-name (string-append name "-" version))
+                (sha256
+                 (base32
+                  "1nk33k0yajg2id4g59bc4szr58r2q6pdq42vgcw054m8ip9wv26h"))
+                (modules '((guix build utils)))
+                ;; Remove bundled Java library archives.
+                (snippet
+                 '(begin
+                    (for-each delete-file (find-files "lib" ".*"))
+                    #t))))
+      (build-system ant-build-system)
+      (arguments
+       `(#:tests? #f ; no tests included
+         #:phases
+         (modify-phases %standard-phases
+           (replace 'install
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let* ((target (assoc-ref outputs "out"))
+                      (doc (string-append target "/share/doc/f-seq/")))
+                 (mkdir-p target)
+                 (mkdir-p doc)
+                 (substitute* "bin/linux/fseq"
+                   (("java") (which "java")))
+                 (install-file "README.txt" doc)
+                 (install-file "bin/linux/fseq" (string-append target "/bin"))
+                 (install-file "build~/fseq.jar" (string-append target "/lib"))
+                 (copy-recursively "lib" (string-append target "/lib"))
+                 #t))))))
+      (inputs
+       `(("perl" ,perl)
+         ("java-commons-cli" ,java-commons-cli)))
+      (home-page "http://fureylab.web.unc.edu/software/fseq/")
+      (synopsis "Feature density estimator for high-throughput sequence tags")
+      (description
+       "F-Seq is a software package that generates a continuous tag sequence
+density estimation allowing identification of biologically meaningful sites
+whose output can be displayed directly in the UCSC Genome Browser.")
+      (license license:gpl3+))))
-- 
2.13.0

Message #8 received at 27377 <at> debbugs.gnu.org (full text, mbox):

From: Ben Woodcroft <b.woodcroft <at> uq.edu.au>
To: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>, 27377 <at> debbugs.gnu.org
Subject: Re: [bug#27377] [PATCH] gnu: Add f-seq.
Date: Sat, 17 Jun 2017 13:31:55 +1000

Hi Ricardo,


On 16/06/17 01:26, Ricardo Wurmus wrote:
> * gnu/packages/bioinformatics.scm (f-seq): New variable.
> [..]
> +      (synopsis "Feature density estimator for high-throughput sequence tags")
> +      (description
> +       "F-Seq is a software package that generates a continuous tag sequence
> +density estimation allowing identification of biologically meaningful sites
> +whose output can be displayed directly in the UCSC Genome Browser.")
"features" is a little vague for me. How about something like this

"F-Seq is a software package that generates a continuous tag sequence
density estimation allowing identification of biologically meaningful sites such as transcription factor binding sites (ChIP-seq) or regions of open chromatin (DNase-seq). Output can be displayed directly in the UCSC Genome Browser."


I also had some problems running this software in a container:

[env]# fseq
/gnu/store/xjfxqh6rp4y4jwr4smwbvjqnikjbivai-profile/bin/fseq: line 30: 
sed: command not found
/gnu/store/xjfxqh6rp4y4jwr4smwbvjqnikjbivai-profile/bin/fseq: line 32: 
sed: command not found
/gnu/store/xjfxqh6rp4y4jwr4smwbvjqnikjbivai-profile/bin/fseq: line 30: 
sed: command not found
/gnu/store/xjfxqh6rp4y4jwr4smwbvjqnikjbivai-profile/bin/fseq: line 32: 
sed: command not found
/gnu/store/xjfxqh6rp4y4jwr4smwbvjqnikjbivai-profile/bin/fseq: line 62: 
dirname: command not found
Error: Could not find or load main class edu.duke.igsp.gkde.Main

(exitstatus 1)


Given that the exitstatus of the above is non-zero, what about adding a 
cheap and cheerful test phase which simply runs "fseq -h" or similar?

Otherwise LGTM.

ben

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.