GNU bug report logs - #2739
diff-mode should highlight "diff:" messages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2739 in the body.
You can then email your comments to 2739 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: jidanni <at> jidanni.org
To: bug-gnu-emacs <at> gnu.org
Subject: diff-mode should highlight "diff:" messages
Date: Sun, 22 Mar 2009 01:46:34 +0800

Diff mode likes highlighting things.
Well, it should extra-highlight important lines that start with
"diff:":


diff -U0 /home/jidanni /cf/tojidanni1/source
diff: /home/jidanni/source: No such file or directory

Diff finished.  Sun Mar 22 01:42:11 2009

(And it should detect the error, probably already done in your source code.)

Message #10 received at 2739 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: jidanni <at> jidanni.org
Cc: 2739 <at> debbugs.gnu.org
Subject: Re: bug#2739: diff-mode should highlight "diff:" messages
Date: Thu, 20 Aug 2020 20:55:51 +0200

jidanni <at> jidanni.org writes:

> Diff mode likes highlighting things.
> Well, it should extra-highlight important lines that start with
> "diff:":
>
> diff -U0 /home/jidanni /cf/tojidanni1/source
> diff: /home/jidanni/source: No such file or directory
>
> Diff finished.  Sun Mar 22 01:42:11 2009
>
> (And it should detect the error, probably already done in your source code.)

Do you have a test case to reproduce this bug?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 2739 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 2739 <at> debbugs.gnu.org
Subject: Re: bug#2739: diff-mode should highlight "diff:" messages
Date: Fri, 21 Aug 2020 21:34:09 +0800

>>>>> "LI" == Lars Ingebrigtsen <larsi <at> gnus.org> writes:
LI> jidanni <at> jidanni.org writes:

>> Diff mode likes highlighting things.
>> Well, it should extra-highlight important lines that start with
>> "diff:":
>> 
>> diff -U0 /home/jidanni /cf/tojidanni1/source
>> diff: /home/jidanni/source: No such file or directory
>> 
>> Diff finished.  Sun Mar 22 01:42:11 2009
>> 
>> (And it should detect the error, probably already done in your source code.)

LI> Do you have a test case to reproduce this bug?

  lrwxrwxrwx   1 jidanni         4 08-21 21:31 pppp -> zzzz
  lrwxrwxrwx   1 jidanni         4 08-21 21:30 yyyyy -> ssss

= runs the command dired-diff (found in dired-mode-map)

diff -U0 /home/jidanni/pppp /home/jidanni/yyyyy
diff: /home/jidanni/pppp: No such file or directory
diff: /home/jidanni/yyyyy: No such file or directory

Diff finished (diff error).  Fri Aug 21 21:31:28 2020


So the errors should be in red.

And in the modeline something should indicate an error.

Message #18 received at 2739 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 2739 <at> debbugs.gnu.org
Subject: Re: bug#2739: diff-mode should highlight "diff:" messages
Date: Fri, 21 Aug 2020 15:46:00 +0200

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> LI> Do you have a test case to reproduce this bug?
>
>   lrwxrwxrwx   1 jidanni         4 08-21 21:31 pppp -> zzzz
>   lrwxrwxrwx   1 jidanni         4 08-21 21:30 yyyyy -> ssss
>
> = runs the command dired-diff (found in dired-mode-map)
>
> diff -U0 /home/jidanni/pppp /home/jidanni/yyyyy
> diff: /home/jidanni/pppp: No such file or directory
> diff: /home/jidanni/yyyyy: No such file or directory
>
> Diff finished (diff error).  Fri Aug 21 21:31:28 2020
>
> So the errors should be in red.

Thanks.  The base function called here is apparently:

(diff "/tmp/unexist1" "/tmp/unexist2" "-u")

Which displays the problem.  It looks like diff picks up on it being an
error, but doesn't do any fontizing in this case.  Which I guess should
be set up from 'diff-sentinel'.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #21 received at 2739 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 2739 <at> debbugs.gnu.org
Subject: Re: bug#2739: diff-mode should highlight "diff:" messages
Date: Fri, 21 Aug 2020 15:59:37 +0200

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> So the errors should be in red.

I've now done this in Emacs 28.

> And in the modeline something should indicate an error.

Hm...  diff-mode doesn't mess around with the mode line normally, so I
think that would be surprising.  I think the red error lines is
sufficient here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #28 received at 2739 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 2739 <at> debbugs.gnu.org
Subject: Re: bug#2739: diff-mode should highlight "diff:" messages
Date: Fri, 21 Aug 2020 22:30:22 +0800

>>>>> "LI" == Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>> And in the modeline something should indicate an error.

LI> Hm...  diff-mode doesn't mess around with the mode line normally, so I
LI> think that would be surprising.  I think the red error lines is
LI> sufficient here.

I was just thinking it could be like
(compile "false")

So there would be three states, no differences, found differences, and errors.

Message #31 received at 2739 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 2739 <at> debbugs.gnu.org
Subject: Re: bug#2739: diff-mode should highlight "diff:" messages
Date: Fri, 21 Aug 2020 17:35:49 +0200

On Aug 21 2020, 積丹尼 Dan Jacobson wrote:

>>>>>> "LI" == Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>>> And in the modeline something should indicate an error.
>
> LI> Hm...  diff-mode doesn't mess around with the mode line normally, so I
> LI> think that would be surprising.  I think the red error lines is
> LI> sufficient here.
>
> I was just thinking it could be like
> (compile "false")
>
> So there would be three states, no differences, found differences, and errors.

diff-mode is about highlighting the contents of a buffer, not about
producing it.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.