GNU bug report logs - #27454
C-S-g [keyboard-quit] doesn't work to get out of disabled command choice

Previous Next

Package: emacs;

Reported by: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>

Date: Fri, 23 Jun 2017 02:34:01 UTC

Severity: wishlist

Tags: notabug

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27454 in the body.
You can then email your comments to 27454 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#27454; Package emacs. (Fri, 23 Jun 2017 02:34:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 23 Jun 2017 02:34:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: C-S-g [keyboard-quit] doesn't work to get out of disabled command
 choice
Date: Fri, 23 Jun 2017 10:33:29 +0800
Please make
 C-S-g [keyboard-quit]
work just like
 C-g [keyboard-quit]
to get out of
 Please type y, n, ! or SPC (the space bar):
in case one's CAPS LOCK key gets stuck, etc.
Seen on
 You have typed e, invoking disabled command gnus-summary-edit-article.
 It is disabled because new users often find it confusing.
 Here’s the first part of its description:




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#27454; Package emacs. (Sun, 21 Jul 2019 15:49:02 GMT) Full text and rfc822 format available.

Message #8 received at 27454 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 27454 <at> debbugs.gnu.org
Subject: Re: bug#27454: C-S-g [keyboard-quit] doesn't work to get out of
 disabled command choice
Date: Sun, 21 Jul 2019 17:48:54 +0200
積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> Please make
>  C-S-g [keyboard-quit]
> work just like
>  C-g [keyboard-quit]
> to get out of
>  Please type y, n, ! or SPC (the space bar):
> in case one's CAPS LOCK key gets stuck, etc.
> Seen on
>  You have typed e, invoking disabled command gnus-summary-edit-article.

To reproduce:

emacs -Q
C-x n n

and then try using C-S-g to break out of it, and that doesn't work.

So I'm guessing that whatever does this translation normally doesn't
work in whatever disabled-command-function uses...

Oh, it's this:

       (while (progn (setq char (read-event))
		     (or (not (numberp char))
			 (not (memq (downcase char)
				    '(?! ?y ?n ?\s ?\C-g)))))
	 (ding)
	 (message "Please type y, n, ! or SPC (the space bar): "))))
 


Because normally C-S-g works the same as C-g (see below).  Should we
perhaps just add C-S-g to the events this function checks for?

---

C-g (translated from C-S-g) runs the command keyboard-quit (found in
global-map), which is an interactive compiled Lisp function in
‘simple.el’.

It is bound to C-g.

(keyboard-quit)

Signal a ‘quit’ condition.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#27454; Package emacs. (Sun, 21 Jul 2019 16:24:02 GMT) Full text and rfc822 format available.

Message #11 received at 27454 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 27454 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#27454: C-S-g [keyboard-quit] doesn't work to get out of
 disabled command choice
Date: Sun, 21 Jul 2019 19:22:54 +0300
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Sun, 21 Jul 2019 17:48:54 +0200
> Cc: 27454 <at> debbugs.gnu.org
> 
>        (while (progn (setq char (read-event))
> 		     (or (not (numberp char))
> 			 (not (memq (downcase char)
> 				    '(?! ?y ?n ?\s ?\C-g)))))
> 	 (ding)
> 	 (message "Please type y, n, ! or SPC (the space bar): "))))
>  
> 
> 
> Because normally C-S-g works the same as C-g (see below).  Should we
> perhaps just add C-S-g to the events this function checks for?

But C-S-g is not a character.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#27454; Package emacs. (Sun, 21 Jul 2019 17:23:02 GMT) Full text and rfc822 format available.

Message #14 received at 27454 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 27454 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#27454: C-S-g [keyboard-quit] doesn't work to get out of
 disabled command choice
Date: Sun, 21 Jul 2019 19:22:28 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Lars Ingebrigtsen <larsi <at> gnus.org>
>> Date: Sun, 21 Jul 2019 17:48:54 +0200
>> Cc: 27454 <at> debbugs.gnu.org
>> 
>>        (while (progn (setq char (read-event))
>> 		     (or (not (numberp char))
>> 			 (not (memq (downcase char)
>> 				    '(?! ?y ?n ?\s ?\C-g)))))
>> 	 (ding)
>> 	 (message "Please type y, n, ! or SPC (the space bar): "))))
>>  
>> 
>> 
>> Because normally C-S-g works the same as C-g (see below).  Should we
>> perhaps just add C-S-g to the events this function checks for?
>
> But C-S-g is not a character.

But it's an event...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#27454; Package emacs. (Sun, 21 Jul 2019 17:54:01 GMT) Full text and rfc822 format available.

Message #17 received at 27454 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 27454 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#27454: C-S-g [keyboard-quit] doesn't work to get out of
 disabled command choice
Date: Sun, 21 Jul 2019 20:53:07 +0300
> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: jidanni <at> jidanni.org,  27454 <at> debbugs.gnu.org
> Date: Sun, 21 Jul 2019 19:22:28 +0200
> 
> >> Because normally C-S-g works the same as C-g (see below).  Should we
> >> perhaps just add C-S-g to the events this function checks for?
> >
> > But C-S-g is not a character.
> 
> But it's an event...

Sure, and we have many others that mean "get me out of here".
Probably should support more than just one extra.

Btw, if I leave CAPS LOCK stuck and type C-g, I do get Quit.  So I
don't think I understand the bug report.  You explicitly pressed C-S-g
in your recipe, but that's not really reasonable in my book -- the
user explicitly pressed Shift, a much less innocent mistake.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#27454; Package emacs. (Sun, 21 Jul 2019 18:18:02 GMT) Full text and rfc822 format available.

Message #20 received at 27454 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 27454 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#27454: C-S-g [keyboard-quit] doesn't work to get out of
 disabled command choice
Date: Sun, 21 Jul 2019 20:17:51 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

> Btw, if I leave CAPS LOCK stuck and type C-g, I do get Quit.  So I
> don't think I understand the bug report.  You explicitly pressed C-S-g
> in your recipe, but that's not really reasonable in my book -- the
> user explicitly pressed Shift, a much less innocent mistake.

Ah, right.  I have caps lock totally disabled, so I wasn't able to test
that bit.  Then I don't think there's anything here to fix, and I'm
closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) notabug. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 21 Jul 2019 18:19:01 GMT) Full text and rfc822 format available.

bug closed, send any further explanations to 27454 <at> debbugs.gnu.org and 積丹尼 Dan Jacobson <jidanni <at> jidanni.org> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 21 Jul 2019 18:19:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 19 Aug 2019 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 223 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.