GNU bug report logs - #27610
iimage mode patch

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27610 in the body.
You can then email your comments to 27610 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Döring, Arne Frederic Maria
 <arne.doering <at> rwth-aachen.de>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: iimage mode patch 
Date: Fri, 7 Jul 2017 17:58:48 +0000

[Message part 1 (text/plain, inline)]

`iimage-mode' binds C-l to `iimage-recenter' and this forwards to `recenter'. But the default function on C-l is `recenter-top-bottom', not `recenter'. I made iimage mode call `recenter-top-bottom' instead.

[Message part 2 (text/html, inline)]

[0001-made-iimage-mode-not-break-default-binding-of-C-l.patch (text/x-patch, attachment)]

Message #8 received at 27610 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Döring, Arne Frederic Maria
 <arne.doering <at> rwth-aachen.de>
Cc: 27610 <at> debbugs.gnu.org
Subject: Re: bug#27610: iimage mode patch
Date: Mon, 24 Jun 2019 18:25:17 +0200

"Döring," Arne Frederic Maria <arne.doering <at> rwth-aachen.de> writes:

> `iimage-mode' binds C-l to `iimage-recenter' and this forwards to `recenter'.
> But the default function on C-l is `recenter-top-bottom', not `recenter'. I
> made iimage mode call `recenter-top-bottom' instead.

Makes sense to call that function instead, yes.  But:

>  (defvar iimage-mode-map
>    (let ((map (make-sparse-keymap)))
> -    (define-key map "\C-l" 'iimage-recenter)
> +    (define-key map "\C-l" 'iimage-recenter-top-bottom)
>      map)
>    "Keymap used in `iimage-mode'.")

[...]

> +(defun iimage-recenter-top-bottom (&optional arg)
> +  "Re-draw images and call `recenter-top-bottom' with ARG."
> +  (interactive "P")
> +  (iimage-mode-buffer nil)
> +  (iimage-mode-buffer t)
> +  (recenter-top-bottom arg))

I don't think this is necessary -- instead iimage-recenter should just
call recenter-top-bottom.  I've now made this change on the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.