GNU bug report logs - #27690
[PATCH] build: Allow mounting of entire disks.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27690 in the body.
You can then email your comments to 27690 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH] build: Allow mounting of entire disks.
Date: Fri, 14 Jul 2017 10:32:15 +0200

* gnu/build/file-systems.scm (disk-partitions): Also return entire drives.
---
 gnu/build/file-systems.scm | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm
index b6930497d..462ed9b7f 100644
--- a/gnu/build/file-systems.scm
+++ b/gnu/build/file-systems.scm
@@ -377,11 +377,14 @@ not valid header was found."
     (string-ref str (- (string-length str) 1)))
 
   (define (partition? name major minor)
-    ;; Select device names that end in a digit, like libblkid's 'probe_all'
-    ;; function does.  Checking for "/sys/dev/block/MAJOR:MINOR/partition"
-    ;; doesn't work for partitions coming from mapped devices.
-    (and (char-set-contains? char-set:digit (last-character name))
-         (> major 2)))                      ;ignore RAM disks and floppy disks
+    ;; grub-mkrescue does some funny things for EFI support which
+    ;; makes it a lot more difficult than one would expect to support
+    ;; booting an ISO-9660 image from an USB flash drive.
+    ;; For example there's a buggy (too small) hidden partition in it
+    ;; which Linux rightfully refuses to mount.
+    ;; In any case, partition tables are supposed to be optional so
+    ;; here we allow checking entire disks for file systems, too.
+    (> major 2))                      ;ignore RAM disks and floppy disks
 
   (call-with-input-file "/proc/partitions"
     (lambda (port)

Message #8 received at 27690 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 27690 <at> debbugs.gnu.org
Subject: Re: [bug#27690] [PATCH] build: Allow mounting of entire disks.
Date: Mon, 17 Jul 2017 11:28:25 +0200

Hello,

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> * gnu/build/file-systems.scm (disk-partitions): Also return entire drives.

In the subject line, please write “file-systems:” instead of “build:”
(the latter is for Makefile and configury.)

> --- a/gnu/build/file-systems.scm
> +++ b/gnu/build/file-systems.scm
> @@ -377,11 +377,14 @@ not valid header was found."
>      (string-ref str (- (string-length str) 1)))
>  
>    (define (partition? name major minor)
> -    ;; Select device names that end in a digit, like libblkid's 'probe_all'
> -    ;; function does.  Checking for "/sys/dev/block/MAJOR:MINOR/partition"
> -    ;; doesn't work for partitions coming from mapped devices.
> -    (and (char-set-contains? char-set:digit (last-character name))
> -         (> major 2)))                      ;ignore RAM disks and floppy disks
> +    ;; grub-mkrescue does some funny things for EFI support which
> +    ;; makes it a lot more difficult than one would expect to support
> +    ;; booting an ISO-9660 image from an USB flash drive.
> +    ;; For example there's a buggy (too small) hidden partition in it
> +    ;; which Linux rightfully refuses to mount.
> +    ;; In any case, partition tables are supposed to be optional so
> +    ;; here we allow checking entire disks for file systems, too.
> +    (> major 2))                      ;ignore RAM disks and floppy disks

I think you can remove ‘last-character’ and keep the comment about
/sys/dev/block.

Have you tested that this doesn’t cause any problems on actual hardware,
like matching things that should really be skipped, and then causing
failures down the road in label/UUID code?

Also, it seems that we’d be departing from what libblkid is doing, per
the comment above.  To me that raises a flag, though if we really need
it that’s fine of course.

Thoughts?  :-)

Thanks,
Ludo’.

Message #13 received at 27690-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 27690-done <at> debbugs.gnu.org
Subject: Re: [bug#27690] [PATCH] build: Allow mounting of entire disks.
Date: Tue, 05 Sep 2017 15:22:12 +0200

This was pushed as 9833bcfc08ef009b9e8b4398baa481ef65c80ad7, closing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.