GNU logs - #27709, boring messages

Message sent to bug-parted@HIDDEN:

Subject: bug#27709: parted does not produce Protective MBR for GPT correctly
Resent-From: Pali =?UTF-8?Q?Roh=C3=A1r?= <pali.rohar@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-parted@HIDDEN
Resent-Date: Sat, 15 Jul 2017 16:43:02 +0000
Resent-Message-ID: <handler.27709.B.150013695529199 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 27709 <at> debbugs.gnu.org
From: Pali =?UTF-8?Q?Roh=C3=A1r?= <pali.rohar@HIDDEN>
Date: Sat, 15 Jul 2017 13:51:04 +0200
User-Agent: KMail/1.13.7 (Linux/3.13.0-117-generic; KDE/4.14.2; x86_64; ; )
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart3115318.89ddLv08ky";
 protocol="application/pgp-signature"; micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <201707151351.04473@pali>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--nextPart3115318.89ddLv08ky
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Bug report originally reported to gparted:
https://bugzilla.gnome.org/show_bug.cgi?id=3D784976

But from second comment it appears that real problem is in parted,
because gparted only used parted. See:

# truncate -s 10G /tmp/gpt
# parted /tmp/gpt
GNU Parted 3.2
Using /tmp/gpt
Welcome to GNU Parted! Type 'help' to view a list of commands.
(parted) mklabel gpt                                                     =20
Warning: The existing disk label on /tmp/gpt will be destroyed and all data=
 on
this disk
will be lost. Do you want to continue?
Yes/No? yes                                                              =20
(parted) quit                                                            =20
# dd if=3D/tmp/gpt bs=3D1 count=3D16 skip=3D446 2>/dev/null | xxd
00000000: 0000 0100 eefe ffff 0100 0000 ffff 3f01  ..............?.

Original bug report:

According to _UEFI Specification 2.6_, section _5 GUID Partition Table (GPT)
Disk Layout_, subsection _5.2.3 Protective MBR_, Table 17. _Protective MBR
Partition Record protecting the entire disk_, **StartingCHS** is 0x000200
(**0/0/2**) and **EndingCHS** is 0xFFFFFF (**1023/255/63**) if it is not
possible to represent last logical block as C-H-S.

But When creating new GPT partition table via gparted StartingCHS is 0/0/1 =
and
EndingCHS is 1023/254/63 which is incorrect.

Please make gparted compliant to UEFI/GPT specification.

Test to reprocude:
$ truncate -s 10G /tmp/gpt
$ sudo ./src/gpartedbin /tmp/gpt
(now create new GPT partition table in menu and exit)
$ dd if=3D/tmp/gpt bs=3D1 count=3D16 skip=3D446 2>/dev/null | xxd
0000000: 0000 0100 eefe ffff 0100 0000 ffff 3f01  ..............?.

StartingCHS is 0x000100 (1st byte - 4th byte) which means 0/0/1
EndingCHS is 0xfeffff (5th byte - 8th byte) which means 1023/254/63

When creating new gpt partition table with gdisk, Protective MBR is filled
correctly:
$ truncate -s 10G /tmp/gpt2
$ printf "o\ny\nw\ny" | gdisk /tmp/gpt2
$ dd if=3D/tmp/gpt2 bs=3D1 count=3D16 skip=3D446 2>/dev/null | xxd
0000000: 0000 0200 eeff ffff 0100 0000 ffff 3f01  ..............?.

StartingCHS is 0x000200 (1st byte - 4th byte) which means 0/0/2
EndingCHS is 0xffffff (5th byte - 8th byte) which means 1023/255/63

Btw, same problem had fdisk from util-linux...
https://github.com/karelzak/util-linux/issues/485

=2D-=20
Pali Roh=C3=A1r
pali.rohar@HIDDEN

--nextPart3115318.89ddLv08ky
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEABECAAYFAllqAagACgkQi/DJPQPkQ1IR5wCdEjdHdoIJBLZI01Ov5RkZjqAU
D3QAoMp+odI0shQFQLjMmpQLcwZRNCPv
=aUUS
-----END PGP SIGNATURE-----

--nextPart3115318.89ddLv08ky--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Pali =?UTF-8?Q?Roh=C3=A1r?= <pali.rohar@HIDDEN>
Subject: bug#27709: Acknowledgement (parted does not produce Protective
 MBR for GPT correctly)
Message-ID: <handler.27709.B.150013695529199.ack <at> debbugs.gnu.org>
References: <201707151351.04473@pali>
X-Gnu-PR-Message: ack 27709
X-Gnu-PR-Package: parted
Reply-To: 27709 <at> debbugs.gnu.org
Date: Sat, 15 Jul 2017 16:43:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-parted@HIDDEN

If you wish to submit further information on this problem, please
send it to 27709 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
27709: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D27709
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-parted@HIDDEN:

Subject: bug#27709: parted does not produce Protective MBR for GPT correctly
Resent-From: Pali =?UTF-8?Q?Roh=C3=A1r?= <pali.rohar@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-parted@HIDDEN
Resent-Date: Mon, 13 Aug 2018 20:05:02 +0000
Resent-Message-ID: <handler.27709.B27709.153419064820216 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 27709 <at> debbugs.gnu.org
Date: Mon, 13 Aug 2018 21:52:50 +0200
From: Pali =?UTF-8?Q?Roh=C3=A1r?= <pali.rohar@HIDDEN>
Message-ID: <20180813195250.numsyzbgmbkppwnj@pali>
References: <201707151351.04473@pali>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="y64jfa3l67ij7ggt"
Content-Disposition: inline
In-Reply-To: <201707151351.04473@pali>
User-Agent: NeoMutt/20170113 (1.7.2)
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


--y64jfa3l67ij7ggt
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Saturday 15 July 2017 13:51:04 Pali Roh=C3=A1r wrote:
> Bug report originally reported to gparted:
> https://bugzilla.gnome.org/show_bug.cgi?id=3D784976
>=20
> But from second comment it appears that real problem is in parted,
> because gparted only used parted. See:
>=20
> # truncate -s 10G /tmp/gpt
> # parted /tmp/gpt
> GNU Parted 3.2
> Using /tmp/gpt
> Welcome to GNU Parted! Type 'help' to view a list of commands.
> (parted) mklabel gpt                                                     =
=20
> Warning: The existing disk label on /tmp/gpt will be destroyed and all da=
ta on
> this disk
> will be lost. Do you want to continue?
> Yes/No? yes                                                              =
=20
> (parted) quit                                                            =
=20
> # dd if=3D/tmp/gpt bs=3D1 count=3D16 skip=3D446 2>/dev/null | xxd
> 00000000: 0000 0100 eefe ffff 0100 0000 ffff 3f01  ..............?.
>=20
> Original bug report:
>=20
> According to _UEFI Specification 2.6_, section _5 GUID Partition Table (G=
PT)
> Disk Layout_, subsection _5.2.3 Protective MBR_, Table 17. _Protective MBR
> Partition Record protecting the entire disk_, **StartingCHS** is 0x000200
> (**0/0/2**) and **EndingCHS** is 0xFFFFFF (**1023/255/63**) if it is not
> possible to represent last logical block as C-H-S.
>=20
> But When creating new GPT partition table via gparted StartingCHS is 0/0/=
1 and
> EndingCHS is 1023/254/63 which is incorrect.
>=20
> Please make gparted compliant to UEFI/GPT specification.
>=20
> Test to reprocude:
> $ truncate -s 10G /tmp/gpt
> $ sudo ./src/gpartedbin /tmp/gpt
> (now create new GPT partition table in menu and exit)
> $ dd if=3D/tmp/gpt bs=3D1 count=3D16 skip=3D446 2>/dev/null | xxd
> 0000000: 0000 0100 eefe ffff 0100 0000 ffff 3f01  ..............?.
>=20
> StartingCHS is 0x000100 (1st byte - 4th byte) which means 0/0/1
> EndingCHS is 0xfeffff (5th byte - 8th byte) which means 1023/254/63
>=20
> When creating new gpt partition table with gdisk, Protective MBR is filled
> correctly:
> $ truncate -s 10G /tmp/gpt2
> $ printf "o\ny\nw\ny" | gdisk /tmp/gpt2
> $ dd if=3D/tmp/gpt2 bs=3D1 count=3D16 skip=3D446 2>/dev/null | xxd
> 0000000: 0000 0200 eeff ffff 0100 0000 ffff 3f01  ..............?.
>=20
> StartingCHS is 0x000200 (1st byte - 4th byte) which means 0/0/2
> EndingCHS is 0xffffff (5th byte - 8th byte) which means 1023/255/63
>=20
> Btw, same problem had fdisk from util-linux...
> https://github.com/karelzak/util-linux/issues/485

It looks like that problem with StartingCHS was fixed in commit:
http://git.savannah.gnu.org/cgit/parted.git/commit/?id=3Ddf6770d213b6032042=
6a3ee0bed118d063b40fc5

But problem with EndingCHS is not fixed yet. Below is a patch which fix
also EndingCHS, to be set to 0xFFFFFF value as required by UEFI Specificati=
on.

diff --git a/libparted/labels/gpt.c b/libparted/labels/gpt.c
index 4f922b2..6f92a34 100644
--- a/libparted/labels/gpt.c
+++ b/libparted/labels/gpt.c
@@ -1144,7 +1144,7 @@ _write_pmbr (PedDevice *dev, bool pmbr_boot)
   pmbr->Signature =3D PED_CPU_TO_LE16 (MSDOS_MBR_SIGNATURE);
   pmbr->PartitionRecord[0].OSType =3D EFI_PMBR_OSTYPE_EFI;
   pmbr->PartitionRecord[0].StartSector =3D 2;
-  pmbr->PartitionRecord[0].EndHead =3D 0xFE;
+  pmbr->PartitionRecord[0].EndHead =3D 0xFF;
   pmbr->PartitionRecord[0].EndSector =3D 0xFF;
   pmbr->PartitionRecord[0].EndTrack =3D 0xFF;
   pmbr->PartitionRecord[0].StartingLBA =3D PED_CPU_TO_LE32 (1);

--=20
Pali Roh=C3=A1r
pali.rohar@HIDDEN

--y64jfa3l67ij7ggt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQS4VrIQdKium2krgIWL8Mk9A+RDUgUCW3HhjwAKCRCL8Mk9A+RD
Uv3/AJ9BAG3GCN3neXuKwR/tOfIprx1xJACgoTN0irasiSiVdgSlT2LWXU131OI=
=HWVZ
-----END PGP SIGNATURE-----

--y64jfa3l67ij7ggt--

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.