GNU bug report logs - #27717
other-window when there is no other window

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27717 in the body.
You can then email your comments to 27717 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <at> gnu.org
Subject: other-window when there is no other window
Date: Sun, 16 Jul 2017 03:48:49 +0800

C-x o runs the command other-window.

Alas, if there is no other window, it does nothing.

It doesn't even print a message "no other window". BUG!

Better yet in this case would be just switch to an other buffer (the
same buffer that switch-to-buffer asks the user about, but without
asking the user.)

And only if there is also no other buffer, then print the message.

Message #8 received at 27717 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>, 
 27717 <at> debbugs.gnu.org
Subject: Re: bug#27717: other-window when there is no other window
Date: Sun, 16 Jul 2017 10:28:24 +0200

> C-x o runs the command other-window.
>
> Alas, if there is no other window, it does nothing.
>
> It doesn't even print a message "no other window". BUG!
>
> Better yet in this case would be just switch to an other buffer (the
> same buffer that switch-to-buffer asks the user about, but without
> asking the user.)
>
> And only if there is also no other buffer, then print the message.

The documentation of ‘other-window’ contains the sentence "COUNT zero
means do not skip any window, so select the selected window."  which
clearly indicates that "doing nothing" is a valid action in this case.
C-x 5 o behaves in a similar way.

Admittedly, saying that ‘other-window’ does "Select another window in
cyclic ordering of windows." is misleading.

martin

Message #11 received at 27717 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 27717 <at> debbugs.gnu.org
Subject: Re: bug#27717: other-window when there is no other window
Date: Sun, 16 Jul 2017 23:13:33 +0800

>>>>> "mr" == martin rudalics <rudalics <at> gmx.at> writes:

mr> The documentation of ‘other-window’ contains the sentence "COUNT zero
mr> means do not skip any window, so select the selected window."  which
mr> clearly indicates that "doing nothing" is a valid action in this case.

"In an interactive call, COUNT is the numeric prefix argument."

All I know is the user did C-x o, not C-u 0 C-x o.

So I would hope the program would distinguish the two.

Message #14 received at 27717 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: rudalics <at> gmx.at, 27717 <at> debbugs.gnu.org
Subject: Re: bug#27717: other-window when there is no other window
Date: Sun, 16 Jul 2017 19:04:23 +0300

> From: 積丹尼 Dan Jacobson
> 	<jidanni <at> jidanni.org>
> Date: Sun, 16 Jul 2017 23:13:33 +0800
> Cc: 27717 <at> debbugs.gnu.org
> 
> "In an interactive call, COUNT is the numeric prefix argument."
> 
> All I know is the user did C-x o, not C-u 0 C-x o.
> 
> So I would hope the program would distinguish the two.

If your ring has exactly one slot, then going to the next will end up
right where you started.  There's nothing odd about that, and no
special reason to signal an error or output a message.  You can
instantly know what happened without any message.

Message #17 received at 27717 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rudalics <at> gmx.at, 27717 <at> debbugs.gnu.org
Subject: Re: bug#27717: other-window when there is no other window
Date: Mon, 17 Jul 2017 00:11:41 +0800

>>>>> "EZ" == Eli Zaretskii <eliz <at> gnu.org> writes:

EZ> If your ring has exactly one slot, then going to the next will end up
EZ> right where you started.  There's nothing odd about that, and no
EZ> special reason to signal an error or output a message.  You can
EZ> instantly know what happened without any message.

OK then don't print a message. But I hope you will implement my ideas
when the ring has more than one slot.

Message #20 received at 27717 <at> debbugs.gnu.org (full text, mbox):

From: Marcin Borkowski <mbork <at> mbork.pl>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 27717 <at> debbugs.gnu.org
Subject: Re: bug#27717: other-window when there is no other window
Date: Sun, 16 Jul 2017 21:13:44 +0200

On 2017-07-15, at 21:48, 積丹尼 Dan Jacobson <jidanni <at> jidanni.org> wrote:

> C-x o runs the command other-window.
>
> Alas, if there is no other window, it does nothing.
>
> It doesn't even print a message "no other window". BUG!
>
> Better yet in this case would be just switch to an other buffer (the
> same buffer that switch-to-buffer asks the user about, but without
> asking the user.)
>
> And only if there is also no other buffer, then print the message.

How about this

http://mbork.pl/2017-02-26_other-window-or-switch-buffer

and that

http://mbork.pl/2017-06-12_smart-next-window-or-buffer

?

Best,

-- 
Marcin Borkowski

Message #23 received at 27717 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: Marcin Borkowski <mbork <at> mbork.pl>
Cc: 27717 <at> debbugs.gnu.org
Subject: Re: bug#27717: other-window when there is no other window
Date: Mon, 17 Jul 2017 07:31:58 +0800

>>>>> "MB" == Marcin Borkowski <mbork <at> mbork.pl> writes:

MB> How about this

MB> http://mbork.pl/2017-02-26_other-window-or-switch-buffer

Something's wrong.

I tried to modify this from your blog post,

(defun other-window-or-switch-buffer ()
  "Call `other-window' if more than one window is visible, switch
to next buffer otherwise."
  (interactive)
  (if (one-window-p)
	  (switch-to-buffer nil)
	(other-window 1)))
(global-set-key "\C-xb" #'other-window-or-switch-buffer)

but there is something wrong with the ASCII or something.

Message #26 received at 27717 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>, 
 Marcin Borkowski <mbork <at> mbork.pl>
Cc: 27717 <at> debbugs.gnu.org
Subject: Re: bug#27717: other-window when there is no other window
Date: Mon, 17 Jul 2017 09:03:18 +0200

> (global-set-key "\C-xb" #'other-window-or-switch-buffer)
>
> but there is something wrong with the ASCII or something.

Try adding a space to get "\C-x b".

martin

Message #29 received at 27717 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Marcin Borkowski <mbork <at> mbork.pl>, 27717 <at> debbugs.gnu.org
Subject: Re: bug#27717: other-window when there is no other window
Date: Mon, 17 Jul 2017 16:18:52 +0800

OK. I think this would be a great redefinition of C-x o:

(defun other-window-or-switch-buffer ()
  "Call `other-window' if more than one window is visible, switch
to next buffer otherwise."
  (interactive)
  (if (one-window-p)
	  (switch-to-buffer nil)
	(other-window 1)))
(global-set-key (kbd "C-x o") 'other-window-or-switch-buffer)

(I don't use frames. So don't know much about that part.)

Message #32 received at 27717 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 27717 <at> debbugs.gnu.org
Subject: Re: bug#27717: other-window when there is no other window
Date: Sat, 17 Aug 2019 16:37:46 -0700

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> C-x o runs the command other-window.
>
> Alas, if there is no other window, it does nothing.
>
> It doesn't even print a message "no other window". BUG!

This has been fixed on the trunk now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.