GNU bug report logs - #27726
26.0.50; plist functions give confusing errors on invalid plists

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27726 in the body.
You can then email your comments to 27726 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; plist functions give confusing errors on invalid plists
Date: Sun, 16 Jul 2017 21:50:27 +0200

(plist-put '(:foo 1 :bar) :zot 2)

Debugger entered--Lisp error: (wrong-type-argument listp (:foo 1 :bar))
  plist-put((:foo 1 :bar) :zot 2)
  eval((plist-put '(:foo 1 :bar) :zot 2) nil)
  elisp--eval-last-sexp(nil)
  eval-last-sexp(nil)
  funcall-interactively(eval-last-sexp nil)
  call-interactively(eval-last-sexp nil nil)
  command-execute(eval-last-sexp)

The error seems to say that '(:foo 1 :bar) isn't a list.  But the
problem is that it's not a valid plist, since it has an odd number of
elements.

So I think there should be a different error being signalled here.  (And
there isn't really a backwards compatibility issue here of introducing a
new error symbol: Emacs 26.1 started signalling errors for these lists;
previously it was fine having odd plists.)


In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
 of 2017-07-16 built on mouse
Repository revision: 45892db6f53cccc045da9c7215b467617c067f04
Windowing system distributor 'The X.Org Foundation', version 11.0.11903000
System Description:	Ubuntu 17.04


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #10 received at 27726 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 27726 <at> debbugs.gnu.org
Subject: Re: 26.0.50; plist functions give confusing errors on invalid plists
Date: Sat, 02 Sep 2017 15:45:00 +0300

unblock 24655 by 27726
thanks

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Sun, 16 Jul 2017 21:50:27 +0200
> 
> 
> (plist-put '(:foo 1 :bar) :zot 2)
> 
> Debugger entered--Lisp error: (wrong-type-argument listp (:foo 1 :bar))
>   plist-put((:foo 1 :bar) :zot 2)
>   eval((plist-put '(:foo 1 :bar) :zot 2) nil)
>   elisp--eval-last-sexp(nil)
>   eval-last-sexp(nil)
>   funcall-interactively(eval-last-sexp nil)
>   call-interactively(eval-last-sexp nil nil)
>   command-execute(eval-last-sexp)
> 
> The error seems to say that '(:foo 1 :bar) isn't a list.  But the
> problem is that it's not a valid plist, since it has an odd number of
> elements.
> 
> So I think there should be a different error being signalled here.  (And
> there isn't really a backwards compatibility issue here of introducing a
> new error symbol: Emacs 26.1 started signalling errors for these lists;
> previously it was fine having odd plists.)

Would someone please look into this bug?

In any case, I don't see why this should block Emacs 26.1, so I'm
unblocking it.

Thanks.

Message #17 received at 27726-done <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 27726-done <at> debbugs.gnu.org
Subject: Re: bug#27726: 26.0.50; plist functions give confusing errors on
 invalid plists
Date: Sat, 02 Sep 2017 19:10:47 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> schrieb am Sa., 2. Sep. 2017 um 14:46 Uhr:

> unblock 24655 by 27726
> thanks
>
> > From: Lars Ingebrigtsen <larsi <at> gnus.org>
> > Date: Sun, 16 Jul 2017 21:50:27 +0200
> >
> >
> > (plist-put '(:foo 1 :bar) :zot 2)
> >
> > Debugger entered--Lisp error: (wrong-type-argument listp (:foo 1 :bar))
> >   plist-put((:foo 1 :bar) :zot 2)
> >   eval((plist-put '(:foo 1 :bar) :zot 2) nil)
> >   elisp--eval-last-sexp(nil)
> >   eval-last-sexp(nil)
> >   funcall-interactively(eval-last-sexp nil)
> >   call-interactively(eval-last-sexp nil nil)
> >   command-execute(eval-last-sexp)
> >
> > The error seems to say that '(:foo 1 :bar) isn't a list.  But the
> > problem is that it's not a valid plist, since it has an odd number of
> > elements.
> >
> > So I think there should be a different error being signalled here.  (And
> > there isn't really a backwards compatibility issue here of introducing a
> > new error symbol: Emacs 26.1 started signalling errors for these lists;
> > previously it was fine having odd plists.)
>
> Would someone please look into this bug?
>

I've installed commit  71766a45f1 to improve the message.

[Message part 2 (text/html, inline)]

Message #20 received at 27726 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: larsi <at> gnus.org, 27726 <at> debbugs.gnu.org
Subject: Re: bug#27726: 26.0.50; plist functions give confusing errors on
 invalid plists
Date: Sat, 02 Sep 2017 22:23:58 +0300

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Sat, 02 Sep 2017 19:10:47 +0000
> Cc: 27726-done <at> debbugs.gnu.org
> 
> I've installed commit 71766a45f1 to improve the message.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.