GNU bug report logs - #27763
egrep.sh: grep missing path

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27763 in the body.
You can then email your comments to 27763 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Santiago Ruano Rincón <santiagorr <at> riseup.net>
To: bug-grep <at> gnu.org
Cc: 863002 <at> bugs.debian.org
Subject: egrep.sh: grep missing path
Date: Wed, 19 Jul 2017 09:22:43 +0200

[Message part 1 (text/plain, inline)]

Control: tags -1 + patch

Hi,

As suggested by this user, it would be better if egrep/fgrep script
calls grep using its absolute path.

On Fri, 19 May 2017 22:04:44 +0100 john mullee <mullee.john <at> gmail.com> wrote:
> Package: grep
> Version: 2.20-4.1
> 
> cat /bin/egrep
>      #!/bin/sh
>      exec grep -E "$@"
> 
> should replace with
> 
>      exec /bin/grep -E "$@"
> 
> to reproduce:
> 
> root <at> debian-512mb-fra1-01:/opt/firewall# bash
> root <at> debian-512mb-fra1-01:/opt/firewall# PATH=/usr/local egrep "any" /etc/*
> bash: egrep: command not found

Please, consider the attached patch. 

Cheers,

Santiago

[0001-src-Makefile.am-egrep.sh-call-grep-using-its-absolut.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 27763 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Santiago Ruano Rincón <santiagorr <at> riseup.net>,
 27763 <at> debbugs.gnu.org
Cc: 863002 <at> bugs.debian.org
Subject: Re: bug#27763: egrep.sh: grep missing path
Date: Wed, 19 Jul 2017 02:56:24 -0700

Santiago Ruano Rincón wrote:

> As suggested by this user, it would be better if egrep/fgrep script
> calls grep using its absolute path.

Debian bug 863002 doesn't explain why it would be better, as the original bug 
report is evidently a case of misunderstanding how PATH works.

Although we used to do it the way you're suggesting, the current way is better 
for users who want to specify their own 'grep' command with their own option 
preferences, and to have these preferences also apply to 'egrep' and 'fgrep'. See:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=19998

Message #11 received at 27763 <at> debbugs.gnu.org (full text, mbox):

From: Santiago Ruano Rincón <santiagorr <at> riseup.net>
To: 27763 <at> debbugs.gnu.org, 863002 <at> bugs.debian.org
Subject: Re: bug#27763: egrep.sh: grep missing path
Date: Wed, 19 Jul 2017 14:05:54 +0200

El 19/07/17 a las 02:56, Paul Eggert escribió:
> Santiago Ruano Rincón wrote:
> 
> > As suggested by this user, it would be better if egrep/fgrep script
> > calls grep using its absolute path.
> 
> Debian bug 863002 doesn't explain why it would be better, as the original
> bug report is evidently a case of misunderstanding how PATH works.

The bug submitter sent me I private mail about that. I let him explain
it publicly answering to this mail.
For me, "it would be better" just because it makes egrep/fgrep call the
grep installed by the package. 

> Although we used to do it the way you're suggesting, the current way is
> better for users who want to specify their own 'grep' command with their own
> option preferences, and to have these preferences also apply to 'egrep' and
> 'fgrep'. See:
> 
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=19998

That makes sense.

Thanks for your answer,

Santiago

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.