GNU bug report logs - #27773
[PATCH] Allow to override build date

Previous Next

Package: automake;

Reported by: "Bernhard M. Wiedemann" <bwiedemann <at> suse.de>

Date: Thu, 20 Jul 2017 15:05:02 UTC

Severity: normal

Tags: fixed, patch

Done: Mathieu Lirzin <mthl <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27773 in the body.
You can then email your comments to 27773 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-automake <at> gnu.org:
bug#27773; Package automake. (Thu, 20 Jul 2017 15:05:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Bernhard M. Wiedemann" <bwiedemann <at> suse.de>:
New bug report received and forwarded. Copy sent to bug-automake <at> gnu.org. (Thu, 20 Jul 2017 15:05:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Bernhard M. Wiedemann" <bwiedemann <at> suse.de>
To: bug-automake <at> gnu.org
Cc: "Bernhard M. Wiedemann" <bwiedemann <at> suse.de>
Subject: [PATCH] Allow to override build date
Date: Thu, 20 Jul 2017 15:21:36 +0200
and use gmtime to not be influenced by timezone settings
in order to make builds reproducible.

While working on the reproducible builds effort, I found that
when building the automake package for openSUSE Linux,
there were slight differences between each build

See https://reproducible-builds.org/ for why this is matters
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
---
 doc/help2man | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/help2man b/doc/help2man
index e651b8d2d..4a9f75064 100755
--- a/doc/help2man
+++ b/doc/help2man
@@ -217,7 +217,7 @@ $version_text ||= get_option_value $ARGV[0], $version_option;
 # the English version expands to the month as a word and the full year.  It
 # is used on the footer of the generated manual pages.  If in doubt, you may
 # just use %x as the value (which should be the full locale-specific date).
-my $date = enc strftime _("%B %Y"), localtime;
+my $date = enc strftime _("%B %Y"), gmtime($ENV{SOURCE_DATE_EPOCH} || time());
 (my $program = $ARGV[0]) =~ s!.*/!!;
 my $package = $program;
 my $version;
-- 
2.12.3





Information forwarded to bug-automake <at> gnu.org:
bug#27773; Package automake. (Tue, 08 Aug 2017 22:08:01 GMT) Full text and rfc822 format available.

Message #8 received at 27773 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Lirzin <mthl <at> gnu.org>
To: "Bernhard M. Wiedemann" <bwiedemann <at> suse.de>
Cc: 27773 <at> debbugs.gnu.org
Subject: Re: bug#27773: [PATCH] Allow to override build date
Date: Wed, 09 Aug 2017 00:07:39 +0200
Hello,

"Bernhard M. Wiedemann" <bwiedemann <at> suse.de> writes:

> and use gmtime to not be influenced by timezone settings
> in order to make builds reproducible.
>
> While working on the reproducible builds effort, I found that
> when building the automake package for openSUSE Linux,
> there were slight differences between each build
>
> See https://reproducible-builds.org/ for why this is matters
> and https://reproducible-builds.org/specs/source-date-epoch/
> for the definition of this variable.
> ---
>  doc/help2man | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/help2man b/doc/help2man
> index e651b8d2d..4a9f75064 100755
> --- a/doc/help2man
> +++ b/doc/help2man
> @@ -217,7 +217,7 @@ $version_text ||= get_option_value $ARGV[0], $version_option;
>  # the English version expands to the month as a word and the full year.  It
>  # is used on the footer of the generated manual pages.  If in doubt, you may
>  # just use %x as the value (which should be the full locale-specific date).
> -my $date = enc strftime _("%B %Y"), localtime;
> +my $date = enc strftime _("%B %Y"), gmtime($ENV{SOURCE_DATE_EPOCH} || time());
>  (my $program = $ARGV[0]) =~ s!.*/!!;
>  my $package = $program;
>  my $version;

'help2man' is a bundled script that is maintained outside of Automake
repository.  Unfortunately it has not being synced with upstream for a
while.  Latest version of GNU Help2man [1] seems to already fix this
reproducibility issue [2].  So instead of applying your patch I have
simply upgraded the bundled script in commit
9322f409a957f153b38ff37ba79ddf4c19cff6ca.

Hopefully that will fix the issue.  If that is not the case feel free to
reopen this bug.

Thanks for the report.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

[1] https://ftp.gnu.org/gnu/help2man/help2man-1.47.4.tar.xz
[2] https://anonscm.debian.org/git/users/bod/help2man.git/commit/?id=8448110e8b7567147b70ff54ddf771306a56d39d




Added tag(s) fixed. Request was from Mathieu Lirzin <mthl <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 08 Aug 2017 22:09:01 GMT) Full text and rfc822 format available.

bug closed, send any further explanations to 27773 <at> debbugs.gnu.org and "Bernhard M. Wiedemann" <bwiedemann <at> suse.de> Request was from Mathieu Lirzin <mthl <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 08 Aug 2017 22:09:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 06 Sep 2017 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 6 years and 205 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.