GNU bug report logs - #27774
[PATCH] gnu: add libgeotiff

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27774 in the body.
You can then email your comments to 27774 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: add libgeotiff
Date: Thu, 20 Jul 2017 17:50:18 +0200

From 4e96405382258d0aa3a1760ac77dd0ac72706786 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20H=C3=B6fling?=
 <bjoern.hoefling <at> bjoernhoefling.de>
Date: Tue, 24 Jan 2017 09:00:07 +0100
Subject: [PATCH] gnu: add libgeotiff

* gnu/packages/geo.scm (libgeotiff): New variable.
---
 gnu/packages/geo.scm | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
index d8d5490f3..019731158 100644
--- a/gnu/packages/geo.scm
+++ b/gnu/packages/geo.scm
@@ -25,9 +25,11 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix utils)
+  #:use-module (gnu packages compression)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gtk)
+  #:use-module (gnu packages image)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages webkit)
   #:use-module (gnu packages xml))
@@ -133,6 +135,60 @@ and driving.")
     (home-page "https://wiki.gnome.org/Apps/Maps")
     (license license:gpl2+)))
 
+(define-public libgeotiff
+  (package
+   (name "libgeotiff")
+   (version "1.4.2")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "http://download.osgeo.org/geotiff/libgeotiff/"
+                                "libgeotiff-"
+                                version ".tar.gz"))
+            (sha256
+             (base32
+              "0vjy3bwfhljjx66p9w999i4mdhsf7vjshx29yc3pn5livf5091xd"))))
+   (build-system gnu-build-system)
+   (arguments
+    `(#:configure-flags
+      `( ,(string-append "--with-zlib")
+         ,(string-append "--with-jpeg")
+         ,(string-append "--with-libtiff="
+                         (assoc-ref %build-inputs "libtiff")))
+    #:phases
+    (modify-phases %standard-phases
+      (add-after
+          'unpack 'delete-nonfree-files
+        (lambda _
+          ;; Remove .csv-files, distributed from
+          ;; EPSG under a restricted license.
+          ;; See LICENSE.txt for full license text.
+          (for-each delete-file (find-files "." "\\.csv$"))
+          ;; Now that we remove the csv-files, we need to modify the Makefile:
+          (substitute* "Makefile.in"
+            (("all-am: Makefile \\$\\(LTLIBRARIES\\) \\$\\(DATA\\) \\$\\(HEADERS\\) geo_config.h")
+             "all-am: Makefile $(LTLIBRARIES) $(HEADERS) geo_config.h")
+            (("install-data-am: install-dist_csvDATA install-includeHEADERS")
+             "install-data-am: install-includeHEADERS"))
+          #t)))))
+   (inputs `(("libjpeg" ,libjpeg)
+             ("libtiff" ,libtiff)
+             ("proj.4" ,proj.4)
+             ("zlib" ,zlib)))
+   (synopsis "Library for handling GeoTIFF (geographic enabled TIFF)")
+   (description
+    "Libgeotiff is a library on top of libtiff for reading and writing
+GeoTIFF information tags.")
+   ;; This is a mixture of various contributions under different licenses
+   ;; Not that the EPSG database is NOT "free to use" as the LICENSE file
+   ;; states, as its commercial redistribution is restricted.
+   ;; We thus remove it from the package.
+   (license (list license:public-domain
+                  license:x11
+                  license:bsd-3
+                  (license:non-copyleft "file://LICENSE"
+                                  "See LICENSE in the distribution.")))
+   (home-page "https://trac.osgeo.org/geotiff/")))
+
 (define-public proj.4
   (package
     (name "proj.4")
-- 
2.12.2

Message #8 received at 27774 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 27774 <at> debbugs.gnu.org
Subject: Re: [bug#27774] [PATCH] gnu: add libgeotiff
Date: Sat, 22 Jul 2017 14:46:24 +0200

[Message part 1 (text/plain, inline)]

Hi Björn!

Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> writes:

> From 4e96405382258d0aa3a1760ac77dd0ac72706786 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Bj=C3=B6rn=20H=C3=B6fling?=
>  <bjoern.hoefling <at> bjoernhoefling.de>
> Date: Tue, 24 Jan 2017 09:00:07 +0100
> Subject: [PATCH] gnu: add libgeotiff
>
> * gnu/packages/geo.scm (libgeotiff): New variable.

[...]
  
> +(define-public libgeotiff
> +  (package
> +   (name "libgeotiff")
> +   (version "1.4.2")
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append "http://download.osgeo.org/geotiff/libgeotiff/"
> +                                "libgeotiff-"
> +                                version ".tar.gz"))
> +            (sha256
> +             (base32
> +              "0vjy3bwfhljjx66p9w999i4mdhsf7vjshx29yc3pn5livf5091xd"))))
> +   (build-system gnu-build-system)
> +   (arguments
> +    `(#:configure-flags
> +      `( ,(string-append "--with-zlib")
> +         ,(string-append "--with-jpeg")
> +         ,(string-append "--with-libtiff="
> +                         (assoc-ref %build-inputs "libtiff")))

I think this can be reduced to...

#:configure-flags
(list "--with-zlib" "--with-jpeg"
      (string-append "--with-libtiff" (assoc-ref ....)))

> +    #:phases
> +    (modify-phases %standard-phases
> +      (add-after
> +          'unpack 'delete-nonfree-files
> +        (lambda _
> +          ;; Remove .csv-files, distributed from
> +          ;; EPSG under a restricted license.
> +          ;; See LICENSE.txt for full license text.
> +          (for-each delete-file (find-files "." "\\.csv$"))
> +          ;; Now that we remove the csv-files, we need to modify the Makefile:
> +          (substitute* "Makefile.in"
> +            (("all-am: Makefile \\$\\(LTLIBRARIES\\) \\$\\(DATA\\) \\$\\(HEADERS\\) geo_config.h")
> +             "all-am: Makefile $(LTLIBRARIES) $(HEADERS) geo_config.h")
> +            (("install-data-am: install-dist_csvDATA install-includeHEADERS")
> +             "install-data-am: install-includeHEADERS"))
> +          #t)))))

Thanks for finding this. Can you move this section to a 'snippet'
instead? Otherwise these restricted files will show up in `guix build -S
libgeotiff`, which we can not allow.

The rest LGTM!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 27774 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 27774 <at> debbugs.gnu.org
Subject: Re: [bug#27774] [PATCH] gnu: add libgeotiff
Date: Sat, 22 Jul 2017 19:18:17 +0530

>> +   (arguments
>> +    `(#:configure-flags
>> +      `( ,(string-append "--with-zlib")
>> +         ,(string-append "--with-jpeg")
>> +         ,(string-append "--with-libtiff="
>> +                         (assoc-ref %build-inputs "libtiff")))

I'm asking this out of ignorance more than anything else. Is this
(assoc-ref %build-inputs "libtiff") call required for "--with-libtiff",
when it is not required for "--with-zlib" and "--with-jpeg"?

Also, can we build this package with libjpeg-turbo, instead of libjpeg?
libjpeg-turbo claims to be faster, and many packages in Arch and
Parabola are built using libjpeg-turbo.

Message #14 received at 27774 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 27774 <at> debbugs.gnu.org
Subject: Re: [bug#27774] [PATCH] gnu: add libgeotiff
Date: Sun, 23 Jul 2017 13:22:44 +0200

On Sat, 22 Jul 2017 14:46:24 +0200
Marius Bakke <mbakke <at> fastmail.com> wrote:

> Hi Björn!
> 
> Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> writes:
> 
> > From 4e96405382258d0aa3a1760ac77dd0ac72706786 Mon Sep 17 00:00:00
> > 2001 From: =?UTF-8?q?Bj=C3=B6rn=20H=C3=B6fling?=
> >  <bjoern.hoefling <at> bjoernhoefling.de>
> > Date: Tue, 24 Jan 2017 09:00:07 +0100
> > Subject: [PATCH] gnu: add libgeotiff
> >
> > * gnu/packages/geo.scm (libgeotiff): New variable.  
> 
> [...]
>   
> > +(define-public libgeotiff
> > +  (package
> > +   (name "libgeotiff")
> > +   (version "1.4.2")
> > +   (source (origin
> > +            (method url-fetch)
> > +            (uri (string-append
> > "http://download.osgeo.org/geotiff/libgeotiff/"
> > +                                "libgeotiff-"
> > +                                version ".tar.gz"))
> > +            (sha256
> > +             (base32
> > +
> > "0vjy3bwfhljjx66p9w999i4mdhsf7vjshx29yc3pn5livf5091xd"))))
> > +   (build-system gnu-build-system)
> > +   (arguments
> > +    `(#:configure-flags
> > +      `( ,(string-append "--with-zlib")
> > +         ,(string-append "--with-jpeg")
> > +         ,(string-append "--with-libtiff="
> > +                         (assoc-ref %build-inputs "libtiff")))  
> 
> I think this can be reduced to...
> 
> #:configure-flags
> (list "--with-zlib" "--with-jpeg"
>       (string-append "--with-libtiff" (assoc-ref ....)))

Of cause!


> > +    #:phases
> > +    (modify-phases %standard-phases
> > +      (add-after
> > +          'unpack 'delete-nonfree-files
> > +        (lambda _
> > +          ;; Remove .csv-files, distributed from
> > +          ;; EPSG under a restricted license.
> > +          ;; See LICENSE.txt for full license text.
> > +          (for-each delete-file (find-files "." "\\.csv$"))
> > +          ;; Now that we remove the csv-files, we need to modify
> > the Makefile:
> > +          (substitute* "Makefile.in"
> > +            (("all-am: Makefile \\$\\(LTLIBRARIES\\) \\$\\(DATA\\)
> > \\$\\(HEADERS\\) geo_config.h")
> > +             "all-am: Makefile $(LTLIBRARIES) $(HEADERS)
> > geo_config.h")
> > +            (("install-data-am: install-dist_csvDATA
> > install-includeHEADERS")
> > +             "install-data-am: install-includeHEADERS"))
> > +          #t)))))  
> 
> Thanks for finding this. Can you move this section to a 'snippet'
> instead? Otherwise these restricted files will show up in `guix build
> -S libgeotiff`, which we can not allow.

I didn't know of the 'snippet' until now. I will rework it with a origin->snippet
and send it in again.

> The rest LGTM!

Message #17 received at 27774 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 27774 <at> debbugs.gnu.org
Subject: Re: [bug#27774] [PATCH] gnu: add libgeotiff
Date: Sun, 23 Jul 2017 13:27:57 +0200

Hi Arun,

On Sat, 22 Jul 2017 19:18:17 +0530
Arun Isaac <arunisaac <at> systemreboot.net> wrote:

> >> +   (arguments
> >> +    `(#:configure-flags
> >> +      `( ,(string-append "--with-zlib")
> >> +         ,(string-append "--with-jpeg")
> >> +         ,(string-append "--with-libtiff="
> >> +                         (assoc-ref %build-inputs "libtiff")))  
> 
> I'm asking this out of ignorance more than anything else. Is this
> (assoc-ref %build-inputs "libtiff") call required for
> "--with-libtiff", when it is not required for "--with-zlib" and
> "--with-jpeg"?

Yes:

If I leave it out (which was my first try anyway) I get this error message:

/gnu/store/k7029k5va68lkapbzcycdzj7m5bjb4b8-bash-4.4.12/bin/bash ../libtool
 --tag=CC   --mode=link gcc -I../ -Iyes -DHAVE_TIFF=1  -g -O2 -O3 -DNDEBUG
   -o libxtiff.la  xtiff.lo  -lproj -Lyes -ltiff -ljpeg -lz -lm  
../libtool: line 6000: cd: yes: No such file or directory

It seams the semantics for --with-libtiff is different than for the other
libraries.


> 
> Also, can we build this package with libjpeg-turbo, instead of
> libjpeg? libjpeg-turbo claims to be faster, and many packages in Arch
> and Parabola are built using libjpeg-turbo.

Good catch. It should be API-compatible, available on all plattforms and
Arch and Ubuntu (checked these) use is as dependency for libgeotiff.

I will give it a try and hopefully will also pack a minimal version of
GDAL to really make use of the library.

Thanks,

Björn

Message #20 received at 27774 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: 27774 <at> debbugs.gnu.org
Subject: Re: [bug#27774] [PATCH] gnu: add libgeotiff
Date: Sun, 23 Jul 2017 21:06:29 +0530

Björn Höfling writes:

> On Sat, 22 Jul 2017 19:18:17 +0530
> Arun Isaac <arunisaac <at> systemreboot.net> wrote:
>
>> >> +   (arguments
>> >> +    `(#:configure-flags
>> >> +      `( ,(string-append "--with-zlib")
>> >> +         ,(string-append "--with-jpeg")
>> >> +         ,(string-append "--with-libtiff="
>> >> +                         (assoc-ref %build-inputs "libtiff")))  
>> 
>> I'm asking this out of ignorance more than anything else. Is this
>> (assoc-ref %build-inputs "libtiff") call required for
>> "--with-libtiff", when it is not required for "--with-zlib" and
>> "--with-jpeg"?
>
> Yes:
>
> If I leave it out (which was my first try anyway) I get this error message:
>
> /gnu/store/k7029k5va68lkapbzcycdzj7m5bjb4b8-bash-4.4.12/bin/bash ../libtool
>  --tag=CC   --mode=link gcc -I../ -Iyes -DHAVE_TIFF=1  -g -O2 -O3 -DNDEBUG
>    -o libxtiff.la  xtiff.lo  -lproj -Lyes -ltiff -ljpeg -lz -lm  
> ../libtool: line 6000: cd: yes: No such file or directory
>
> It seams the semantics for --with-libtiff is different than for the other
> libraries.

Ok.

>> Also, can we build this package with libjpeg-turbo, instead of
>> libjpeg? libjpeg-turbo claims to be faster, and many packages in Arch
>> and Parabola are built using libjpeg-turbo.
>
> Good catch. It should be API-compatible, available on all plattforms and
> Arch and Ubuntu (checked these) use is as dependency for libgeotiff.
>
> I will give it a try and hopefully will also pack a minimal version of
> GDAL to really make use of the library.

That's great!

Message #23 received at 27774 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: 27774 <at> debbugs.gnu.org
Subject: Re: [bug#27774] [PATCH] gnu: add libgeotiff
Date: Tue, 25 Jul 2017 12:28:59 +0530

> +   ;; This is a mixture of various contributions under different licenses
> +   ;; Not that the EPSG database is NOT "free to use" as the LICENSE file
> +   ;; states, as its commercial redistribution is restricted.
> +   ;; We thus remove it from the package.
> +   (license (list license:public-domain
> +                  license:x11
> +                  license:bsd-3
> +                  (license:non-copyleft "file://LICENSE"
> +                                  "See LICENSE in the distribution.")))

I think it might also be worthwhile mentioning (as comments) which files
are under which license.

Message #26 received at 27774 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 27774 <at> debbugs.gnu.org
Subject: Re: [bug#27774] [PATCH] gnu: add libgeotiff
Date: Fri, 08 Sep 2017 17:53:08 +0200

Hello Björn,

Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> skribis:

> I will give it a try and hopefully will also pack a minimal version of
> GDAL to really make use of the library.

Any update on this patch?

TIA,
Ludo’.

Message #29 received at 27774 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 27774 <at> debbugs.gnu.org
Subject: Re: [bug#27774] [PATCH] gnu: add libgeotiff
Date: Wed, 13 Sep 2017 08:55:49 +0200

On Fri, 08 Sep 2017 17:53:08 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Hello Björn,
> 
> Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> skribis:
> 
> > I will give it a try and hopefully will also pack a minimal version
> > of GDAL to really make use of the library.  
> 
> Any update on this patch?
> 
> TIA,
> Ludo’.


Sorry, I was on vacation and forgot to mention that to you.

Yes, had some progress but at some point built failed, need to bisect.

Hope to fix it within a week.

Björn

Message #32 received at 27774 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Arun Isaac <arunisaac <at> systemreboot.net>, 27774 <at> debbugs.gnu.org
Subject: Re: [bug#27774] [PATCH] gnu: add libgeotiff
Date: Wed, 18 Oct 2017 23:20:41 +0200

Hi Björn,

> On Fri, 08 Sep 2017 17:53:08 +0200
> ludo <at> gnu.org (Ludovic Courtès) wrote:
>
>> Hello Björn,
>> 
>> Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> skribis:
>> 
>> > I will give it a try and hopefully will also pack a minimal version
>> > of GDAL to really make use of the library.  
>> 
>> Any update on this patch?
>> 
>> TIA,
>> Ludo’.
>
>
> Sorry, I was on vacation and forgot to mention that to you.
>
> Yes, had some progress but at some point built failed, need to bisect.
>
> Hope to fix it within a week.

How’s it going? :)
Do you need help with this patch?

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #37 received at 27774 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 27774 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, mbakke <at> fastmail.com
Subject: [PATCH 0/1] Add libgeotiff
Date: Wed,  3 Jan 2018 22:25:59 +0530

I am unsure if Bjorn is coming back. So, I have completed the patch. Let me
know if everything is fine. I'll push it.

Björn Höfling (1):
  gnu: Add libgeotiff.

 gnu/packages/geo.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

-- 
2.15.1

Message #40 received at 27774 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 27774 <at> debbugs.gnu.org
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 mbakke <at> fastmail.com, Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 1/1] gnu: Add libgeotiff.
Date: Wed,  3 Jan 2018 22:26:00 +0530

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>

* gnu/packages/geo.scm (libgeotiff): New variable.

Signed-off-by: Arun Isaac <arunisaac <at> systemreboot.net>
---
 gnu/packages/geo.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
index 7bf1562ba..c3a62c641 100644
--- a/gnu/packages/geo.scm
+++ b/gnu/packages/geo.scm
@@ -25,9 +25,11 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix utils)
+  #:use-module (gnu packages compression)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gtk)
+  #:use-module (gnu packages image)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages webkit)
   #:use-module (gnu packages xml))
@@ -137,6 +139,55 @@ and driving.")
     (home-page "https://wiki.gnome.org/Apps/Maps")
     (license license:gpl2+)))
 
+(define-public libgeotiff
+  (package
+    (name "libgeotiff")
+    (version "1.4.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://download.osgeo.org/geotiff/libgeotiff/libgeotiff-"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "0vjy3bwfhljjx66p9w999i4mdhsf7vjshx29yc3pn5livf5091xd"))
+       (modules '((guix build utils)))
+       (snippet
+        '(begin
+           ;; Remove .csv files, distributed from EPSG under a restricted
+           ;; license. See LICENSE for full license text.
+           (for-each delete-file (find-files "." "\\.csv$"))
+           ;; Now that we have removed the csv files, we need to modify the Makefile.
+           (substitute* "Makefile.in"
+             (("^all-am: .*$")
+              "all-am: Makefile $(LTLIBRARIES) $(HEADERS) geo_config.h\n")
+             (("^install-data-am: .*$")
+              "install-data-am: install-includeHEADERS"))))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("libjpeg-turbo" ,libjpeg-turbo)
+       ("libtiff" ,libtiff)
+       ("proj.4" ,proj.4)
+       ("zlib" ,zlib)))
+    (arguments
+     `(#:configure-flags
+       (list (string-append "--with-zlib")
+             (string-append "--with-jpeg")
+             (string-append "--with-libtiff=" (assoc-ref %build-inputs "libtiff")))))
+    (synopsis "Library for handling GeoTIFF (geographic enabled TIFF)")
+    (description "libgeotiff is a library on top of libtiff for reading and
+writing GeoTIFF information tags.")
+    (home-page "https://trac.osgeo.org/geotiff/")
+    ;; This is a mixture of various contributions under different licenses.
+    ;; Note that the EPSG database is NOT "free to use" as the LICENSE file
+    ;; states, as its commercial redistribution is restricted. Hence, we have
+    ;; removed it from the package.
+    (license (list license:public-domain
+                   license:x11
+                   license:bsd-3
+                   (license:non-copyleft "file://LICENSE"
+                                         "See LICENSE in the distribution.")))))
+
 (define-public proj.4
   (package
     (name "proj.4")
-- 
2.15.1

Message #43 received at 27774 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 27774 <at> debbugs.gnu.org
Subject: Re: [bug#27774] [PATCH 0/1] Add libgeotiff
Date: Wed, 3 Jan 2018 13:24:32 -0500

[Message part 1 (text/plain, inline)]

On Wed, Jan 03, 2018 at 10:25:59PM +0530, Arun Isaac wrote:
> I am unsure if Bjorn is coming back. So, I have completed the patch. Let me
> know if everything is fine. I'll push it.

Thanks Arun! The updated patch looks good to me.

[signature.asc (application/pgp-signature, inline)]

Message #48 received at 27774-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 27774-done <at> debbugs.gnu.org
Subject: Re: [bug#27774] [PATCH 0/1] Add libgeotiff
Date: Thu, 04 Jan 2018 12:25:58 +0530

Leo Famulari <leo <at> famulari.name> writes:

> On Wed, Jan 03, 2018 at 10:25:59PM +0530, Arun Isaac wrote:
>> I am unsure if Bjorn is coming back. So, I have completed the patch. Let me
>> know if everything is fine. I'll push it.
>
> Thanks Arun! The updated patch looks good to me.

Pushed, thanks!

Message #51 received at 27774 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 27774 <at> debbugs.gnu.org, mbakke <at> fastmail.com
Subject: Re: [PATCH 1/1] gnu: Add libgeotiff.
Date: Sat, 27 Jan 2018 21:07:05 +0100

Hi Arun,

thanks for finishing that. I messed my git repository and then forgot
about it because of other things.

Björn


On Wed,  3 Jan 2018 22:26:00 +0530
Arun Isaac <arunisaac <at> systemreboot.net> wrote:

> From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
> 
> * gnu/packages/geo.scm (libgeotiff): New variable.
> 
> Signed-off-by: Arun Isaac <arunisaac <at> systemreboot.net>
> ---
>  gnu/packages/geo.scm | 51
> +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed,
> 51 insertions(+)
> 
> diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
> index 7bf1562ba..c3a62c641 100644
> --- a/gnu/packages/geo.scm
> +++ b/gnu/packages/geo.scm
> @@ -25,9 +25,11 @@
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix packages)
>    #:use-module (guix utils)
> +  #:use-module (gnu packages compression)
>    #:use-module (gnu packages glib)
>    #:use-module (gnu packages gnome)
>    #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages image)
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages webkit)
>    #:use-module (gnu packages xml))
> @@ -137,6 +139,55 @@ and driving.")
>      (home-page "https://wiki.gnome.org/Apps/Maps")
>      (license license:gpl2+)))
>  
> +(define-public libgeotiff
> +  (package
> +    (name "libgeotiff")
> +    (version "1.4.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> "http://download.osgeo.org/geotiff/libgeotiff/libgeotiff-"
> +                           version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0vjy3bwfhljjx66p9w999i4mdhsf7vjshx29yc3pn5livf5091xd"))
> +       (modules '((guix build utils)))
> +       (snippet
> +        '(begin
> +           ;; Remove .csv files, distributed from EPSG under a
> restricted
> +           ;; license. See LICENSE for full license text.
> +           (for-each delete-file (find-files "." "\\.csv$"))
> +           ;; Now that we have removed the csv files, we need to
> modify the Makefile.
> +           (substitute* "Makefile.in"
> +             (("^all-am: .*$")
> +              "all-am: Makefile $(LTLIBRARIES) $(HEADERS)
> geo_config.h\n")
> +             (("^install-data-am: .*$")
> +              "install-data-am: install-includeHEADERS"))))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("libjpeg-turbo" ,libjpeg-turbo)
> +       ("libtiff" ,libtiff)
> +       ("proj.4" ,proj.4)
> +       ("zlib" ,zlib)))
> +    (arguments
> +     `(#:configure-flags
> +       (list (string-append "--with-zlib")
> +             (string-append "--with-jpeg")
> +             (string-append "--with-libtiff=" (assoc-ref
> %build-inputs "libtiff")))))
> +    (synopsis "Library for handling GeoTIFF (geographic enabled
> TIFF)")
> +    (description "libgeotiff is a library on top of libtiff for
> reading and +writing GeoTIFF information tags.")
> +    (home-page "https://trac.osgeo.org/geotiff/")
> +    ;; This is a mixture of various contributions under different
> licenses.
> +    ;; Note that the EPSG database is NOT "free to use" as the
> LICENSE file
> +    ;; states, as its commercial redistribution is restricted.
> Hence, we have
> +    ;; removed it from the package.
> +    (license (list license:public-domain
> +                   license:x11
> +                   license:bsd-3
> +                   (license:non-copyleft "file://LICENSE"
> +                                         "See LICENSE in the
> distribution."))))) +
>  (define-public proj.4
>    (package
>      (name "proj.4")

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.