GNU bug report logs - #27882
[PATCH] gnu: Add knights.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27882 in the body.
You can then email your comments to 27882 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: guix-patches <at> gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>
Subject: [PATCH] gnu: Add knights.
Date: Sun, 30 Jul 2017 21:36:37 +0200

* gnu/packages/games.scm (knights): New variable.
---
 gnu/packages/games.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index d8848f82f..844b93b5f 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -350,6 +350,45 @@ played.  Freedoom complements the Doom engine with free levels, artwork, sound
 effects and music to make a completely free game.")
    (license license:bsd-3)))
 
+(define-public knights
+  (package
+    (name "knights")
+    (version "025")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://www.knightsgame.org.uk/files/knights_"
+                                  version "_src.tar.gz"))
+              (sha256
+               (base32
+                "18vp2ygvn0s0jz8rm585jqf6hjqkam1ximq81k0r9hpmfj7wb88f"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:make-flags
+       (list (string-append "PREFIX=" (assoc-ref %outputs "out")))
+       #:phases
+       (modify-phases %standard-phases
+         ;; No configure script.
+         (delete 'configure))
+       #:tests? #f)) ;; No check target.
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("boost" ,boost)
+       ("sdl-union" ,(sdl-union (list sdl sdl-image sdl-mixer)))
+       ("freetype" ,freetype)
+       ("fontconfig" ,fontconfig)
+       ("curl" ,curl)))
+    (home-page "http://www.knightsgame.org.uk/")
+    (synopsis "Multiplayer dungeon game involving knights and quests")
+    (description "Knights is a multiplayer game involving several knights who
+must run around a dungeon and complete various quests.  Each game revolves
+around a quest – for example, you might have to find some items and carry them
+back to your starting point.  This may sound easy, but as there are only
+enough items in the dungeon for one player to win, you may end up having to
+kill your opponents to get their stuff!  Other quests involve escaping from
+the dungeon, fighting a duel to the death against the enemy knights, or
+destroying an ancient book using a special wand.")
+    (license license:gpl3)))
+
 (define-public gnubg
   (package
     (name "gnubg")
-- 
2.13.3

Message #8 received at 27882 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 27882 <at> debbugs.gnu.org
Subject: Re: [bug#27882] [PATCH] gnu: Add knights.
Date: Mon, 31 Jul 2017 15:13:54 +0530

Thanks for the patch!

> +    (license license:gpl3)))

The license should be gpl3+. Also, there appear to be other bundled
dependencies in src/external and src/coercri under different licenses
(bsd, boost license, etc.). Could you check?

Message #13 received at 27882-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 27882-done <at> debbugs.gnu.org
Subject: Re: [bug#27882] [PATCH] gnu: Add knights.
Date: Sat, 16 Dec 2017 10:25:35 +0100

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> Thanks for the patch!
>
>> +    (license license:gpl3)))
>
> The license should be gpl3+.

You are right.

> Also, there appear to be other bundled
> dependencies in src/external and src/coercri under different licenses
> (bsd, boost license, etc.). Could you check?

I’ve added a list of these included sources and their licenses.  Pushed
to master with commit 02345c963.

Thanks for your review!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.