GNU logs - #27889, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#27889: Polkit actions are not updated after guix system reconfigure
Resent-From: Ryan Moe <ryan.moe@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Mon, 31 Jul 2017 21:10:02 +0000
Resent-Message-ID: <handler.27889.B.150153535024196 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 27889 <at> debbugs.gnu.org
MIME-Version: 1.0
From: Ryan Moe <ryan.moe@HIDDEN>
Date: Mon, 31 Jul 2017 14:08:59 -0700
Message-ID: <CAN-ReHqDxmNcsPAffCo4PYKpf0qjvdvGne0eAeB7Pf8spHsc_A@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

When a service is added to or removed from the system configuration,
polkit actions are not appropriately registered or unregistered.

The policy files are added and deleted correctly but the polkitd
process needs a SIGHUP afterwards to update the list of registered
actions.


Steps to reproduce:

1. Add (xfce-desktop-service) to (services) in config.scm. [Or any
service which adds polkit actions]

2. Run guix system reconfigure.

3. Observe that the policy files are in place but not registered:
    $ ls /etc/polkit-1/actions/*xfce*
    /etc/polkit-1/actions/org.xfce.thunar.policy

    $ pkaction | grep -i xfce
    $

4. Run killall -HUP polkitd

5. Observe that actions are registered.
    $ pkaction | grep -i xfce
    org.xfce.thunar

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Ryan Moe <ryan.moe@HIDDEN>
Subject: bug#27889: Acknowledgement (Polkit actions are not updated after
 guix system reconfigure)
Message-ID: <handler.27889.B.150153535024196.ack <at> debbugs.gnu.org>
References: <CAN-ReHqDxmNcsPAffCo4PYKpf0qjvdvGne0eAeB7Pf8spHsc_A@HIDDEN>
X-Gnu-PR-Message: ack 27889
X-Gnu-PR-Package: guix
Reply-To: 27889 <at> debbugs.gnu.org
Date: Mon, 31 Jul 2017 21:10:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 27889 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
27889: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D27889
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#27889: Polkit actions are not updated after guix system reconfigure
Resent-From: Danny Milosavljevic <dannym@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Mon, 31 Jul 2017 21:35:02 +0000
Resent-Message-ID: <handler.27889.B27889.150153685826550 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 27889 <at> debbugs.gnu.org
Cc: Ryan Moe <ryan.moe@HIDDEN>
Date: Mon, 31 Jul 2017 23:34:04 +0200
From: Danny Milosavljevic <dannym@HIDDEN>
Message-ID: <20170731233404.691437c0@HIDDEN>
In-Reply-To: <CAN-ReHqDxmNcsPAffCo4PYKpf0qjvdvGne0eAeB7Pf8spHsc_A@HIDDEN>
References: <CAN-ReHqDxmNcsPAffCo4PYKpf0qjvdvGne0eAeB7Pf8spHsc_A@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Oops!

That's indeed still broken.

But gnu/services/shepherd.scm shepherd-service-file could be extended to provide a "restart" action (shepherd itself already supports it).

The general format for shepherd is:

(register-services
  (make <service>
        #:provides '(apache-2.0 apache httpd)
        #:requires '()
        #:start (...)
        #:stop (...)
        #:actions (make-actions
                   (restart (...)))))
                    ^^^^^^^^^^^^^

But the Guix <shepherd-service> record, which is the source that is eventually compiled to the above, neither has an "actions" slot nor a "restart" slot.  It would have to be extended with one.

I wonder whether it would make sense to make shepherd automatically default to a SIGHUP restart action for daemonized processes instead, though.  It's not exactly rare for daemons to provide that.

Also, does "guix system reconfigure" already call this restart action if it's present?

Message sent to bug-guix@HIDDEN:

Subject: bug#27889: Polkit actions are not updated after guix system reconfigure
Resent-From: Ryan Moe <ryan.moe@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Mon, 31 Jul 2017 23:11:01 +0000
Resent-Message-ID: <handler.27889.B27889.15015426332579 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Danny Milosavljevic <dannym@HIDDEN>
Cc: 27889 <at> debbugs.gnu.org
MIME-Version: 1.0
In-Reply-To: <20170731233404.691437c0@HIDDEN>
References: <CAN-ReHqDxmNcsPAffCo4PYKpf0qjvdvGne0eAeB7Pf8spHsc_A@HIDDEN>
 <20170731233404.691437c0@HIDDEN>
From: Ryan Moe <ryan.moe@HIDDEN>
Date: Mon, 31 Jul 2017 16:10:25 -0700
Message-ID: <CAN-ReHoqipxjd-NOM7YvAjTU_2-KeAey3bxzfbJ1QmEQdbf0HA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Mon, Jul 31, 2017 at 2:34 PM, Danny Milosavljevic
<dannym@HIDDEN> wrote:
> Oops!
>
> That's indeed still broken.
>
> But gnu/services/shepherd.scm shepherd-service-file could be extended to provide a "restart" action (shepherd itself already supports it).
>
> The general format for shepherd is:
>
> (register-services
>   (make <service>
>         #:provides '(apache-2.0 apache httpd)
>         #:requires '()
>         #:start (...)
>         #:stop (...)
>         #:actions (make-actions
>                    (restart (...)))))
>                     ^^^^^^^^^^^^^
>
> But the Guix <shepherd-service> record, which is the source that is eventually compiled to the above, neither has an "actions" slot nor a "restart" slot.  It would have to be extended with one.
>
> I wonder whether it would make sense to make shepherd automatically default to a SIGHUP restart action for daemonized processes instead, though.  It's not exactly rare for daemons to provide that.
>
> Also, does "guix system reconfigure" already call this restart action if it's present?

polkitd isn't managed by shepherd. It looks to be managed by dbus and
I'm not sure how to restart an individual dbus service (or if you even
can). Restarting dbus-system is obviously too intrusive (it does
reload the policy files at the expense of restarting my X session :)).

Message sent to bug-guix@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#27889: Polkit actions are not updated after guix system reconfigure
Resent-From: Danny Milosavljevic <dannym@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 01 Aug 2017 07:19:02 +0000
Resent-Message-ID: <handler.27889.B27889.150157188513240 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 27889
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: Ryan Moe <ryan.moe@HIDDEN>
Cc: 27889 <at> debbugs.gnu.org
Received: via spool by 27889-submit <at> debbugs.gnu.org id=B27889.150157188513240
          (code B ref 27889); Tue, 01 Aug 2017 07:19:02 +0000
Received: (at 27889) by debbugs.gnu.org; 1 Aug 2017 07:18:05 +0000
Received: from localhost ([127.0.0.1]:36030 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1dcRRN-0003RU-9t
	for submit <at> debbugs.gnu.org; Tue, 01 Aug 2017 03:18:05 -0400
Received: from dd1012.kasserver.com ([85.13.128.8]:34230)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dannym@HIDDEN>) id 1dcRRK-0003R8-V0
 for 27889 <at> debbugs.gnu.org; Tue, 01 Aug 2017 03:18:03 -0400
Received: from localhost (77.118.188.11.wireless.dyn.drei.com [77.118.188.11])
 by dd1012.kasserver.com (Postfix) with ESMTPSA id E109A1CA0360;
 Tue,  1 Aug 2017 09:17:58 +0200 (CEST)
Date: Tue, 1 Aug 2017 09:17:53 +0200
From: Danny Milosavljevic <dannym@HIDDEN>
Message-ID: <20170801091753.0f9dd3cf@HIDDEN>
In-Reply-To: <CAN-ReHoqipxjd-NOM7YvAjTU_2-KeAey3bxzfbJ1QmEQdbf0HA@HIDDEN>
References: <CAN-ReHqDxmNcsPAffCo4PYKpf0qjvdvGne0eAeB7Pf8spHsc_A@HIDDEN>
 <20170731233404.691437c0@HIDDEN>
 <CAN-ReHoqipxjd-NOM7YvAjTU_2-KeAey3bxzfbJ1QmEQdbf0HA@HIDDEN>
X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

> polkitd isn't managed by shepherd. It looks to be managed by dbus and
> I'm not sure how to restart an individual dbus service (or if you even
> can). Restarting dbus-system is obviously too intrusive (it does
> reload the policy files at the expense of restarting my X session :)).

Yeah, we specifically don't restart dbus because of that.

But I guess we could still send SIGHUP to polkitd.

I'm not sure how to find out which polkitd it is - if we don't want to restart a superset.

Also, pstree says that polkitd forked and started another polkitd.  There are two polkitd.  Which one has to get the SIGHUP?

Message sent to bug-guix@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#27889: Polkit actions are not updated after guix system reconfigure
Resent-From: ludo@HIDDEN (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 01 Aug 2017 10:04:01 +0000
Resent-Message-ID: <handler.27889.B27889.150158183228221 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 27889
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: Danny Milosavljevic <dannym@HIDDEN>
Cc: Ryan Moe <ryan.moe@HIDDEN>, 27889 <at> debbugs.gnu.org
Received: via spool by 27889-submit <at> debbugs.gnu.org id=B27889.150158183228221
          (code B ref 27889); Tue, 01 Aug 2017 10:04:01 +0000
Received: (at 27889) by debbugs.gnu.org; 1 Aug 2017 10:03:52 +0000
Received: from localhost ([127.0.0.1]:36130 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1dcU1o-0007L7-GS
	for submit <at> debbugs.gnu.org; Tue, 01 Aug 2017 06:03:52 -0400
Received: from eggs.gnu.org ([208.118.235.92]:57094)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1dcU1n-0007Kv-Gh
 for 27889 <at> debbugs.gnu.org; Tue, 01 Aug 2017 06:03:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ludo@HIDDEN>) id 1dcU1h-0006b3-8g
 for 27889 <at> debbugs.gnu.org; Tue, 01 Aug 2017 06:03:46 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD
 autolearn=disabled version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49651)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>)
 id 1dcU1a-0006Xe-Ep; Tue, 01 Aug 2017 06:03:38 -0400
Received: from [193.50.110.251] (port=38214 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1dcU1a-0002JK-0g; Tue, 01 Aug 2017 06:03:38 -0400
From: ludo@HIDDEN (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <CAN-ReHqDxmNcsPAffCo4PYKpf0qjvdvGne0eAeB7Pf8spHsc_A@HIDDEN>
 <20170731233404.691437c0@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 14 Thermidor an 225 de la =?UTF-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-unknown-linux-gnu
Date: Tue, 01 Aug 2017 12:03:34 +0200
In-Reply-To: <20170731233404.691437c0@HIDDEN> (Danny Milosavljevic's
 message of "Mon, 31 Jul 2017 23:34:04 +0200")
Message-ID: <87vam7r4eh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

Hello,

Danny Milosavljevic <dannym@HIDDEN> skribis:

> But gnu/services/shepherd.scm shepherd-service-file could be extended to =
provide a "restart" action (shepherd itself already supports it).
>
> The general format for shepherd is:
>
> (register-services
>   (make <service>
>         #:provides '(apache-2.0 apache httpd)
>         #:requires '()
>         #:start (...)
>         #:stop (...)
>         #:actions (make-actions
>                    (restart (...)))))
>                     ^^^^^^^^^^^^^
>
> But the Guix <shepherd-service> record, which is the source that is event=
ually compiled to the above, neither has an "actions" slot nor a "restart" =
slot.  It would have to be extended with one.
>
> I wonder whether it would make sense to make shepherd automatically defau=
lt to a SIGHUP restart action for daemonized processes instead, though.  It=
's not exactly rare for daemons to provide that.
>
> Also, does "guix system reconfigure" already call this restart action if =
it's present?

Not yet, but it should.  I think the patches at
<https://bugs.gnu.org/26830> would be sufficient if the action boils
down to sending SIGHUP.  Perhaps time to revive that patch set!

Ludo=E2=80=99.

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.