GNU bug report logs - #27950
[PATCH] Add The Ur-Quan Masters

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27950 in the body.
You can then email your comments to 27950 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Van Ymeren <adam <at> vany.ca>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add The Ur-Quan Masters
Date: Fri, 04 Aug 2017 09:33:36 -0400

This is my first package so obviously comments are welcome.  This
package only contains the engine.  The data files are distributed as a
few separate archives.  According to their wiki the data files are
available under a free(ish) license (CC BY-NC-SA 2.5).  A few separate
packages will have to be made for those I guess?  I'm not sure how to
include multiple source files in a single package, if this is even
supported.

UQM uses a pretty custom looking build system so I had to replace all
phases of the build, but it appears to work now.  After installation the
games starts and the dies complaining about missing data files.

---
 gnu/packages/games.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 2dec9a395..08f99cf61 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -4579,3 +4579,56 @@ computer-hosted roleplaying games.  This is the last version released by
 Crowther & Woods, its original authors, in 1995.  It has been known as
 \"adventure 2.5\" and \"430-point adventure\".")
       (license license:bsd-2))))
+
+(define-public uqm
+  (package
+   (name "uqm")
+   (version "0.7.0")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://sourceforge/sc2/UQM/0.7/"
+                                name "-" version "-source.tgz"))
+            (sha256
+             (base32
+              "08dj7fsvflxx69an6vpf3wx050mk0ycmdv401yffrrqbgxgmqsd3"))))
+   (build-system gnu-build-system)
+   (arguments
+    '(#:tests? #f
+      #:phases
+      (modify-phases %standard-phases
+        (add-after 'patch-source-shebangs 'patch-build-config
+          (lambda* (#:key outputs #:allow-other-keys)
+            (substitute* "build/unix/build.config"
+              (("/usr/local/games") (assoc-ref outputs "out")))))
+        (add-after 'set-paths 'set-sdl-paths
+          (lambda* (#:key inputs #:allow-other-keys)
+            (setenv "CPATH"
+                    (string-append (assoc-ref inputs "sdl-union")
+                                   "/include/SDL"))))
+        (replace 'configure
+          (lambda _
+            (setenv "SH" (which "sh"))
+            (zero? (system* "sh" "build.sh" "uqm" "config"))))
+        (replace 'build
+          (lambda _
+            (zero? (system* "sh" "build.sh" "uqm"))))
+        (replace 'install
+          (lambda _
+            (zero? (system* "sh" "build.sh" "uqm" "install")))))))
+   (inputs
+    `(("sdl-union" ,(sdl-union (list sdl sdl-image sdl-mixer)))
+      ("glu" ,glu)
+      ("libvorbis" ,libvorbis)
+      ("libogg" ,libogg)
+      ("libmikmod" ,libmikmod)))
+   (native-inputs
+    `(("mesa" ,mesa)
+      ("pkg-config" ,pkg-config)))
+   (home-page "http://sc2.sourceforge.net/")
+   (synopsis "Port of Star Control II for modern systems")
+   (description
+    "The Ur-Quan Masters, sometimes referred to as UQM, is a port of Star
+Control II for modern personal computers and operating systems from the
+original 3DO source code released to the fan community by Toys For Bob in
+August 2002.")
+    (license license:gpl2+)))
-- 
2.13.3

Message #8 received at 27950 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Adam Van Ymeren <adam <at> vany.ca>, 27950 <at> debbugs.gnu.org
Subject: Re: [bug#27950] [PATCH] Add The Ur-Quan Masters
Date: Mon, 07 Aug 2017 23:42:00 +0200

[Message part 1 (text/plain, inline)]

Adam Van Ymeren <adam <at> vany.ca> writes:

> This is my first package so obviously comments are welcome.  This
> package only contains the engine.  The data files are distributed as a
> few separate archives.  According to their wiki the data files are
> available under a free(ish) license (CC BY-NC-SA 2.5).  A few separate
> packages will have to be made for those I guess?  I'm not sure how to
> include multiple source files in a single package, if this is even
> supported.

Hello Adam, and welcome! Nice work for a first package. :-)

Unfortunately CC BY-NC-SA can not be included in Guix since it disallows
commercial redistribution. Do you know if there are any freely
redistributable data files available?

See 'hyperrogue' and 'git' for a couple of examples of having multiple
"origins".

> UQM uses a pretty custom looking build system so I had to replace all
> phases of the build, but it appears to work now.  After installation the
> games starts and the dies complaining about missing data files.

The patch looks good to me. Now we just need some data files :-)

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 27950 <at> debbugs.gnu.org (full text, mbox):

From: Adam Van Ymeren <adam <at> vany.ca>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 27950 <at> debbugs.gnu.org
Subject: Re: [bug#27950] [PATCH] Add The Ur-Quan Masters
Date: Tue, 08 Aug 2017 14:07:21 -0400

Marius Bakke <mbakke <at> fastmail.com> writes:

> Hello Adam, and welcome! Nice work for a first package. :-)

Thanks!

>
> Unfortunately CC BY-NC-SA can not be included in Guix since it disallows
> commercial redistribution. Do you know if there are any freely
> redistributable data files available?

Crap, I hadn't actually checked the license of the content until I was
basically done with the engine.  I see debian has packaged the content
into their "non-free" repository.

There does not appear to be any free data files, and the developers
appear to have been fairly insistant on choosing the non-commercial
creative commons license which is disappointing.

Oh well, it's probably not worth including this package unless we can
get free data files.  Due to the age of the game, perhaps the developers
could be persuaded into changing the license.  I mights send the an
email to ask.

Message #14 received at 27950 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: Adam Van Ymeren <adam <at> vany.ca>, 27950 <at> debbugs.gnu.org
Subject: Re: [bug#27950] [PATCH] Add The Ur-Quan Masters
Date: Mon, 04 Sep 2017 15:13:56 +0200

Hello,

Marius Bakke <mbakke <at> fastmail.com> skribis:

> Adam Van Ymeren <adam <at> vany.ca> writes:
>
>> This is my first package so obviously comments are welcome.  This
>> package only contains the engine.  The data files are distributed as a
>> few separate archives.  According to their wiki the data files are
>> available under a free(ish) license (CC BY-NC-SA 2.5).  A few separate
>> packages will have to be made for those I guess?  I'm not sure how to
>> include multiple source files in a single package, if this is even
>> supported.
>
> Hello Adam, and welcome! Nice work for a first package. :-)
>
> Unfortunately CC BY-NC-SA can not be included in Guix since it disallows
> commercial redistribution. Do you know if there are any freely
> redistributable data files available?

Note that the GNU FSDG are more liberal than Debian’s guidelines when it
comes to “non-functional data” such as game artwork:

  https://www.gnu.org/distros/free-system-distribution-guidelines.html

That said, the “NC” bit can probably cause practical problems, such as
if someone sells a GuixSD DVD, or if a company runs ‘guix publish’ and
happens to redistribute the thing.

Regardless, thanks for your work, Adam!

Ludo’.

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adonay Felipe Nogueira <adfeno <at> hyperbola.info>
To: guix-patches <at> gnu.org
Subject: Re: [bug#27950] [PATCH] Add The Ur-Quan Masters
Date: Wed, 06 Sep 2017 14:31:46 -0300

Yes, the "NC" part is problematic, see:
<https://www.gnu.org/distros/free-system-distribution-guidelines.html#non-functional-data>

Note that, at least for non-functional data: the GNU FSDG is more
"strict" towards system distributions than the free/libre software
philosophy is to software in general.

For the first, the work must allow freedom 2 entirely. For the latter,
only the "share" part of freedom 2.

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hello,
>
>
> Note that the GNU FSDG are more liberal than Debian’s guidelines when it
> comes to “non-functional data” such as game artwork:
>
>   https://www.gnu.org/distros/free-system-distribution-guidelines.html
>
> That said, the “NC” bit can probably cause practical problems, such as
> if someone sells a GuixSD DVD, or if a company runs ‘guix publish’ and
> happens to redistribute the thing.
>
> Regardless, thanks for your work, Adam!
>
> Ludo’.
>
>
>
>

-- 
- https://libreplanet.org/wiki/User:Adfeno
- Palestrante e consultor sobre /software/ livre (não confundir com
  gratis).
- "WhatsApp"? Ele não é livre. Por favor, use o GNU Ring ou o Tox.
- Contato: https://libreplanet.org/wiki/User:Adfeno#vCard
- Arquivos comuns aceitos (apenas sem DRM): Corel Draw, Microsoft
  Office, MP3, MP4, WMA, WMV.
- Arquivos comuns aceitos e enviados: CSV, GNU Dia, GNU Emacs Org, GNU
  GIMP, Inkscape SVG, JPG, LibreOffice (padrão ODF), OGG, OPUS, PDF
  (apenas sem DRM), PNG, TXT, WEBM.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.