GNU bug report logs - #28064
eshell-cmpl should not auto-complete ~/./

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28064 in the body.
You can then email your comments to 28064 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yegor Timoshenko <yegortimoshenko <at> gmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: eshell-cmpl should not auto-complete ~/./
Date: Sat, 12 Aug 2017 13:44:48 +0000

[Message part 1 (text/plain, inline)]

GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.16)
 of 2017-08-09

To reproduce:

M-x eshell
Type `cd ~/.` and press TAB.

It will auto-complete to `cd ~/./`. I don't think it's useful.

[Message part 2 (text/html, inline)]

Message #10 received at 28064 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Yegor Timoshenko <yegortimoshenko <at> gmail.com>, 28064 <at> debbugs.gnu.org
Subject: Re: eshell-cmpl should not auto-complete ~/./
Date: Sun, 12 Mar 2023 00:02:52 -0800

[Message part 1 (text/plain, inline)]

On 8/12/2017 6:44 AM, Yegor Timoshenko wrote:
> M-x eshell
> Type `cd ~/.` and press TAB.
> 
> It will auto-complete to `cd ~/./`. I don't think it's useful.

A much-delayed thanks for reporting this. I looked into this, and it was 
due to 'eshell-expand-user-reference' calling 'expand-file-name' on the 
argument. This meant that when you press TAB, the "~/." gets converted 
into "/home/user" before passing the command to Pcomplete. Then 
Pcomplete would incorrectly assume you wanted to complete "/home/user", 
which just becomes "/home/user/".

Attached is a fix. Normally I'd write a regression test for this, but I 
haven't come up with a good way to do this without messing up the user's 
real home directory...

[0001-Don-t-over-normalize-file-names-starting-with-in-Esh.patch (text/plain, attachment)]

Message #15 received at 28064-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Yegor Timoshenko <yegortimoshenko <at> gmail.com>, 28064-done <at> debbugs.gnu.org
Subject: Re: bug#28064: eshell-cmpl should not auto-complete ~/./
Date: Sat, 18 Mar 2023 19:58:20 -0700

On 3/12/2023 12:02 AM, Jim Porter wrote:
> Attached is a fix. Normally I'd write a regression test for this, but I 
> haven't come up with a good way to do this without messing up the user's 
> real home directory...

Merged as 6afa91f7966. Closing this now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.