X-Loop: help-debbugs@HIDDEN Subject: bug#28153: Test suite fails due to mkpart no longer taking partition label Resent-From: "A. Wilcox" <awilfox@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-parted@HIDDEN Resent-Date: Sat, 19 Aug 2017 21:58:01 +0000 Resent-Message-ID: <handler.28153.B.150317983218820 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 28153 X-GNU-PR-Package: parted X-GNU-PR-Keywords: To: 28153 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-parted@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.150317983218820 (code B ref -1); Sat, 19 Aug 2017 21:58:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Aug 2017 21:57:12 +0000 Received: from localhost ([127.0.0.1]:45902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1djBjz-0004tU-BL for submit <at> debbugs.gnu.org; Sat, 19 Aug 2017 17:57:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <awilfox@HIDDEN>) id 1djBjx-0004tH-PO for submit <at> debbugs.gnu.org; Sat, 19 Aug 2017 17:57:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <awilfox@HIDDEN>) id 1djBjr-0007Zk-AB for submit <at> debbugs.gnu.org; Sat, 19 Aug 2017 17:57:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43778) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <awilfox@HIDDEN>) id 1djBjr-0007Ze-6U for submit <at> debbugs.gnu.org; Sat, 19 Aug 2017 17:57:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <awilfox@HIDDEN>) id 1djBjp-000884-Ug for bug-parted@HIDDEN; Sat, 19 Aug 2017 17:57:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <awilfox@HIDDEN>) id 1djBjm-0007Xv-Sl for bug-parted@HIDDEN; Sat, 19 Aug 2017 17:57:02 -0400 Received: from mail.wilcox-tech.com ([45.32.83.9]:40598) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <awilfox@HIDDEN>) id 1djBjm-0007Wx-Ix for bug-parted@HIDDEN; Sat, 19 Aug 2017 17:56:58 -0400 Received: (qmail 19445 invoked from network); 19 Aug 2017 21:56:53 -0000 Received: from ip68-13-242-69.ok.ok.cox.net (HELO ?10.1.1.57?) (awilcox@HIDDEN@68.13.242.69) by mail.wilcox-tech.com with ESMTPA; 19 Aug 2017 21:56:53 -0000 From: "A. Wilcox" <awilfox@HIDDEN> Organization: =?UTF-8?Q?Ad=C3=A9lie?= Linux Message-ID: <5998B41F.503@HIDDEN> Date: Sat, 19 Aug 2017 16:56:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="65Qq4gDItSBSjbusVAuhTl5RFmh4s1D4o" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -4.1 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --65Qq4gDItSBSjbusVAuhTl5RFmh4s1D4o Content-Type: multipart/mixed; boundary="------------090705040209070002050803" This is a multi-part message in MIME format. --------------090705040209070002050803 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable While testing parted 3.2 for our new Linux distribution, I came across a few test failures; they were all due to 'mkpart' no longer naming partitions. I believe this patch to correct this. Best, --arw --=20 A. Wilcox (awilfox) Project Lead, Ad=C3=A9lie Linux http://adelielinux.org --------------090705040209070002050803 Content-Type: text/x-patch; name="tests-call-name-correctly.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="tests-call-name-correctly.patch" mkpart syntax recently changed, tests do not reflect that. --- parted-3.2/tests/t5000-tags.sh.old 2014-06-15 18:17:43.000000000 +000= 0 +++ parted-3.2/tests/t5000-tags.sh 2017-08-19 18:55:03.207451920 +0000 @@ -48,7 +48,7 @@ compare exp out || fail=3D1 =20 # add a partition -parted -s $dev u s mkpart name1 ${start_sector} ${end_sector} >out 2>&1 = \ +parted -s $dev u s mkpart primary ${start_sector} ${end_sector} name 1 n= ame1 >out 2>&1 \ || fail=3D1 =20 # print the table before modification --- parted-3.2/tests/t0208-mkpart-end-in-IEC.sh.old 2014-06-15 18:17:43.0= 00000000 +0000 +++ parted-3.2/tests/t0208-mkpart-end-in-IEC.sh 2017-08-19 20:05:19.65087= 5813 +0000 @@ -25,22 +25,22 @@ =20 dd if=3D/dev/null of=3D$dev bs=3D1M seek=3D$n_mbs || fail=3D1 # create 1st partition -parted --align=3Dnone -s $dev mklabel gpt mkpart p1 1MiB 2MiB > err 2>&1= || fail=3D1 +parted --align=3Dnone -s $dev mklabel gpt mkpart primary 1MiB 2MiB name = 1 p1 > err 2>&1 || fail=3D1 compare /dev/null err || fail=3D1 # expect no output #parted -m -s $dev u s p > exp || fail=3D1 =20 # create 2nd partition - they should not overlap # this time specify default unit -parted --align=3Dnone -s $dev unit MiB mkpart p2 2 3 > err 2>&1 || fail=3D= 1 +parted --align=3Dnone -s $dev unit MiB mkpart primary 2 3 name 2 p2 > er= r 2>&1 || fail=3D1 compare /dev/null err || fail=3D1 # expect no output =20 # create 3rd partition - expect no overlap # specify default unit, but explicitly override it -parted --align=3Dnone -s $dev unit TB mkpart p3 3MiB 4MiB > err 2>&1 || = fail=3D1 +parted --align=3Dnone -s $dev unit TB mkpart primary 3MiB 4MiB name 3 p3= > err 2>&1 || fail=3D1 compare /dev/null err || fail=3D1 # expect no output =20 # Specify default unit of MiB, yet use explicit ending sector number. -parted --align=3Dnone -s $dev unit MiB mkpart p4 4MiB 10239s > err 2>&1 = || fail=3D1 +parted --align=3Dnone -s $dev unit MiB mkpart primary 4MiB 10239s name 4= p4 > err 2>&1 || fail=3D1 compare /dev/null err || fail=3D1 # expect no output =20 # check boundaries of the partitions --------------090705040209070002050803-- --65Qq4gDItSBSjbusVAuhTl5RFmh4s1D4o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZmLQgAAoJEMspy1GSK50Uf70P/ivAsCBeRz6qCGf0LLntwArF xuQsKn9SriP3Tpp1Y+S2enHbOJ3pUaqPIaKVC0IlA6eQ8rCivW+OmUiOWajKBmFe meYjk7b6azHz2oAzNW0fyP7oF2pK/cITo9q8SQdIH5EfLTqYvmWbNrYdPAi+NL0R Q35BKjQ8rrACTE84GPDZ4CGsjDgJIDQoEsbxXjhHzx6r5uhfXnhTA2f/sIi9kn1x GVcp75LD/2vk+5RDb6tXKYuyWwsCaeA9OgmNJrHf/messGUwyREppba4uCEts4sB be6oMoshWUZJp3Ff5Nsnqh9dng9fRtpt8QcShZKFHQvCR1OmGR2u3QJ2J7gak16a M9ixyGZV9QFwH60cCiLpkYJGfEOTVW7HNdBcAteAD8begSOscz31BTZIcYUPi9m6 DcaQmBFW98oLCUhFsvEwpr7o1KA07T6mvvGQ3ZnUQXHnoTSv59+QXBYM2y9Qbtz8 r0huxUXjira+7OPJAwv172zUTQUd0V5blhufBOxMClvfZm2fX7pDSvUxM8hlrDjE 08E7KZm60eLmcyB3e70hReGshOVbmWObOqYv9MrBU4KVjnJaNZe4dqGudA0iu1D5 i3BBOOwurMMEREyqjt2MrKaDp/m4PiOamCY+fwqAulgCJ62YAcRkAsM3aOSKedxD KX/4V7xeOCnBznzgUjIv =rhnu -----END PGP SIGNATURE----- --65Qq4gDItSBSjbusVAuhTl5RFmh4s1D4o--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: "A. Wilcox" <awilfox@HIDDEN> Subject: bug#28153: Acknowledgement (Test suite fails due to mkpart no longer taking partition label) Message-ID: <handler.28153.B.150317983218820.ack <at> debbugs.gnu.org> References: <5998B41F.503@HIDDEN> X-Gnu-PR-Message: ack 28153 X-Gnu-PR-Package: parted Reply-To: 28153 <at> debbugs.gnu.org Date: Sat, 19 Aug 2017 21:58:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-parted@HIDDEN If you wish to submit further information on this problem, please send it to 28153 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 28153: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28153 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#28153: Test suite fails due to mkpart no longer taking partition label Resent-From: "Brian C. Lane" <bcl@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-parted@HIDDEN Resent-Date: Tue, 12 Sep 2017 17:26:02 +0000 Resent-Message-ID: <handler.28153.B28153.150523715624177 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 28153 X-GNU-PR-Package: parted X-GNU-PR-Keywords: To: "A. Wilcox" <awilfox@HIDDEN> Cc: 28153 <at> debbugs.gnu.org Received: via spool by 28153-submit <at> debbugs.gnu.org id=B28153.150523715624177 (code B ref 28153); Tue, 12 Sep 2017 17:26:02 +0000 Received: (at 28153) by debbugs.gnu.org; 12 Sep 2017 17:25:56 +0000 Received: from localhost ([127.0.0.1]:36254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1drowd-0006Ht-MY for submit <at> debbugs.gnu.org; Tue, 12 Sep 2017 13:25:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <bcl@HIDDEN>) id 1drowa-0006Hb-35 for 28153 <at> debbugs.gnu.org; Tue, 12 Sep 2017 13:25:52 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 481C4356D3; Tue, 12 Sep 2017 17:25:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 481C4356D3 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=bcl@HIDDEN Received: from lister.brianlane.com (ovpn-112-32.phx2.redhat.com [10.3.112.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 914EB6FA84; Tue, 12 Sep 2017 17:25:45 +0000 (UTC) Date: Tue, 12 Sep 2017 10:25:42 -0700 From: "Brian C. Lane" <bcl@HIDDEN> Message-ID: <20170912172542.GT27555@HIDDEN> References: <5998B41F.503@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5998B41F.503@HIDDEN> User-Agent: Mutt/1.8.3 (2017-05-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 12 Sep 2017 17:25:46 +0000 (UTC) X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.0 (-----) On Sat, Aug 19, 2017 at 04:56:47PM -0500, A. Wilcox wrote: > While testing parted 3.2 for our new Linux distribution, I came across a > few test failures; they were all due to 'mkpart' no longer naming > partitions. I believe this patch to correct this. > No longer naming partitions is a bug. What version of parted are you using? I'm not seeing this behavior with Fedora 25 and parted 3.2 (+ patches) -- Brian C. Lane (PST8PDT)
X-Loop: help-debbugs@HIDDEN Subject: bug#28153: Test suite fails due to mkpart no longer taking partition label Resent-From: "A. Wilcox" <awilfox@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-parted@HIDDEN Resent-Date: Tue, 12 Sep 2017 20:28:02 +0000 Resent-Message-ID: <handler.28153.B28153.15052480748485 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 28153 X-GNU-PR-Package: parted X-GNU-PR-Keywords: To: "Brian C. Lane" <bcl@HIDDEN> Cc: 28153 <at> debbugs.gnu.org Received: via spool by 28153-submit <at> debbugs.gnu.org id=B28153.15052480748485 (code B ref 28153); Tue, 12 Sep 2017 20:28:02 +0000 Received: (at 28153) by debbugs.gnu.org; 12 Sep 2017 20:27:54 +0000 Received: from localhost ([127.0.0.1]:36391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1drrmk-0002Cm-4h for submit <at> debbugs.gnu.org; Tue, 12 Sep 2017 16:27:54 -0400 Received: from mail.wilcox-tech.com ([45.32.83.9]:60202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <awilfox@HIDDEN>) id 1drrmi-0002Ce-5K for 28153 <at> debbugs.gnu.org; Tue, 12 Sep 2017 16:27:52 -0400 Received: (qmail 25313 invoked from network); 12 Sep 2017 20:27:47 -0000 Received: from 107-131-85-42.lightspeed.tulsok.sbcglobal.net (HELO ?192.168.1.157?) (awilcox@HIDDEN@107.131.85.42) by mail.wilcox-tech.com with ESMTPA; 12 Sep 2017 20:27:47 -0000 References: <5998B41F.503@HIDDEN> <20170912172542.GT27555@HIDDEN> From: "A. Wilcox" <awilfox@HIDDEN> Organization: =?UTF-8?Q?Ad=C3=A9lie?= Linux Message-ID: <59B84340.7070409@HIDDEN> Date: Tue, 12 Sep 2017 15:27:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20170912172542.GT27555@HIDDEN> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 12/09/17 12:25, Brian C. Lane wrote: > On Sat, Aug 19, 2017 at 04:56:47PM -0500, A. Wilcox wrote: >> While testing parted 3.2 for our new Linux distribution, I came >> across a few test failures; they were all due to 'mkpart' no >> longer naming partitions. I believe this patch to correct this. >> > > No longer naming partitions is a bug. What version of parted are > you using? I'm not seeing this behavior with Fedora 25 and parted > 3.2 (+ patches) > This is Adélie Linux, a fork of Alpine Linux, based on musl libc. We are using parted 3.2 with no patches (at least, beyond the test suite patches that I sent). I thought that this was a simple syntax change, and didn't realise that it wasn't intentional / the actual bug. Sorry. I can investigate further after our current package push is finished. All the best, - --arw - -- A. Wilcox (awilfox) Project Lead, Adélie Linux http://adelielinux.org -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZuEMwAAoJEMspy1GSK50UqREP/2vIsdR8PHalI4qCIBZcW53J Rgnhgekt6+3G4MvHqRkggfM0e2zaRiVydPK99myZ6KhZCI22kfYScL0LOFfNioY/ p/SyGhLYM9X62Z9E0XJaL2ygDdBZw1Aem/9111gO5FKmv7DmL5aIhSgDFzmA3+iK nI4VXAMsCS7MoVog14isBKWrAonCEI8kZis/8cIOyHX/vnxlvIlnVtCqQScL2a1Q /1CuKYH2PI/RFSUTLFE5q7Xypk7BR6/Zdg1t66OLhTh8oX6qUTXk47Ai1goprR4z zyMDUMZqjCIj7rQHXkxcbTOA/1rGVKlRbBPvHM1ZE+k1qNq4PWS6Po4//Nuo13iA 49DMvQUJfvUazZxZwVkizmwkgR83bMUVt7lXBgInWMwM1UZHEVzIJay7ZOAWqRDR QPsaBJmEmoRkjUaO638iFXqtjFRreij3VWn/J0BARjWajpw+ryWPVjxQCTYawt7a LKTpAsi4/TUL/YtU0A2T5ZaN4D6oxFdomuW2+gz7TuyT5a3pIzEe5x602jl7aZG+ PruAfXlvaG9p+WX+xcPqd5H6jlWTdNREVmQj8H/NmNJXY8mIld+UMNkrZjKmD5PH GIoIXAgJBLrlml4qJ6X7pSsec+OMw3cdIs7MlahF4TCwlOqMIH8j8emGIkPET5En YN6SljiEobD6Bi+9EfiW =IuIN -----END PGP SIGNATURE-----
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.