GNU bug report logs - #28170
Add gnutls/dane + use it where its needed (gnurl, libmicrohttpd, gnunet)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28170 in the body.
You can then email your comments to 28170 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: guix-patches <at> gnu.org
Subject: Add gnutls/dane + use it where its needed (gnurl, libmicrohttpd,
 gnunet)
Date: Mon, 21 Aug 2017 09:57:26 +0000

[Message part 1 (text/plain, inline)]

The dependency chain of GNUnet demands GnuTLS with DANE support.
You can use it without DANE, but there are certain parts which
will not work. DANE is recommended. (ports of FREEBSD uses
gnutls-dane for libmicrohttpd aswell for example).

The attached patches:
- Add 'gnutls/dane'
- Use it in
  - libmicrohttpd
  - gnurl
  - gnunet
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[0001-gnu-gnutls-Add-gnutls-dane.patch (text/plain, attachment)]

[0002-gnu-gnurl-Use-gnutls-dane-as-input.patch (text/plain, attachment)]

[0003-gnu-libmicrohttpd-Use-gnutls-dane-as-input.patch (text/plain, attachment)]

[0004-gnu-gnunet-Use-gnutls-dane-as-input.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 28170 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28170 <at> debbugs.gnu.org
Subject: Re: [bug#28170] Add gnutls/dane + use it where its needed (gnurl,
 libmicrohttpd, gnunet)
Date: Sat, 30 Sep 2017 12:26:16 +0100

[Message part 1 (text/plain, inline)]

On Mon, 21 Aug 2017 09:57:26 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> The dependency chain of GNUnet demands GnuTLS with DANE support.
> You can use it without DANE, but there are certain parts which
> will not work. DANE is recommended. (ports of FREEBSD uses
> gnutls-dane for libmicrohttpd aswell for example).

> From c9dedfd1a6f91d557006b00505a428be84102b1e Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> infotropique.org>
> Date: Mon, 21 Aug 2017 09:28:51 +0000
> Subject: [PATCH 1/4] gnu: gnutls: Add 'gnutls-dane'.
> 
> * gnu/packages/tls.scm (gnutls/dane): New variable.

Hey, so I'm trying to do some reviewing.

What was your reasoning for creating a new gnutls/dane package, rather
than adding unbound to the existing gnutls package?

I don't know much about GnuTLS, but it would be good to make it clear
why this approach was taken, especially in the commit message and by
the gnutls/dane package definition.

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 28170 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 28170 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28170] Add gnutls/dane + use it where its needed (gnurl,
 libmicrohttpd, gnunet)
Date: Sat, 30 Sep 2017 12:23:09 +0000

[Message part 1 (text/plain, inline)]

Christopher Baines transcribed 2.1K bytes:
> On Mon, 21 Aug 2017 09:57:26 +0000
> ng0 <ng0 <at> infotropique.org> wrote:
> 
> > The dependency chain of GNUnet demands GnuTLS with DANE support.
> > You can use it without DANE, but there are certain parts which
> > will not work. DANE is recommended. (ports of FREEBSD uses
> > gnutls-dane for libmicrohttpd aswell for example).
> 
> > From c9dedfd1a6f91d557006b00505a428be84102b1e Mon Sep 17 00:00:00 2001
> > From: ng0 <ng0 <at> infotropique.org>
> > Date: Mon, 21 Aug 2017 09:28:51 +0000
> > Subject: [PATCH 1/4] gnu: gnutls: Add 'gnutls-dane'.
> > 
> > * gnu/packages/tls.scm (gnutls/dane): New variable.
> 
> Hey, so I'm trying to do some reviewing.
> 
> What was your reasoning for creating a new gnutls/dane package, rather
> than adding unbound to the existing gnutls package?
> 
> I don't know much about GnuTLS, but it would be good to make it clear
> why this approach was taken, especially in the commit message and by
> the gnutls/dane package definition.

Honestly, I did not want to touch the gnutls package for this.
I wanted to leave the option open to have gnutls without dane.
Sure, it's a useful feature. If you think I should apply it
directly to gnutls, tell me and I'll send a new patch.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 28170 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28170 <at> debbugs.gnu.org
Subject: Re: [bug#28170] Add gnutls/dane + use it where its needed (gnurl,
 libmicrohttpd, gnunet)
Date: Sat, 30 Sep 2017 13:43:46 +0100

[Message part 1 (text/plain, inline)]

On Sat, 30 Sep 2017 12:23:09 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> Christopher Baines transcribed 2.1K bytes:
> > On Mon, 21 Aug 2017 09:57:26 +0000
> > ng0 <ng0 <at> infotropique.org> wrote:
> >   
> > > The dependency chain of GNUnet demands GnuTLS with DANE support.
> > > You can use it without DANE, but there are certain parts which
> > > will not work. DANE is recommended. (ports of FREEBSD uses
> > > gnutls-dane for libmicrohttpd aswell for example).  
> >   
> > > From c9dedfd1a6f91d557006b00505a428be84102b1e Mon Sep 17 00:00:00
> > > 2001 From: ng0 <ng0 <at> infotropique.org>
> > > Date: Mon, 21 Aug 2017 09:28:51 +0000
> > > Subject: [PATCH 1/4] gnu: gnutls: Add 'gnutls-dane'.
> > > 
> > > * gnu/packages/tls.scm (gnutls/dane): New variable.  
> > 
> > Hey, so I'm trying to do some reviewing.
> > 
> > What was your reasoning for creating a new gnutls/dane package,
> > rather than adding unbound to the existing gnutls package?
> > 
> > I don't know much about GnuTLS, but it would be good to make it
> > clear why this approach was taken, especially in the commit message
> > and by the gnutls/dane package definition.  
> 
> Honestly, I did not want to touch the gnutls package for this.
> I wanted to leave the option open to have gnutls without dane.
> Sure, it's a useful feature. If you think I should apply it
> directly to gnutls, tell me and I'll send a new patch.

I'm happy with that reason, if you could put that in the relevant
commit message, or in a comment by the gnutls/dane package definition
(or both), I'll check I can build all the changed packages, and push
if they all build for me.

[Message part 2 (application/pgp-signature, inline)]

Message #17 received at 28170 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 28170 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28170] Add gnutls/dane + use it where its needed (gnurl,
 libmicrohttpd, gnunet)
Date: Sat, 30 Sep 2017 14:01:44 +0000

[Message part 1 (text/plain, inline)]

Christopher Baines transcribed 2.8K bytes:
> On Sat, 30 Sep 2017 12:23:09 +0000
> ng0 <ng0 <at> infotropique.org> wrote:
> 
> > Christopher Baines transcribed 2.1K bytes:
> > > On Mon, 21 Aug 2017 09:57:26 +0000
> > > ng0 <ng0 <at> infotropique.org> wrote:
> > >   
> > > > The dependency chain of GNUnet demands GnuTLS with DANE support.
> > > > You can use it without DANE, but there are certain parts which
> > > > will not work. DANE is recommended. (ports of FREEBSD uses
> > > > gnutls-dane for libmicrohttpd aswell for example).  
> > >   
> > > > From c9dedfd1a6f91d557006b00505a428be84102b1e Mon Sep 17 00:00:00
> > > > 2001 From: ng0 <ng0 <at> infotropique.org>
> > > > Date: Mon, 21 Aug 2017 09:28:51 +0000
> > > > Subject: [PATCH 1/4] gnu: gnutls: Add 'gnutls-dane'.
> > > > 
> > > > * gnu/packages/tls.scm (gnutls/dane): New variable.  
> > > 
> > > Hey, so I'm trying to do some reviewing.
> > > 
> > > What was your reasoning for creating a new gnutls/dane package,
> > > rather than adding unbound to the existing gnutls package?
> > > 
> > > I don't know much about GnuTLS, but it would be good to make it
> > > clear why this approach was taken, especially in the commit message
> > > and by the gnutls/dane package definition.  
> > 
> > Honestly, I did not want to touch the gnutls package for this.
> > I wanted to leave the option open to have gnutls without dane.
> > Sure, it's a useful feature. If you think I should apply it
> > directly to gnutls, tell me and I'll send a new patch.
> 
> I'm happy with that reason, if you could put that in the relevant
> commit message, or in a comment by the gnutls/dane package definition
> (or both), I'll check I can build all the changed packages, and push
> if they all build for me.

Okay. Appended.

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org

[0001-gnu-gnutls-Add-gnutls-dane.patch (text/plain, attachment)]

[0002-gnu-gnurl-Use-gnutls-dane-as-input.patch (text/plain, attachment)]

[0003-gnu-libmicrohttpd-Use-gnutls-dane-as-input.patch (text/plain, attachment)]

[0004-gnu-gnunet-Use-gnutls-dane-as-input.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 28170 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 28170 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28170] Add gnutls/dane + use it where its needed (gnurl,
 libmicrohttpd, gnunet)
Date: Sat, 30 Sep 2017 14:03:41 +0000

[Message part 1 (text/plain, inline)]

Christopher Baines transcribed 2.8K bytes:
> On Sat, 30 Sep 2017 12:23:09 +0000
> ng0 <ng0 <at> infotropique.org> wrote:
> 
> > Christopher Baines transcribed 2.1K bytes:
> > > On Mon, 21 Aug 2017 09:57:26 +0000
> > > ng0 <ng0 <at> infotropique.org> wrote:
> > >   
> > > > The dependency chain of GNUnet demands GnuTLS with DANE support.
> > > > You can use it without DANE, but there are certain parts which
> > > > will not work. DANE is recommended. (ports of FREEBSD uses
> > > > gnutls-dane for libmicrohttpd aswell for example).  
> > >   
> > > > From c9dedfd1a6f91d557006b00505a428be84102b1e Mon Sep 17 00:00:00
> > > > 2001 From: ng0 <ng0 <at> infotropique.org>
> > > > Date: Mon, 21 Aug 2017 09:28:51 +0000
> > > > Subject: [PATCH 1/4] gnu: gnutls: Add 'gnutls-dane'.
> > > > 
> > > > * gnu/packages/tls.scm (gnutls/dane): New variable.  
> > > 
> > > Hey, so I'm trying to do some reviewing.
> > > 
> > > What was your reasoning for creating a new gnutls/dane package,
> > > rather than adding unbound to the existing gnutls package?
> > > 
> > > I don't know much about GnuTLS, but it would be good to make it
> > > clear why this approach was taken, especially in the commit message
> > > and by the gnutls/dane package definition.  
> > 
> > Honestly, I did not want to touch the gnutls package for this.
> > I wanted to leave the option open to have gnutls without dane.
> > Sure, it's a useful feature. If you think I should apply it
> > directly to gnutls, tell me and I'll send a new patch.
> 
> I'm happy with that reason, if you could put that in the relevant
> commit message, or in a comment by the gnutls/dane package definition
> (or both), I'll check I can build all the changed packages, and push
> if they all build for me.


…and I need to send it again, there were some changes introduced which
broke this package it seems.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 28170 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 28170 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28170] Add gnutls/dane + use it where its needed (gnurl,
 libmicrohttpd, gnunet)
Date: Sat, 30 Sep 2017 14:12:55 +0000

[Message part 1 (text/plain, inline)]

The fix in this version is to only add the necessary input
to the inherited gnutls.

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org

[0001-gnu-gnutls-Add-gnutls-dane.patch (text/plain, attachment)]

[0002-gnu-gnurl-Use-gnutls-dane-as-input.patch (text/plain, attachment)]

[0003-gnu-libmicrohttpd-Use-gnutls-dane-as-input.patch (text/plain, attachment)]

[0004-gnu-gnunet-Use-gnutls-dane-as-input.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 28170 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28170 <at> debbugs.gnu.org
Subject: Re: [bug#28170] Add gnutls/dane + use it where its needed (gnurl,
 libmicrohttpd, gnunet)
Date: Sat, 30 Sep 2017 15:34:44 +0100

[Message part 1 (text/plain, inline)]

On Sat, 30 Sep 2017 14:12:55 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> The fix in this version is to only add the necessary input
> to the inherited gnutls.

Ok. One hopefully final thing. From the commit message [1], it's not
clear to me if this is fixing an issue with the GNUnet package, by
providing it with the right dependencies, or, adding additional
functionality to the GNUnet package, by providing a more capable GnuTLS?

1: "GNUnet and its dependency chain needs GnuTLS with DANE support."

[Message part 2 (application/pgp-signature, inline)]

Message #29 received at 28170 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 28170 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28170] Add gnutls/dane + use it where its needed (gnurl,
 libmicrohttpd, gnunet)
Date: Sat, 30 Sep 2017 14:56:36 +0000

[Message part 1 (text/plain, inline)]

Christopher Baines transcribed 1.7K bytes:
> On Sat, 30 Sep 2017 14:12:55 +0000
> ng0 <ng0 <at> infotropique.org> wrote:
> 
> > The fix in this version is to only add the necessary input
> > to the inherited gnutls.
> 
> Ok. One hopefully final thing. From the commit message [1], it's not
> clear to me if this is fixing an issue with the GNUnet package, by
> providing it with the right dependencies, or, adding additional
> functionality to the GNUnet package, by providing a more capable GnuTLS?
> 
> 1: "GNUnet and its dependency chain needs GnuTLS with DANE support."
> 
It provides the right GnuTLS to GNUnet, libmicrohttpd and gnURL.
Certain features of these applications will not work without it.
GnuTLS without Dane is not fatal error for these packages, but
Dane is recommended.
I have no idea how I should put this into the very strict dictionary
we have in commit messages… In more free-form it would be no problem
for me.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 28170 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 28170 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28170] Add gnutls/dane + use it where its needed (gnurl,
 libmicrohttpd, gnunet)
Date: Sat, 30 Sep 2017 15:01:52 +0000

[Message part 1 (text/plain, inline)]

ng0 transcribed 2.1K bytes:
> Christopher Baines transcribed 1.7K bytes:
> > On Sat, 30 Sep 2017 14:12:55 +0000
> > ng0 <ng0 <at> infotropique.org> wrote:
> > 
> > > The fix in this version is to only add the necessary input
> > > to the inherited gnutls.
> > 
> > Ok. One hopefully final thing. From the commit message [1], it's not
> > clear to me if this is fixing an issue with the GNUnet package, by
> > providing it with the right dependencies, or, adding additional
> > functionality to the GNUnet package, by providing a more capable GnuTLS?
> > 
> > 1: "GNUnet and its dependency chain needs GnuTLS with DANE support."
> > 
> It provides the right GnuTLS to GNUnet, libmicrohttpd and gnURL.
> Certain features of these applications will not work without it.
> GnuTLS without Dane is not fatal error for these packages, but
> Dane is recommended.
> I have no idea how I should put this into the very strict dictionary
> we have in commit messages… In more free-form it would be no problem
> for me.
> -- 
> ng0
> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> GnuPG: https://krosos.org/dist/keys/
> https://www.infotropique.org https://krosos.org

Okay, I now see what you mean.

To make it short: the correct dependency is provided in place
of the current working-but-not-correct GnuTLS.

Is that more clear?

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 28170 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28170 <at> debbugs.gnu.org
Subject: Re: [bug#28170] Add gnutls/dane + use it where its needed (gnurl,
 libmicrohttpd, gnunet)
Date: Sat, 30 Sep 2017 17:05:04 +0100

[Message part 1 (text/plain, inline)]

On Sat, 30 Sep 2017 15:01:52 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> ng0 transcribed 2.1K bytes:
> > Christopher Baines transcribed 1.7K bytes:  
> > > On Sat, 30 Sep 2017 14:12:55 +0000
> > > ng0 <ng0 <at> infotropique.org> wrote:
> > >   
> > > > The fix in this version is to only add the necessary input
> > > > to the inherited gnutls.  
> > > 
> > > Ok. One hopefully final thing. From the commit message [1], it's
> > > not clear to me if this is fixing an issue with the GNUnet
> > > package, by providing it with the right dependencies, or, adding
> > > additional functionality to the GNUnet package, by providing a
> > > more capable GnuTLS?
> > > 
> > > 1: "GNUnet and its dependency chain needs GnuTLS with DANE
> > > support." 
> > It provides the right GnuTLS to GNUnet, libmicrohttpd and gnURL.
> > Certain features of these applications will not work without it.
> > GnuTLS without Dane is not fatal error for these packages, but
> > Dane is recommended.
> > I have no idea how I should put this into the very strict dictionary
> > we have in commit messages… In more free-form it would be no problem
> > for me.
> > -- 
> > ng0
> > GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> > GnuPG: https://krosos.org/dist/keys/
> > https://www.infotropique.org https://krosos.org  
> 
> Okay, I now see what you mean.
> 
> To make it short: the correct dependency is provided in place
> of the current working-but-not-correct GnuTLS.
> 
> Is that more clear?

I think you've made it clear to me now.

From what you're saying, I think its the 2nd thing I said. Making this
change will enable some functionality in the GNUnet package (and
possibly some of the other packages changed).

I'm not sure using the word "correct" helps, unless you say what the
dependencies are correct/incorrect with respect to, for example, if the
GNUnet documentation says that it should be built with GnuTLS with Dane
support, then that would be a reason to talk about correctness.

As for the commit format. As I understand the conventions, you can put
anything in between the first line, and the changelog at the bottom.
For example, one case where I ended up writing quite a bit is here [1].

It doesn't have to be very specific, but something about the intent or
intended effect of the change in each commit would be very useful.

1:
http://git.savannah.gnu.org/cgit/guix.git/commit/?id=6230e155afd8c43c12ee3f03032aac34433db11a

[Message part 2 (application/pgp-signature, inline)]

Message #38 received at 28170 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 28170 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28170] Add gnutls/dane + use it where its needed (gnurl,
 libmicrohttpd, gnunet)
Date: Sat, 30 Sep 2017 16:36:05 +0000

[Message part 1 (text/plain, inline)]

Christopher Baines transcribed 3.6K bytes:
> On Sat, 30 Sep 2017 15:01:52 +0000
> ng0 <ng0 <at> infotropique.org> wrote:
> 
> > ng0 transcribed 2.1K bytes:
> > > Christopher Baines transcribed 1.7K bytes:  
> > > > On Sat, 30 Sep 2017 14:12:55 +0000
> > > > ng0 <ng0 <at> infotropique.org> wrote:
> > > >   
> > > > > The fix in this version is to only add the necessary input
> > > > > to the inherited gnutls.  
> > > > 
> > > > Ok. One hopefully final thing. From the commit message [1], it's
> > > > not clear to me if this is fixing an issue with the GNUnet
> > > > package, by providing it with the right dependencies, or, adding
> > > > additional functionality to the GNUnet package, by providing a
> > > > more capable GnuTLS?
> > > > 
> > > > 1: "GNUnet and its dependency chain needs GnuTLS with DANE
> > > > support." 
> > > It provides the right GnuTLS to GNUnet, libmicrohttpd and gnURL.
> > > Certain features of these applications will not work without it.
> > > GnuTLS without Dane is not fatal error for these packages, but
> > > Dane is recommended.
> > > I have no idea how I should put this into the very strict dictionary
> > > we have in commit messages… In more free-form it would be no problem
> > > for me.
> > > -- 
> > > ng0
> > > GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> > > GnuPG: https://krosos.org/dist/keys/
> > > https://www.infotropique.org https://krosos.org  
> > 
> > Okay, I now see what you mean.
> > 
> > To make it short: the correct dependency is provided in place
> > of the current working-but-not-correct GnuTLS.
> > 
> > Is that more clear?
> 
> I think you've made it clear to me now.
> 
> From what you're saying, I think its the 2nd thing I said. Making this
> change will enable some functionality in the GNUnet package (and
> possibly some of the other packages changed).
> 
> I'm not sure using the word "correct" helps, unless you say what the
> dependencies are correct/incorrect with respect to, for example, if the
> GNUnet documentation says that it should be built with GnuTLS with Dane
> support, then that would be a reason to talk about correctness.

Yes it does state this, in the documentation and all these applications
list the dependency in README aswell.
This is why I thought the original, first version, comment I made in
gnutls/dane was enough. But I'll have to be more clear then.
Well if gnURL doesn't state it in its README I have to add it, if it's
not in there it's my mistake - it's correct nevertheless.

> As for the commit format. As I understand the conventions, you can put
> anything in between the first line, and the changelog at the bottom.
> For example, one case where I ended up writing quite a bit is here [1].
> 
> It doesn't have to be very specific, but something about the intent or
> intended effect of the change in each commit would be very useful.
> 
> 1:
> http://git.savannah.gnu.org/cgit/guix.git/commit/?id=6230e155afd8c43c12ee3f03032aac34433db11a

Okay, thanks. I will change the commit messages and
reference our (GNUnet) README and documentation sections.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org

[0001-gnu-gnutls-Add-gnutls-dane.patch (text/plain, attachment)]

[0002-gnu-gnurl-Use-gnutls-dane-as-input.patch (text/plain, attachment)]

[0003-gnu-libmicrohttpd-Use-gnutls-dane-as-input.patch (text/plain, attachment)]

[0004-gnu-gnunet-Use-gnutls-dane-as-input.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #41 received at 28170 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28170 <at> debbugs.gnu.org
Subject: Re: [bug#28170] Add gnutls/dane + use it where its needed (gnurl,
 libmicrohttpd, gnunet)
Date: Sat, 30 Sep 2017 18:38:15 +0100

[Message part 1 (text/plain, inline)]

On Sat, 30 Sep 2017 16:36:05 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> Christopher Baines transcribed 3.6K bytes:
> > On Sat, 30 Sep 2017 15:01:52 +0000
> > ng0 <ng0 <at> infotropique.org> wrote:
> >   
> > > ng0 transcribed 2.1K bytes:  
> > > > Christopher Baines transcribed 1.7K bytes:    
> > > > > On Sat, 30 Sep 2017 14:12:55 +0000
> > > > > ng0 <ng0 <at> infotropique.org> wrote:
> > > > >     
> > > > > > The fix in this version is to only add the necessary input
> > > > > > to the inherited gnutls.    
> > > > > 
> > > > > Ok. One hopefully final thing. From the commit message [1],
> > > > > it's not clear to me if this is fixing an issue with the
> > > > > GNUnet package, by providing it with the right dependencies,
> > > > > or, adding additional functionality to the GNUnet package, by
> > > > > providing a more capable GnuTLS?
> > > > > 
> > > > > 1: "GNUnet and its dependency chain needs GnuTLS with DANE
> > > > > support."   
> > > > It provides the right GnuTLS to GNUnet, libmicrohttpd and gnURL.
> > > > Certain features of these applications will not work without it.
> > > > GnuTLS without Dane is not fatal error for these packages, but
> > > > Dane is recommended.
> > > > I have no idea how I should put this into the very strict
> > > > dictionary we have in commit messages… In more free-form it
> > > > would be no problem for me.
> > > > -- 
> > > > ng0
> > > > GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> > > > GnuPG: https://krosos.org/dist/keys/
> > > > https://www.infotropique.org https://krosos.org    
> > > 
> > > Okay, I now see what you mean.
> > > 
> > > To make it short: the correct dependency is provided in place
> > > of the current working-but-not-correct GnuTLS.
> > > 
> > > Is that more clear?  
> > 
> > I think you've made it clear to me now.
> > 
> > From what you're saying, I think its the 2nd thing I said. Making
> > this change will enable some functionality in the GNUnet package
> > (and possibly some of the other packages changed).
> > 
> > I'm not sure using the word "correct" helps, unless you say what the
> > dependencies are correct/incorrect with respect to, for example, if
> > the GNUnet documentation says that it should be built with GnuTLS
> > with Dane support, then that would be a reason to talk about
> > correctness.  
> 
> Yes it does state this, in the documentation and all these
> applications list the dependency in README aswell.
> This is why I thought the original, first version, comment I made in
> gnutls/dane was enough. But I'll have to be more clear then.
> Well if gnURL doesn't state it in its README I have to add it, if it's
> not in there it's my mistake - it's correct nevertheless.

Ah yes, I didn't really take in that comment in when I read the patch,
but I can see it now "This is required for GNS functionality by
GNUnet and gnURL.". That's great information, and having it in the
commit would also be great.

[Message part 2 (application/pgp-signature, inline)]

Message #46 received at 28170-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28170-done <at> debbugs.gnu.org
Subject: Re: [bug#28170] Add gnutls/dane + use it where its needed (gnurl,
 libmicrohttpd, gnunet)
Date: Sun, 1 Oct 2017 10:52:39 +0100

[Message part 1 (text/plain, inline)]

On Sat, 30 Sep 2017 16:36:05 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> Christopher Baines transcribed 3.6K bytes:
> > On Sat, 30 Sep 2017 15:01:52 +0000
> > ng0 <ng0 <at> infotropique.org> wrote:
> >   
> > > ng0 transcribed 2.1K bytes:  
> > > > Christopher Baines transcribed 1.7K bytes:    
> > > > > On Sat, 30 Sep 2017 14:12:55 +0000
> > > > > ng0 <ng0 <at> infotropique.org> wrote:
> > > > >     
> > > > > > The fix in this version is to only add the necessary input
> > > > > > to the inherited gnutls.    
> > > > > 
> > > > > Ok. One hopefully final thing. From the commit message [1],
> > > > > it's not clear to me if this is fixing an issue with the
> > > > > GNUnet package, by providing it with the right dependencies,
> > > > > or, adding additional functionality to the GNUnet package, by
> > > > > providing a more capable GnuTLS?
> > > > > 
> > > > > 1: "GNUnet and its dependency chain needs GnuTLS with DANE
> > > > > support."   
> > > > It provides the right GnuTLS to GNUnet, libmicrohttpd and gnURL.
> > > > Certain features of these applications will not work without it.
> > > > GnuTLS without Dane is not fatal error for these packages, but
> > > > Dane is recommended.
> > > > I have no idea how I should put this into the very strict
> > > > dictionary we have in commit messages… In more free-form it
> > > > would be no problem for me.
> > > > -- 
> > > > ng0
> > > > GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> > > > GnuPG: https://krosos.org/dist/keys/
> > > > https://www.infotropique.org https://krosos.org    
> > > 
> > > Okay, I now see what you mean.
> > > 
> > > To make it short: the correct dependency is provided in place
> > > of the current working-but-not-correct GnuTLS.
> > > 
> > > Is that more clear?  
> > 
> > I think you've made it clear to me now.
> > 
> > From what you're saying, I think its the 2nd thing I said. Making
> > this change will enable some functionality in the GNUnet package
> > (and possibly some of the other packages changed).
> > 
> > I'm not sure using the word "correct" helps, unless you say what the
> > dependencies are correct/incorrect with respect to, for example, if
> > the GNUnet documentation says that it should be built with GnuTLS
> > with Dane support, then that would be a reason to talk about
> > correctness.  
> 
> Yes it does state this, in the documentation and all these
> applications list the dependency in README aswell.
> This is why I thought the original, first version, comment I made in
> gnutls/dane was enough. But I'll have to be more clear then.
> Well if gnURL doesn't state it in its README I have to add it, if it's
> not in there it's my mistake - it's correct nevertheless.
> 
> > As for the commit format. As I understand the conventions, you can
> > put anything in between the first line, and the changelog at the
> > bottom. For example, one case where I ended up writing quite a bit
> > is here [1].
> > 
> > It doesn't have to be very specific, but something about the intent
> > or intended effect of the change in each commit would be very
> > useful.
> > 
> > 1:
> > http://git.savannah.gnu.org/cgit/guix.git/commit/?id=6230e155afd8c43c12ee3f03032aac34433db11a  
> 
> Okay, thanks. I will change the commit messages and
> reference our (GNUnet) README and documentation sections.

I've now merged the patches that were attached to this email :)

Thanks,

Chris

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.