GNU bug report logs - #28357
[PATCH] gnu: qtmultimedia: Build gstreamer backend.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28357 in the body.
You can then email your comments to 28357 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: guix-patches <at> gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>
Subject: [PATCH] gnu: qtmultimedia: Build gstreamer backend.
Date: Tue,  5 Sep 2017 15:46:52 +0200

* gnu/packages/qt.scm (qtmultimedia)[inputs]: Add gstreamer and
gst-plugins-base.
[arguments]: Replace configure phase to pass extra arguments to qmake.
---
 gnu/packages/qt.scm | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 3e3588a50..bc275ebb0 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -46,6 +46,7 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnuzilla)
   #:use-module (gnu packages gperf)
+  #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages icu4c)
   #:use-module (gnu packages image)
@@ -776,7 +777,15 @@ developers using C++ or QML, a CSS & JavaScript like language.")
                    (("spectrum") "#"))))))
     (arguments
      (substitute-keyword-arguments (package-arguments qtsvg)
-       ((#:tests? _ #f) #f))) ; TODO: Enable the tests
+       ((#:phases phases)
+        `(modify-phases ,phases
+           (replace 'configure
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let ((out (assoc-ref outputs "out")))
+                 (zero? (system* "qmake" "QT_BUILD_PARTS = libs tools tests"
+                                 (string-append "QMAKE_LFLAGS_RPATH=-Wl,-rpath," out "/lib -Wl,-rpath,")
+                                 (string-append "PREFIX=" out))))))))
+       ((#:tests? _ #f) #f)))           ; TODO: Enable the tests
     (native-inputs
      `(("perl" ,perl)
        ("pkg-config" ,pkg-config)
@@ -786,7 +795,10 @@ developers using C++ or QML, a CSS & JavaScript like language.")
      `(("alsa-lib" ,alsa-lib)
        ("mesa" ,mesa)
        ("pulseaudio" ,pulseaudio)
-       ("qtbase" ,qtbase)))))
+       ("qtbase" ,qtbase)
+       ;; Gstreamer is needed for the mediaplayer plugin
+       ("gstreamer" ,gstreamer)
+       ("gst-plugins-base" ,gst-plugins-base)))))
 
 (define-public qtwayland
   (package (inherit qtsvg)
-- 
2.14.1

Message #8 received at 28357 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 28357 <at> debbugs.gnu.org
Subject: Re: [bug#28357] [PATCH] gnu: qtmultimedia: Build gstreamer backend.
Date: Fri, 08 Sep 2017 18:08:07 +0200

Ricardo Wurmus <rekado <at> elephly.net> skribis:

> * gnu/packages/qt.scm (qtmultimedia)[inputs]: Add gstreamer and
> gst-plugins-base.
> [arguments]: Replace configure phase to pass extra arguments to qmake.

LGTM, thanks!

Ludo'.

Message #13 received at 28357-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 28357-done <at> debbugs.gnu.org
Subject: Re: [bug#28357] [PATCH] gnu: qtmultimedia: Build gstreamer backend.
Date: Thu, 28 Sep 2017 13:29:28 +0200

Ludovic Courtès <ludo <at> gnu.org> writes:

> Ricardo Wurmus <rekado <at> elephly.net> skribis:
>
>> * gnu/packages/qt.scm (qtmultimedia)[inputs]: Add gstreamer and
>> gst-plugins-base.
>> [arguments]: Replace configure phase to pass extra arguments to qmake.
>
> LGTM, thanks!

Pushed with 0423131156c9ff4a242e59db3f4dde912d8e400a.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.