GNU bug report logs - #28378
[PATCH] gnu: Add heimdall.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28378 in the body.
You can then email your comments to 28378 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH] gnu: Add heimdall.
Date: Thu,  7 Sep 2017 00:36:53 +0200

* gnu/packages/android.scm (heimdall): New variable.
---
 gnu/packages/android.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
index be3f50add..20bd21bdf 100644
--- a/gnu/packages/android.scm
+++ b/gnu/packages/android.scm
@@ -22,13 +22,18 @@
 
 (define-module (gnu packages android)
   #:use-module (guix packages)
+  #:use-module (guix download)
   #:use-module (guix git-download)
+  #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system python)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages)
+  #:use-module (gnu packages compression)
   #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages libusb)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages qt)
   #:use-module (gnu packages ssh)
   #:use-module (gnu packages version-control)
   #:use-module (gnu packages tls))
@@ -399,3 +404,51 @@ parts of the development workflow.  Repo is not meant to replace Git, only to
 make it easier to work with Git.  The repo command is an executable Python
 script that you can put anywhere in your path.")
     (license license:asl2.0)))
+
+(define-public heimdall
+  (package
+    (name "heimdall")
+    (version "1.4.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/Benjamin-Dobell/Heimdall/"
+                           "archive/v" version ".tar.gz"))
+       (file-name (string-append "heimdall-" version ".tar.gz"))
+       (sha256
+        (base32 "1y7gwg3lipyp2zcysm2vid1qg5nwin9bxbvgzs28lz2rya4fz6sq"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release")
+       #:tests? #f ; No tests exist.
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-invocations
+           (lambda* (#:key outputs #:allow-other-keys)
+             (substitute* '("heimdall-frontend/source/aboutform.cpp"
+                            "heimdall-frontend/source/mainwindow.cpp")
+               (("start[(]\"heimdall\"")
+                (string-append "start(\"" (assoc-ref outputs "out")
+                               "/bin/heimdall\"")))
+             #t))
+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (out-bin (string-append out "/bin"))
+                    (out-lib (string-append out "/lib")))
+               (mkdir-p out-bin)
+               (mkdir-p out-lib)
+               (install-file "../build/bin/heimdall" out-bin)
+               (install-file "../build/bin/heimdall-frontend" out-bin)
+               (install-file "../build/libpit/libpit.a" out-lib)
+               #t))))))
+    (inputs
+     `(("libusb" ,libusb)
+       ("qtbase" ,qtbase)
+       ("zlib" ,zlib)))
+    (home-page "http://glassechidna.com.au/heimdall/")
+    (synopsis "Samsung Flashing Tool")
+    (description
+     "@command{heimdall} can be used to flash firmware onto Samsung mobile
+devices.")
+    (license license:expat)))

Message #8 received at 28378 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 28378 <at> debbugs.gnu.org
Subject: Re: [bug#28378] [PATCH] gnu: Add heimdall.
Date: Thu, 07 Sep 2017 10:05:53 +0200

Hi Danny,

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> * gnu/packages/android.scm (heimdall): New variable.

Could you team up with Julien on <https://bugs.gnu.org/28285> to merge
the two submissions?

Thanks in advance!

Ludo’.

Message #13 received at 28378 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 28378 <at> debbugs.gnu.org
Subject: Re: [bug#28378] [PATCH] gnu: Add heimdall.
Date: Wed, 20 Sep 2017 22:09:02 +0200

[Message part 1 (text/plain, inline)]

Le Thu, 07 Sep 2017 10:05:53 +0200,
ludo <at> gnu.org (Ludovic Courtès) a écrit :

> Hi Danny,
> 
> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
> 
> > * gnu/packages/android.scm (heimdall): New variable.  
> 
> Could you team up with Julien on <https://bugs.gnu.org/28285> to merge
> the two submissions?
Hi,

here is the result of the merge of the two patches. I'm not sure we need
the static library?

Danny, what do you think of it?

> 
> Thanks in advance!
> 
> Ludo’.
> 
> 
> 

[0001-gnu-Add-heimdall.patch (text/x-patch, attachment)]

Message #16 received at 28378 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 28378 <at> debbugs.gnu.org
Subject: Re: [bug#28378] [PATCH] gnu: Add heimdall.
Date: Wed, 20 Sep 2017 22:34:23 +0200

Hi Julien,

Julien Lepiller <julien <at> lepiller.eu> skribis:

> From 0cd2378f5aa2626f8118d607a6b3558c212d80ec Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien <at> lepiller.eu>
> Date: Tue, 29 Aug 2017 23:54:16 +0200
> Subject: [PATCH] gnu: Add heimdall.
>
> * gnu/packages/flashing-tools.scm (heimdall): New variable.
>
> Co-Authored-By: Danny Milosavljevic <dannym <at> scratchpost.org>

It LGTM.  I don’t see why libpit.a is needed, but I’ll let you decide.  :-)

> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release")

Why not keep the default “RelWithDebInfo”?

Thanks!

Ludo’.

Message #21 received at 28378-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 28378-done <at> debbugs.gnu.org
Subject: Re: [bug#28378] [PATCH] gnu: Add heimdall.
Date: Tue, 3 Oct 2017 21:46:27 +0200

Le Wed, 20 Sep 2017 22:34:23 +0200,
ludo <at> gnu.org (Ludovic Courtès) a écrit :

> Hi Julien,
> 
> Julien Lepiller <julien <at> lepiller.eu> skribis:
> 
> > From 0cd2378f5aa2626f8118d607a6b3558c212d80ec Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <julien <at> lepiller.eu>
> > Date: Tue, 29 Aug 2017 23:54:16 +0200
> > Subject: [PATCH] gnu: Add heimdall.
> >
> > * gnu/packages/flashing-tools.scm (heimdall): New variable.
> >
> > Co-Authored-By: Danny Milosavljevic <dannym <at> scratchpost.org>  
> 
> It LGTM.  I don’t see why libpit.a is needed, but I’ll let you
> decide.  :-)
> 
> > +    (build-system cmake-build-system)
> > +    (arguments
> > +     `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release")  
> 
> Why not keep the default “RelWithDebInfo”?
That's what was documented in this package.

Pushed as f282aa530b91c8fecb910bc0a3323fcbd4d39ffb.

> 
> Thanks!
> 
> Ludo’.

Message #29 received at 28378 <at> debbugs.gnu.org (full text, mbox):

From: Mekeor Melire <mekeor.melire <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 28378 <at> debbugs.gnu.org
Subject: Re: [bug#28378] [PATCH] gnu: Add heimdall.
Date: Wed, 04 Oct 2017 23:27:32 +0200

Ludovic Courtès <ludo <at> gnu.org> writes:

> Julien Lepiller <julien <at> lepiller.eu> skribis:
[…]
>> * gnu/packages/flashing-tools.scm (heimdall): New variable.
[…]
>> +    (build-system cmake-build-system)
>> +    (arguments
>> +     `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release")
>
> Why not keep the default “RelWithDebInfo”?

BUMP. This seems to be the only last remark on this nice new package
definition.

Message #32 received at 28378 <at> debbugs.gnu.org (full text, mbox):

From: Mekeor Melire <mekeor.melire <at> gmail.com>
To: 28378 <at> debbugs.gnu.org
Subject: Re: [bug#28378] [PATCH] gnu: Add heimdall.
Date: Wed, 04 Oct 2017 23:31:51 +0200

Sorry, I just saw that it's already pushed to master now. Thank you very
much for your effort!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.