GNU bug report logs - #28413
26.0.50; enable frame filters for gdb-mi

Previous Next

Package: emacs;

Reported by: Tom Tromey <tom <at> tromey.com>

Date: Mon, 11 Sep 2017 00:39:01 UTC

Severity: minor

Tags: patch

Found in version 26.0.50

Fixed in version 27.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28413 in the body.
You can then email your comments to 28413 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#28413; Package emacs. (Mon, 11 Sep 2017 00:39:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tom Tromey <tom <at> tromey.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 11 Sep 2017 00:39:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tom Tromey <tom <at> tromey.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; enable frame filters for gdb-mi
Date: Sun, 10 Sep 2017 18:37:52 -0600
[Message part 1 (text/plain, inline)]
I noticed that gdb-mi doesn't enable frame filters.

I think it shouldn't hurt to simply always enable them, as in the
attached patch.

Tom

[P (text/x-patch, inline)]
commit 331aa85eaee7da4547e49a5200153526190bc95f
Author: Tom Tromey <tom <at> tromey.com>
Date:   Mon Mar 6 15:10:05 2017 -0700

    Send -enable-frame-filters to gdb
    
    * lisp/progmodes/gdb-mi.el (gdb-init-1): Send -enable-frame-filters to
    gdb.

diff --git a/lisp/progmodes/gdb-mi.el b/lisp/progmodes/gdb-mi.el
index a30669d..34ca437 100644
--- a/lisp/progmodes/gdb-mi.el
+++ b/lisp/progmodes/gdb-mi.el
@@ -947,6 +947,7 @@ gdb-init-1
     (gdb-input "-gdb-set non-stop 1" 'gdb-non-stop-handler))
 
   (gdb-input "-enable-pretty-printing" 'ignore)
+  (gdb-input "-enable-frame-filters" 'ignore)
 
   ;; Find source file and compilation directory here.
   (if gdb-create-source-file-list
[Message part 3 (text/plain, inline)]



In GNU Emacs 26.0.50 (build 18, x86_64-pc-linux-gnu, GTK+ Version 3.22.17)
 of 2017-09-09 built on bapiya
Repository revision: 4131f9785e30f2a31745125c714e922892113c62
Windowing system distributor 'Fedora Project', version 11.0.11903000
System Description:	Fedora release 25 (Twenty Five)

Recent messages:
Making completion list... [2 times]
funcall-interactively: End of buffer
Quit [2 times]
When done with a buffer, type C-x #
Auto-saving...done
Auto-saving...done
Auto-saving...done
Saving file /home/tromey/gdb/binutils-gdb/.git/.gitsendemail.msg.TbtaV7...
Wrote /home/tromey/gdb/binutils-gdb/.git/.gitsendemail.msg.TbtaV7
C-x C-g is undefined

Configured using:
 'configure --prefix=/home/tromey/Emacs/install'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: en_US.utf8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: C/*l

Minor modes in effect:
  shell-dirtrack-mode: t
  bug-reference-prog-mode: t
  diff-auto-refine-mode: t
  flyspell-mode: t
  which-function-mode: t
  erc-services-mode: t
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-networks-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-match-mode: t
  erc-netsplit-mode: t
  erc-hl-nicks-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  savehist-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  auto-fill-function: tromey-c++-do-auto-fill
  transient-mark-mode: t
  abbrev-mode: t

Load-path shadows:
/home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/26.0.50/lisp/play/bubbles

Features:
(shadow emacsbug noutline outline tcl supercite regi mail-hist nnir
texinfo gnus-draft jka-compr make-mode find-file term/xterm xterm
goto-addr log-edit shell find-dired pulse vc-mtn vc-hg etags xref
project log-view pcvs-util smerge-mode bug-reference cc-mode cc-fonts
cc-guess cc-menus cc-cmds vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs
copyright vc-git diff-mode easy-mmode map shr-color shr svg dom
flow-fill mm-archive gnus-html url-queue browse-url xml url-cache mm-url
url url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util misearch multi-isearch mailalias sort smiley
gnus-cite gnus-async gnus-bcklg mail-extr gnus-ml disp-table gnus-topic
nndraft nnmh nnfolder utf-7 network-stream nsm starttls gnus-agent
gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache
gnus-registry registry ebdb-gnus gnus-art mm-uu mml2015 mm-view
mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo smtpmail
gnus-start gnus-cloud nnimap nnmail mail-source tls gnutls utf7 netrc
nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus add-log
nnheader profiler cl-print debug dabbrev help-fns radix-tree elec-pair
flyspell ispell diminish edmacro kmacro projectile grep compile ibuf-ext
ibuffer ibuffer-loaddefs dash appt diary-lib diary-loaddefs which-func
imenu minimap autorevert filenotify cus-start cus-load status
erc-services erc-list erc-menu erc-join erc-ring erc-networks
erc-pcomplete pcomplete erc-track erc-match erc-netsplit erc-hl-nicks
color erc-button erc-fill erc-stamp wid-edit erc-goodies erc erc-backend
erc-compat thingatpt pp warnings advice vc-dir ewoc vc vc-dispatcher
cc-styles cc-align cc-engine cc-vars cc-defs ebdb-complete ebdb-message
sendmail message puny dired dired-loaddefs format-spec rfc822 mml
mml-sec epa derived epg gnus-util rmail rmail-loaddefs mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util
ietf-drums mail-prsvr mail-utils gmm-utils mailheader ebdb-mua ebdb-com
crm mailabbrev ebdb-format qp ebdb cl-extra help-mode eieio-opt speedbar
sb-image ezimage dframe find-func eieio-base pcase subr-x cal-menu
calendar cal-loaddefs timezone ange-ftp comint ansi-color ring server
savehist finder-inf dwarf-mode-autoloads gdb-shell-autoloads
lisppaste-autoloads pydoc-info-autoloads info-look cl
weblogger-autoloads info package easymenu epg-config url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache url-vars seq byte-opt gv bytecomp byte-compile cconv
cl-loaddefs cl-lib time-date mule-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote dbusbind inotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 1393195 721365)
 (symbols 48 51459 81)
 (miscs 40 16109 1526)
 (strings 32 507292 69060)
 (string-bytes 1 13719589)
 (vectors 16 244763)
 (vector-slots 8 3668114 248015)
 (floats 8 474 1253)
 (intervals 56 29271 2181)
 (buffers 992 94))

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#28413; Package emacs. (Mon, 11 Sep 2017 14:49:02 GMT) Full text and rfc822 format available.

Message #8 received at 28413 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tom Tromey <tom <at> tromey.com>
Cc: 28413 <at> debbugs.gnu.org
Subject: Re: bug#28413: 26.0.50; enable frame filters for gdb-mi
Date: Mon, 11 Sep 2017 17:48:18 +0300
> From: Tom Tromey <tom <at> tromey.com>
> Date: Sun, 10 Sep 2017 18:37:52 -0600
> 
> I noticed that gdb-mi doesn't enable frame filters.
> 
> I think it shouldn't hurt to simply always enable them, as in the
> attached patch.

Looks reasonable, thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#28413; Package emacs. (Sun, 29 Sep 2019 01:18:02 GMT) Full text and rfc822 format available.

Message #11 received at 28413 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Tom Tromey <tom <at> tromey.com>, 28413 <at> debbugs.gnu.org
Subject: Re: bug#28413: 26.0.50; enable frame filters for gdb-mi
Date: Sun, 29 Sep 2019 03:17:38 +0200
tags 28413 + patch
quit

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Tom Tromey <tom <at> tromey.com>
>> Date: Sun, 10 Sep 2017 18:37:52 -0600
>>
>> I noticed that gdb-mi doesn't enable frame filters.
>>
>> I think it shouldn't hurt to simply always enable them, as in the
>> attached patch.
>
> Looks reasonable, thanks.

This patch was never installed at the time.  Should it be installed?

Best regards,
Stefan Kangas




Added tag(s) patch. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Sun, 29 Sep 2019 01:18:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#28413; Package emacs. (Sun, 29 Sep 2019 07:34:01 GMT) Full text and rfc822 format available.

Message #16 received at 28413 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: tom <at> tromey.com, 28413 <at> debbugs.gnu.org
Subject: Re: bug#28413: 26.0.50; enable frame filters for gdb-mi
Date: Sun, 29 Sep 2019 10:33:34 +0300
> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Sun, 29 Sep 2019 03:17:38 +0200
> Cc: Tom Tromey <tom <at> tromey.com>, 28413 <at> debbugs.gnu.org
> 
> >> I noticed that gdb-mi doesn't enable frame filters.
> >>
> >> I think it shouldn't hurt to simply always enable them, as in the
> >> attached patch.
> >
> > Looks reasonable, thanks.
> 
> This patch was never installed at the time.  Should it be installed?

Yes.  I believe I expected Tom to install it.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#28413; Package emacs. (Wed, 30 Oct 2019 21:29:01 GMT) Full text and rfc822 format available.

Message #19 received at 28413 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tom <at> tromey.com, 28413 <at> debbugs.gnu.org
Subject: Re: bug#28413: 26.0.50; enable frame filters for gdb-mi
Date: Wed, 30 Oct 2019 22:28:10 +0100
close 28413 27.1
thanks

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Stefan Kangas <stefan <at> marxist.se>
>> Date: Sun, 29 Sep 2019 03:17:38 +0200
>> Cc: Tom Tromey <tom <at> tromey.com>, 28413 <at> debbugs.gnu.org
>> 
>> >> I noticed that gdb-mi doesn't enable frame filters.
>> >>
>> >> I think it shouldn't hurt to simply always enable them, as in the
>> >> attached patch.
>> >
>> > Looks reasonable, thanks.
>> 
>> This patch was never installed at the time.  Should it be installed?
>
> Yes.  I believe I expected Tom to install it.

OK, I've now pushed it as commit 772f1c4189.  Closing.

Best regards,
Stefan Kangas




bug marked as fixed in version 27.1, send any further explanations to 28413 <at> debbugs.gnu.org and Tom Tromey <tom <at> tromey.com> Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Wed, 30 Oct 2019 21:29:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 28 Nov 2019 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 122 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.