GNU bug report logs - #28515
[PATCH] fix url-current-object is undefined

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28515 in the body.
You can then email your comments to 28515 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yuya Minami <yuya373 <at> me.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Yuya Minami <yuya373 <at> me.com>
Subject: [PATCH] fix url-current-object is undefined
Date: Tue, 19 Sep 2017 22:39:53 +0900

`url-http-find-free-connection` using `url-current-object`, but this
variable is nil at this point.
---
 lisp/url/url-http.el | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index 9e8c58b1cd..078106fb8d 100644
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -1249,9 +1249,10 @@ The return value of this function is the retrieval buffer."
 	 (nsm-noninteractive (or url-request-noninteractive
 				 (and (boundp 'url-http-noninteractive)
 				      url-http-noninteractive)))
-         (connection (url-http-find-free-connection (url-host url)
-                                                    (url-port url)
-                                                    gateway-method))
+         (connection (let ((url-current-object url))
+                       (url-http-find-free-connection (url-host url)
+                                                      (url-port url)
+                                                      gateway-method)))
          (mime-accept-string url-mime-accept-string)
 	 (buffer (or retry-buffer
 		     (generate-new-buffer
--
2.14.1

Message #8 received at 28515 <at> debbugs.gnu.org (full text, mbox):

From: 南 優也 <yuya373 <at> me.com>
To: 28515 <at> debbugs.gnu.org
Date: Mon, 25 Sep 2017 07:20:27 +0000 (GMT)

[Message part 1 (text/plain, inline)]

additional information:
`url-http` calls `url-http-find-free-connection` before `(setq url-current-object url)` and `url-http-find-free-connection` calls `url-open-stream` and `url-open-stream` referencing `url-current-object` before `url-http` updates it's value.
when `url-open-stream` referencing `url-current-object`, it's value is `nil` or old `url-current-object`.

so, let `url-current-object` to `url` in `url-http` before calling `url-http-find-free-connection`.

[Message part 2 (text/html, inline)]

Message #13 received at 28515-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: 南 優也 <yuya373 <at> me.com>
Cc: 28515-done <at> debbugs.gnu.org
Subject: Re: bug#28515:
Date: Sat, 30 Sep 2017 16:35:30 +0300

> From: 南 優也 <yuya373 <at> me.com>
> Date: Mon, 25 Sep 2017 07:20:27 +0000 (GMT)
> 
> additional information:
> `url-http` calls `url-http-find-free-connection` before `(setq url-current-object url)` and `url-http-find-free-connection` calls `url-open-stream` and `url-open-stream` referencing `url-current-object` before `url-http` updates it's value.
> when `url-open-stream` referencing `url-current-object`, it's value is `nil` or old `url-current-object`.
> 
> so, let `url-current-object` to `url` in `url-http` before calling `url-http-find-free-connection`.

Thanks, I fixed this on the emacs-26 branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.