GNU bug report logs - #28558
[PATCH] gnu: Add atool.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28558 in the body.
You can then email your comments to 28558 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add atool.
Date: Fri, 22 Sep 2017 23:49:14 +0200

* gnu/packages/compression.scm (atool): New variable.
---
 gnu/packages/compression.scm |   27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index 7eeeaf3..76cca5f 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -17,6 +17,7 @@
 ;;; Copyright © 2017 ng0 <contact.ng0 <at> cryptolab.net>
 ;;; Copyright © 2017 Manolis Fragkiskos Ragkousis <manolis837 <at> gmail.com>
 ;;; Copyright © 2017 Theodoros Foradis <theodoros.for <at> openmailbox.org>
+;;; Copyright © 2017 Stefan Reichör <stefan <at> xsteve.at>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1572,3 +1573,29 @@ zip archives.  Files can be added from data buffers, files, or compressed data
 copied directly from other zip archives.  Changes made without closing the
 archive can be reverted.")
     (license license:bsd-3)))
+
+(define-public atool
+  (package
+    (name "atool")
+    (version "0.39.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://savannah.nongnu.org/download/atool/atool-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0fvhzip2v08jgnlfpyj6rapan39xlsl1ksgq4lp8gfsai2ah1xma"))))
+    (inputs
+     `(("perl" ,perl)))
+    (build-system gnu-build-system)
+    (synopsis  "Universal tool to manage file archives of various types")
+    (description "The main command is @command{aunpack} which extracts files
+from an archive.  The other commands provided are @command{apack} (to create
+archives), @command{als} (to list files in archives), and @command{acat} (to
+extract files to standard out).  As @command{atool} invokes external programs
+to handle the archives, not all commands may be supported for a certain type
+of archives.")
+    (home-page "http://www.nongnu.org/atool/")
+    (license license:gpl2+)))

Message #8 received at 28558 <at> debbugs.gnu.org (full text, mbox):

From: Ben Woodcroft <b.woodcroft <at> uq.edu.au>
To: Stefan Reichör <stefan <at> xsteve.at>, 28558 <at> debbugs.gnu.org
Subject: Re: [bug#28558] [PATCH] gnu: Add atool.
Date: Sat, 23 Sep 2017 18:43:10 +1000

On 23/09/17 07:49, Stefan Reichör wrote:
> * gnu/packages/compression.scm (atool): New variable.
Thanks for the patch. While adding all compression programs supported 
(e.g. tar) as inputs is probably too much given their large number, I 
think it would be good to add "file" and patch in the path to "file" in 
bin/atool. WDYT?

Otherwise LGTM.
ben

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: guix-patches <at> gnu.org
Subject: Re: [bug#28558] [PATCH] gnu: Add atool.
Date: Sat, 23 Sep 2017 20:16:48 +0200

Hi Ben,

> On 23/09/17 07:49, Stefan Reichör wrote:
>> * gnu/packages/compression.scm (atool): New variable.
> Thanks for the patch. While adding all compression programs supported
> (e.g. tar) as inputs is probably too much given their large number, I
> think it would be good to add "file" and patch in the path to "file"
> in bin/atool. WDYT?

Thanks for your feedback. I don't think that file is an important tool
for atool. At least I use only archives with the correct file extension.
And all the archives that I remember that I downloaded from some site
also provided the correct file extension. In that case file is not needed to
detect the archive type.

However, if you think that hard coding the full path to file is a good
thing I will update my patch. It should be doable for me...

> Otherwise LGTM.
> ben


Stefan.

Message #14 received at 28558 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 28558 <at> debbugs.gnu.org
Subject: Re: [bug#28558] [PATCH] gnu: Add atool.
Date: Sat, 07 Oct 2017 22:47:44 +0200

Hi Stefan,

Stefan Reichör <stefan <at> xsteve.at> skribis:

>> On 23/09/17 07:49, Stefan Reichör wrote:
>>> * gnu/packages/compression.scm (atool): New variable.
>> Thanks for the patch. While adding all compression programs supported
>> (e.g. tar) as inputs is probably too much given their large number, I
>> think it would be good to add "file" and patch in the path to "file"
>> in bin/atool. WDYT?
>
> Thanks for your feedback. I don't think that file is an important tool
> for atool. At least I use only archives with the correct file extension.
> And all the archives that I remember that I downloaded from some site
> also provided the correct file extension. In that case file is not needed to
> detect the archive type.
>
> However, if you think that hard coding the full path to file is a good
> thing I will update my patch. It should be doable for me...

As discussed earlier in another thread, I think it’s a good idea to
hard-code absolute file names.  Could you update the patch accordingly?

TIA,
Ludo’.

Message #17 received at 28558 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28558 <at> debbugs.gnu.org
Subject: Re: [bug#28558] [PATCH] gnu: Add atool.
Date: Sun, 08 Oct 2017 11:25:54 +0200

> Hi Stefan,
>
> Stefan Reichör <stefan <at> xsteve.at> skribis:
>
>>> On 23/09/17 07:49, Stefan Reichör wrote:
>>>> * gnu/packages/compression.scm (atool): New variable.
>>> Thanks for the patch. While adding all compression programs supported
>>> (e.g. tar) as inputs is probably too much given their large number, I
>>> think it would be good to add "file" and patch in the path to "file"
>>> in bin/atool. WDYT?
>>
>> Thanks for your feedback. I don't think that file is an important tool
>> for atool. At least I use only archives with the correct file extension.
>> And all the archives that I remember that I downloaded from some site
>> also provided the correct file extension. In that case file is not needed to
>> detect the archive type.
>>
>> However, if you think that hard coding the full path to file is a good
>> thing I will update my patch. It should be doable for me...
>
> As discussed earlier in another thread, I think it’s a good idea to
> hard-code absolute file names.  Could you update the patch accordingly?
>
> TIA,
> Ludo’.

Hi Ludo!

I am really busy for the next weeks. So I won't have time to do some
work for Guix. I will try to improve my patches when I find the time.

Stefan.

Message #22 received at 28558-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 28558-done <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#28558] [PATCH] gnu: Add atool.
Date: Wed, 18 Oct 2017 23:10:37 +0200

Hi Stefan,

I took the liberty to patch the path to file in the executable, add a
copyright line for you, and push the patch to master with commit
ef5c40aa2.

Thanks for your contribution!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.