GNU bug report logs - #28562
[PATCH] gnu: eudev: Update to 3.2.4 and generate manpages.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28562 in the body.
You can then email your comments to 28562 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: eudev: Update to 3.2.4 and generate manpages.
Date: Fri, 22 Sep 2017 23:51:08 -0400

[Message part 1 (text/plain, inline)]

Hello,

The attached patch generates and installs the manpages for our eudev
package and updates it to the current 3.2.4 release.

I believe this should go to core-updates since it impacts more than 700
packages, based on `guix refresh --list-dependent eudev':

--8<---------------cut here---------------start------------->8---
Building the following 377 packages would ensure 718 dependent packages are rebuilt--8<---------------cut here---------------end--------------->8---

Thanks,

Maxim

[0001-gnu-eudev-Update-to-3.2.4-and-generate-manpages.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: Re: [PATCH] gnu: eudev: Update to 3.2.4 and generate manpages.
Date: Fri, 22 Sep 2017 23:55:43 -0400

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> I believe this should go to core-updates since it impacts more than 700
> packages, based on `guix refresh --list-dependent eudev':

Correction: s/core-updates/staging, according to the manual.

Message #11 received at 28562 <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 28562 <at> debbugs.gnu.org
Subject: Re: [bug#28562] [PATCH] gnu: eudev: Update to 3.2.4 and generate
 manpages.
Date: Mon, 25 Sep 2017 10:33:42 +0200

Hi Maxim,

thanks for the patch!

Only one thing: we don't have to substitute the location of autoreconf
in autogen.sh: because autoconf is a native input, its executables are
already in the build environment PATH:

> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'bootstrap
> +           (lambda* (#:key inputs #:allow-other-keys)
> +            (substitute* "autogen.sh"
> +              (("autoreconf")
> +               (string-append (assoc-ref inputs "autoconf")
> +                              "/bin/autoreconf")))

If you agree, I can push with that change (and will try to remember to
push to staging :0) ).

Thomas

Message #14 received at 28562 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Thomas Danckaert <post <at> thomasdanckaert.be>
Cc: 28562 <at> debbugs.gnu.org
Subject: Re: [bug#28562] [PATCHv2] gnu: eudev: Update to 3.2.4 and generate
 manpages.
Date: Mon, 25 Sep 2017 16:54:57 -0400

[Message part 1 (text/plain, inline)]

Thomas Danckaert <post <at> thomasdanckaert.be> writes:

> Hi Maxim,
>
> thanks for the patch!
>
> Only one thing: we don't have to substitute the location of autoreconf
> in autogen.sh: because autoconf is a native input, its executables are
> already in the build environment PATH:
>
>> +     '(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'configure 'bootstrap
>> +           (lambda* (#:key inputs #:allow-other-keys)
>> +            (substitute* "autogen.sh"
>> +              (("autoreconf")
>> +               (string-append (assoc-ref inputs "autoconf")
>> +                              "/bin/autoreconf")))
>
> If you agree, I can push with that change (and will try to remember to
> push to staging :0) ).
>
> Thomas

Hi Thomas,

Thanks for the review! You are right about the unnecessary autoreconf
substitution; I just removed that part and could rebuild
successfully. If you need the modified patch I've attached it.

Thank you!

Maxim

[0001-gnu-eudev-Update-to-3.2.4-and-generate-manpages.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 28562 <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: maxim.cournoyer <at> gmail.com, 28562-done <at> debbugs.gnu.org
Cc: 28562 <at> debbugs.gnu.org
Subject: Re: [bug#28562] [PATCHv2] gnu: eudev: Update to 3.2.4 and generate
 manpages.
Date: Thu, 28 Sep 2017 20:31:02 +0200 (CEST)

pushed (to staging)!

Thomas

Message #25 received at 28562 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Thomas Danckaert <post <at> thomasdanckaert.be>
Cc: 28562 <at> debbugs.gnu.org, 28562-done <at> debbugs.gnu.org
Subject: Re: [bug#28562] [PATCHv2] gnu: eudev: Update to 3.2.4 and generate
 manpages.
Date: Thu, 28 Sep 2017 18:03:40 -0400

Thomas Danckaert <post <at> thomasdanckaert.be> writes:

> pushed (to staging)!
>
> Thomas

Thanks, Thomas!

Maxim

Message #31 received at 28562-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Thomas Danckaert <post <at> thomasdanckaert.be>, maxim.cournoyer <at> gmail.com,
 28562-done <at> debbugs.gnu.org
Subject: Re: bug#28562: [PATCHv2] gnu: eudev: Update to 3.2.4 and
 generate	manpages.
Date: Thu, 05 Oct 2017 00:51:54 +0200

[Message part 1 (text/plain, inline)]

Thomas Danckaert <post <at> thomasdanckaert.be> writes:

> pushed (to staging)!

eudev and many dependents had already been built on Hydra, so I
reverted it and added it on core-updates instead.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.