GNU bug report logs - #28594
nototools (required for building Noto from source)

Previous Next

Package: guix-patches;

Reported by: ng0 <ng0 <at> infotropique.org>

Date: Mon, 25 Sep 2017 12:20:02 UTC

Severity: normal

Done: Leo Famulari <leo <at> famulari.name>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28594 in the body.
You can then email your comments to 28594 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Mon, 25 Sep 2017 12:20:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to ng0 <ng0 <at> infotropique.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 25 Sep 2017 12:20:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: guix-patches <at> gnu.org
Subject: nototools (required for building Noto from source)
Date: Mon, 25 Sep 2017 12:18:41 +0000
[Message part 1 (text/plain, inline)]
This patch series adds the python2 application set "nototools".
It is a requirement for resolving #28404 (Google Noto Fonts).
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org
[0001-gnu-python-fonttools-Update-to-3.15.1.patch (text/plain, attachment)]
[0002-gnu-Add-python2-ufolib.patch (text/plain, attachment)]
[0003-gnu-Add-python2-setuptools-scm-git-archive.patch (text/plain, attachment)]
[0004-gnu-Add-python2-pyclipper.patch (text/plain, attachment)]
[0005-gnu-Add-python2-booleanoperations.patch (text/plain, attachment)]
[0006-gnu-Add-python2-defcon.patch (text/plain, attachment)]
[0007-gnu-Add-nototools.patch (text/plain, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Sun, 01 Oct 2017 18:43:01 GMT) Full text and rfc822 format available.

Message #8 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Sun, 1 Oct 2017 18:41:51 +0000
[Message part 1 (text/plain, inline)]
Update, using the snapshot nototools tagged per request.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org
[0001-gnu-python-fonttools-Update-to-3.15.1.patch (text/plain, attachment)]
[0002-gnu-Add-python2-ufolib.patch (text/plain, attachment)]
[0003-gnu-Add-python2-setuptools-scm-git-archive.patch (text/plain, attachment)]
[0004-gnu-Add-python2-pyclipper.patch (text/plain, attachment)]
[0005-gnu-Add-python2-booleanoperations.patch (text/plain, attachment)]
[0006-gnu-Add-python2-defcon.patch (text/plain, attachment)]
[0007-gnu-Add-nototools.patch (text/plain, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Sun, 01 Oct 2017 18:49:02 GMT) Full text and rfc822 format available.

Message #11 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Sun, 1 Oct 2017 18:47:37 +0000
[Message part 1 (text/plain, inline)]
ng0 transcribed 16K bytes:
> Update, using the snapshot nototools tagged per request.

And another one, fixing the leading spaces / indentation.

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org
[0001-gnu-python-fonttools-Update-to-3.15.1.patch (text/plain, attachment)]
[0002-gnu-Add-python2-ufolib.patch (text/plain, attachment)]
[0003-gnu-Add-python2-setuptools-scm-git-archive.patch (text/plain, attachment)]
[0004-gnu-Add-python2-pyclipper.patch (text/plain, attachment)]
[0005-gnu-Add-python2-booleanoperations.patch (text/plain, attachment)]
[0006-gnu-Add-python2-defcon.patch (text/plain, attachment)]
[0007-gnu-Add-nototools.patch (text/plain, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Fri, 13 Oct 2017 06:51:02 GMT) Full text and rfc822 format available.

Message #14 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Fri, 13 Oct 2017 07:50:50 +0100
[Message part 1 (text/plain, inline)]
On Sun, 1 Oct 2017 18:47:37 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> From fd3b03257e7382b555986c0a64300ce6c9ff03fa Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> infotropique.org>
> Date: Wed, 20 Sep 2017 11:31:51 +0000
> Subject: [PATCH 1/7] gnu: python-fonttools: Update to 3.15.1.
> 
> * gnu/packages/python.scm (python-fonttools): Update to 3.15.1.
> (source)[uri]: Use 'pypi-uri'.
> ---
>  gnu/packages/python.scm | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

This patch looks good to me :)
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Fri, 13 Oct 2017 06:54:02 GMT) Full text and rfc822 format available.

Message #17 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Fri, 13 Oct 2017 07:53:21 +0100
[Message part 1 (text/plain, inline)]
On Sun, 1 Oct 2017 18:47:37 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> From 3f92924aa71d63beb1ade69261e17da26969eee9 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> infotropique.org>
> Date: Wed, 20 Sep 2017 11:39:29 +0000
> Subject: [PATCH 2/7] gnu: Add python2-ufolib.
> 
> * gnu/packages/python.scm (python2-ufolib): New variable.
> ---
>  gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)

guix lint reports a couple of issues:

gnu/packages/python.scm:7483:5: python2-ufolib <at> 2.1.0: description should start with an upper-case letter or digit
gnu/packages/python.scm:7481:14: python2-ufolib <at> 2.1.0: no period allowed at the end of the synopsis

Apart from that though, I think this looks fine.
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Fri, 13 Oct 2017 07:01:02 GMT) Full text and rfc822 format available.

Message #20 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Fri, 13 Oct 2017 08:00:40 +0100
[Message part 1 (text/plain, inline)]
On Sun, 1 Oct 2017 18:47:37 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> * gnu/packages/python.scm (python2-setuptools-scm-git-archive): New
> variable. ---
>  gnu/packages/python.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 052547316..de42e6835 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -7424,6 +7424,28 @@ from an XML-based format.")
>  files.  UFO is a file format that stores fonts source files.")
>      (license license:bsd-3)))
>  
> +(define-public python2-setuptools-scm-git-archive
> +  (package
> +    (name "python2-setuptools-scm-git-archive")
> +    (version "1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "setuptools_scm_git_archive" version))
> +       (sha256
> +        (base32
> +         "1nii1sz5jq75ilf18bjnr11l9rz1lvdmyk66bxl7q90qan85yhjj"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2))
> +    (propagated-inputs
> +     `(("python2-setuptools-scm" ,python2-setuptools-scm)))
> +    (home-page
> "https://github.com/Changaco/setuptools_scm_git_archive/")
> +    (synopsis "setuptools_scm plugin for git archives")
> +    (description
> +     "setuptools_scm plugin for git archives")

Maybe use something like this for the description:

The setuptools_scm_git_archive package is a plugin to setuptools_scm,
which supports obtaining versions from git archives that belong to
tagged versions. 

> +    (license license:expat)))

guix lint warns about the synopsis:

gnu/packages/python.scm:7504:14: python2-setuptools-scm-git-archive <at> 1.0: synopsis should start with an upper-case letter or digit

But other than that, this looks good to me.
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Fri, 13 Oct 2017 07:02:02 GMT) Full text and rfc822 format available.

Message #23 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Fri, 13 Oct 2017 08:01:51 +0100
[Message part 1 (text/plain, inline)]
On Sun, 1 Oct 2017 18:47:37 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> * gnu/packages/python.scm (python2-pyclipper): New variable.
> ---
>  gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)

Looks fine to me :)
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Fri, 13 Oct 2017 07:05:01 GMT) Full text and rfc822 format available.

Message #26 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Fri, 13 Oct 2017 08:04:19 +0100
[Message part 1 (text/plain, inline)]
On Sun, 1 Oct 2017 18:47:37 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> * gnu/packages/python.scm (python2-booleanoperations): New variable.
> ---
>  gnu/packages/python.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)

This looks fine to me as well.
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Fri, 13 Oct 2017 07:09:02 GMT) Full text and rfc822 format available.

Message #29 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Fri, 13 Oct 2017 08:08:54 +0100
[Message part 1 (text/plain, inline)]
On Sun, 1 Oct 2017 18:47:37 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> * gnu/packages/python.scm (python2-defcon): New variable.
> ---
>  gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 90cc5283f..6e0dfd01c 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -7501,6 +7501,39 @@ Angus Johnson's Clipper library (ver. 6.2.1)")
>  boolean operations on paths.")
>      (license license:expat)))
>  
> +(define-public python2-defcon
> +  (package
> +    (name "python2-defcon")
> +    (version "0.3.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "defcon" version ".zip"))
> +       (sha256
> +        (base32
> +         "1f41w54fdjy9izxcwzqa142kd56whqsg9nq5k4508jb6iip84h89"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2))
> +    (native-inputs
> +     `(("unzip" ,unzip)
> +       ("python2-pytest-3.0" ,python2-pytest-3.0)
> +       ("python2-pytest-runner" ,python2-pytest-runner)))
> +    (propagated-inputs
> +     `(("python2-fonttools" ,python2-fonttools)
> +       ("python2-ufolib" ,python2-ufolib)))
> +    (home-page "https://pypi.python.org/pypi/defcon")
> +    (synopsis "set of flexible objects for representing UFO data")

I'd suggest:

Flexible objects for representing @acronym{UFO, unified font object}
data.

> +    (description
> +     "Defcon is a set of UFO based objects optimized for use in
> +font editing applications.  The objects are built to be lightweight,
> +fast and flexible.  The objects are very bare-bones and they are not
> +meant to be end-all, be-all objects.  Rather, they are meant to
> provide +base functionality so that you can focus on your
> application’s behavior, +not object observing or maintaining cached
> data.  Defcon implements +UFO3 as described by the UFO font format.")
> +    (license license:expat)))
> +

Maybe markup the first UFO in the description with @acronym as well,
but apart from that, this looks fine.
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Fri, 13 Oct 2017 07:14:01 GMT) Full text and rfc822 format available.

Message #32 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Fri, 13 Oct 2017 08:12:52 +0100
[Message part 1 (text/plain, inline)]
On Sun, 1 Oct 2017 18:47:37 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> * gnu/packages/fontutils.scm (nototools): New variable.
> ---
>  gnu/packages/fontutils.scm | 44
> +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 43
> insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
> index 15401f652..ca10c10b0 100644
> --- a/gnu/packages/fontutils.scm
> +++ b/gnu/packages/fontutils.scm
> @@ -5,6 +5,7 @@
>  ;;; Copyright © 2016, 2017 Efraim Flashner <efraim <at> flashner.co.il>
>  ;;; Copyright © 2017 Rene Saavedra <rennes <at> openmailbox.org>
>  ;;; Copyright © 2017 Leo Famulari <leo <at> famulari.name>
> +;;; Copyright © 2017 ng0 <ng0 <at> infotropique.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -44,7 +45,8 @@
>    #:use-module (guix svn-download)
>    #:use-module (guix git-download)
>    #:use-module (guix build-system cmake)
> -  #:use-module (guix build-system gnu))
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix build-system python))
>  
>  (define-public freetype
>    (package
> @@ -565,3 +567,43 @@ opentype fonts.  You can save fonts in many
> different outline formats, and generate bitmaps.")
>     (license license:gpl3+)
>     (home-page "https://fontforge.github.io/en-US/")))
> +
> +(define-public nototools
> +  (package
> +    (name "nototools")
> +    (version "20170925")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/googlei18n/nototools/"
> +                           "archive/v2017-09-25-tooling-for-phase3-"
> +                           "update.tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1pvacw18cm9l4sb66pqyjc7hc74xhhfxc7kd5ald8lixf4wzg0s8"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2))
> +    (propagated-inputs
> +     `(("python2-booleanoperations" ,python2-booleanoperations)
> +       ("python2-defcon" ,python2-defcon)
> +       ("python2-fonttools" ,python2-fonttools)
> +       ("python2-pillow" ,python2-pillow)
> +       ("python2-pyclipper" ,python2-pyclipper)
> +       ("python2-ufolib" ,python2-ufolib)))
> +    (home-page "https://github.com/googlei18n/nototools")
> +    (synopsis "Noto fonts support tools and scripts")
> +    (description
> +     "Nototools is a python package containing python scripts used to
> +maintain the Noto Fonts project.")
> +    (license (list license:asl2.0
> +                   ;; Sample texts are attributed to UN and OHCHR.
> +                   ;; The permissions on the UDHR are pretty lax:
> +                   ;;
> http://www.ohchr.org/EN/UDHR/Pages/Introduction.aspx
> +                   ;; "If UDHR translations or materials are
> reproduced, users
> +                   ;; should make reference to this website as a
> source by
> +                   ;; providing a link."
> +                   license:public-domain
> +                   license:non-copyleft
> "file://sample_texts/attributions.txt"
> +                   "See sample_texts/attributions.txt in the
> distribution."))))

This whole patchset looks pretty good to me. I've built all the
packages, but haven't tested them.

guix lint has one complaint here about the license:

gnu/packages/fontutils.scm:591:13: nototools <at> 20170925: invalid license
field

I'm not quite sure what this means.

I think it would be good to fix at least the linting issues, then this
can be merged.
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Fri, 13 Oct 2017 08:24:02 GMT) Full text and rfc822 format available.

Message #35 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: ng0 <ng0 <at> infotropique.org>, 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Fri, 13 Oct 2017 08:23:19 +0000
[Message part 1 (text/plain, inline)]
Christopher Baines transcribed 4.7K bytes:
> On Sun, 1 Oct 2017 18:47:37 +0000
> ng0 <ng0 <at> infotropique.org> wrote:
> 
> > * gnu/packages/fontutils.scm (nototools): New variable.
> > ---
> >  gnu/packages/fontutils.scm | 44
> > +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 43
> > insertions(+), 1 deletion(-)
> > 
> > diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
> > index 15401f652..ca10c10b0 100644
> > --- a/gnu/packages/fontutils.scm
> > +++ b/gnu/packages/fontutils.scm
> > @@ -5,6 +5,7 @@
> >  ;;; Copyright © 2016, 2017 Efraim Flashner <efraim <at> flashner.co.il>
> >  ;;; Copyright © 2017 Rene Saavedra <rennes <at> openmailbox.org>
> >  ;;; Copyright © 2017 Leo Famulari <leo <at> famulari.name>
> > +;;; Copyright © 2017 ng0 <ng0 <at> infotropique.org>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -44,7 +45,8 @@
> >    #:use-module (guix svn-download)
> >    #:use-module (guix git-download)
> >    #:use-module (guix build-system cmake)
> > -  #:use-module (guix build-system gnu))
> > +  #:use-module (guix build-system gnu)
> > +  #:use-module (guix build-system python))
> >  
> >  (define-public freetype
> >    (package
> > @@ -565,3 +567,43 @@ opentype fonts.  You can save fonts in many
> > different outline formats, and generate bitmaps.")
> >     (license license:gpl3+)
> >     (home-page "https://fontforge.github.io/en-US/")))
> > +
> > +(define-public nototools
> > +  (package
> > +    (name "nototools")
> > +    (version "20170925")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (string-append "https://github.com/googlei18n/nototools/"
> > +                           "archive/v2017-09-25-tooling-for-phase3-"
> > +                           "update.tar.gz"))
> > +       (file-name (string-append name "-" version ".tar.gz"))
> > +       (sha256
> > +        (base32
> > +         "1pvacw18cm9l4sb66pqyjc7hc74xhhfxc7kd5ald8lixf4wzg0s8"))))
> > +    (build-system python-build-system)
> > +    (arguments
> > +     `(#:python ,python-2))
> > +    (propagated-inputs
> > +     `(("python2-booleanoperations" ,python2-booleanoperations)
> > +       ("python2-defcon" ,python2-defcon)
> > +       ("python2-fonttools" ,python2-fonttools)
> > +       ("python2-pillow" ,python2-pillow)
> > +       ("python2-pyclipper" ,python2-pyclipper)
> > +       ("python2-ufolib" ,python2-ufolib)))
> > +    (home-page "https://github.com/googlei18n/nototools")
> > +    (synopsis "Noto fonts support tools and scripts")
> > +    (description
> > +     "Nototools is a python package containing python scripts used to
> > +maintain the Noto Fonts project.")
> > +    (license (list license:asl2.0
> > +                   ;; Sample texts are attributed to UN and OHCHR.
> > +                   ;; The permissions on the UDHR are pretty lax:
> > +                   ;;
> > http://www.ohchr.org/EN/UDHR/Pages/Introduction.aspx
> > +                   ;; "If UDHR translations or materials are
> > reproduced, users
> > +                   ;; should make reference to this website as a
> > source by
> > +                   ;; providing a link."
> > +                   license:public-domain
> > +                   license:non-copyleft
> > "file://sample_texts/attributions.txt"
> > +                   "See sample_texts/attributions.txt in the
> > distribution."))))
> 
> This whole patchset looks pretty good to me. I've built all the
> packages, but haven't tested them.
> 
> guix lint has one complaint here about the license:
> 
> gnu/packages/fontutils.scm:591:13: nototools <at> 20170925: invalid license
> field
> 
> I'm not quite sure what this means.

I think I know it, the non-copyleft needs to be adjusted to the list.
Thanks. I really should run lint for longer patchseries. I admit I do
this not very often.
Thanks for your review.

> I think it would be good to fix at least the linting issues, then this
> can be merged.



-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://dist.ng0.infotropique.org/dist/keys/
https://www.infotropique.org https://ng0.infotropique.org
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Fri, 13 Oct 2017 19:35:01 GMT) Full text and rfc822 format available.

Message #38 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Fri, 13 Oct 2017 20:34:21 +0100
[Message part 1 (text/plain, inline)]
On Fri, 13 Oct 2017 08:23:19 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> Christopher Baines transcribed 4.7K bytes:
> > On Sun, 1 Oct 2017 18:47:37 +0000
> > ng0 <ng0 <at> infotropique.org> wrote:
> >   
> > > * gnu/packages/fontutils.scm (nototools): New variable.
> > > ---
> > >  gnu/packages/fontutils.scm | 44
> > > +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 43
> > > insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/gnu/packages/fontutils.scm
> > > b/gnu/packages/fontutils.scm index 15401f652..ca10c10b0 100644
> > > --- a/gnu/packages/fontutils.scm
> > > +++ b/gnu/packages/fontutils.scm
> > > @@ -5,6 +5,7 @@
> > >  ;;; Copyright © 2016, 2017 Efraim Flashner
> > > <efraim <at> flashner.co.il> ;;; Copyright © 2017 Rene Saavedra
> > > <rennes <at> openmailbox.org> ;;; Copyright © 2017 Leo Famulari
> > > <leo <at> famulari.name> +;;; Copyright © 2017 ng0
> > > <ng0 <at> infotropique.org> ;;;
> > >  ;;; This file is part of GNU Guix.
> > >  ;;;
> > > @@ -44,7 +45,8 @@
> > >    #:use-module (guix svn-download)
> > >    #:use-module (guix git-download)
> > >    #:use-module (guix build-system cmake)
> > > -  #:use-module (guix build-system gnu))
> > > +  #:use-module (guix build-system gnu)
> > > +  #:use-module (guix build-system python))
> > >  
> > >  (define-public freetype
> > >    (package
> > > @@ -565,3 +567,43 @@ opentype fonts.  You can save fonts in many
> > > different outline formats, and generate bitmaps.")
> > >     (license license:gpl3+)
> > >     (home-page "https://fontforge.github.io/en-US/")))
> > > +
> > > +(define-public nototools
> > > +  (package
> > > +    (name "nototools")
> > > +    (version "20170925")
> > > +    (source
> > > +     (origin
> > > +       (method url-fetch)
> > > +       (uri (string-append
> > > "https://github.com/googlei18n/nototools/"
> > > +
> > > "archive/v2017-09-25-tooling-for-phase3-"
> > > +                           "update.tar.gz"))
> > > +       (file-name (string-append name "-" version ".tar.gz"))
> > > +       (sha256
> > > +        (base32
> > > +
> > > "1pvacw18cm9l4sb66pqyjc7hc74xhhfxc7kd5ald8lixf4wzg0s8"))))
> > > +    (build-system python-build-system)
> > > +    (arguments
> > > +     `(#:python ,python-2))
> > > +    (propagated-inputs
> > > +     `(("python2-booleanoperations" ,python2-booleanoperations)
> > > +       ("python2-defcon" ,python2-defcon)
> > > +       ("python2-fonttools" ,python2-fonttools)
> > > +       ("python2-pillow" ,python2-pillow)
> > > +       ("python2-pyclipper" ,python2-pyclipper)
> > > +       ("python2-ufolib" ,python2-ufolib)))
> > > +    (home-page "https://github.com/googlei18n/nototools")
> > > +    (synopsis "Noto fonts support tools and scripts")
> > > +    (description
> > > +     "Nototools is a python package containing python scripts
> > > used to +maintain the Noto Fonts project.")
> > > +    (license (list license:asl2.0
> > > +                   ;; Sample texts are attributed to UN and
> > > OHCHR.
> > > +                   ;; The permissions on the UDHR are pretty lax:
> > > +                   ;;
> > > http://www.ohchr.org/EN/UDHR/Pages/Introduction.aspx
> > > +                   ;; "If UDHR translations or materials are
> > > reproduced, users
> > > +                   ;; should make reference to this website as a
> > > source by
> > > +                   ;; providing a link."
> > > +                   license:public-domain
> > > +                   license:non-copyleft
> > > "file://sample_texts/attributions.txt"
> > > +                   "See sample_texts/attributions.txt in the
> > > distribution."))))  
> > 
> > This whole patchset looks pretty good to me. I've built all the
> > packages, but haven't tested them.
> > 
> > guix lint has one complaint here about the license:
> > 
> > gnu/packages/fontutils.scm:591:13: nototools <at> 20170925: invalid
> > license field
> > 
> > I'm not quite sure what this means.  
> 
> I think I know it, the non-copyleft needs to be adjusted to the list.
> Thanks. I really should run lint for longer patchseries. I admit I do
> this not very often.
> Thanks for your review.

You're welcome :)

It looks to me like the python-fonttools patch could be merged now,
shall I merge it? I only ask as I don't want to mess up your workflow?
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Fri, 13 Oct 2017 20:01:01 GMT) Full text and rfc822 format available.

Message #41 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: ng0 <ng0 <at> infotropique.org>, 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Fri, 13 Oct 2017 20:00:37 +0000
[Message part 1 (text/plain, inline)]
Christopher Baines transcribed 5.4K bytes:
> On Fri, 13 Oct 2017 08:23:19 +0000
> ng0 <ng0 <at> infotropique.org> wrote:
> 
> > Christopher Baines transcribed 4.7K bytes:
> > > On Sun, 1 Oct 2017 18:47:37 +0000
> > > ng0 <ng0 <at> infotropique.org> wrote:
> > >   
> > > > * gnu/packages/fontutils.scm (nototools): New variable.
> > > > ---
> > > >  gnu/packages/fontutils.scm | 44
> > > > +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 43
> > > > insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/gnu/packages/fontutils.scm
> > > > b/gnu/packages/fontutils.scm index 15401f652..ca10c10b0 100644
> > > > --- a/gnu/packages/fontutils.scm
> > > > +++ b/gnu/packages/fontutils.scm
> > > > @@ -5,6 +5,7 @@
> > > >  ;;; Copyright © 2016, 2017 Efraim Flashner
> > > > <efraim <at> flashner.co.il> ;;; Copyright © 2017 Rene Saavedra
> > > > <rennes <at> openmailbox.org> ;;; Copyright © 2017 Leo Famulari
> > > > <leo <at> famulari.name> +;;; Copyright © 2017 ng0
> > > > <ng0 <at> infotropique.org> ;;;
> > > >  ;;; This file is part of GNU Guix.
> > > >  ;;;
> > > > @@ -44,7 +45,8 @@
> > > >    #:use-module (guix svn-download)
> > > >    #:use-module (guix git-download)
> > > >    #:use-module (guix build-system cmake)
> > > > -  #:use-module (guix build-system gnu))
> > > > +  #:use-module (guix build-system gnu)
> > > > +  #:use-module (guix build-system python))
> > > >  
> > > >  (define-public freetype
> > > >    (package
> > > > @@ -565,3 +567,43 @@ opentype fonts.  You can save fonts in many
> > > > different outline formats, and generate bitmaps.")
> > > >     (license license:gpl3+)
> > > >     (home-page "https://fontforge.github.io/en-US/")))
> > > > +
> > > > +(define-public nototools
> > > > +  (package
> > > > +    (name "nototools")
> > > > +    (version "20170925")
> > > > +    (source
> > > > +     (origin
> > > > +       (method url-fetch)
> > > > +       (uri (string-append
> > > > "https://github.com/googlei18n/nototools/"
> > > > +
> > > > "archive/v2017-09-25-tooling-for-phase3-"
> > > > +                           "update.tar.gz"))
> > > > +       (file-name (string-append name "-" version ".tar.gz"))
> > > > +       (sha256
> > > > +        (base32
> > > > +
> > > > "1pvacw18cm9l4sb66pqyjc7hc74xhhfxc7kd5ald8lixf4wzg0s8"))))
> > > > +    (build-system python-build-system)
> > > > +    (arguments
> > > > +     `(#:python ,python-2))
> > > > +    (propagated-inputs
> > > > +     `(("python2-booleanoperations" ,python2-booleanoperations)
> > > > +       ("python2-defcon" ,python2-defcon)
> > > > +       ("python2-fonttools" ,python2-fonttools)
> > > > +       ("python2-pillow" ,python2-pillow)
> > > > +       ("python2-pyclipper" ,python2-pyclipper)
> > > > +       ("python2-ufolib" ,python2-ufolib)))
> > > > +    (home-page "https://github.com/googlei18n/nototools")
> > > > +    (synopsis "Noto fonts support tools and scripts")
> > > > +    (description
> > > > +     "Nototools is a python package containing python scripts
> > > > used to +maintain the Noto Fonts project.")
> > > > +    (license (list license:asl2.0
> > > > +                   ;; Sample texts are attributed to UN and
> > > > OHCHR.
> > > > +                   ;; The permissions on the UDHR are pretty lax:
> > > > +                   ;;
> > > > http://www.ohchr.org/EN/UDHR/Pages/Introduction.aspx
> > > > +                   ;; "If UDHR translations or materials are
> > > > reproduced, users
> > > > +                   ;; should make reference to this website as a
> > > > source by
> > > > +                   ;; providing a link."
> > > > +                   license:public-domain
> > > > +                   license:non-copyleft
> > > > "file://sample_texts/attributions.txt"
> > > > +                   "See sample_texts/attributions.txt in the
> > > > distribution."))))  
> > > 
> > > This whole patchset looks pretty good to me. I've built all the
> > > packages, but haven't tested them.
> > > 
> > > guix lint has one complaint here about the license:
> > > 
> > > gnu/packages/fontutils.scm:591:13: nototools <at> 20170925: invalid
> > > license field
> > > 
> > > I'm not quite sure what this means.  
> > 
> > I think I know it, the non-copyleft needs to be adjusted to the list.
> > Thanks. I really should run lint for longer patchseries. I admit I do
> > this not very often.
> > Thanks for your review.
> 
> You're welcome :)
> 
> It looks to me like the python-fonttools patch could be merged now,
> shall I merge it? I only ask as I don't want to mess up your workflow?


I have no time this weekend to work on it, I am busy with other things.
If you want to clean up the bits that are necessary and want to merge
it that would be very kind of you.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://dist.ng0.infotropique.org/dist/keys/
https://www.infotropique.org https://ng0.infotropique.org
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Sat, 14 Oct 2017 06:34:01 GMT) Full text and rfc822 format available.

Message #44 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Sat, 14 Oct 2017 07:32:48 +0100
[Message part 1 (text/plain, inline)]
On Fri, 13 Oct 2017 20:00:37 +0000
ng0 <ng0 <at> infotropique.org> wrote:

> Christopher Baines transcribed 5.4K bytes:
> > On Fri, 13 Oct 2017 08:23:19 +0000
> > ng0 <ng0 <at> infotropique.org> wrote:
> >   
> > > Christopher Baines transcribed 4.7K bytes:  
> > > > On Sun, 1 Oct 2017 18:47:37 +0000
> > > > ng0 <ng0 <at> infotropique.org> wrote:
> > > >     
> > > > > * gnu/packages/fontutils.scm (nototools): New variable.
> > > > > ---
> > > > >  gnu/packages/fontutils.scm | 44
> > > > > +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 43
> > > > > insertions(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/gnu/packages/fontutils.scm
> > > > > b/gnu/packages/fontutils.scm index 15401f652..ca10c10b0 100644
> > > > > --- a/gnu/packages/fontutils.scm
> > > > > +++ b/gnu/packages/fontutils.scm
> > > > > @@ -5,6 +5,7 @@
> > > > >  ;;; Copyright © 2016, 2017 Efraim Flashner
> > > > > <efraim <at> flashner.co.il> ;;; Copyright © 2017 Rene Saavedra
> > > > > <rennes <at> openmailbox.org> ;;; Copyright © 2017 Leo Famulari
> > > > > <leo <at> famulari.name> +;;; Copyright © 2017 ng0
> > > > > <ng0 <at> infotropique.org> ;;;
> > > > >  ;;; This file is part of GNU Guix.
> > > > >  ;;;
> > > > > @@ -44,7 +45,8 @@
> > > > >    #:use-module (guix svn-download)
> > > > >    #:use-module (guix git-download)
> > > > >    #:use-module (guix build-system cmake)
> > > > > -  #:use-module (guix build-system gnu))
> > > > > +  #:use-module (guix build-system gnu)
> > > > > +  #:use-module (guix build-system python))
> > > > >  
> > > > >  (define-public freetype
> > > > >    (package
> > > > > @@ -565,3 +567,43 @@ opentype fonts.  You can save fonts in many
> > > > > different outline formats, and generate bitmaps.")
> > > > >     (license license:gpl3+)
> > > > >     (home-page "https://fontforge.github.io/en-US/")))
> > > > > +
> > > > > +(define-public nototools
> > > > > +  (package
> > > > > +    (name "nototools")
> > > > > +    (version "20170925")
> > > > > +    (source
> > > > > +     (origin
> > > > > +       (method url-fetch)
> > > > > +       (uri (string-append
> > > > > "https://github.com/googlei18n/nototools/"
> > > > > +
> > > > > "archive/v2017-09-25-tooling-for-phase3-"
> > > > > +                           "update.tar.gz"))
> > > > > +       (file-name (string-append name "-" version ".tar.gz"))
> > > > > +       (sha256
> > > > > +        (base32
> > > > > +
> > > > > "1pvacw18cm9l4sb66pqyjc7hc74xhhfxc7kd5ald8lixf4wzg0s8"))))
> > > > > +    (build-system python-build-system)
> > > > > +    (arguments
> > > > > +     `(#:python ,python-2))
> > > > > +    (propagated-inputs
> > > > > +     `(("python2-booleanoperations" ,python2-booleanoperations)
> > > > > +       ("python2-defcon" ,python2-defcon)
> > > > > +       ("python2-fonttools" ,python2-fonttools)
> > > > > +       ("python2-pillow" ,python2-pillow)
> > > > > +       ("python2-pyclipper" ,python2-pyclipper)
> > > > > +       ("python2-ufolib" ,python2-ufolib)))
> > > > > +    (home-page "https://github.com/googlei18n/nototools")
> > > > > +    (synopsis "Noto fonts support tools and scripts")
> > > > > +    (description
> > > > > +     "Nototools is a python package containing python scripts
> > > > > used to +maintain the Noto Fonts project.")
> > > > > +    (license (list license:asl2.0
> > > > > +                   ;; Sample texts are attributed to UN and
> > > > > OHCHR.
> > > > > +                   ;; The permissions on the UDHR are pretty lax:
> > > > > +                   ;;
> > > > > http://www.ohchr.org/EN/UDHR/Pages/Introduction.aspx
> > > > > +                   ;; "If UDHR translations or materials are
> > > > > reproduced, users
> > > > > +                   ;; should make reference to this website as a
> > > > > source by
> > > > > +                   ;; providing a link."
> > > > > +                   license:public-domain
> > > > > +                   license:non-copyleft
> > > > > "file://sample_texts/attributions.txt"
> > > > > +                   "See sample_texts/attributions.txt in the
> > > > > distribution."))))    
> > > > 
> > > > This whole patchset looks pretty good to me. I've built all the
> > > > packages, but haven't tested them.
> > > > 
> > > > guix lint has one complaint here about the license:
> > > > 
> > > > gnu/packages/fontutils.scm:591:13: nototools <at> 20170925: invalid
> > > > license field
> > > > 
> > > > I'm not quite sure what this means.    
> > > 
> > > I think I know it, the non-copyleft needs to be adjusted to the list.
> > > Thanks. I really should run lint for longer patchseries. I admit I do
> > > this not very often.
> > > Thanks for your review.  
> > 
> > You're welcome :)
> > 
> > It looks to me like the python-fonttools patch could be merged now,
> > shall I merge it? I only ask as I don't want to mess up your workflow?  
> 
> 
> I have no time this weekend to work on it, I am busy with other things.
> If you want to clean up the bits that are necessary and want to merge
> it that would be very kind of you.

I've gone ahead and merged the python-fonttools related patch, but I'm
not planning to look at the other patches, at least not at the moment :)
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Fri, 20 Oct 2017 20:11:01 GMT) Full text and rfc822 format available.

Message #47 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: ng0 <ng0 <at> infotropique.org>, 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Fri, 20 Oct 2017 20:09:21 +0000
[Message part 1 (text/plain, inline)]
Updated patchseries appended.

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://dist.ng0.infotropique.org/dist/keys/
https://www.infotropique.org https://ng0.infotropique.org
[0001-gnu-Add-python2-ufolib.patch (text/plain, attachment)]
[0002-gnu-Add-python2-setuptools-scm-git-archive.patch (text/plain, attachment)]
[0003-gnu-Add-python2-pyclipper.patch (text/plain, attachment)]
[0004-gnu-Add-python2-booleanoperations.patch (text/plain, attachment)]
[0005-gnu-Add-python2-defcon.patch (text/plain, attachment)]
[0006-gnu-Add-nototools.patch (text/plain, attachment)]
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#28594; Package guix-patches. (Tue, 28 Nov 2017 19:04:01 GMT) Full text and rfc822 format available.

Message #50 received at 28594 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> n0.is>
To: Christopher Baines <mail <at> cbaines.net>
Cc: ng0 <ng0 <at> infotropique.org>, 28594 <at> debbugs.gnu.org
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Tue, 28 Nov 2017 19:02:50 +0000
[Message part 1 (text/plain, inline)]
There has been no comment in 38 days. Could someone look into this?
It's my understanding that it is ready to merge.

I have no push access, so I can not push it.

ng0 transcribed 14K bytes:
> Updated patchseries appended.
> 
> -- 
> ng0
> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> GnuPG: https://dist.ng0.infotropique.org/dist/keys/
> https://www.infotropique.org https://ng0.infotropique.org

> From f830472640712346a80982ab3027e2bd64e5cdff Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> infotropique.org>
> Date: Wed, 20 Sep 2017 11:39:29 +0000
> Subject: [PATCH 1/6] gnu: Add python2-ufolib.
> 
> * gnu/packages/python.scm (python2-ufolib): New variable.
> ---
>  gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 0684090c3..1de08f2cd 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -7412,6 +7412,32 @@ from an XML-based format.")
>  (define-public python2-fonttools
>    (package-with-python2 python-fonttools))
>  
> +(define-public python2-ufolib
> +  (package
> +    (name "python2-ufolib")
> +    (version "2.1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "ufoLib" version ".zip"))
> +       (sha256
> +        (base32 "1njin1465qqzshnrvcl5sbv0bsy15gj6fycbw4lmcnwkx5sldgyx"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2))
> +    (propagated-inputs
> +     `(("python2-fonttools" ,python2-fonttools)))
> +    (native-inputs
> +     `(("unzip" ,unzip)
> +       ("python2-pytest-3.0" ,python2-pytest-3.0)
> +       ("python2-pytest-runner" ,python2-pytest-runner)))
> +    (home-page "https://github.com/unified-font-object/ufoLib")
> +    (synopsis "Low-level UFO reader and writer")
> +    (description
> +     "UfoLib reads and writes Unified Font Object (UFO)
> +files.  UFO is a file format that stores fonts source files.")
> +    (license license:bsd-3)))
> +
>  (define-public python-ly
>    (package
>      (name "python-ly")
> -- 
> 2.14.2
> 

> From afc7f67ba0269d77989c2534d5c1627af716fda9 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> infotropique.org>
> Date: Wed, 20 Sep 2017 11:49:31 +0000
> Subject: [PATCH 2/6] gnu: Add python2-setuptools-scm-git-archive.
> 
> * gnu/packages/python.scm (python2-setuptools-scm-git-archive): New variable.
> ---
>  gnu/packages/python.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 1de08f2cd..dac308e1b 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -7438,6 +7438,30 @@ from an XML-based format.")
>  files.  UFO is a file format that stores fonts source files.")
>      (license license:bsd-3)))
>  
> +(define-public python2-setuptools-scm-git-archive
> +  (package
> +    (name "python2-setuptools-scm-git-archive")
> +    (version "1.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "setuptools_scm_git_archive" version))
> +       (sha256
> +        (base32
> +         "1nii1sz5jq75ilf18bjnr11l9rz1lvdmyk66bxl7q90qan85yhjj"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2))
> +    (propagated-inputs
> +     `(("python2-setuptools-scm" ,python2-setuptools-scm)))
> +    (home-page "https://github.com/Changaco/setuptools_scm_git_archive/")
> +    (synopsis "Setuptools_scm plugin for git archives")
> +    (description
> +     "The setuptools_scm_git_archive package is a plugin to
> +setuptools_scm, which supports obtaining versions from git archives that
> +belong to tagged versions.")
> +    (license license:expat)))
> +
>  (define-public python-ly
>    (package
>      (name "python-ly")
> -- 
> 2.14.2
> 

> From 564f921e767c21f1683f5d6a39a874779a2c4628 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> infotropique.org>
> Date: Wed, 20 Sep 2017 12:00:41 +0000
> Subject: [PATCH 3/6] gnu: Add python2-pyclipper.
> 
> * gnu/packages/python.scm (python2-pyclipper): New variable.
> ---
>  gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index dac308e1b..879f6953a 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -7462,6 +7462,32 @@ setuptools_scm, which supports obtaining versions from git archives that
>  belong to tagged versions.")
>      (license license:expat)))
>  
> +(define-public python2-pyclipper
> +(package
> +  (name "python2-pyclipper")
> +  (version "1.0.6")
> +  (source
> +   (origin
> +     (method url-fetch)
> +     (uri (pypi-uri "pyclipper" version ".zip"))
> +     (sha256
> +      (base32
> +       "1zpmwv3bya3j984y5cf9x9d5108kf6mxldcba68wiq0frv5qrssw"))))
> +  (build-system python-build-system)
> +  (arguments
> +   `(#:python ,python-2
> +     #:tests? #f)); 8 Tests fail, 37 succeed
> +  (propagated-inputs
> +   `(("python2-setuptools-scm-git-archive" ,python2-setuptools-scm-git-archive)))
> +  (native-inputs
> +   `(("unzip" ,unzip)))
> +  (home-page "https://github.com/greginvm/pyclipper")
> +  (synopsis "Wrapper for Angus Johnson's Clipper library")
> +  (description
> +   "Pyclipper is a Cython wrapper for the C++ translation of the
> +Angus Johnson's Clipper library (ver. 6.2.1)")
> +  (license license:expat)))
> +
>  (define-public python-ly
>    (package
>      (name "python-ly")
> -- 
> 2.14.2
> 

> From 0d7311347e24b76c9898b3da1a417021c51e40de Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> infotropique.org>
> Date: Wed, 20 Sep 2017 18:07:47 +0000
> Subject: [PATCH 4/6] gnu: Add python2-booleanoperations.
> 
> * gnu/packages/python.scm (python2-booleanoperations): New variable.
> ---
>  gnu/packages/python.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 879f6953a..50ce4e116 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -7488,6 +7488,35 @@ belong to tagged versions.")
>  Angus Johnson's Clipper library (ver. 6.2.1)")
>    (license license:expat)))
>  
> +(define-public python2-booleanoperations
> +  (package
> +    (name "python2-booleanoperations")
> +    (version "0.7.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "booleanOperations" version ".zip"))
> +       (sha256
> +        (base32
> +         "1hw42fazdpvsn77glx96hwsj9l17mvx37sc5707s08y5w6fx16mn"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2))
> +    (native-inputs
> +     `(("unzip" ,unzip)
> +       ("python2-pytest-3.0" ,python2-pytest-3.0)
> +       ("python2-pytest-runner" ,python2-pytest-runner)))
> +    (propagated-inputs
> +     `(("python-fonttools" ,python2-fonttools)
> +       ("python-pyclipper" ,python2-pyclipper)
> +       ("python-ufolib" ,python2-ufolib)))
> +    (home-page "https://github.com/typemytype/booleanOperations")
> +    (synopsis "Boolean operations on paths")
> +    (description
> +     "BooleanOperations provides a python library that enables
> +boolean operations on paths.")
> +    (license license:expat)))
> +
>  (define-public python-ly
>    (package
>      (name "python-ly")
> -- 
> 2.14.2
> 

> From 4678eb87f6ee5b2bf6bd3c9dbe2c7114985cb653 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> infotropique.org>
> Date: Mon, 25 Sep 2017 11:13:03 +0000
> Subject: [PATCH 5/6] gnu: Add python2-defcon.
> 
> * gnu/packages/python.scm (python2-defcon): New variable.
> ---
>  gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 50ce4e116..893240fdf 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -7517,6 +7517,39 @@ Angus Johnson's Clipper library (ver. 6.2.1)")
>  boolean operations on paths.")
>      (license license:expat)))
>  
> +(define-public python2-defcon
> +  (package
> +    (name "python2-defcon")
> +    (version "0.3.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "defcon" version ".zip"))
> +       (sha256
> +        (base32
> +         "1f41w54fdjy9izxcwzqa142kd56whqsg9nq5k4508jb6iip84h89"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2))
> +    (native-inputs
> +     `(("unzip" ,unzip)
> +       ("python2-pytest-3.0" ,python2-pytest-3.0)
> +       ("python2-pytest-runner" ,python2-pytest-runner)))
> +    (propagated-inputs
> +     `(("python2-fonttools" ,python2-fonttools)
> +       ("python2-ufolib" ,python2-ufolib)))
> +    (home-page "https://pypi.python.org/pypi/defcon")
> +    (synopsis "Flexible objects for representing @acronym{UFO, unified font object} data")
> +    (description
> +     "Defcon is a set of @acronym{UFO, unified font object} based objects
> +optimized for use in font editing applications.  The objects are built to
> +be lightweight, fast and flexible.  The objects are very bare-bones and
> +they are not meant to be end-all, be-all objects.  Rather, they are meant
> +to provide base functionality so that you can focus on your application’s
> +behavior, not object observing or maintaining cached data.  Defcon
> +implements UFO3 as described by the UFO font format.")
> +    (license license:expat)))
> +
>  (define-public python-ly
>    (package
>      (name "python-ly")
> -- 
> 2.14.2
> 

> From f0e5236fb62fb79a5deef3c3179ea9393483b7a7 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> infotropique.org>
> Date: Mon, 25 Sep 2017 12:12:55 +0000
> Subject: [PATCH 6/6] gnu: Add nototools.
> 
> * gnu/packages/fontutils.scm (nototools): New variable.
> ---
>  gnu/packages/fontutils.scm | 45 ++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 44 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
> index 323cfab6f..a72fc005c 100644
> --- a/gnu/packages/fontutils.scm
> +++ b/gnu/packages/fontutils.scm
> @@ -5,6 +5,7 @@
>  ;;; Copyright © 2016, 2017 Efraim Flashner <efraim <at> flashner.co.il>
>  ;;; Copyright © 2017 Rene Saavedra <rennes <at> openmailbox.org>
>  ;;; Copyright © 2017 Leo Famulari <leo <at> famulari.name>
> +;;; Copyright © 2017 ng0 <ng0 <at> infotropique.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -44,7 +45,8 @@
>    #:use-module (guix svn-download)
>    #:use-module (guix git-download)
>    #:use-module (guix build-system cmake)
> -  #:use-module (guix build-system gnu))
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix build-system python))
>  
>  (define-public freetype
>    (package
> @@ -556,3 +558,44 @@ opentype fonts.  You can save fonts in many different outline formats, and
>  generate bitmaps.")
>     (license license:gpl3+)
>     (home-page "https://fontforge.github.io/en-US/")))
> +
> +(define-public nototools
> +  (package
> +    (name "nototools")
> +    (version "20170925")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/googlei18n/nototools/"
> +                           "archive/v2017-09-25-tooling-for-phase3-"
> +                           "update.tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1pvacw18cm9l4sb66pqyjc7hc74xhhfxc7kd5ald8lixf4wzg0s8"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2))
> +    (propagated-inputs
> +     `(("python2-booleanoperations" ,python2-booleanoperations)
> +       ("python2-defcon" ,python2-defcon)
> +       ("python2-fonttools" ,python2-fonttools)
> +       ("python2-pillow" ,python2-pillow)
> +       ("python2-pyclipper" ,python2-pyclipper)
> +       ("python2-ufolib" ,python2-ufolib)))
> +    (home-page "https://github.com/googlei18n/nototools")
> +    (synopsis "Noto fonts support tools and scripts")
> +    (description
> +     "Nototools is a python package containing python scripts used to
> +maintain the Noto Fonts project.")
> +    (license (list license:asl2.0
> +                   ;; Sample texts are attributed to UN and OHCHR.
> +                   ;; The permissions on the UDHR are pretty lax:
> +                   ;; http://www.ohchr.org/EN/UDHR/Pages/Introduction.aspx
> +                   ;; "If UDHR translations or materials are reproduced, users
> +                   ;; should make reference to this website as a source by
> +                   ;; providing a link."
> +                   license:public-domain
> +                   (license:non-copyleft
> +                    "file://sample_texts/attributions.txt"
> +                    "See sample_texts/attributions.txt in the distribution.")))))
> -- 
> 2.14.2
> 




-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is
[signature.asc (application/pgp-signature, inline)]

Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Tue, 28 Nov 2017 19:59:02 GMT) Full text and rfc822 format available.

Notification sent to ng0 <ng0 <at> infotropique.org>:
bug acknowledged by developer. (Tue, 28 Nov 2017 19:59:03 GMT) Full text and rfc822 format available.

Message #55 received at 28594-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28594-done <at> debbugs.gnu.org, Christopher Baines <mail <at> cbaines.net>
Subject: Re: [bug#28594] nototools (required for building Noto from source)
Date: Tue, 28 Nov 2017 14:58:12 -0500
[Message part 1 (text/plain, inline)]
On Fri, Oct 20, 2017 at 08:09:21PM +0000, ng0 wrote:
> Updated patchseries appended.

Thanks! I moved the font-specific packages to (gnu packages fontutils),
added Python 3 package variants where it was easy, and pushed as
20d2c6e749bb65707b90623e495b0e8d32bd92e6.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 27 Dec 2017 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 6 years and 112 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.