GNU logs - #28729, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#28729: 26.0.60; Incorrect Edebug spec for gv-define-setter
Resent-From: Gemini Lasswell <gazally@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 07 Oct 2017 13:53:01 +0000
Resent-Message-ID: <handler.28729.B.15073843233287 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 28729 <at> debbugs.gnu.org
From: Gemini Lasswell <gazally@HIDDEN>
Date: Sat, 07 Oct 2017 06:51:25 -0700
Message-ID: <87r2ufyski.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

The Edebug spec for gv-define-setter is incorrect. It should use
:name, so Edebug doesn't confuse it with the getter, and it should use
def-body instead of body. To reproduce the problem, put this bit of
code into *scratch*:

(defun obo-ref (a idx)
  (aref a (1- idx)))

(gv-define-setter obo-ref (val a idx)
  `(aset ,a (1- ,idx) ,val))

(defvar my-array [ 10 20 30 40 ])

(defun set-first-elem (n)
  (setf (obo-ref my-array 1) n))

Then:

M-x edebug-all-defs RET
M-x eval-buffer RET

Result: Eager macro-expansion failure: (wrong-type-argument consp nil)

M-: (obo-ref my-array 3) RET
SPC SPC

Result: Edebug starts stepping through the setter, then quits with
"Source has changed - reevaluate definition of obo-ref".

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Gemini Lasswell <gazally@HIDDEN>
Subject: bug#28729: Acknowledgement (26.0.60; Incorrect Edebug spec for
 gv-define-setter)
Message-ID: <handler.28729.B.15073843233287.ack <at> debbugs.gnu.org>
References: <87r2ufyski.fsf@HIDDEN>
X-Gnu-PR-Message: ack 28729
X-Gnu-PR-Package: emacs
Reply-To: 28729 <at> debbugs.gnu.org
Date: Sat, 07 Oct 2017 13:53:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 28729 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
28729: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28729
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 15 Jul 2019 09:06:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jul 15 05:06:00 2019
Received: from localhost ([127.0.0.1]:46347 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1hmwvo-0003Zn-9U
	for submit <at> debbugs.gnu.org; Mon, 15 Jul 2019 05:06:00 -0400
Received: from quimby.gnus.org ([80.91.231.51]:38698)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1hmwvl-0003Ze-WF
 for control <at> debbugs.gnu.org; Mon, 15 Jul 2019 05:05:58 -0400
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie)
 by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.89) (envelope-from <larsi@HIDDEN>) id 1hmwvj-00051C-4m
 for control <at> debbugs.gnu.org; Mon, 15 Jul 2019 11:05:57 +0200
Date: Mon, 15 Jul 2019 11:05:54 +0200
Message-Id: <87y30zu0p9.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
Subject: control message for bug #28729
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview:  tags 28729 + confirmed quit 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 28729 + confirmed
quit

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#28729: 26.0.60; Incorrect Edebug spec for gv-define-setter
Resent-From: Lars Ingebrigtsen <larsi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 15 Jul 2019 09:17:01 +0000
Resent-Message-ID: <handler.28729.B28729.156318219219866 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Gemini Lasswell <gazally@HIDDEN>
Cc: 28729 <at> debbugs.gnu.org
From: Lars Ingebrigtsen <larsi@HIDDEN>
References: <87r2ufyski.fsf@HIDDEN>
Date: Mon, 15 Jul 2019 11:16:24 +0200
In-Reply-To: <87r2ufyski.fsf@HIDDEN> (Gemini Lasswell's message of "Sat,
 07 Oct 2017 06:51:25 -0700")
Message-ID: <87v9w3u07r.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Gemini Lasswell <gazally@HIDDEN> writes:

> The Edebug spec for gv-define-setter is incorrect. It should use
> :name, so Edebug doesn't confuse it with the getter, and it should use
> def-body instead of body. To reproduce the problem, put this bit of
> code into *scratch*:
>
> (defun obo-ref (a idx)
>   (aref a (1- idx)))
>
> (gv-define-setter obo-ref (val a idx)
>   `(aset ,a (1- ,idx) ,val))
>
> (defvar my-array [ 10 20 30 40 ])
>
> (defun set-first-elem (n)
>   (setf (obo-ref my-array 1) n))
>
> Then:
>
> M-x edebug-all-defs RET
> M-x eval-buffer RET
>
> Result: Eager macro-expansion failure: (wrong-type-argument consp nil)

I can confirm that changing `body' to `def-body' fixes this bug.

> M-: (obo-ref my-array 3) RET
> SPC SPC
>
> Result: Edebug starts stepping through the setter, then quits with
> "Source has changed - reevaluate definition of obo-ref".

This is till a problem.  I'm not sure what you mean by "It should use
:name" -- how does that work in edebug specs?  (I'm not particularly
familiar with edebug internals.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.