GNU bug report logs - #28886
[PATCH] gnu: Add emacs-robe.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28886 in the body.
You can then email your comments to 28886 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-robe.
Date: Wed, 18 Oct 2017 07:20:27 +0100

* gnu/packages/emacs.scm (emacs-robe): New variable.
---
 gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 315db18a5..45dde77e0 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2124,6 +2124,31 @@ tables.")
 mode-line.")
     (license license:gpl2+)))
 
+(define-public emacs-robe
+  (package
+    (name "emacs-robe")
+    (version "0.8.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/dgutov/robe/"
+                           "archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1vp45y99fwj88z04ah4yppz4z568qcib646az6m9az5ar0f203br"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-inf-ruby" ,emacs-inf-ruby)))
+    (home-page "https://github.com/dgutov/robe")
+    (synopsis "Ruby code assistance tool for Emacs")
+    (description
+     "Robe can provide information on loaded classes and modules in Ruby code,
+as well as where methods are defined.  This allows the user to jump to method
+definitions, modules and classes, display method documentation and provide
+method and constant name completion.")
+    (license license:gpl3+)))
+
 (define-public emacs-rspec
   (package
     (name "emacs-rspec")
-- 
2.14.2

Message #8 received at 28886 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 28886 <at> debbugs.gnu.org
Subject: Re: [bug#28886] [PATCH] gnu: Add emacs-robe.
Date: Wed, 18 Oct 2017 22:31:33 +0200

Hi,

> * gnu/packages/emacs.scm (emacs-robe): New variable.
> ---

Thanks, this looks good.

The website lists a couple of Ruby dependencies:

--8<---------------cut here---------------start------------->8---
* pry
* pry-doc >= 0.6.0 (on MRI)
* method_source >= 0.8.2 (for compatibility with the latest
 Rubinius)
--8<---------------cut here---------------end--------------->8---

yet, I don’t see them among the inputs of this package.  Is this just
something that users are reasonably expected to have on their systems
when they want to use robe, or should these things be among the inputs?

I trust you made the right decision here, but I thought I’d just ask as
it is a bit confusing.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #13 received at 28886 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 28886 <at> debbugs.gnu.org
Subject: Re: [bug#28886] [PATCH] gnu: Add emacs-robe.
Date: Mon, 04 Dec 2017 00:04:02 +0100

Hi again,

some time ago I wrote this:

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Hi,
>
>> * gnu/packages/emacs.scm (emacs-robe): New variable.
>> ---
>
> Thanks, this looks good.
>
> The website lists a couple of Ruby dependencies:
>
> --8<---------------cut here---------------start------------->8---
> * pry
> * pry-doc >= 0.6.0 (on MRI)
> * method_source >= 0.8.2 (for compatibility with the latest
>  Rubinius)
> --8<---------------cut here---------------end--------------->8---
>
> yet, I don’t see them among the inputs of this package.  Is this just
> something that users are reasonably expected to have on their systems
> when they want to use robe, or should these things be among the inputs?
>
> I trust you made the right decision here, but I thought I’d just ask as
> it is a bit confusing.

“pry” is a ruby debugger, right?  It is a runtime dependency, but one
would expect a Ruby developer to provide one version or another,
dependent on their project.

If this is correct I don’t want to block this patch: it looks good to
me.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #18 received at 28886-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 28886-done <at> debbugs.gnu.org
Subject: Re: [bug#28886] [PATCH] gnu: Add emacs-robe.
Date: Sat, 09 Dec 2017 21:14:43 +0000

[Message part 1 (text/plain, inline)]

Ricardo Wurmus writes:

> Hi again,
>
> some time ago I wrote this:
>
> Ricardo Wurmus <rekado <at> elephly.net> writes:
>
>> Hi,
>>
>>> * gnu/packages/emacs.scm (emacs-robe): New variable.
>>> ---
>>
>> Thanks, this looks good.
>>
>> The website lists a couple of Ruby dependencies:
>>
>> --8<---------------cut here---------------start------------->8---
>> * pry
>> * pry-doc >= 0.6.0 (on MRI)
>> * method_source >= 0.8.2 (for compatibility with the latest
>>  Rubinius)
>> --8<---------------cut here---------------end--------------->8---
>>
>> yet, I don’t see them among the inputs of this package.  Is this just
>> something that users are reasonably expected to have on their systems
>> when they want to use robe, or should these things be among the inputs?
>>
>> I trust you made the right decision here, but I thought I’d just ask as
>> it is a bit confusing.
>
> “pry” is a ruby debugger, right?  It is a runtime dependency, but one
> would expect a Ruby developer to provide one version or another,
> dependent on their project.
>
> If this is correct I don’t want to block this patch: it looks good to
> me.

Ok, great. I was planning on trying to use this more, but I haven't got
around to that yet. I've pushed this to master now, maybe that will
help.

Thanks for reviewing :)

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.