GNU bug report logs - #28943
25.2; desktop-kill should not be in kill-emacs-hook

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: minor; Reported by: Pierre Neidhardt <ambrevar@HIDDEN>; merged with #21833; dated Sun, 22 Oct 2017 16:28:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Forcibly Merged 21833 28943. Request was from Glenn Morris <rgm@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 22 Oct 2017 16:27:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 22 12:27:39 2017
Received: from localhost ([127.0.0.1]:56098 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1e6J6A-000132-Pq
	for submit <at> debbugs.gnu.org; Sun, 22 Oct 2017 12:27:39 -0400
Received: from eggs.gnu.org ([208.118.235.92]:52416)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ambrevar@HIDDEN>) id 1e6J69-00012p-7G
 for submit <at> debbugs.gnu.org; Sun, 22 Oct 2017 12:27:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ambrevar@HIDDEN>) id 1e6J63-00020B-1C
 for submit <at> debbugs.gnu.org; Sun, 22 Oct 2017 12:27:32 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM,
 T_DKIM_INVALID autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:33363)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <ambrevar@HIDDEN>) id 1e6J62-000203-UQ
 for submit <at> debbugs.gnu.org; Sun, 22 Oct 2017 12:27:30 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43366)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <ambrevar@HIDDEN>) id 1e6J61-0001VY-Nb
 for bug-gnu-emacs@HIDDEN; Sun, 22 Oct 2017 12:27:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ambrevar@HIDDEN>) id 1e6J5y-0001yl-JO
 for bug-gnu-emacs@HIDDEN; Sun, 22 Oct 2017 12:27:29 -0400
Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:47676)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <ambrevar@HIDDEN>) id 1e6J5y-0001y4-D1
 for bug-gnu-emacs@HIDDEN; Sun, 22 Oct 2017 12:27:26 -0400
Received: by mail-wm0-x22e.google.com with SMTP id t69so5455782wmt.2
 for <bug-gnu-emacs@HIDDEN>; Sun, 22 Oct 2017 09:27:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=user-agent:from:to:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=VX/6iE2HR04G4MFB9Qwwp3Sea1z2kPLKekZ6qqbY4Og=;
 b=R4aqpSDuWQhrudiIgvcSrmJaMseVzlD22/wBaXb0ltG9Ia3BOWVwmNb0Ueeb4HKkrg
 G/LXAmwmu14htoEOcSFKonPn1pvZzLWVmRPuEL42/i3x0v2/ojZkfLzU7NjpVyxjdezk
 tjlvHfLZZd9RI99ue8xySqYGlR4hP+VuFi0BLEn7SFBUpRzMob+AFnCpx5RpsLxybLvO
 mrk5gzqAaICGRbHA+ncV1fwFAKpuHEZyQ/GiTcQ95aoECjaME3WJg90rFLK8B6aPOcxz
 PYKf+yY7Asu1l+6B1b3GfaeZXueCRX76Xh7wiOBkBwP7RceJWC6OvxDEINOmOxaWBLbo
 dbGg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:user-agent:from:to:subject:date:message-id
 :mime-version:content-transfer-encoding;
 bh=VX/6iE2HR04G4MFB9Qwwp3Sea1z2kPLKekZ6qqbY4Og=;
 b=d416HJ9FdxMRrnl5widi8F1NsuZlMjdxNLz7DDt9Lm1ddgH8TpjUASxyNPLGJxiqmb
 AmqsOWYvs7Bl9TqLiRRzKvE3DO4LOSW3p8mGaTlPx3KGj46MdqBLQoWFgsRQZ3RrYNoj
 iKfGXr3Y3Rc/HP0G6HPBqH/z3WepsV6bfxL9gEi84XjoOaj9D9+uHKZa95y1j2cufE3h
 YRjnvFnRKGyQ0iI5fwY4bNkX6ubtgE45yWgDTbOAtSaS2Pvwxhh4CceQjldG1TAE6Fnl
 1iCDV3pZ+vppka76aZD/ySet8OJzq/ejPaHYqfLKGYtyiFlX2jhvlFg15lT5ZyDcb7T0
 pCrw==
X-Gm-Message-State: AMCzsaXnuartZnQSVXpuporxk3sUkEnvKt38xL1yyg/QsFeY+jRUOEqG
 TKNx1Ym+A0YvfMzCGtKSH/Ulcw==
X-Google-Smtp-Source: ABhQp+Q43eQhzzLEFcUJV+Tc9rgUKk+bvA601/qMLy0eqNx9xdd7QgBwDork1tje132P5W3ZRxhOTQ==
X-Received: by 10.28.55.71 with SMTP id e68mr3590359wma.139.1508689643751;
 Sun, 22 Oct 2017 09:27:23 -0700 (PDT)
Received: from dhiov23k ([197.1.53.85])
 by smtp.gmail.com with ESMTPSA id o3sm3454072wmg.3.2017.10.22.09.27.22
 for <bug-gnu-emacs@HIDDEN>
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Sun, 22 Oct 2017 09:27:23 -0700 (PDT)
User-agent: mu4e 0.9.18; emacs 25.2.1
From: Pierre Neidhardt <ambrevar@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 25.2; desktop-kill should not be in kill-emacs-hook
Date: Sun, 22 Oct 2017 17:27:21 +0100
Message-ID: <87fuabup06.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
 recognized.
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -4.0 (----)


As per the documentation of `kill-emacs-hook':

> functions placed on this hook should not
> expect to be able to interact with the user.  To ask for confirmation,
> see ‘kill-emacs-query-functions’ instead.

In the meanwhile, `desktop-kill':

> If the desktop should be saved and ‘desktop-dirname’
> is nil, ask the user where to save the desktop.

I suggest either we move `desktop-kill' to `kill-emacs-query-functions'
or we define two functions, one with user interaction, the other one
unattended.



In GNU Emacs 25.2.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.16)
 of 2017-09-02 built on dhiov23k
Windowing system distributor 'The X.Org Foundation', version 11.0.11905000
System Description:	Gentoo Base System release 2.4.1

Configured using:
 'configure --prefix=/usr --build=x86_64-pc-linux-gnu
 --host=x86_64-pc-linux-gnu --mandir=/usr/share/man
 --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc
 --localstatedir=/var/lib --disable-dependency-tracking
 --disable-silent-rules --docdir=/usr/share/doc/emacs-25.2
 --htmldir=/usr/share/doc/emacs-25.2/html --libdir=/usr/lib64
 --program-suffix=-emacs-25 --infodir=/usr/share/info/emacs-25
 --localstatedir=/var
 --enable-locallisppath=/etc/emacs:/usr/share/emacs/site-lisp
 --with-gameuser=:gamestat --without-compress-install
 --with-file-notification=inotify --enable-acl --without-dbus
 --without-modules --without-gpm --without-hesiod --without-kerberos
 --without-kerberos5 --with-xml2 --without-selinux --with-gnutls
 --without-wide-int --with-zlib --with-sound=alsa --with-x --without-ns
 --without-gconf --without-gsettings --without-toolkit-scroll-bars
 --with-gif --with-jpeg --with-png --with-rsvg --with-tiff --with-xpm
 --with-imagemagick --with-xft --without-cairo --without-libotf
 --without-m17n-flt --with-x-toolkit=gtk3 --without-xwidgets
 GENTOO_PACKAGE=app-editors/emacs-25.2 'CFLAGS=-march=ivybridge -O2
 -pipe' CPPFLAGS= 'LDFLAGS=-Wl,-O1 -Wl,--as-needed''

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND NOTIFY ACL GNUTLS LIBXML2
FREETYPE XFT ZLIB GTK3 X11

Important settings:
  value of $LANG: en_US.utf8
  locale-coding-system: utf-8-unix




Acknowledgement sent to Pierre Neidhardt <ambrevar@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#28943; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 22 Oct 2017 23:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.