GNU bug report logs - #28943
25.2; desktop-kill should not be in kill-emacs-hook

Previous Next

Package: emacs;

Reported by: Pierre Neidhardt <ambrevar <at> gmail.com>

Date: Sun, 22 Oct 2017 16:28:01 UTC

Severity: minor

Merged with 21833

Found in versions 24.4, 25.2

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28943 in the body.
You can then email your comments to 28943 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#28943; Package emacs. (Sun, 22 Oct 2017 16:28:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Pierre Neidhardt <ambrevar <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 22 Oct 2017 16:28:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.2; desktop-kill should not be in kill-emacs-hook
Date: Sun, 22 Oct 2017 17:27:21 +0100
As per the documentation of `kill-emacs-hook':

> functions placed on this hook should not
> expect to be able to interact with the user.  To ask for confirmation,
> see ‘kill-emacs-query-functions’ instead.

In the meanwhile, `desktop-kill':

> If the desktop should be saved and ‘desktop-dirname’
> is nil, ask the user where to save the desktop.

I suggest either we move `desktop-kill' to `kill-emacs-query-functions'
or we define two functions, one with user interaction, the other one
unattended.



In GNU Emacs 25.2.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.16)
 of 2017-09-02 built on dhiov23k
Windowing system distributor 'The X.Org Foundation', version 11.0.11905000
System Description:	Gentoo Base System release 2.4.1

Configured using:
 'configure --prefix=/usr --build=x86_64-pc-linux-gnu
 --host=x86_64-pc-linux-gnu --mandir=/usr/share/man
 --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc
 --localstatedir=/var/lib --disable-dependency-tracking
 --disable-silent-rules --docdir=/usr/share/doc/emacs-25.2
 --htmldir=/usr/share/doc/emacs-25.2/html --libdir=/usr/lib64
 --program-suffix=-emacs-25 --infodir=/usr/share/info/emacs-25
 --localstatedir=/var
 --enable-locallisppath=/etc/emacs:/usr/share/emacs/site-lisp
 --with-gameuser=:gamestat --without-compress-install
 --with-file-notification=inotify --enable-acl --without-dbus
 --without-modules --without-gpm --without-hesiod --without-kerberos
 --without-kerberos5 --with-xml2 --without-selinux --with-gnutls
 --without-wide-int --with-zlib --with-sound=alsa --with-x --without-ns
 --without-gconf --without-gsettings --without-toolkit-scroll-bars
 --with-gif --with-jpeg --with-png --with-rsvg --with-tiff --with-xpm
 --with-imagemagick --with-xft --without-cairo --without-libotf
 --without-m17n-flt --with-x-toolkit=gtk3 --without-xwidgets
 GENTOO_PACKAGE=app-editors/emacs-25.2 'CFLAGS=-march=ivybridge -O2
 -pipe' CPPFLAGS= 'LDFLAGS=-Wl,-O1 -Wl,--as-needed''

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND NOTIFY ACL GNUTLS LIBXML2
FREETYPE XFT ZLIB GTK3 X11

Important settings:
  value of $LANG: en_US.utf8
  locale-coding-system: utf-8-unix




Forcibly Merged 21833 28943. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 22 Oct 2017 23:16:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#28943; Package emacs. (Tue, 31 Oct 2017 08:42:01 GMT) Full text and rfc822 format available.

Message #10 received at 28943 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Pierre Neidhardt <ambrevar <at> gmail.com>, 28943 <at> debbugs.gnu.org
Subject: Re: bug#28943: 25.2; desktop-kill should not be in kill-emacs-hook
Date: Tue, 31 Oct 2017 09:41:04 +0100
> In the meanwhile, `desktop-kill':
>
>> If the desktop should be saved and ‘desktop-dirname’
>> is nil, ask the user where to save the desktop.
>
> I suggest either we move `desktop-kill' to `kill-emacs-query-functions'
> or we define two functions, one with user interaction, the other one
> unattended.

I think we should just move it to ‘kill-emacs-query-functions’.  A
cursory look reveals that at least ‘eshell-save-some-last-dir’,
‘eshell-save-some-history’ and ‘ps-kill-emacs-check’ seem to have the
same problem.

martin





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#28943; Package emacs. (Fri, 02 Jul 2021 15:34:02 GMT) Full text and rfc822 format available.

Message #13 received at 28943 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 28943 <at> debbugs.gnu.org, Pierre Neidhardt <ambrevar <at> gmail.com>
Subject: Re: bug#28943: 25.2; desktop-kill should not be in kill-emacs-hook
Date: Fri, 02 Jul 2021 17:33:43 +0200
martin rudalics <rudalics <at> gmx.at> writes:

>> I suggest either we move `desktop-kill' to `kill-emacs-query-functions'
>> or we define two functions, one with user interaction, the other one
>> unattended.
>
> I think we should just move it to ‘kill-emacs-query-functions’.

It seems like everybody agreed about that, so I've now made this change
in Emacs 28.

> A cursory look reveals that at least ‘eshell-save-some-last-dir’,
> ‘eshell-save-some-history’ and ‘ps-kill-emacs-check’ seem to have the
> same problem.

Ditto.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug marked as fixed in version 28.1, send any further explanations to 28943 <at> debbugs.gnu.org and Pierre Neidhardt <ambrevar <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 02 Jul 2021 15:34:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 31 Jul 2021 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 242 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.