GNU bug report logs -
#28976
[PATCH] gnu: calcurse: Used the "fixed" test-only tzdata for tests.
Previous Next
Reported by: Leo Famulari <leo <at> famulari.name>
Date: Tue, 24 Oct 2017 20:14:02 UTC
Severity: normal
Tags: patch
Done: Leo Famulari <leo <at> famulari.name>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28976 in the body.
You can then email your comments to 28976 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#28976
; Package
guix-patches
.
(Tue, 24 Oct 2017 20:14:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Leo Famulari <leo <at> famulari.name>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Tue, 24 Oct 2017 20:14:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/calcurse.scm (calcurse)[inputs]: Remove tzdata and add ...
[native-inputs]: tzdata-2017a.
[arguments]: Add tzdata-2017a to #:disallowed-references.
---
gnu/packages/calcurse.scm | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/calcurse.scm b/gnu/packages/calcurse.scm
index 20a9a8fb4..826b1f1d0 100644
--- a/gnu/packages/calcurse.scm
+++ b/gnu/packages/calcurse.scm
@@ -1,5 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2014, 2015, 2017 Eric Bavier <bavier <at> member.fsf.org>
+;;; Copyright © 2014, 2015, 2017 Leo Famulari <leo <at> famulari.name>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -38,13 +39,17 @@
(base32
"0il0y06akdqgy0f9p40m4x6arn66nh7sr1w1i41bszycs7div266"))))
(build-system gnu-build-system)
- (inputs `(("ncurses" ,ncurses)
- ("tzdata" ,tzdata)))
+ (inputs `(("ncurses" ,ncurses)))
+ (native-inputs `(("tzdata" ,tzdata-2017a)))
(arguments
;; The ical tests all want to create a ".calcurse" directory, and may
;; fail with "cannot create directory '.calcurse': File exists" if run
;; concurently.
- '(#:parallel-tests? #f
+ `(#:parallel-tests? #f
+ ;; Since this tzdata is only used for tests and not referenced by the
+ ;; built package, used the "fixed" obsolete version of tzdata and ensure
+ ;; it does not sneak in to the closure.
+ #:disallowed-references (,tzdata-2017a)
#:phases (modify-phases %standard-phases
(add-before 'check 'check-setup
(lambda* (#:key inputs #:allow-other-keys)
--
2.14.3
Information forwarded
to
guix-patches <at> gnu.org
:
bug#28976
; Package
guix-patches
.
(Tue, 24 Oct 2017 21:14:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 28976 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:
> * gnu/packages/calcurse.scm (calcurse)[inputs]: Remove tzdata and add ...
> [native-inputs]: tzdata-2017a.
> [arguments]: Add tzdata-2017a to #:disallowed-references.
LGTM.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#28976
; Package
guix-patches
.
(Thu, 26 Oct 2017 04:46:01 GMT)
Full text and
rfc822 format available.
Message #11 received at 28976 <at> debbugs.gnu.org (full text, mbox):
On Tue, 24 Oct 2017 16:13:04 -0400
Leo Famulari <leo <at> famulari.name> wrote:
> * gnu/packages/calcurse.scm (calcurse)[inputs]: Remove tzdata and add ...
> [native-inputs]: tzdata-2017a.
> [arguments]: Add tzdata-2017a to #:disallowed-references.
> ---
> gnu/packages/calcurse.scm | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/calcurse.scm b/gnu/packages/calcurse.scm
> index 20a9a8fb4..826b1f1d0 100644
> --- a/gnu/packages/calcurse.scm
> +++ b/gnu/packages/calcurse.scm
> @@ -1,5 +1,6 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright © 2014, 2015, 2017 Eric Bavier <bavier <at> member.fsf.org>
> +;;; Copyright © 2014, 2015, 2017 Leo Famulari <leo <at> famulari.name>
Do you want all the copyright years? or copy-paste error?
Otherwise LGTM!
Thanks,
`~Eric
Information forwarded
to
guix-patches <at> gnu.org
:
bug#28976
; Package
guix-patches
.
(Thu, 26 Oct 2017 14:47:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 28976 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Wed, Oct 25, 2017 at 06:45:47PM -0500, Eric Bavier wrote:
> On Tue, 24 Oct 2017 16:13:04 -0400
> Leo Famulari <leo <at> famulari.name> wrote:
>
> > * gnu/packages/calcurse.scm (calcurse)[inputs]: Remove tzdata and add ...
> > [native-inputs]: tzdata-2017a.
> > [arguments]: Add tzdata-2017a to #:disallowed-references.
> > ---
> > gnu/packages/calcurse.scm | 11 ++++++++---
> > 1 file changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/gnu/packages/calcurse.scm b/gnu/packages/calcurse.scm
> > index 20a9a8fb4..826b1f1d0 100644
> > --- a/gnu/packages/calcurse.scm
> > +++ b/gnu/packages/calcurse.scm
> > @@ -1,5 +1,6 @@
> > ;;; GNU Guix --- Functional package management for GNU
> > ;;; Copyright © 2014, 2015, 2017 Eric Bavier <bavier <at> member.fsf.org>
> > +;;; Copyright © 2014, 2015, 2017 Leo Famulari <leo <at> famulari.name>
>
> Do you want all the copyright years? or copy-paste error?
Copy-paste error! :)
Fixed in commit 17650569d44efbd6425f0bd93a8ff57f220034ed.
[signature.asc (application/pgp-signature, inline)]
bug closed, send any further explanations to
28976 <at> debbugs.gnu.org and Leo Famulari <leo <at> famulari.name>
Request was from
Leo Famulari <leo <at> famulari.name>
to
control <at> debbugs.gnu.org
.
(Thu, 21 Dec 2017 19:20:02 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Fri, 19 Jan 2018 12:24:06 GMT)
Full text and
rfc822 format available.
This bug report was last modified 6 years and 90 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.