GNU bug report logs -
#29206
Make xref-show-xrefs-function a defcustom
Previous Next
Reported by: Fritz Stelzer <brotzeitmacher <at> gmail.com>
Date: Wed, 8 Nov 2017 09:44:02 UTC
Severity: wishlist
Tags: fixed, patch
Fixed in version 27.1
Done: Lars Ingebrigtsen <larsi <at> gnus.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29206 in the body.
You can then email your comments to 29206 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#29206; Package
emacs.
(Wed, 08 Nov 2017 09:44:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Fritz Stelzer <brotzeitmacher <at> gmail.com>:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org.
(Wed, 08 Nov 2017 09:44:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
master c89870d7ef8b59febba9060f0da25b24403c2e08
Author: brotzeit <brotzeitmacher <at> gmail.com>
AuthorDate: Wed Nov 8 10:39:57 2017 +0100
Commit: brotzeit <brotzeitmacher <at> gmail.com>
CommitDate: Wed Nov 8 10:39:57 2017 +0100
Parent: 83dc3f0e9b * lisp/net/tramp-cmds.el, lisp/allout.el: Avoid
custom-set-variables
Merged: master
Containing: master
Follows: emacs-25.1 (130661)
Make xref-show-xrefs-function a defcustom
1 file changed, 3 insertions(+), 2 deletions(-)
lisp/progmodes/xref.el | 5 +++--
modified lisp/progmodes/xref.el
@@ -738,8 +738,9 @@ xref--show-xref-buffer
;; The controversial multiple definitions case is handed off to
;; xref-show-xrefs-function.
-(defvar xref-show-xrefs-function 'xref--show-xref-buffer
- "Function to display a list of xrefs.")
+(defcustom xref-show-xrefs-function 'xref--show-xref-buffer
+ "Function to display a list of xrefs."
+ :type 'function)
(defvar xref--read-identifier-history nil)
[Message part 2 (text/html, inline)]
Added tag(s) patch.
Request was from
Noam Postavsky <npostavs <at> users.sourceforge.net>
to
control <at> debbugs.gnu.org.
(Thu, 09 Nov 2017 19:57:01 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#29206; Package
emacs.
(Sat, 18 Nov 2017 10:16:02 GMT)
Full text and
rfc822 format available.
Message #10 received at 29206 <at> debbugs.gnu.org (full text, mbox):
> From: Fritz Stelzer <brotzeitmacher <at> gmail.com>
> Date: Wed, 8 Nov 2017 10:43:29 +0100
>
> master c89870d7ef8b59febba9060f0da25b24403c2e08
> Author: brotzeit <brotzeitmacher <at> gmail.com>
> AuthorDate: Wed Nov 8 10:39:57 2017 +0100
> Commit: brotzeit <brotzeitmacher <at> gmail.com>
> CommitDate: Wed Nov 8 10:39:57 2017 +0100
>
> Parent: 83dc3f0e9b * lisp/net/tramp-cmds.el, lisp/allout.el: Avoid custom-set-variables
> Merged: master
> Containing: master
> Follows: emacs-25.1 (130661)
>
> Make xref-show-xrefs-function a defcustom
>
> 1 file changed, 3 insertions(+), 2 deletions(-)
> lisp/progmodes/xref.el | 5 +++--
>
> modified lisp/progmodes/xref.el
> @@ -738,8 +738,9 @@ xref--show-xref-buffer
> ;; The controversial multiple definitions case is handed off to
> ;; xref-show-xrefs-function.
>
> -(defvar xref-show-xrefs-function 'xref--show-xref-buffer
> - "Function to display a list of xrefs.")
> +(defcustom xref-show-xrefs-function 'xref--show-xref-buffer
> + "Function to display a list of xrefs."
> + :type 'function)
>
> (defvar xref--read-identifier-history nil)
Dmitry, any comments on this? (If accepted, the defcustom should have
a :version tag.)
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#29206; Package
emacs.
(Sat, 18 Nov 2017 23:43:01 GMT)
Full text and
rfc822 format available.
Message #13 received at 29206 <at> debbugs.gnu.org (full text, mbox):
On 11/18/17 12:14 PM, Eli Zaretskii wrote:
>> -(defvar xref-show-xrefs-function 'xref--show-xref-buffer
>> - "Function to display a list of xrefs.")
>> +(defcustom xref-show-xrefs-function 'xref--show-xref-buffer
>> + "Function to display a list of xrefs."
>> + :type 'function)
>>
>> (defvar xref--read-identifier-history nil)
>
> Dmitry, any comments on this? (If accepted, the defcustom should have
> a :version tag.)
I don't really see the point, yet: we don't offer any alternative
functions, and if the user is going to write one, `setq' is just as easy
to do.
Further, applying this kind of minor change (and finding it important)
seems like it would indicate that xref is kind of "stable", which it is
not, so far.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#29206; Package
emacs.
(Sun, 19 Nov 2017 15:29:02 GMT)
Full text and
rfc822 format available.
Message #16 received at 29206 <at> debbugs.gnu.org (full text, mbox):
> Cc: 29206 <at> debbugs.gnu.org
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Date: Sun, 19 Nov 2017 01:42:17 +0200
>
> On 11/18/17 12:14 PM, Eli Zaretskii wrote:
>
> >> -(defvar xref-show-xrefs-function 'xref--show-xref-buffer
> >> - "Function to display a list of xrefs.")
> >> +(defcustom xref-show-xrefs-function 'xref--show-xref-buffer
> >> + "Function to display a list of xrefs."
> >> + :type 'function)
> >>
> >> (defvar xref--read-identifier-history nil)
> >
> > Dmitry, any comments on this? (If accepted, the defcustom should have
> > a :version tag.)
>
> I don't really see the point, yet: we don't offer any alternative
> functions, and if the user is going to write one, `setq' is just as easy
> to do.
>
> Further, applying this kind of minor change (and finding it important)
> seems like it would indicate that xref is kind of "stable", which it is
> not, so far.
Fine with me, then please close as "wontfix".
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#29206; Package
emacs.
(Mon, 20 Nov 2017 22:19:01 GMT)
Full text and
rfc822 format available.
Message #19 received at 29206 <at> debbugs.gnu.org (full text, mbox):
On 11/19/17 5:28 PM, Eli Zaretskii wrote:
> Fine with me, then please close as "wontfix".
If you don't mind, I'd rather keep it open for now. And close it if the
situation doesn't change, say, within the next development cycle.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#29206; Package
emacs.
(Mon, 24 Jun 2019 20:32:01 GMT)
Full text and
rfc822 format available.
Message #22 received at 29206 <at> debbugs.gnu.org (full text, mbox):
Dmitry Gutov <dgutov <at> yandex.ru> writes:
> On 11/19/17 5:28 PM, Eli Zaretskii wrote:
>
>> Fine with me, then please close as "wontfix".
>
> If you don't mind, I'd rather keep it open for now. And close it if
> the situation doesn't change, say, within the next development cycle.
That was a year and a half ago -- what's your opinion now?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#29206; Package
emacs.
(Mon, 24 Jun 2019 23:37:02 GMT)
Full text and
rfc822 format available.
Message #25 received at 29206 <at> debbugs.gnu.org (full text, mbox):
On 24.06.2019 23:31, Lars Ingebrigtsen wrote:
> That was a year and a half ago -- what's your opinion now?
I'd be fine with it now. Though the surrounding code has changed a bit
and the patch doesn't apply anymore.
The same change would need to be made for xref-show-definitions-function
as well, I think.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#29206; Package
emacs.
(Tue, 25 Jun 2019 11:10:02 GMT)
Full text and
rfc822 format available.
Message #28 received at 29206 <at> debbugs.gnu.org (full text, mbox):
Dmitry Gutov <dgutov <at> yandex.ru> writes:
> I'd be fine with it now. Though the surrounding code has changed a bit
> and the patch doesn't apply anymore.
>
> The same change would need to be made for
> xref-show-definitions-function as well, I think.
OK; I've now made these changes.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed.
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org.
(Tue, 25 Jun 2019 11:11:02 GMT)
Full text and
rfc822 format available.
bug marked as fixed in version 27.1, send any further explanations to
29206 <at> debbugs.gnu.org and Fritz Stelzer <brotzeitmacher <at> gmail.com>
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org.
(Tue, 25 Jun 2019 11:11:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#29206; Package
emacs.
(Tue, 25 Jun 2019 13:33:02 GMT)
Full text and
rfc822 format available.
Message #35 received at 29206 <at> debbugs.gnu.org (full text, mbox):
On 25.06.2019 14:09, Lars Ingebrigtsen wrote:
> Dmitry Gutov <dgutov <at> yandex.ru> writes:
>
>> I'd be fine with it now. Though the surrounding code has changed a bit
>> and the patch doesn't apply anymore.
>>
>> The same change would need to be made for
>> xref-show-definitions-function as well, I think.
>
> OK; I've now made these changes.
Nice. Thank you.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Wed, 24 Jul 2019 11:24:04 GMT)
Full text and
rfc822 format available.
This bug report was last modified 4 years and 271 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.